[HADOOP-13782] Make MutableRates metrics thread-local write, aggregate-on-read

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha2
• Component/s: metrics
• Target Version/s: 2.7.4
• Hadoop Flags: Reviewed
• Assignee: Erik Krogen
• Reporter: Erik Krogen
• Created: 01/Nov/16 21:10
• Updated: 09/Nov/16 01:10
• Resolved: 09/Nov/16 00:18

Description

Currently the MutableRates metrics class serializes all writes to metrics it contains because of its use of MetricsRegistry.add() (i.e., even two increments of unrelated metrics contained within the same MutableRates object will serialize w.r.t. each other). This class is used by RpcDetailedMetrics, which may have many hundreds of threads contending to modify these metrics. Instead we should allow updates to unrelated metrics objects to happen concurrently. To do so we can let each thread locally collect metrics, and on a snapshot, aggregate the metrics from all of the threads.

I have collected some benchmark performance numbers in HADOOP-13747 (https://issues.apache.org/jira/secure/attachment/12835043/benchmark_results) which indicate that this can bring significantly higher performance in high contention situations.

Issue Links

• is blocked by: HADOOP-13804 MutableStat mean loses accuracy if add(long, long) is used
• is related to: HADOOP-13747 Use LongAdder for more efficient metrics tracking
• is required by: HDFS-10872 Add MutableRate metrics for FSNamesystemLock operations