Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13766

Fix a typo in the comments of RPC.getProtocolVersion

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: common
    • Labels:
      None

      Description

      Typo in the comments. Protocol name should be versionID.

      1. HADOOP-13766.001.patch
        0.9 kB
        Ethan Li
      2. HADOOP-13766.002.patch
        0.9 kB
        Ethan Li

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10884 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10884/)
        HADOOP-13766. Fix a typo in the comments of RPC.getProtocolVersion. (wang: rev c7a5f2906fcfd073a402b6981b091bd6d9b80294)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10884 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10884/ ) HADOOP-13766 . Fix a typo in the comments of RPC.getProtocolVersion. (wang: rev c7a5f2906fcfd073a402b6981b091bd6d9b80294) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        Hide
        andrew.wang Andrew Wang added a comment -

        Committed, thanks for the contribution Ethan!

        Show
        andrew.wang Andrew Wang added a comment - Committed, thanks for the contribution Ethan!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 16s trunk passed
        +1 compile 9m 41s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 19s trunk passed
        +1 findbugs 1m 23s trunk passed
        +1 javadoc 0m 48s trunk passed
        +1 mvninstall 0m 36s the patch passed
        +1 compile 9m 14s the patch passed
        +1 javac 9m 14s the patch passed
        +1 checkstyle 0m 31s the patch passed
        +1 mvnsite 1m 0s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 33s the patch passed
        +1 javadoc 0m 48s the patch passed
        +1 unit 8m 6s hadoop-common in the patch passed.
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        45m 43s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13766
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840204/HADOOP-13766.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 134b8de21ed7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4667564
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11121/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11121/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 16s trunk passed +1 compile 9m 41s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 9m 14s the patch passed +1 javac 9m 14s the patch passed +1 checkstyle 0m 31s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 33s the patch passed +1 javadoc 0m 48s the patch passed +1 unit 8m 6s hadoop-common in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 45m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13766 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840204/HADOOP-13766.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 134b8de21ed7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4667564 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11121/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11121/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ethanli Ethan Li added a comment -

        Thank you, Andrew. Sorry, not familiar with this.

        Show
        ethanli Ethan Li added a comment - Thank you, Andrew. Sorry, not familiar with this.
        Hide
        andrew.wang Andrew Wang added a comment -

        Hi Ethan, could you please address the checkstyle issue? I'm guessing the line needs to be wrapped to 80 chars. Otherwise LGTM, thanks.

        Show
        andrew.wang Andrew Wang added a comment - Hi Ethan, could you please address the checkstyle issue? I'm guessing the line needs to be wrapped to 80 chars. Otherwise LGTM, thanks.
        Hide
        ethanli Ethan Li added a comment -

        Just fix typos in comments. No new tests are needed

        Show
        ethanli Ethan Li added a comment - Just fix typos in comments. No new tests are needed
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 15s trunk passed
        +1 compile 7m 40s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 17s trunk passed
        +1 javadoc 0m 41s trunk passed
        +1 mvninstall 0m 36s the patch passed
        +1 compile 6m 56s the patch passed
        +1 javac 6m 56s the patch passed
        -0 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 1 new + 189 unchanged - 0 fixed = 190 total (was 189)
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 1s The patch has no whitespace issues.
        +1 findbugs 1m 28s the patch passed
        +1 javadoc 0m 41s the patch passed
        -1 unit 6m 58s hadoop-common in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        39m 33s



        Reason Tests
        Failed junit tests hadoop.ha.TestZKFailoverController



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13766
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835630/HADOOP-13766.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 68cf80d4baeb 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ac35ee9
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10911/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10911/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10911/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10911/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 15s trunk passed +1 compile 7m 40s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 17s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 6m 56s the patch passed +1 javac 6m 56s the patch passed -0 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 1 new + 189 unchanged - 0 fixed = 190 total (was 189) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 1m 28s the patch passed +1 javadoc 0m 41s the patch passed -1 unit 6m 58s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 39m 33s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13766 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835630/HADOOP-13766.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 68cf80d4baeb 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ac35ee9 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10911/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10911/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10911/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10911/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            ethanli Ethan Li
            Reporter:
            ethanli Ethan Li
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development