[HADOOP-13721] Remove stale method ViewFileSystem#getTrashCanLocation

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha2
• Fix Version/s: 3.0.0-alpha2
• Component/s: viewfs
• Target Version/s: 3.0.0-alpha2
• Hadoop Flags: Incompatible change
• Release Note: The unused method getTrashCanLocation has been removed. This method has long been superceded by FileSystem#getTrashRoot.
• Assignee: Manoj Govindassamy
• Reporter: Manoj Govindassamy
• Created: 13/Oct/16 21:44
• Updated: 14/Oct/16 21:19
• Resolved: 14/Oct/16 21:09

Description

ViewFileSystem which extends FileSystem has a public method getTrashCanLocation which is neither overridden nor used by anybody. Looks like it existed when the file was created, and also I see the implementation returning homeDirectory which might not be the expected one in cases of expunge. So, inclined to remove this stale and potentially dangerous method unless anyone has any concerns.

  public Path getTrashCanLocation(final Path f) throws FileNotFoundException {
    final InodeTree.ResolveResult<FileSystem> res = 
      fsState.resolve(getUriPath(f), true);
    return res.isInternalDir() ? null : res.targetFileSystem.getHomeDirectory();
  }