Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13720

Add more info to the msgs printed in AbstractDelegationTokenSecretManager for better supportability

    Details

      Description

      Currently AbstractDelegationTokenSecretManager$checkToken does

        protected DelegationTokenInformation checkToken(TokenIdent identifier)
            throws InvalidToken {
          assert Thread.holdsLock(this);
          DelegationTokenInformation info = getTokenInfo(identifier);
          if (info == null) {
            throw new InvalidToken("token (" + identifier.toString()
                + ") can't be found in cache");
          }
          if (info.getRenewDate() < Time.now()) {
            throw new InvalidToken("token (" + identifier.toString() + ") is expired");
          }
          return info;
        } 
      

      When a token is expried, we throw the above exception without printing out the info.getRenewDate() in the message. If we print it out, we could know for how long the token has not been renewed. This will help us investigate certain issues.

      Create this jira as a request to add that part.

      1. HADOOP-13720.001.patch
        1 kB
        Yongjun Zhang
      2. HADOOP-13720.002.patch
        5 kB
        Yongjun Zhang
      3. HADOOP-13720.003.patch
        7 kB
        Yongjun Zhang
      4. HADOOP-13720.004.patch
        7 kB
        Yongjun Zhang
      5. HADOOP-13720.005.patch
        9 kB
        Yongjun Zhang
      6. HADOOP-13720.006.patch
        14 kB
        Yongjun Zhang
      7. HADOOP-13720.007.patch
        14 kB
        Yongjun Zhang

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          I'd add the current time too. Why? Helps identify one of those situations where the VMs clock is totally broken.

          Show
          stevel@apache.org Steve Loughran added a comment - I'd add the current time too. Why? Helps identify one of those situations where the VMs clock is totally broken.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Nice suggestion Steve Loughran, thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Nice suggestion Steve Loughran , thanks.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Hi Steve Loughran, uploaded a quick patch, would you please help taking a look? thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Hi Steve Loughran , uploaded a quick patch, would you please help taking a look? thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 5s trunk passed
          +1 compile 6m 51s trunk passed
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 57s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 20s trunk passed
          +1 javadoc 0m 41s trunk passed
          +1 mvninstall 0m 35s the patch passed
          +1 compile 7m 34s the patch passed
          +1 javac 7m 34s the patch passed
          +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 49 unchanged - 1 fixed = 49 total (was 50)
          +1 mvnsite 0m 54s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 25s the patch passed
          +1 javadoc 0m 42s the patch passed
          -1 unit 19m 53s hadoop-common in the patch failed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          51m 10s



          Reason Tests
          Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13720
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833425/HADOOP-13720.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f7ef47619f21 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 701c27a
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10792/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10792/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10792/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 5s trunk passed +1 compile 6m 51s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 35s the patch passed +1 compile 7m 34s the patch passed +1 javac 7m 34s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 49 unchanged - 1 fixed = 49 total (was 50) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 42s the patch passed -1 unit 19m 53s hadoop-common in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 51m 10s Reason Tests Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13720 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833425/HADOOP-13720.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f7ef47619f21 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 701c27a Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10792/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10792/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10792/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Yongjun Zhang for the patch.
          Looking at the class, I think we should also improve message for a similar case.

             if (id.getMaxDate() < now) {
                throw new InvalidToken(renewer + " tried to renew an expired token");
              }
          

          What do you think?

          Show
          xiaochen Xiao Chen added a comment - Thanks Yongjun Zhang for the patch. Looking at the class, I think we should also improve message for a similar case. if (id.getMaxDate() < now) { throw new InvalidToken(renewer + " tried to renew an expired token" ); } What do you think?
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Xiao Chen much for the review, Very good comment!

          I just uploaded a new rev, with a lot more other similar changes, and we can change the summary of this jira to "Add more information to AbstractDelegationTokenSecretManager for better supportability"

          Would you please take a look again?

          + Steve Loughran too.

          Thank you guys.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Xiao Chen much for the review, Very good comment! I just uploaded a new rev, with a lot more other similar changes, and we can change the summary of this jira to "Add more information to AbstractDelegationTokenSecretManager for better supportability" Would you please take a look again? + Steve Loughran too. Thank you guys.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          looks pretty good. I think the bit where " currentTime: " + now is included in an error message needs to convert now from a long into a human readable time though.

          Show
          stevel@apache.org Steve Loughran added a comment - looks pretty good. I think the bit where " currentTime: " + now is included in an error message needs to convert now from a long into a human readable time though.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 41s trunk passed
          +1 compile 7m 45s trunk passed
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 25s trunk passed
          +1 javadoc 0m 43s trunk passed
          +1 mvninstall 0m 38s the patch passed
          +1 compile 9m 14s the patch passed
          +1 javac 9m 14s the patch passed
          +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 49 unchanged - 1 fixed = 49 total (was 50)
          +1 mvnsite 1m 6s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 2m 0s hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 0m 48s the patch passed
          +1 unit 9m 29s hadoop-common in the patch passed.
          +1 asflicense 0m 25s The patch does not generate ASF License warnings.
          45m 11s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-common
            Invocation of toString on org.apache.hadoop.security.token.Token.getIdentifier() in org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.renewToken(Token, String) At AbstractDelegationTokenSecretManager.java:in org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.renewToken(Token, String) At AbstractDelegationTokenSecretManager.java:[line 512]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13720
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836643/HADOOP-13720.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ea3b344a599e 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0dc2a6a
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10964/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10964/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10964/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 41s trunk passed +1 compile 7m 45s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 25s trunk passed +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 9m 14s the patch passed +1 javac 9m 14s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 49 unchanged - 1 fixed = 49 total (was 50) +1 mvnsite 1m 6s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 2m 0s hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 48s the patch passed +1 unit 9m 29s hadoop-common in the patch passed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 45m 11s Reason Tests FindBugs module:hadoop-common-project/hadoop-common   Invocation of toString on org.apache.hadoop.security.token.Token.getIdentifier() in org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.renewToken(Token, String) At AbstractDelegationTokenSecretManager.java:in org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.renewToken(Token, String) At AbstractDelegationTokenSecretManager.java: [line 512] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13720 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836643/HADOOP-13720.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ea3b344a599e 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0dc2a6a Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10964/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10964/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10964/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 54s trunk passed
          +1 compile 6m 55s trunk passed
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 20s trunk passed
          +1 javadoc 0m 43s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 6m 50s the patch passed
          +1 javac 6m 50s the patch passed
          -0 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 3 new + 74 unchanged - 2 fixed = 77 total (was 76)
          +1 mvnsite 0m 54s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 29s hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          +1 javadoc 0m 43s the patch passed
          +1 unit 7m 46s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          38m 23s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-common
            Invocation of toString on org.apache.hadoop.security.token.Token.getIdentifier() in org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.renewToken(Token, String) At AbstractDelegationTokenSecretManager.java:in org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.renewToken(Token, String) At AbstractDelegationTokenSecretManager.java:[line 512]
            Call to method of static java.text.DateFormat in org.apache.hadoop.util.Time.formatTime(long) At Time.java:java.text.DateFormat in org.apache.hadoop.util.Time.formatTime(long) At Time.java:[line 69]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13720
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836701/HADOOP-13720.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7f07a5c06cb6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dcc07ad
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10968/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10968/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10968/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10968/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 54s trunk passed +1 compile 6m 55s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 50s the patch passed +1 javac 6m 50s the patch passed -0 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 3 new + 74 unchanged - 2 fixed = 77 total (was 76) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 29s hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 0m 43s the patch passed +1 unit 7m 46s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 38m 23s Reason Tests FindBugs module:hadoop-common-project/hadoop-common   Invocation of toString on org.apache.hadoop.security.token.Token.getIdentifier() in org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.renewToken(Token, String) At AbstractDelegationTokenSecretManager.java:in org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.renewToken(Token, String) At AbstractDelegationTokenSecretManager.java: [line 512]   Call to method of static java.text.DateFormat in org.apache.hadoop.util.Time.formatTime(long) At Time.java:java.text.DateFormat in org.apache.hadoop.util.Time.formatTime(long) At Time.java: [line 69] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13720 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836701/HADOOP-13720.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7f07a5c06cb6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dcc07ad Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10968/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10968/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10968/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10968/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Steve Loughran, good comments! Uploaded rev3 to address that. Would you please take a look?

          Hi Xiao Chen, thanks again for your earlier review, I will appreciate it if you could take a look at the new rev.

          Thank you all!

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Steve Loughran , good comments! Uploaded rev3 to address that. Would you please take a look? Hi Xiao Chen , thanks again for your earlier review, I will appreciate it if you could take a look at the new rev. Thank you all!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 47s trunk passed
          +1 compile 7m 24s trunk passed
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 58s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 19s trunk passed
          +1 javadoc 0m 45s trunk passed
          +1 mvninstall 0m 40s the patch passed
          +1 compile 7m 10s the patch passed
          +1 javac 7m 10s the patch passed
          -0 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 3 new + 74 unchanged - 2 fixed = 77 total (was 76)
          +1 mvnsite 0m 54s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 31s hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 0m 43s the patch passed
          +1 unit 8m 10s hadoop-common in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          39m 46s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-common
            Call to method of static java.text.DateFormat in org.apache.hadoop.util.Time.formatTime(long) At Time.java:java.text.DateFormat in org.apache.hadoop.util.Time.formatTime(long) At Time.java:[line 69]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13720
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836723/HADOOP-13720.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3dbbf0005cab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7e521c5
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10969/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10969/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10969/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10969/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 47s trunk passed +1 compile 7m 24s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 19s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 7m 10s the patch passed +1 javac 7m 10s the patch passed -0 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 3 new + 74 unchanged - 2 fixed = 77 total (was 76) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 31s hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 43s the patch passed +1 unit 8m 10s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 39m 46s Reason Tests FindBugs module:hadoop-common-project/hadoop-common   Call to method of static java.text.DateFormat in org.apache.hadoop.util.Time.formatTime(long) At Time.java:java.text.DateFormat in org.apache.hadoop.util.Time.formatTime(long) At Time.java: [line 69] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13720 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836723/HADOOP-13720.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3dbbf0005cab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7e521c5 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10969/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10969/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10969/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10969/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          rev4 to fix findbugs.

          Show
          yzhangal Yongjun Zhang added a comment - rev4 to fix findbugs.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 24s trunk passed
          +1 compile 7m 17s trunk passed
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 58s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 18s trunk passed
          +1 javadoc 0m 45s trunk passed
          +1 mvninstall 0m 40s the patch passed
          +1 compile 7m 31s the patch passed
          +1 javac 7m 31s the patch passed
          -0 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 3 new + 74 unchanged - 2 fixed = 77 total (was 76)
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 31s hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 0m 43s the patch passed
          +1 unit 9m 51s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          42m 21s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-common
            Call to method of static java.text.DateFormat in org.apache.hadoop.util.Time.formatTime(long) At Time.java:java.text.DateFormat in org.apache.hadoop.util.Time.formatTime(long) At Time.java:[line 69]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13720
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836732/HADOOP-13720.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9b949ea8c763 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7e521c5
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10971/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10971/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10971/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10971/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 24s trunk passed +1 compile 7m 17s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 7m 31s the patch passed +1 javac 7m 31s the patch passed -0 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 3 new + 74 unchanged - 2 fixed = 77 total (was 76) +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 31s hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 43s the patch passed +1 unit 9m 51s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 42m 21s Reason Tests FindBugs module:hadoop-common-project/hadoop-common   Call to method of static java.text.DateFormat in org.apache.hadoop.util.Time.formatTime(long) At Time.java:java.text.DateFormat in org.apache.hadoop.util.Time.formatTime(long) At Time.java: [line 69] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13720 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836732/HADOOP-13720.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9b949ea8c763 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7e521c5 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10971/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10971/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10971/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10971/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          aah, findbugs is still complaining. You could just go "current time =" + new Date(now()}; maybe add a deprecation warning, but shut up findbugs

          Show
          stevel@apache.org Steve Loughran added a comment - aah, findbugs is still complaining. You could just go "current time =" + new Date(now()}; maybe add a deprecation warning, but shut up findbugs
          Hide
          yzhangal Yongjun Zhang added a comment -

          Fix findbugs and checkstyle, with rev5.

          Show
          yzhangal Yongjun Zhang added a comment - Fix findbugs and checkstyle, with rev5.
          Hide
          yzhangal Yongjun Zhang added a comment - - edited

          Thanks Steve Loughran, did not see your comment until now, I had a different solution in rev05, basically to use thread local variable to avoid the potential race condition. Would you please take a look? thanks!

          Show
          yzhangal Yongjun Zhang added a comment - - edited Thanks Steve Loughran , did not see your comment until now, I had a different solution in rev05, basically to use thread local variable to avoid the potential race condition. Would you please take a look? thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 22s trunk passed
          +1 compile 7m 48s trunk passed
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 28s trunk passed
          +1 javadoc 0m 44s trunk passed
          +1 mvninstall 0m 42s the patch passed
          +1 compile 7m 26s the patch passed
          +1 javac 7m 26s the patch passed
          +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 53 unchanged - 23 fixed = 53 total (was 76)
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 31s the patch passed
          +1 javadoc 0m 43s the patch passed
          +1 unit 8m 40s hadoop-common in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          41m 42s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13720
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837198/HADOOP-13720.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 287cb5f8a6b0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / abfc15d
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10993/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10993/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 22s trunk passed +1 compile 7m 48s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 28s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 42s the patch passed +1 compile 7m 26s the patch passed +1 javac 7m 26s the patch passed +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 53 unchanged - 23 fixed = 53 total (was 76) +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 43s the patch passed +1 unit 8m 40s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 41m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13720 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837198/HADOOP-13720.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 287cb5f8a6b0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / abfc15d Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10993/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10993/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Hi Steve Loughran and Xiao Chen,

          Thanks a lot for your earlier review. Would you please take a look at the latest rev? Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Hi Steve Loughran and Xiao Chen , Thanks a lot for your earlier review. Would you please take a look at the latest rev? Thanks.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Yongjun Zhang for the new revs, and Steve for the reviews.

          Looks great overall. Some nitty comments:

          • Please update the jira title as you proposed.
          • It requires more operations (create thread local format, and format the the time) when exception happens, but I think that's fine.
          • I see some exceptions throws with (identifier) while some throws without the (). Suggest to make them consistent.
          • Can we add a unit test for the new Time#formatTime ? OTOH there is no existing tests....
          • long curTime = Time.now(); naming it now would be more consistent with current code, for example renewToken.
          Show
          xiaochen Xiao Chen added a comment - Thanks Yongjun Zhang for the new revs, and Steve for the reviews. Looks great overall. Some nitty comments: Please update the jira title as you proposed. It requires more operations (create thread local format, and format the the time) when exception happens, but I think that's fine. I see some exceptions throws with (identifier) while some throws without the () . Suggest to make them consistent. Can we add a unit test for the new Time#formatTime ? OTOH there is no existing tests.... long curTime = Time.now(); naming it now would be more consistent with current code, for example renewToken .
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Xiao Chen. Good comments!

          I uploaded rev06 to address all of them except the second one.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Xiao Chen . Good comments! I uploaded rev06 to address all of them except the second one.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 59s trunk passed
          +1 compile 10m 53s trunk passed
          +1 checkstyle 0m 34s trunk passed
          +1 mvnsite 1m 7s trunk passed
          +1 mvneclipse 0m 22s trunk passed
          +1 findbugs 1m 33s trunk passed
          +1 javadoc 0m 51s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 9m 16s the patch passed
          +1 javac 9m 16s the patch passed
          -0 checkstyle 0m 34s hadoop-common-project/hadoop-common: The patch generated 1 new + 52 unchanged - 24 fixed = 53 total (was 76)
          +1 mvnsite 1m 4s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 37s the patch passed
          +1 javadoc 0m 52s the patch passed
          +1 unit 7m 51s hadoop-common in the patch passed.
          +1 asflicense 0m 40s The patch does not generate ASF License warnings.
          47m 40s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13720
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838051/HADOOP-13720.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 257dd221aeb5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dbb133c
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11031/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11031/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11031/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 59s trunk passed +1 compile 10m 53s trunk passed +1 checkstyle 0m 34s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 22s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 51s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 9m 16s the patch passed +1 javac 9m 16s the patch passed -0 checkstyle 0m 34s hadoop-common-project/hadoop-common: The patch generated 1 new + 52 unchanged - 24 fixed = 53 total (was 76) +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 37s the patch passed +1 javadoc 0m 52s the patch passed +1 unit 7m 51s hadoop-common in the patch passed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 47m 40s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13720 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838051/HADOOP-13720.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 257dd221aeb5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbb133c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11031/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11031/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11031/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          -1 mvninstall 1m 42s root in trunk failed.
          +1 compile 12m 17s trunk passed
          +1 checkstyle 0m 34s trunk passed
          +1 mvnsite 1m 9s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 1m 40s trunk passed
          +1 javadoc 0m 55s trunk passed
          +1 mvninstall 0m 45s the patch passed
          -1 compile 9m 59s root in the patch failed.
          -1 javac 9m 59s root in the patch failed.
          -0 checkstyle 0m 36s hadoop-common-project/hadoop-common: The patch generated 1 new + 52 unchanged - 24 fixed = 53 total (was 76)
          +1 mvnsite 1m 4s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          -1 whitespace 0m 0s The patch has 170 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 4s The patch 384 line(s) with tabs.
          +1 findbugs 1m 39s the patch passed
          +1 javadoc 0m 55s the patch passed
          +1 unit 8m 47s hadoop-common in the patch passed.
          -1 asflicense 1m 19s The patch generated 3 ASF License warnings.
          56m 8s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13720
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838062/HADOOP-13720.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ed6d82f966ca 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 29e3b34
          Default Java 1.8.0_101
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v3.0.0
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/patch-compile-root.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/patch-compile-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/whitespace-tabs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. -1 mvninstall 1m 42s root in trunk failed. +1 compile 12m 17s trunk passed +1 checkstyle 0m 34s trunk passed +1 mvnsite 1m 9s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 55s trunk passed +1 mvninstall 0m 45s the patch passed -1 compile 9m 59s root in the patch failed. -1 javac 9m 59s root in the patch failed. -0 checkstyle 0m 36s hadoop-common-project/hadoop-common: The patch generated 1 new + 52 unchanged - 24 fixed = 53 total (was 76) +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 18s the patch passed -1 whitespace 0m 0s The patch has 170 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 4s The patch 384 line(s) with tabs. +1 findbugs 1m 39s the patch passed +1 javadoc 0m 55s the patch passed +1 unit 8m 47s hadoop-common in the patch passed. -1 asflicense 1m 19s The patch generated 3 ASF License warnings. 56m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13720 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838062/HADOOP-13720.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ed6d82f966ca 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 29e3b34 Default Java 1.8.0_101 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/patch-compile-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/whitespace-tabs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11032/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment - - edited

          Thanks Yongjun Zhang for the new rev. +1 from me pending:

          throw new AccessControlException(renewer
                    + " tries to renew a token (" + id    // <---- why not formatTokenId(id) ? 
                    + ") with non-matching renewer " + id.getRenewer());
          

          (and a new jenkins run)

          Show
          xiaochen Xiao Chen added a comment - - edited Thanks Yongjun Zhang for the new rev. +1 from me pending: throw new AccessControlException(renewer + " tries to renew a token (" + id // <---- why not formatTokenId(id) ? + ") with non-matching renewer " + id.getRenewer()); (and a new jenkins run)
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 8s trunk passed
          +1 compile 12m 33s trunk passed
          +1 checkstyle 0m 35s trunk passed
          +1 mvnsite 1m 12s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          +1 findbugs 1m 35s trunk passed
          +1 javadoc 0m 56s trunk passed
          +1 mvninstall 0m 47s the patch passed
          +1 compile 10m 27s the patch passed
          +1 javac 10m 26s the patch passed
          -0 checkstyle 0m 36s hadoop-common-project/hadoop-common: The patch generated 1 new + 52 unchanged - 24 fixed = 53 total (was 76)
          +1 mvnsite 1m 7s the patch passed
          +1 mvneclipse 0m 24s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 51s the patch passed
          +1 unit 9m 2s hadoop-common in the patch passed.
          +1 asflicense 0m 40s The patch does not generate ASF License warnings.
          53m 29s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13720
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838062/HADOOP-13720.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3242287058de 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e1c6ef2
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11037/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11037/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11037/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 8s trunk passed +1 compile 12m 33s trunk passed +1 checkstyle 0m 35s trunk passed +1 mvnsite 1m 12s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 1m 35s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 47s the patch passed +1 compile 10m 27s the patch passed +1 javac 10m 26s the patch passed -0 checkstyle 0m 36s hadoop-common-project/hadoop-common: The patch generated 1 new + 52 unchanged - 24 fixed = 53 total (was 76) +1 mvnsite 1m 7s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 51s the patch passed +1 unit 9m 2s hadoop-common in the patch passed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 53m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13720 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838062/HADOOP-13720.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3242287058de 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e1c6ef2 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11037/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11037/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11037/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Xiao Chen, thanks for catching one I missed! uploaded new rev.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Xiao Chen , thanks for catching one I missed! uploaded new rev.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 15s trunk passed
          +1 compile 11m 8s trunk passed
          +1 checkstyle 0m 34s trunk passed
          +1 mvnsite 1m 8s trunk passed
          +1 mvneclipse 0m 22s trunk passed
          +1 findbugs 1m 33s trunk passed
          +1 javadoc 0m 51s trunk passed
          +1 mvninstall 0m 36s the patch passed
          +1 compile 9m 26s the patch passed
          +1 javac 9m 26s the patch passed
          +1 checkstyle 0m 34s hadoop-common-project/hadoop-common: The patch generated 0 new + 52 unchanged - 24 fixed = 52 total (was 76)
          +1 mvnsite 1m 4s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 44s the patch passed
          +1 javadoc 0m 52s the patch passed
          +1 unit 8m 21s hadoop-common in the patch passed.
          +1 asflicense 0m 43s The patch does not generate ASF License warnings.
          49m 7s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13720
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838199/HADOOP-13720.007.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 32f1520e245f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c619e9b
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11042/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11042/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 15s trunk passed +1 compile 11m 8s trunk passed +1 checkstyle 0m 34s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 22s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 51s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 9m 26s the patch passed +1 javac 9m 26s the patch passed +1 checkstyle 0m 34s hadoop-common-project/hadoop-common: The patch generated 0 new + 52 unchanged - 24 fixed = 52 total (was 76) +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 44s the patch passed +1 javadoc 0m 52s the patch passed +1 unit 8m 21s hadoop-common in the patch passed. +1 asflicense 0m 43s The patch does not generate ASF License warnings. 49m 7s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13720 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838199/HADOOP-13720.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 32f1520e245f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c619e9b Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11042/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11042/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10818 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10818/)
          HADOOP-13720. Add more info to the msgs printed in (yzhang: rev fd2f22adec5c2f21f792045dbfde9385c21403ec)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/Timer.java
          • (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestTime.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Time.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10818 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10818/ ) HADOOP-13720 . Add more info to the msgs printed in (yzhang: rev fd2f22adec5c2f21f792045dbfde9385c21403ec) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/Timer.java (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestTime.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Time.java
          Hide
          yzhangal Yongjun Zhang added a comment -

          Committed to trunk, branch-2 and branch-2.8.

          Thanks Xiao Chen and Steve Loughran for the review.

          Show
          yzhangal Yongjun Zhang added a comment - Committed to trunk, branch-2 and branch-2.8. Thanks Xiao Chen and Steve Loughran for the review.

            People

            • Assignee:
              yzhangal Yongjun Zhang
              Reporter:
              yzhangal Yongjun Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development