Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13670

Update CHANGES.txt to reflect all the changes in branch-2.7

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.4
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      When committing to branch-2.7, we need to edit CHANGES.txt. However, there are some recent commits to branch-2.7 without editing CHANGES.txt. We need to update the change log.

      1. HADOOP-13670.patch
        6 kB
        Brahma Reddy Battula
      2. HADOOP-13670-branch-2.7.patch
        6 kB
        Brahma Reddy Battula
      3. HADOOP-13670-branch-2.7-02.patch
        6 kB
        Brahma Reddy Battula
      4. HADOOP-13670-branch-2.7-003.patch
        8 kB
        Brahma Reddy Battula
      5. HADOOP-13670-branch-2.7-004.patch
        8 kB
        Brahma Reddy Battula
      6. HADOOP-13670-branch-2.7-005.patch
        8 kB
        Brahma Reddy Battula
      7. HADOOP-13670-branch-2.7-006.patch
        8 kB
        Brahma Reddy Battula

        Issue Links

          Activity

          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          ok..done..Thanks Akira again.

          Show
          brahmareddy Brahma Reddy Battula added a comment - ok..done..Thanks Akira again.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you for committing this. Would you update CHANGES.txt to reflect this issue?

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you for committing this. Would you update CHANGES.txt to reflect this issue?
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Akira Ajisaka thanks a lot for review.. Pushed to branch-2.7

          Show
          brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka thanks a lot for review.. Pushed to branch-2.7
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1. Thanks Brahma.

          I updated as per your comment, but parent jira also needs to be changed..?

          The parent jira is a new feature, so you don't need to change.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1. Thanks Brahma. I updated as per your comment, but parent jira also needs to be changed..? The parent jira is a new feature, so you don't need to change.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          0 mvndep 0m 24s Maven dependency ordering for branch
          0 mvndep 0m 13s Maven dependency ordering for patch
          -1 whitespace 0m 0s The patch has 1264 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 26s The patch 40 line(s) with tabs.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          2m 1s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HADOOP-13670
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831932/HADOOP-13670-branch-2.7-006.patch
          Optional Tests asflicense
          uname Linux c88400985234 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 039c3a7
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10689/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10689/artifact/patchprocess/whitespace-tabs.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10689/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. 0 mvndep 0m 24s Maven dependency ordering for branch 0 mvndep 0m 13s Maven dependency ordering for patch -1 whitespace 0m 0s The patch has 1264 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 26s The patch 40 line(s) with tabs. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 2m 1s Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HADOOP-13670 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831932/HADOOP-13670-branch-2.7-006.patch Optional Tests asflicense uname Linux c88400985234 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 039c3a7 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10689/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10689/artifact/patchprocess/whitespace-tabs.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10689/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Uploaded the patch....
          Earlier as parent HDFS-10475 marked as new featuter, I updated there..now I updated as per your comment, but parent jira also needs to be changed..?

          Show
          brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch.... Earlier as parent HDFS-10475 marked as new featuter, I updated there..now I updated as per your comment, but parent jira also needs to be changed..?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          0 mvndep 0m 32s Maven dependency ordering for branch
          0 mvndep 0m 13s Maven dependency ordering for patch
          -1 whitespace 0m 0s The patch has 1105 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 26s The patch 40 line(s) with tabs.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          2m 15s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HADOOP-13670
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831921/HADOOP-13670-branch-2.7-005.patch
          Optional Tests asflicense
          uname Linux 34347aa8b10b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 039c3a7
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10687/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10687/artifact/patchprocess/whitespace-tabs.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10687/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. 0 mvndep 0m 32s Maven dependency ordering for branch 0 mvndep 0m 13s Maven dependency ordering for patch -1 whitespace 0m 0s The patch has 1105 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 26s The patch 40 line(s) with tabs. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 2m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HADOOP-13670 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831921/HADOOP-13670-branch-2.7-005.patch Optional Tests asflicense uname Linux 34347aa8b10b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 039c3a7 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10687/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10687/artifact/patchprocess/whitespace-tabs.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10687/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you for the update. I'm thinking it's better to move HDFS-10896 from new features to optimization because HDFS-10896 itself is not a new feature.

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you for the update. I'm thinking it's better to move HDFS-10896 from new features to optimization because HDFS-10896 itself is not a new feature.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Uploaded patch to address the comments( added recent commits).

          Show
          brahmareddy Brahma Reddy Battula added a comment - Uploaded patch to address the comments( added recent commits).
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Brahma Reddy Battula for updating the patch!

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Brahma Reddy Battula for updating the patch! Would you fix the indents for HDFS-10744 , HDFS-9145 , and HDFS-7933 ? Would you include HDFS-10609 and HDFS-10896 , which were committed recently? I'm +1 if these are addressed.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          0 mvndep 0m 29s Maven dependency ordering for branch
          0 mvndep 0m 13s Maven dependency ordering for patch
          -1 whitespace 0m 0s The patch has 942 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 22s The patch 36 line(s) with tabs.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          2m 14s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HADOOP-13670
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831732/HADOOP-13670-branch-2.7-004.patch
          Optional Tests asflicense
          uname Linux 7fc23ecdac0e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 5c99959
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10668/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10668/artifact/patchprocess/whitespace-tabs.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10668/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. 0 mvndep 0m 29s Maven dependency ordering for branch 0 mvndep 0m 13s Maven dependency ordering for patch -1 whitespace 0m 0s The patch has 942 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 22s The patch 36 line(s) with tabs. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 2m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HADOOP-13670 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831732/HADOOP-13670-branch-2.7-004.patch Optional Tests asflicense uname Linux 7fc23ecdac0e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 5c99959 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10668/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10668/artifact/patchprocess/whitespace-tabs.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10668/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Rebased the patch and inlcuded HADOOP-13434 entry.Kindly review.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Rebased the patch and inlcuded HADOOP-13434 entry.Kindly review.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Mostly looks good to me.

          1. Would you rebase your patch?
          2. I found HADOOP-13434 is not in 2.7.3 section. Would you add this?

          As version rule, I think ,we should not give new features and incompatiable issues with dot and minor releases.

          Agreed, but probably there are some reasons for new features and incompatible changes to get committed between dot releases. We need to know why they were committed.

          Show
          ajisakaa Akira Ajisaka added a comment - Mostly looks good to me. Would you rebase your patch? I found HADOOP-13434 is not in 2.7.3 section. Would you add this? As version rule, I think ,we should not give new features and incompatiable issues with dot and minor releases. Agreed, but probably there are some reasons for new features and incompatible changes to get committed between dot releases. We need to know why they were committed.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          0 mvndep 0m 31s Maven dependency ordering for branch
          0 mvndep 0m 13s Maven dependency ordering for patch
          -1 whitespace 0m 0s The patch has 777 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 19s The patch 32 line(s) with tabs.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          2m 8s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HADOOP-13670
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831543/HADOOP-13670-branch-2.7-003.patch
          Optional Tests asflicense
          uname Linux 8ade5126f22e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / c08346e
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10655/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10655/artifact/patchprocess/whitespace-tabs.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10655/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. 0 mvndep 0m 31s Maven dependency ordering for branch 0 mvndep 0m 13s Maven dependency ordering for patch -1 whitespace 0m 0s The patch has 777 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 19s The patch 32 line(s) with tabs. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 2m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HADOOP-13670 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831543/HADOOP-13670-branch-2.7-003.patch Optional Tests asflicense uname Linux 8ade5126f22e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / c08346e whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10655/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10655/artifact/patchprocess/whitespace-tabs.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10655/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Uploaded the patch to address all the missing entries..Akira Ajisaka kindly review..

          As version rule, I think ,we should not give new features and incompatiable issues with dot and minor releases.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch to address all the missing entries.. Akira Ajisaka kindly review.. As version rule, I think ,we should not give new features and incompatiable issues with dot and minor releases.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          0 mvndep 0m 30s Maven dependency ordering for branch
          0 mvndep 0m 12s Maven dependency ordering for patch
          -1 whitespace 0m 1s The patch has 628 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 14s The patch 32 line(s) with tabs.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          1m 59s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HADOOP-13670
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831280/HADOOP-13670-branch-2.7-02.patch
          Optional Tests asflicense
          uname Linux d67d0a6e9c8e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / c08346e
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10641/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10641/artifact/patchprocess/whitespace-tabs.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project hadoop-mapreduce-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10641/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. 0 mvndep 0m 30s Maven dependency ordering for branch 0 mvndep 0m 12s Maven dependency ordering for patch -1 whitespace 0m 1s The patch has 628 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 14s The patch 32 line(s) with tabs. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 1m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HADOOP-13670 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831280/HADOOP-13670-branch-2.7-02.patch Optional Tests asflicense uname Linux d67d0a6e9c8e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / c08346e whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10641/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10641/artifact/patchprocess/whitespace-tabs.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10641/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Uploaded patch to address the above comments..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Uploaded patch to address the above comments..
          Hide
          ajisakaa Akira Ajisaka added a comment -

          There is already an entry for MAPREDUCE-4784.

          Show
          ajisakaa Akira Ajisaka added a comment - There is already an entry for MAPREDUCE-4784 .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The issues under HDFS-10616 without HDFS-10655 should be moved to OPTIMIZATIONS instead of BUG FIXES.

          Show
          ajisakaa Akira Ajisaka added a comment - The issues under HDFS-10616 without HDFS-10655 should be moved to OPTIMIZATIONS instead of BUG FIXES. HDFS-10656 HDFS-10674 HDFS-10662 HDFS-10673 HDFS-10744
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Brahma Reddy Battula for reporting this and creating the patch!

          Release 2.7.3 - UNRELEASED

          We should update the date to 2016-08-25 to be consistent with branch-2.7.3.

          In your patch, there are some patterns to indicate the assignee (XXX) and the committer (YYY).

          1. (Contributed by XXX via YYY)
          2. (XXX via YYY)
          3. Contributed by XXX

          Pattern 2 is mostly used, so would you update the patch to use the pattern?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Brahma Reddy Battula for reporting this and creating the patch! Release 2.7.3 - UNRELEASED We should update the date to 2016-08-25 to be consistent with branch-2.7.3. In your patch, there are some patterns to indicate the assignee (XXX) and the committer (YYY). (Contributed by XXX via YYY) (XXX via YYY) Contributed by XXX Pattern 2 is mostly used, so would you update the patch to use the pattern?
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Seems to jenkins report is falky on whitespace..I verified till 8593225e85396ce88ed698adab135a470807647e this commit..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Seems to jenkins report is falky on whitespace..I verified till 8593225e85396ce88ed698adab135a470807647e this commit..
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 11m 30s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          0 mvndep 0m 15s Maven dependency ordering for branch
          0 mvndep 0m 7s Maven dependency ordering for patch
          -1 whitespace 0m 0s The patch has 292 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 7s The patch 16 line(s) with tabs.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          12m 47s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HADOOP-13670
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831242/HADOOP-13670-branch-2.7.patch
          Optional Tests asflicense
          uname Linux 694c54b93b7e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / c08346e
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10640/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10640/artifact/patchprocess/whitespace-tabs.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project hadoop-yarn-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10640/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 11m 30s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. 0 mvndep 0m 15s Maven dependency ordering for branch 0 mvndep 0m 7s Maven dependency ordering for patch -1 whitespace 0m 0s The patch has 292 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 7s The patch 16 line(s) with tabs. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 12m 47s Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HADOOP-13670 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831242/HADOOP-13670-branch-2.7.patch Optional Tests asflicense uname Linux 694c54b93b7e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / c08346e whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10640/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10640/artifact/patchprocess/whitespace-tabs.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project hadoop-yarn-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10640/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HADOOP-13670 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HADOOP-13670
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831240/HADOOP-13670.patch
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10639/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-13670 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-13670 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831240/HADOOP-13670.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10639/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Uploaded the patch add missing commit logs in CHANGES.txt.

          Akira Ajisaka can you take look once..

          I think following also we need to change..?

          Release 2.7.3 - UNRELEASED

          Show
          brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch add missing commit logs in CHANGES.txt. Akira Ajisaka can you take look once.. I think following also we need to change..? Release 2.7.3 - UNRELEASED

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              brahmareddy Brahma Reddy Battula
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development