Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Bump HTrace version from 4.0.1-incubating to 4.1.0-incubating.

      Description

      We're currently pulling in version 4.0.1-incubating - I think we should upgrade to the latest 4.1.0-incubating.

      1. HADOOP-13661.002.patch
        1 kB
        Sean Mackrory
      2. HADOOP-13661.001.patch
        0.4 kB
        Sean Mackrory

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 12m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 28s trunk passed
          +1 compile 0m 9s trunk passed
          +1 mvnsite 0m 12s trunk passed
          +1 mvneclipse 0m 8s trunk passed
          +1 javadoc 0m 9s trunk passed
          +1 mvninstall 0m 6s the patch passed
          +1 compile 0m 6s the patch passed
          +1 javac 0m 6s the patch passed
          +1 mvnsite 0m 9s the patch passed
          +1 mvneclipse 0m 6s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 6s the patch passed
          +1 unit 0m 6s hadoop-project in the patch passed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          21m 58s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830412/HADOOP-13661.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 483f95de9438 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8e06d86
          Default Java 1.8.0_101
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10602/testReport/
          modules C: hadoop-project U: hadoop-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10602/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 28s trunk passed +1 compile 0m 9s trunk passed +1 mvnsite 0m 12s trunk passed +1 mvneclipse 0m 8s trunk passed +1 javadoc 0m 9s trunk passed +1 mvninstall 0m 6s the patch passed +1 compile 0m 6s the patch passed +1 javac 0m 6s the patch passed +1 mvnsite 0m 9s the patch passed +1 mvneclipse 0m 6s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 6s the patch passed +1 unit 0m 6s hadoop-project in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 21m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830412/HADOOP-13661.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 483f95de9438 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8e06d86 Default Java 1.8.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10602/testReport/ modules C: hadoop-project U: hadoop-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10602/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          The patch looks good to me and looks like it does not introduce incompatibility.
          One nit: the Tracing doc still mentions htrace-htraced-4.0.1-incubating.jar. Do you think it should also be updated to reflect the new version?

          Thanks!

          Show
          jojochuang Wei-Chiu Chuang added a comment - The patch looks good to me and looks like it does not introduce incompatibility. One nit: the Tracing doc still mentions htrace-htraced-4.0.1-incubating.jar. Do you think it should also be updated to reflect the new version? Thanks!
          Hide
          mackrorysd Sean Mackrory added a comment -

          Good catch - we should definitely update other references to that version. Attaching an updated patch.

          Show
          mackrorysd Sean Mackrory added a comment - Good catch - we should definitely update other references to that version. Attaching an updated patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 7m 41s trunk passed
          +1 compile 8m 2s trunk passed
          +1 mvnsite 1m 8s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          +1 javadoc 0m 56s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 0m 45s the patch passed
          +1 compile 8m 7s the patch passed
          +1 javac 8m 7s the patch passed
          +1 mvnsite 1m 12s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 javadoc 1m 0s the patch passed
          +1 unit 0m 8s hadoop-project in the patch passed.
          +1 unit 9m 8s hadoop-common in the patch passed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          40m 51s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13661
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830570/HADOOP-13661.002.patch
          Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml
          uname Linux c73c373ffc9d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1831be8
          Default Java 1.8.0_101
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10616/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10616/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 7m 41s trunk passed +1 compile 8m 2s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 23s trunk passed +1 javadoc 0m 56s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed +1 compile 8m 7s the patch passed +1 javac 8m 7s the patch passed +1 mvnsite 1m 12s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 javadoc 1m 0s the patch passed +1 unit 0m 8s hadoop-project in the patch passed. +1 unit 9m 8s hadoop-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 40m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13661 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830570/HADOOP-13661.002.patch Optional Tests asflicense mvnsite compile javac javadoc mvninstall unit xml uname Linux c73c373ffc9d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1831be8 Default Java 1.8.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10616/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10616/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          As usual: what's at risk here? HBase? What version are they on?

          Show
          stevel@apache.org Steve Loughran added a comment - As usual: what's at risk here? HBase? What version are they on?
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          It might be easier if we target it at 3.0.

          Show
          jojochuang Wei-Chiu Chuang added a comment - It might be easier if we target it at 3.0.
          Hide
          mackrorysd Sean Mackrory added a comment - - edited

          They're currently depending on 3.1.0 (both directly and via Hadoop 2.7 - if you use the hadoop-3.0 profile to build against 3.0.0-SNAPSHOT, it uses 4.0.1-incubating too). I started a thread on dev-common and dev@hbase to discuss this and other upgrades and make sure I'm doing enough testing to ease any concerns here.

          Show
          mackrorysd Sean Mackrory added a comment - - edited They're currently depending on 3.1.0 (both directly and via Hadoop 2.7 - if you use the hadoop-3.0 profile to build against 3.0.0-SNAPSHOT, it uses 4.0.1-incubating too). I started a thread on dev-common and dev@hbase to discuss this and other upgrades and make sure I'm doing enough testing to ease any concerns here.
          Hide
          mackrorysd Sean Mackrory added a comment -

          It might be easier if we target it at 3.0

          Yeah I definitely meant to target this for 3.x as opposed to a 2.x release. If we can do it in time for 3.0 that'd be ideal, I think, because that's a time when people are going to be more prepared for any potential incompatibilities if we can't catch them all. I checked in with HBase and they did mention they're hoping to use a shaded Hadoop client artifact that might eliminate such concerns (see HADOOP-11804). Beyond that, the 3.0-compatible profile isn't entirely working yet, so it'll be tough to gauge what additional problems this may introduce.

          Show
          mackrorysd Sean Mackrory added a comment - It might be easier if we target it at 3.0 Yeah I definitely meant to target this for 3.x as opposed to a 2.x release. If we can do it in time for 3.0 that'd be ideal, I think, because that's a time when people are going to be more prepared for any potential incompatibilities if we can't catch them all. I checked in with HBase and they did mention they're hoping to use a shaded Hadoop client artifact that might eliminate such concerns (see HADOOP-11804 ). Beyond that, the 3.0-compatible profile isn't entirely working yet, so it'll be tough to gauge what additional problems this may introduce.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Downstream projects that I know of use htrace:
          HBase, Accumulo

          Hbase explicitly defines its own htrace version 3.1.0-incubating, and even if I switch to hadoop-3.0 profile it sticks to htrace 3.1.0-incubating.

          Accumulo does the same.

          So since it doesn't break these two downstream projects I am +1 for the 02 patch. I'll wait until end of Friday so that anyone has a chance to comment.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Downstream projects that I know of use htrace: HBase, Accumulo Hbase explicitly defines its own htrace version 3.1.0-incubating, and even if I switch to hadoop-3.0 profile it sticks to htrace 3.1.0-incubating. Accumulo does the same. So since it doesn't break these two downstream projects I am +1 for the 02 patch. I'll wait until end of Friday so that anyone has a chance to comment.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Committed patch 002 to trunk. Thanks Sean Mackrory for the patch and thanks Steve Loughran for the extra caution

          Show
          jojochuang Wei-Chiu Chuang added a comment - Committed patch 002 to trunk. Thanks Sean Mackrory for the patch and thanks Steve Loughran for the extra caution
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10623 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10623/)
          HADOOP-13661. Upgrade HTrace version. Contributed by Sean Mackrory. (weichiu: rev ed9fcbec544df149d08d9ac31989a7291eff6507)

          • (edit) hadoop-project/pom.xml
          • (edit) hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10623 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10623/ ) HADOOP-13661 . Upgrade HTrace version. Contributed by Sean Mackrory. (weichiu: rev ed9fcbec544df149d08d9ac31989a7291eff6507) (edit) hadoop-project/pom.xml (edit) hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md

            People

            • Assignee:
              mackrorysd Sean Mackrory
              Reporter:
              mackrorysd Sean Mackrory
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development