Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13628

Support to retrieve specific property from configuration via REST API

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.3
    • Fix Version/s: 2.9.0, 3.0.0-alpha2, 2.8.3
    • Component/s: conf
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently we can use rest API to retrieve all configuration properties per daemon, but unable to get a specific property by name. This causes extra parse work at client side when dealing with Hadoop configurations, and also it's quite over head to send all configuration in a http response over network. Propose to support following a name parameter in the http request, by issuing

      curl --header "Accept:application/json" http://${RM_HOST}/conf?name=yarn.nodemanager.aux-services
      

      get output

      {"property"{"key":"yarn.resourcemanager.hostname","value":"${RM_HOST}","isFinal":false,"resource":"yarn-site.xml"}}
      

      This change is fully backwards compatible.

      1. 404_error_browser.png
        80 kB
        Weiwei Yang
      2. HADOOP-13628.01.patch
        12 kB
        Weiwei Yang
      3. HADOOP-13628.02.patch
        12 kB
        Weiwei Yang
      4. HADOOP-13628.03.patch
        26 kB
        Weiwei Yang
      5. HADOOP-13628.04.patch
        26 kB
        Weiwei Yang
      6. HADOOP-13628.05.patch
        26 kB
        Weiwei Yang
      7. HADOOP-13628.06.patch
        27 kB
        Weiwei Yang

        Activity

        Hide
        jzhuge John Zhuge added a comment -

        Backported to branch-2 and branch-2.8 for HADOOP-14260.

        Show
        jzhuge John Zhuge added a comment - Backported to branch-2 and branch-2.8 for HADOOP-14260 .
        Hide
        cheersyang Weiwei Yang added a comment -
        Show
        cheersyang Weiwei Yang added a comment - Thanks Mingliang Liu
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10548 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10548/)
        HADOOP-13628. Support to retrieve specific property from configuration (liuml07: rev 00160f71b6d98244fcb1cb58b2db9fc24f1cd672)

        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfServlet.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ConfServlet.java
        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10548 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10548/ ) HADOOP-13628 . Support to retrieve specific property from configuration (liuml07: rev 00160f71b6d98244fcb1cb58b2db9fc24f1cd672) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfServlet.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ConfServlet.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        Hide
        liuml07 Mingliang Liu added a comment -

        I've committed to trunk branch. We can backport this later to branch-2 if it's needed. Thanks for your contribution, Weiwei Yang.

        Show
        liuml07 Mingliang Liu added a comment - I've committed to trunk branch. We can backport this later to branch-2 if it's needed. Thanks for your contribution, Weiwei Yang .
        Hide
        cheersyang Weiwei Yang added a comment -

        Hi Mingliang Liu

        Please let me know your thought, so we can move forward. Thanks a lot.

        Show
        cheersyang Weiwei Yang added a comment - Hi Mingliang Liu Please let me know your thought, so we can move forward. Thanks a lot.
        Hide
        cheersyang Weiwei Yang added a comment -

        Hello Mingliang Liu

        Majority of the conflicts is from HADOOP-13588, that one add the support of ACCEPT header in ConfServlet, but it was only committed to trunk. So we have 2 options here,

        1. Commit HADOOP-13588 to branch-2 and branch-2.7 as well, then this one.
        2. Only commit this one to trunk

        I am OK with either option, and a little bit prefer to #2, because this ticket was initially for the development of YARN-5145 and that one is in trunk. Please let me know your option. Thank you!

        Show
        cheersyang Weiwei Yang added a comment - Hello Mingliang Liu Majority of the conflicts is from HADOOP-13588 , that one add the support of ACCEPT header in ConfServlet, but it was only committed to trunk. So we have 2 options here, 1. Commit HADOOP-13588 to branch-2 and branch-2.7 as well, then this one. 2. Only commit this one to trunk I am OK with either option, and a little bit prefer to #2, because this ticket was initially for the development of YARN-5145 and that one is in trunk. Please let me know your option. Thank you!
        Hide
        liuml07 Mingliang Liu added a comment -

        Can you provide a branch-2 and branch-2.7 patch, Weiwei Yang? I saw non-trivial conflicts when committing. Thanks.

        Show
        liuml07 Mingliang Liu added a comment - Can you provide a branch-2 and branch-2.7 patch, Weiwei Yang ? I saw non-trivial conflicts when committing. Thanks.
        Hide
        cheersyang Weiwei Yang added a comment -
        Show
        cheersyang Weiwei Yang added a comment - Thanks Mingliang Liu
        Hide
        liuml07 Mingliang Liu added a comment -

        Will commit in 3 days if no more comments. Thanks.

        Show
        liuml07 Mingliang Liu added a comment - Will commit in 3 days if no more comments. Thanks.
        Hide
        cheersyang Weiwei Yang added a comment -

        Hello Mingliang Liu

        I just uploaded v6 patch according to your comments. The patch should have addressed Steve's concerns, I've replied and hopefully he can confirm that. Also the plain text support will be tracked via ticket HADOOP-13639.

        Thanks

        Show
        cheersyang Weiwei Yang added a comment - Hello Mingliang Liu I just uploaded v6 patch according to your comments. The patch should have addressed Steve's concerns, I've replied and hopefully he can confirm that. Also the plain text support will be tracked via ticket HADOOP-13639 . Thanks
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 9m 0s trunk passed
        +1 compile 9m 36s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 22s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 38s the patch passed
        +1 compile 7m 3s the patch passed
        +1 javac 7m 3s the patch passed
        +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 285 unchanged - 2 fixed = 285 total (was 287)
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 1s The patch has no whitespace issues.
        +1 findbugs 1m 32s the patch passed
        +1 javadoc 0m 45s the patch passed
        +1 unit 8m 23s hadoop-common in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        44m 19s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13628
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830619/HADOOP-13628.06.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 084ec965c90d 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6437ba1
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10621/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10621/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 9m 0s trunk passed +1 compile 9m 36s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 22s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 7m 3s the patch passed +1 javac 7m 3s the patch passed +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 285 unchanged - 2 fixed = 285 total (was 287) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 8m 23s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 44m 19s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13628 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830619/HADOOP-13628.06.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 084ec965c90d 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6437ba1 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10621/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10621/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        The patch looks good to me overall. Steve Loughran can you confirm that your concerns are all addressed? Thanks.

        One nit is that TestConfServlet#setUp() can be static and @BeforeClass?

        Show
        liuml07 Mingliang Liu added a comment - The patch looks good to me overall. Steve Loughran can you confirm that your concerns are all addressed? Thanks. One nit is that TestConfServlet#setUp() can be static and @BeforeClass ?
        Hide
        cheersyang Weiwei Yang added a comment -

        Hello Steve Loughran and Mingliang Liu

        The patch is ready for review for quite some days, can you guys help to review?
        We have some discussions in new Yarn UI work, if this one can be done, then it would be a lot easier to implement YARN-5145.

        Thanks a lot.

        Show
        cheersyang Weiwei Yang added a comment - Hello Steve Loughran and Mingliang Liu The patch is ready for review for quite some days, can you guys help to review? We have some discussions in new Yarn UI work, if this one can be done, then it would be a lot easier to implement YARN-5145 . Thanks a lot.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 8m 17s trunk passed
        +1 compile 7m 54s trunk passed
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 0m 59s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 24s trunk passed
        +1 javadoc 0m 45s trunk passed
        +1 mvninstall 0m 40s the patch passed
        +1 compile 7m 28s the patch passed
        +1 javac 7m 28s the patch passed
        +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 285 unchanged - 2 fixed = 285 total (was 287)
        +1 mvnsite 0m 56s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 30s the patch passed
        +1 javadoc 0m 46s the patch passed
        +1 unit 7m 56s hadoop-common in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        41m 54s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13628
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830466/HADOOP-13628.05.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c80dc1154b87 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e17a497
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10609/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10609/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 17s trunk passed +1 compile 7m 54s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 7m 28s the patch passed +1 javac 7m 28s the patch passed +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 285 unchanged - 2 fixed = 285 total (was 287) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 30s the patch passed +1 javadoc 0m 46s the patch passed +1 unit 7m 56s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 41m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13628 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830466/HADOOP-13628.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c80dc1154b87 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e17a497 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10609/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10609/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        cheersyang Weiwei Yang added a comment -

        Hello Steve Loughran

        1. I have created HADOOP-13639 for the plain text stuff.
        2. For the 404 error, use following command
        curl --header "Accept:application/json" http://deale1.fyre.ibm.com:8088/conf?name=xxx
        

        you will get following output

        <html>
        <head>
        <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1"/>
        <title>Error 404 Property xxx not found</title>
        </head>
        <body><h2>HTTP ERROR 404</h2>
        <p>Problem accessing /conf. Reason:
        <pre>    Property xxx not found</pre></p><hr /><i><small>Powered by Jetty://</small></i><br/>
        </br>
        ...
        </body>
        </html>
        

        from browser, you'll get error like screen shot 404_error_browser.png

        Show
        cheersyang Weiwei Yang added a comment - Hello Steve Loughran I have created HADOOP-13639 for the plain text stuff. For the 404 error, use following command curl --header "Accept:application/json" http: //deale1.fyre.ibm.com:8088/conf?name=xxx you will get following output <html> <head> <meta http-equiv= "Content-Type" content= "text/html; charset=ISO-8859-1" /> <title>Error 404 Property xxx not found</title> </head> <body><h2>HTTP ERROR 404</h2> <p>Problem accessing /conf. Reason: <pre> Property xxx not found</pre></p><hr /><i><small>Powered by Jetty: //</small></i><br/> </br> ... </body> </html> from browser, you'll get error like screen shot 404_error_browser.png
        Hide
        stevel@apache.org Steve Loughran added a comment -
        1. go on, support text/plain too
        2. when there's a 404, what content type comes back? I ask as there's aways the risk that bad client code will fail badly trying to parse the HTML, without looking at the status code. As long as text/html comes back, we get to deny all responsibility
        Show
        stevel@apache.org Steve Loughran added a comment - go on, support text/plain too when there's a 404, what content type comes back? I ask as there's aways the risk that bad client code will fail badly trying to parse the HTML, without looking at the status code. As long as text/html comes back, we get to deny all responsibility
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 50s trunk passed
        +1 compile 6m 54s trunk passed
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 22s trunk passed
        +1 javadoc 0m 45s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 6m 53s the patch passed
        +1 javac 6m 53s the patch passed
        -0 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 1 new + 286 unchanged - 2 fixed = 287 total (was 288)
        +1 mvnsite 0m 56s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 31s the patch passed
        +1 javadoc 0m 46s the patch passed
        +1 unit 7m 54s hadoop-common in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        38m 43s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13628
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829667/HADOOP-13628.04.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 22d7ba96c994 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 964e546
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10557/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10557/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10557/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 50s trunk passed +1 compile 6m 54s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 22s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 53s the patch passed +1 javac 6m 53s the patch passed -0 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 1 new + 286 unchanged - 2 fixed = 287 total (was 288) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 46s the patch passed +1 unit 7m 54s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 38m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13628 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829667/HADOOP-13628.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 22d7ba96c994 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 964e546 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10557/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10557/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10557/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        cheersyang Weiwei Yang added a comment -

        v3 patch has following updates

        • Supported both JSON and XML format of response
        • Added some tests in TestConfServlet#testGetProperty, use some mockups to test the API
        • Query for a non-exist configuration property will get a 404 error now
        • Extracted some common code in Configuration for reuse, such as Configuration#appendXMLProperty and Configuration#appendJSONProperty
        • Improved java doc

        Some more explanation to the behaviors. When you want to query for a property, issue following command

        curl --header "accept: application/xml" http://deale1.fyre.ibm.com:8088/conf?name=yarn.ipc.rpc.class
        
        Output:
        <property><name>yarn.ipc.rpc.class</name><value>org.apache.hadoop.yarn.ipc.HadoopYarnProtoRPC</value><final>false</final><source>yarn-default.xml</source></property>
        

        if you want to get a json output, just modify the header

        curl --header "accept: application/json" http://deale1.fyre.ibm.com:8088/conf?name=yarn.ipc.rpc.class
        
        Output:
        {"property":{"key":"yarn.ipc.rpc.class","value":"org.apache.hadoop.yarn.ipc.HadoopYarnProtoRPC","isFinal":false,"resource":"yarn-default.xml"}}
        

        if you provided a non-exist property name

        curl --header "accept: application/xml" http://deale1.fyre.ibm.com:8088/conf?name=unknown.property
        
        Output:
        ...
        <title>Error 404 Property unknown.property not found</title>
        </head>
        <body><h2>HTTP ERROR 404</h2>
        <p>Problem accessing /conf. Reason:
        <pre>    Property unknown.property not found</pre></p><hr /><i><small>Powered by Jetty://</small></i><br/>
        <br/>
        

        if you did not provide any value to name parameter, or did not use it, it behaves just like before, dump all configuration properties. So following commands will get same output

        curl --header "accept: application/xml" http://deale1.fyre.ibm.com:8088/conf?name=""
        curl --header "accept: application/xml" http://deale1.fyre.ibm.com:8088/conf?name=
        curl --header "accept: application/xml" http://deale1.fyre.ibm.com:8088/conf
        
        Output:
        All properties...
        
        Show
        cheersyang Weiwei Yang added a comment - v3 patch has following updates Supported both JSON and XML format of response Added some tests in TestConfServlet#testGetProperty , use some mockups to test the API Query for a non-exist configuration property will get a 404 error now Extracted some common code in Configuration for reuse, such as Configuration#appendXMLProperty and Configuration#appendJSONProperty Improved java doc Some more explanation to the behaviors. When you want to query for a property, issue following command curl --header "accept: application/xml" http: //deale1.fyre.ibm.com:8088/conf?name=yarn.ipc.rpc.class Output: <property><name>yarn.ipc.rpc.class</name><value>org.apache.hadoop.yarn.ipc.HadoopYarnProtoRPC</value>< final > false </ final ><source>yarn- default .xml</source></property> if you want to get a json output, just modify the header curl --header "accept: application/json" http: //deale1.fyre.ibm.com:8088/conf?name=yarn.ipc.rpc.class Output: { "property" :{ "key" : "yarn.ipc.rpc.class" , "value" : "org.apache.hadoop.yarn.ipc.HadoopYarnProtoRPC" , "isFinal" : false , "resource" : "yarn- default .xml" }} if you provided a non-exist property name curl --header "accept: application/xml" http: //deale1.fyre.ibm.com:8088/conf?name=unknown.property Output: ... <title>Error 404 Property unknown.property not found</title> </head> <body><h2>HTTP ERROR 404</h2> <p>Problem accessing /conf. Reason: <pre> Property unknown.property not found</pre></p><hr /><i><small>Powered by Jetty: //</small></i><br/> <br/> if you did not provide any value to name parameter, or did not use it, it behaves just like before, dump all configuration properties. So following commands will get same output curl --header "accept: application/xml" http: //deale1.fyre.ibm.com:8088/conf?name="" curl --header "accept: application/xml" http: //deale1.fyre.ibm.com:8088/conf?name= curl --header "accept: application/xml" http: //deale1.fyre.ibm.com:8088/conf Output: All properties...
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 57s trunk passed
        +1 compile 6m 59s trunk passed
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 21s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 6m 59s the patch passed
        +1 javac 6m 59s the patch passed
        -0 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 9 new + 285 unchanged - 2 fixed = 294 total (was 287)
        +1 mvnsite 0m 54s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 27s the patch passed
        -1 javadoc 0m 44s hadoop-common-project_hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 unit 9m 17s hadoop-common in the patch passed.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        40m 12s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13628
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829642/HADOOP-13628.03.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0bf4b31438b1 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 964e546
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10556/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10556/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10556/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10556/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 57s trunk passed +1 compile 6m 59s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 21s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 59s the patch passed +1 javac 6m 59s the patch passed -0 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 9 new + 285 unchanged - 2 fixed = 294 total (was 287) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 27s the patch passed -1 javadoc 0m 44s hadoop-common-project_hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 unit 9m 17s hadoop-common in the patch passed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 40m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13628 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829642/HADOOP-13628.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0bf4b31438b1 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 964e546 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10556/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10556/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10556/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10556/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        cheersyang Weiwei Yang added a comment -

        Hello Steve Loughran

        Can create a new ticket for that? Lets try to stay with the issue this JIRA trying to resolve. Are you OK with that?
        I have just done a new patch. Uploading for review now.

        Thanks

        Show
        cheersyang Weiwei Yang added a comment - Hello Steve Loughran Can create a new ticket for that? Lets try to stay with the issue this JIRA trying to resolve. Are you OK with that? I have just done a new patch. Uploading for review now. Thanks
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Here's why I'd like the text option: you can feed the entire value into something, like a curl > file without doing any JSON parsing.

        all that's needed it to look at the type: text/plain = text, text/json ==json, etc. It's the RESTy way.

        Show
        stevel@apache.org Steve Loughran added a comment - Here's why I'd like the text option: you can feed the entire value into something, like a curl > file without doing any JSON parsing. all that's needed it to look at the type: text/plain = text, text/json ==json, etc. It's the RESTy way.
        Hide
        cheersyang Weiwei Yang added a comment - - edited

        Hi Steve Loughran

        Thank you for the comments.

        Does it return the fully evaluated config?

        Yes it does.

        <pre> blocks

        Thanks will do that.

        Unknown properties should return 404

        That makes sense, will do that

        Could we have a text/plain one which returns just the text value?

        I am a little hesitated to do that, I did not see any place else that supports to return plain text, we'd better keep consistency, what do you say?

        Presumably a MiniHDFS cluster serves up this data and would respond to a few Jersey requests?

        I will add some more tests in TestConfServlet to verify http responses for both json an xml format. I will try to mock http requests instead of using mini cluster, hopefully that will be better.

        Show
        cheersyang Weiwei Yang added a comment - - edited Hi Steve Loughran Thank you for the comments. Does it return the fully evaluated config? Yes it does. <pre> blocks Thanks will do that. Unknown properties should return 404 That makes sense, will do that Could we have a text/plain one which returns just the text value? I am a little hesitated to do that, I did not see any place else that supports to return plain text, we'd better keep consistency, what do you say? Presumably a MiniHDFS cluster serves up this data and would respond to a few Jersey requests? I will add some more tests in TestConfServlet to verify http responses for both json an xml format. I will try to mock http requests instead of using mini cluster, hopefully that will be better.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        I like this too. Does it return the fully evaluated config?

        • JSON examples in javadoc should be wrapped in <pre> blocks
        • Unknown properties should return 404. This is a rest API, not a SOAP one where the result is hidden in the body.
        • Could we have a text/plain one which returns just the text value? I could have some fun there. For example, it could be pulled straight into google sheets.
        • We need a functional test for this. Presumably a MiniHDFS cluster serves up this data and would respond to a few Jersey requests?
        Show
        stevel@apache.org Steve Loughran added a comment - I like this too. Does it return the fully evaluated config? JSON examples in javadoc should be wrapped in <pre> blocks Unknown properties should return 404. This is a rest API, not a SOAP one where the result is hidden in the body. Could we have a text/plain one which returns just the text value? I could have some fun there. For example, it could be pulled straight into google sheets. We need a functional test for this. Presumably a MiniHDFS cluster serves up this data and would respond to a few Jersey requests?
        Hide
        liuml07 Mingliang Liu added a comment -

        I like the idea. +1 for the proposal.

        Show
        liuml07 Mingliang Liu added a comment - I like the idea. +1 for the proposal.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 3s trunk passed
        +1 compile 7m 56s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 1m 13s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 43s trunk passed
        +1 javadoc 0m 52s trunk passed
        +1 mvninstall 0m 40s the patch passed
        +1 compile 9m 11s the patch passed
        +1 javac 9m 11s the patch passed
        -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 1 new + 283 unchanged - 2 fixed = 284 total (was 285)
        +1 mvnsite 1m 10s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 1m 28s the patch passed
        -1 javadoc 0m 45s hadoop-common-project_hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
        +1 unit 8m 22s hadoop-common in the patch passed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        43m 47s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13628
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829414/HADOOP-13628.02.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 55643b223977 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c6d1d74
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10551/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10551/artifact/patchprocess/whitespace-eol.txt
        javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10551/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10551/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10551/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 3s trunk passed +1 compile 7m 56s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 13s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 52s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 9m 11s the patch passed +1 javac 9m 11s the patch passed -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 1 new + 283 unchanged - 2 fixed = 284 total (was 285) +1 mvnsite 1m 10s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 1m 28s the patch passed -1 javadoc 0m 45s hadoop-common-project_hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 unit 8m 22s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 43m 47s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13628 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829414/HADOOP-13628.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 55643b223977 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c6d1d74 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10551/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10551/artifact/patchprocess/whitespace-eol.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10551/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10551/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10551/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 30s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 35s trunk passed
        +1 compile 6m 49s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 16s trunk passed
        +1 javadoc 0m 46s trunk passed
        -1 mvninstall 0m 32s hadoop-common in the patch failed.
        -1 compile 0m 49s root in the patch failed.
        -1 javac 0m 49s root in the patch failed.
        -0 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 4 new + 284 unchanged - 2 fixed = 288 total (was 286)
        -1 mvnsite 0m 34s hadoop-common in the patch failed.
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 21s hadoop-common in the patch failed.
        -1 javadoc 0m 42s hadoop-common-project_hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
        -1 unit 0m 38s hadoop-common in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        24m 15s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13628
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829411/HADOOP-13628.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cf27e95f7cd8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c6d1d74
        Default Java 1.8.0_101
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/patch-compile-root.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/patch-compile-root.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
        javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 30s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 35s trunk passed +1 compile 6m 49s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 16s trunk passed +1 javadoc 0m 46s trunk passed -1 mvninstall 0m 32s hadoop-common in the patch failed. -1 compile 0m 49s root in the patch failed. -1 javac 0m 49s root in the patch failed. -0 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 4 new + 284 unchanged - 2 fixed = 288 total (was 286) -1 mvnsite 0m 34s hadoop-common in the patch failed. +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 21s hadoop-common in the patch failed. -1 javadoc 0m 42s hadoop-common-project_hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) -1 unit 0m 38s hadoop-common in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 24m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13628 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829411/HADOOP-13628.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cf27e95f7cd8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c6d1d74 Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/patch-compile-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10550/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        cheersyang Weiwei Yang added a comment -

        Upload v1 patch, it only contains the support for JSON format response, I am open for comments if it looks OK or not. Then I can move forward to finish the XML part. Thanks a lot.

        Show
        cheersyang Weiwei Yang added a comment - Upload v1 patch, it only contains the support for JSON format response, I am open for comments if it looks OK or not. Then I can move forward to finish the XML part. Thanks a lot.

          People

          • Assignee:
            cheersyang Weiwei Yang
            Reporter:
            cheersyang Weiwei Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development