Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13605

Clean up FileSystem javadocs, logging; improve diagnostics on FS load

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.8.0
    • 2.9.0, 3.0.0-alpha2
    • fs
    • None
    • Reviewed

    Description

      We can't easily debug FS instantiation problems as there isn't much detail in what was going on.

      We can add more logging, but cannot simply switch FileSystem.LOG to SLF4J —the class is used in too many places, including tests which cast it. Instead, add a new private SLF4J Logger, LOGGER and switch logging to it.

      While working in the base FileSystem class, take the opportunity to clean up javadocs and comments

      1. add the list of exceptions, including indicating which base classes throw UnsupportedOperationExceptions
      2. cut bits in the comments which are not true

      The outcome of this patch is that IDEs shouldn't highlight most of the file as flawed in some way or another

      Attachments

        1. HADOOP-13605-branch-2-003.patch
          132 kB
          Steve Loughran
        2. HADOOP-13605-branch-2-002.patch
          132 kB
          Steve Loughran
        3. HADOOP-13605-branch-2-001.patch
          79 kB
          Steve Loughran
        4. HADOOP-13605-005.patch
          135 kB
          Steve Loughran
        5. HADOOP-13605-004.patch
          131 kB
          Steve Loughran

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            stevel@apache.org Steve Loughran Assign to me
            stevel@apache.org Steve Loughran
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment