Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13601

Fix typo in a log messages of AbstractDelegationTokenSecretManager

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.4, 3.0.0-alpha2
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      I am conducting research on log related bugs. I tried to make a tool to fix repetitive yet simple patterns of bugs that are related to logs. Typos in log messages are one of the reoccurring bugs. Therefore, I made a tool find typos in log statements. During my experiments, I managed to find the following typos in Hadoop Common:

      in file /hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java, LOG.info("Token cancelation requested for identifier: "+id),
      cancelation should be cancellation

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10469 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10469/)
        HADOOP-13601. Fix a log message typo in (liuml07: rev e80386d69d5fb6a08aa3366e42d2518747af569f)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10469 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10469/ ) HADOOP-13601 . Fix a log message typo in (liuml07: rev e80386d69d5fb6a08aa3366e42d2518747af569f) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
        Hide
        liuml07 Mingliang Liu added a comment -

        Committed to trunk through branch-2.7.

        Show
        liuml07 Mingliang Liu added a comment - Committed to trunk through branch-2.7 .
        Hide
        liuml07 Mingliang Liu added a comment -

        Added Mehran Hassani to the Hadoop Contributors 1 list. Now you can assign JIRAs to youself Mehran Hassani.

        +1 for the patch. Will commit in a second.

        Show
        liuml07 Mingliang Liu added a comment - Added Mehran Hassani to the Hadoop Contributors 1 list. Now you can assign JIRAs to youself Mehran Hassani . +1 for the patch. Will commit in a second.
        Hide
        busbey Sean Busbey added a comment -

        +1 change looks good to me. We don't have tests for logging, so I wouldn't expect a test change. The timed out test looks unrelated.

        Show
        busbey Sean Busbey added a comment - +1 change looks good to me. We don't have tests for logging, so I wouldn't expect a test change. The timed out test looks unrelated.
        Hide
        MehranHassani Mehran Hassani added a comment -

        @Yiqun Lin should I change something in my patch? Since its still not committed

        Show
        MehranHassani Mehran Hassani added a comment - @Yiqun Lin should I change something in my patch? Since its still not committed
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 10s trunk passed
        +1 compile 7m 14s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 20s trunk passed
        +1 javadoc 0m 46s trunk passed
        +1 mvninstall 0m 38s the patch passed
        +1 compile 6m 57s the patch passed
        +1 javac 6m 57s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 29s the patch passed
        +1 javadoc 0m 45s the patch passed
        -1 unit 19m 54s hadoop-common in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        51m 18s



        Reason Tests
        Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13601
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828746/HADOOP-13601.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7b8ee89373ed 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ec3ea18
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10525/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10525/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10525/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 10s trunk passed +1 compile 7m 14s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 6m 57s the patch passed +1 javac 6m 57s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 29s the patch passed +1 javadoc 0m 45s the patch passed -1 unit 19m 54s hadoop-common in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 51m 18s Reason Tests Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13601 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828746/HADOOP-13601.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7b8ee89373ed 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ec3ea18 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10525/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10525/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10525/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Mehran Hassani for providing the patch! The latest patch looks good to me. +1. Please trggier the button Submit Patch to let the status of this JIRA from "open" to "patch available". Then the jenkins will run and test with your patch.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Mehran Hassani for providing the patch! The latest patch looks good to me. +1. Please trggier the button Submit Patch to let the status of this JIRA from "open" to "patch available". Then the jenkins will run and test with your patch.
        Hide
        MehranHassani Mehran Hassani added a comment - - edited

        Sean Busbey Can you please check if its fine? if so I will do the other once like this. Thanks

        Show
        MehranHassani Mehran Hassani added a comment - - edited Sean Busbey Can you please check if its fine? if so I will do the other once like this. Thanks
        Hide
        busbey Sean Busbey added a comment -

        good finds! interested in coming up with a patch for fixing these? Our contributor guide covers everything needed to work across the code base, but I'd imagine for these things a simple manual test of compilation before and after the changes should suffice.

        Show
        busbey Sean Busbey added a comment - good finds! interested in coming up with a patch for fixing these? Our contributor guide covers everything needed to work across the code base, but I'd imagine for these things a simple manual test of compilation before and after the changes should suffice.

          People

          • Assignee:
            MehranHassani Mehran Hassani
            Reporter:
            MehranHassani Mehran Hassani
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development