Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13552

RetryInvocationHandler logs all remote exceptions

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      RetryInvocationHandler logs a warning for any exception that it does not retry. There are many exceptions that the client can automatically handle, like FileNotFoundException, UnresolvedPathException, etc., so now every one of these generates a scary looking stack trace as a warning then the program continues normally.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10364 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10364/)
          HADOOP-13552. RetryInvocationHandler logs all remote exceptions. (jlowe: rev 92d8f371553b88e5b3a9d3354e93f75d60d81368)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10364 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10364/ ) HADOOP-13552 . RetryInvocationHandler logs all remote exceptions. (jlowe: rev 92d8f371553b88e5b3a9d3354e93f75d60d81368) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
          Hide
          jlowe Jason Lowe added a comment -

          I committed this to trunk, branch-2, and branch-2.8.

          Show
          jlowe Jason Lowe added a comment - I committed this to trunk, branch-2, and branch-2.8.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for the review, Jing! Committing this.

          Show
          jlowe Jason Lowe added a comment - Thanks for the review, Jing! Committing this.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 38s trunk passed
          +1 compile 6m 54s trunk passed
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 32s trunk passed
          +1 javadoc 0m 46s trunk passed
          +1 mvninstall 0m 47s the patch passed
          +1 compile 8m 22s the patch passed
          +1 javac 8m 22s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 41s the patch passed
          +1 javadoc 0m 49s the patch passed
          +1 unit 9m 10s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          41m 44s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13552
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825737/HADOOP-13552.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 678b5d8a8a26 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a445b82
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10390/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10390/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 38s trunk passed +1 compile 6m 54s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 32s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 47s the patch passed +1 compile 8m 22s the patch passed +1 javac 8m 22s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 41s the patch passed +1 javadoc 0m 49s the patch passed +1 unit 9m 10s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 41m 44s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13552 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825737/HADOOP-13552.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 678b5d8a8a26 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a445b82 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10390/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10390/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for the fix, Jason Lowe. +1 pending Jenkins.

          Show
          jingzhao Jing Zhao added a comment - Thanks for the fix, Jason Lowe . +1 pending Jenkins.
          Hide
          jlowe Jason Lowe added a comment -

          Attaching a patch that changes the warning log to a debug log in case this is still useful for debugging why the invocation handler isn't retrying when it should.

          Show
          jlowe Jason Lowe added a comment - Attaching a patch that changes the warning log to a debug log in case this is still useful for debugging why the invocation handler isn't retrying when it should.
          Hide
          jlowe Jason Lowe added a comment -

          Looks like this was introduced in HADOOP-13146. Normally logging then throwing the same exception is an anti-pattern since it either logs when it shouldn't (as in this case) or it ends up logging more than once when the ultimate handler of the exception fields it.

          Show
          jlowe Jason Lowe added a comment - Looks like this was introduced in HADOOP-13146 . Normally logging then throwing the same exception is an anti-pattern since it either logs when it shouldn't (as in this case) or it ends up logging more than once when the ultimate handler of the exception fields it.

            People

            • Assignee:
              jlowe Jason Lowe
              Reporter:
              jlowe Jason Lowe
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development