[HADOOP-13486] Method invocation in log can be replaced by variable because the variable's toString method contain more info

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.7.2
• Labels: easyfix easytest
• Assignee: Attila Bukor
• Reporter: Nemo Chen
• Created: 11/Aug/16 18:23
• Updated: 14/Feb/17 20:55
• Resolved: 14/Feb/17 20:55

Description

Similar to the fix in HADOOP-6419, in file:

hadoop-rel-release-2.7.2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java

Connection c = (Connection)key.attachment();
...
LOG.info(Thread.currentThread().getName() + ": readAndProcess from client " + c.getHostAddress() + " threw exception [" + e + "]", (e instanceof WrappedRpcServerException) ? null : e);
...

in class Connection, the toString method contains both getHostAddress() and remotePort

public String toString() {
      return getHostAddress() + ":" + remotePort; 
    }

Therefore the c.getHostAddress() should be replaced by c for simplicity and information wise.

Issue Links

• is part of: HADOOP-14034 Allow ipc layer exceptions to selectively close connections