[HADOOP-13484] Log refactoring: method invocation should be replaced by variable

• Type: Bug
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.7.2
• Component/s: metrics
• Assignee: Vrushali C
• Reporter: Nemo Chen
• Created: 11/Aug/16 14:14
• Updated: 11/Aug/16 16:20

Description

Similar to the fix for HDFS-409. In file:

hadoop-rel-release-2.7.2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableRates.java

In code block:

String name = method.getName();
LOG.debug(name);
try { registry.newRate(name, name, false, true); }
catch (Exception e) {
        LOG.error("Error creating rate metrics for "+ method.getName(), e);
}

method.getName() is better to be replaced by variable name.