Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13427

Eliminate needless uses of FileSystem#{exists(), isFile(), isDirectory()}

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We're cleaning up Hive and Spark's use of FileSystem.exists, because it is often the case we see code of exists+open, exists+delete, when the exists probe is needless. Against object stores, expensive needless.

      Hadoop can set an example here by stripping them out. It will also show where there are opportunities to optimise things better and/or improve reporting.

      1. HADOOP-13427.003.patch
        56 kB
        Mingliang Liu
      2. HADOOP-13427.004.patch
        60 kB
        Mingliang Liu
      3. HADOOP-13427.005.patch
        60 kB
        Mingliang Liu
      4. HADOOP-13427.006.patch
        60 kB
        Mingliang Liu
      5. HADOOP-13427.007.patch
        60 kB
        Steve Loughran
      6. HADOOP-13427.008.patch
        60 kB
        Mingliang Liu
      7. HADOOP-13427.008.patch
        60 kB
        Mingliang Liu
      8. HADOOP-13427.009.patch
        60 kB
        Mingliang Liu
      9. HADOOP-13427.009.patch
        60 kB
        Mingliang Liu
      10. HADOOP-13427-001.patch
        53 kB
        Steve Loughran
      11. HADOOP-13427-002.patch
        53 kB
        Steve Loughran

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10839 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10839/)
          HADOOP-13427. Eliminate needless uses of FileSystem#{exists(), isFile(), (liuml07: rev 5af572b6443715b7a741296c1bd520a1840f9a7c)

          • (edit) hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          • (edit) hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobResourceUploader.java
          • (edit) hadoop-tools/hadoop-openstack/src/main/java/org/apache/hadoop/fs/swift/util/SwiftTestUtils.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager/src/main/java/org/apache/hadoop/yarn/server/sharedcachemanager/store/InMemorySCMStore.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmissionFiles.java
          • (edit) hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistTool.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NonAppendableFSNodeLabelStore.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsAdmin.java
          • (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/TestPreemptableFileOutputCommitter.java
          • (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java
          • (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/JavaKeyStoreProvider.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/PartialFileOutputCommitter.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java
          • (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/util/DistCpUtils.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/FileSystemBasedConfigurationProvider.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/HistoryServerFileSystemStateStoreService.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/FileSystemApplicationHistoryStore.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/FileOutputCommitter.java
          • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/WasbFsck.java
          • (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java
          • (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyCommitter.java
          • (edit) hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/state/StatePool.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/sharedcache/SharedCacheUploader.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/FileSystemTimelineWriter.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestFileSystemApplicationHistoryStore.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10839 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10839/ ) HADOOP-13427 . Eliminate needless uses of FileSystem#{exists(), isFile(), (liuml07: rev 5af572b6443715b7a741296c1bd520a1840f9a7c) (edit) hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java (edit) hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobResourceUploader.java (edit) hadoop-tools/hadoop-openstack/src/main/java/org/apache/hadoop/fs/swift/util/SwiftTestUtils.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager/src/main/java/org/apache/hadoop/yarn/server/sharedcachemanager/store/InMemorySCMStore.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmissionFiles.java (edit) hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistTool.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NonAppendableFSNodeLabelStore.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsAdmin.java (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/TestPreemptableFileOutputCommitter.java (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/JavaKeyStoreProvider.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/PartialFileOutputCommitter.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/util/DistCpUtils.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/FileSystemBasedConfigurationProvider.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/HistoryServerFileSystemStateStoreService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/FileSystemApplicationHistoryStore.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/FileOutputCommitter.java (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/WasbFsck.java (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyCommitter.java (edit) hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/state/StatePool.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/sharedcache/SharedCacheUploader.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/FileSystemTimelineWriter.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestFileSystemApplicationHistoryStore.java
          Hide
          liuml07 Mingliang Liu added a comment -

          Committed to trunk and branch-2 branches. Should we also backport to branch-2.8 as well?

          Thanks.

          Show
          liuml07 Mingliang Liu added a comment - Committed to trunk and branch-2 branches. Should we also backport to branch-2.8 as well? Thanks.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1

          Show
          stevel@apache.org Steve Loughran added a comment - +1
          Hide
          liuml07 Mingliang Liu added a comment -

          This is a clean world.

          Ping Steve Loughran

          Show
          liuml07 Mingliang Liu added a comment - This is a clean world. Ping Steve Loughran
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 1m 38s Maven dependency ordering for branch
          +1 mvninstall 7m 51s trunk passed
          +1 compile 9m 47s trunk passed
          +1 checkstyle 1m 46s trunk passed
          +1 mvnsite 9m 8s trunk passed
          +1 mvneclipse 5m 53s trunk passed
          +1 findbugs 12m 50s trunk passed
          +1 javadoc 7m 0s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 6m 24s the patch passed
          +1 compile 9m 22s the patch passed
          +1 javac 9m 22s the patch passed
          +1 checkstyle 1m 50s root: The patch generated 0 new + 868 unchanged - 9 fixed = 868 total (was 877)
          +1 mvnsite 9m 58s the patch passed
          +1 mvneclipse 6m 44s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 15m 45s the patch passed
          +1 javadoc 7m 57s the patch passed
          +1 unit 8m 27s hadoop-common in the patch passed.
          +1 unit 1m 6s hadoop-hdfs-client in the patch passed.
          +1 unit 2m 28s hadoop-yarn-common in the patch passed.
          +1 unit 14m 37s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 2m 54s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 unit 0m 37s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 2m 57s hadoop-mapreduce-client-core in the patch passed.
          +1 unit 8m 51s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 18s hadoop-mapreduce-client-hs in the patch passed.
          +1 unit 0m 44s hadoop-mapreduce-examples in the patch passed.
          +1 unit 11m 7s hadoop-distcp in the patch passed.
          +1 unit 0m 59s hadoop-archives in the patch passed.
          +1 unit 0m 47s hadoop-archive-logs in the patch passed.
          +1 unit 0m 32s hadoop-rumen in the patch passed.
          +1 unit 0m 53s hadoop-extras in the patch passed.
          +1 unit 0m 25s hadoop-openstack in the patch passed.
          +1 unit 1m 34s hadoop-azure in the patch passed.
          +1 asflicense 0m 39s The patch does not generate ASF License warnings.
          205m 1s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13427
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838798/HADOOP-13427.009.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0136140578b0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 99c2bbd
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11062/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11062/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 38s Maven dependency ordering for branch +1 mvninstall 7m 51s trunk passed +1 compile 9m 47s trunk passed +1 checkstyle 1m 46s trunk passed +1 mvnsite 9m 8s trunk passed +1 mvneclipse 5m 53s trunk passed +1 findbugs 12m 50s trunk passed +1 javadoc 7m 0s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 6m 24s the patch passed +1 compile 9m 22s the patch passed +1 javac 9m 22s the patch passed +1 checkstyle 1m 50s root: The patch generated 0 new + 868 unchanged - 9 fixed = 868 total (was 877) +1 mvnsite 9m 58s the patch passed +1 mvneclipse 6m 44s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 15m 45s the patch passed +1 javadoc 7m 57s the patch passed +1 unit 8m 27s hadoop-common in the patch passed. +1 unit 1m 6s hadoop-hdfs-client in the patch passed. +1 unit 2m 28s hadoop-yarn-common in the patch passed. +1 unit 14m 37s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 2m 54s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 unit 0m 37s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 2m 57s hadoop-mapreduce-client-core in the patch passed. +1 unit 8m 51s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 18s hadoop-mapreduce-client-hs in the patch passed. +1 unit 0m 44s hadoop-mapreduce-examples in the patch passed. +1 unit 11m 7s hadoop-distcp in the patch passed. +1 unit 0m 59s hadoop-archives in the patch passed. +1 unit 0m 47s hadoop-archive-logs in the patch passed. +1 unit 0m 32s hadoop-rumen in the patch passed. +1 unit 0m 53s hadoop-extras in the patch passed. +1 unit 0m 25s hadoop-openstack in the patch passed. +1 unit 1m 34s hadoop-azure in the patch passed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 205m 1s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13427 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838798/HADOOP-13427.009.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0136140578b0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99c2bbd Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11062/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11062/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          I believe the npm bug has been fixed by Wangda, so the v9 patch should compile successfully.

          If I can, I +1 on v9 patch

          Any further thoughts, Steve Loughran?

          Show
          liuml07 Mingliang Liu added a comment - I believe the npm bug has been fixed by Wangda, so the v9 patch should compile successfully. If I can, I +1 on v9 patch Any further thoughts, Steve Loughran ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 34s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 1m 49s Maven dependency ordering for branch
          +1 mvninstall 7m 38s trunk passed
          -1 compile 7m 46s root in trunk failed.
          +1 checkstyle 1m 47s trunk passed
          +1 mvnsite 10m 0s trunk passed
          +1 mvneclipse 6m 40s trunk passed
          +1 findbugs 13m 47s trunk passed
          +1 javadoc 8m 6s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 6m 22s the patch passed
          -1 compile 5m 46s root in the patch failed.
          -1 javac 5m 46s root in the patch failed.
          +1 checkstyle 1m 53s root: The patch generated 0 new + 871 unchanged - 9 fixed = 871 total (was 880)
          +1 mvnsite 10m 57s the patch passed
          +1 mvneclipse 7m 44s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 16m 44s the patch passed
          +1 javadoc 8m 55s the patch passed
          +1 unit 8m 9s hadoop-common in the patch passed.
          +1 unit 1m 10s hadoop-hdfs-client in the patch passed.
          +1 unit 2m 32s hadoop-yarn-common in the patch passed.
          +1 unit 14m 44s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 2m 57s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 unit 0m 41s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 2m 59s hadoop-mapreduce-client-core in the patch passed.
          +1 unit 8m 56s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 21s hadoop-mapreduce-client-hs in the patch passed.
          +1 unit 0m 47s hadoop-mapreduce-examples in the patch passed.
          +1 unit 11m 16s hadoop-distcp in the patch passed.
          +1 unit 1m 2s hadoop-archives in the patch passed.
          +1 unit 0m 49s hadoop-archive-logs in the patch passed.
          +1 unit 0m 36s hadoop-rumen in the patch passed.
          +1 unit 0m 57s hadoop-extras in the patch passed.
          +1 unit 0m 29s hadoop-openstack in the patch passed.
          +1 unit 1m 37s hadoop-azure in the patch passed.
          +1 asflicense 0m 47s The patch does not generate ASF License warnings.
          208m 39s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13427
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838469/HADOOP-13427.008.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0aa67374d1e3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 93eeb13
          Default Java 1.8.0_101
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11049/artifact/patchprocess/branch-compile-root.txt
          findbugs v3.0.0
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11049/artifact/patchprocess/patch-compile-root.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11049/artifact/patchprocess/patch-compile-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11049/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11049/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 34s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 49s Maven dependency ordering for branch +1 mvninstall 7m 38s trunk passed -1 compile 7m 46s root in trunk failed. +1 checkstyle 1m 47s trunk passed +1 mvnsite 10m 0s trunk passed +1 mvneclipse 6m 40s trunk passed +1 findbugs 13m 47s trunk passed +1 javadoc 8m 6s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 6m 22s the patch passed -1 compile 5m 46s root in the patch failed. -1 javac 5m 46s root in the patch failed. +1 checkstyle 1m 53s root: The patch generated 0 new + 871 unchanged - 9 fixed = 871 total (was 880) +1 mvnsite 10m 57s the patch passed +1 mvneclipse 7m 44s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 16m 44s the patch passed +1 javadoc 8m 55s the patch passed +1 unit 8m 9s hadoop-common in the patch passed. +1 unit 1m 10s hadoop-hdfs-client in the patch passed. +1 unit 2m 32s hadoop-yarn-common in the patch passed. +1 unit 14m 44s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 2m 57s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 unit 0m 41s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 2m 59s hadoop-mapreduce-client-core in the patch passed. +1 unit 8m 56s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 21s hadoop-mapreduce-client-hs in the patch passed. +1 unit 0m 47s hadoop-mapreduce-examples in the patch passed. +1 unit 11m 16s hadoop-distcp in the patch passed. +1 unit 1m 2s hadoop-archives in the patch passed. +1 unit 0m 49s hadoop-archive-logs in the patch passed. +1 unit 0m 36s hadoop-rumen in the patch passed. +1 unit 0m 57s hadoop-extras in the patch passed. +1 unit 0m 29s hadoop-openstack in the patch passed. +1 unit 1m 37s hadoop-azure in the patch passed. +1 asflicense 0m 47s The patch does not generate ASF License warnings. 208m 39s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13427 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838469/HADOOP-13427.008.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0aa67374d1e3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 93eeb13 Default Java 1.8.0_101 compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11049/artifact/patchprocess/branch-compile-root.txt findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11049/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11049/artifact/patchprocess/patch-compile-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11049/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11049/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 42s trunk passed
          -1 compile 7m 4s root in trunk failed.
          +1 checkstyle 1m 48s trunk passed
          +1 mvnsite 10m 5s trunk passed
          +1 mvneclipse 6m 55s trunk passed
          +1 findbugs 13m 45s trunk passed
          +1 javadoc 8m 6s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 6m 23s the patch passed
          -1 compile 5m 52s root in the patch failed.
          -1 javac 5m 52s root in the patch failed.
          +1 checkstyle 1m 51s root: The patch generated 0 new + 868 unchanged - 9 fixed = 868 total (was 877)
          +1 mvnsite 10m 53s the patch passed
          +1 mvneclipse 7m 43s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 17m 28s the patch passed
          +1 javadoc 8m 24s the patch passed
          +1 unit 9m 7s hadoop-common in the patch passed.
          +1 unit 1m 12s hadoop-hdfs-client in the patch passed.
          +1 unit 2m 33s hadoop-yarn-common in the patch passed.
          +1 unit 14m 42s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 3m 3s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 unit 0m 38s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 3m 1s hadoop-mapreduce-client-core in the patch passed.
          +1 unit 9m 22s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 24s hadoop-mapreduce-client-hs in the patch passed.
          +1 unit 0m 46s hadoop-mapreduce-examples in the patch passed.
          +1 unit 11m 39s hadoop-distcp in the patch passed.
          +1 unit 1m 1s hadoop-archives in the patch passed.
          +1 unit 0m 50s hadoop-archive-logs in the patch passed.
          +1 unit 0m 36s hadoop-rumen in the patch passed.
          +1 unit 0m 57s hadoop-extras in the patch passed.
          +1 unit 0m 29s hadoop-openstack in the patch passed.
          +1 unit 1m 38s hadoop-azure in the patch passed.
          +1 asflicense 0m 45s The patch does not generate ASF License warnings.
          207m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13427
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838402/HADOOP-13427.008.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 40247abac15b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 89354f0
          Default Java 1.8.0_101
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11048/artifact/patchprocess/branch-compile-root.txt
          findbugs v3.0.0
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11048/artifact/patchprocess/patch-compile-root.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11048/artifact/patchprocess/patch-compile-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11048/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11048/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 42s trunk passed -1 compile 7m 4s root in trunk failed. +1 checkstyle 1m 48s trunk passed +1 mvnsite 10m 5s trunk passed +1 mvneclipse 6m 55s trunk passed +1 findbugs 13m 45s trunk passed +1 javadoc 8m 6s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 6m 23s the patch passed -1 compile 5m 52s root in the patch failed. -1 javac 5m 52s root in the patch failed. +1 checkstyle 1m 51s root: The patch generated 0 new + 868 unchanged - 9 fixed = 868 total (was 877) +1 mvnsite 10m 53s the patch passed +1 mvneclipse 7m 43s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 17m 28s the patch passed +1 javadoc 8m 24s the patch passed +1 unit 9m 7s hadoop-common in the patch passed. +1 unit 1m 12s hadoop-hdfs-client in the patch passed. +1 unit 2m 33s hadoop-yarn-common in the patch passed. +1 unit 14m 42s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 3m 3s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 unit 0m 38s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 3m 1s hadoop-mapreduce-client-core in the patch passed. +1 unit 9m 22s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 24s hadoop-mapreduce-client-hs in the patch passed. +1 unit 0m 46s hadoop-mapreduce-examples in the patch passed. +1 unit 11m 39s hadoop-distcp in the patch passed. +1 unit 1m 1s hadoop-archives in the patch passed. +1 unit 0m 50s hadoop-archive-logs in the patch passed. +1 unit 0m 36s hadoop-rumen in the patch passed. +1 unit 0m 57s hadoop-extras in the patch passed. +1 unit 0m 29s hadoop-openstack in the patch passed. +1 unit 1m 38s hadoop-azure in the patch passed. +1 asflicense 0m 45s The patch does not generate ASF License warnings. 207m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13427 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838402/HADOOP-13427.008.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 40247abac15b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 89354f0 Default Java 1.8.0_101 compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11048/artifact/patchprocess/branch-compile-root.txt findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11048/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11048/artifact/patchprocess/patch-compile-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11048/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11048/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -
          checkstyle warning
          ./hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java:620:        partStream = destFs.create(tmpOutput, false, conf.getInt("io.file.buffer.size", 4096),: Line is longer than 80 characters (found 94).
          

          We didn't need this change as the trailing whitespace is totally unrelated. The v8 patch is to address this; and the trailing whitespace is the only change from v7 patch.

          +1 on the v8 patch.

          Show
          liuml07 Mingliang Liu added a comment - checkstyle warning ./hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java:620: partStream = destFs.create(tmpOutput, false , conf.getInt( "io.file.buffer.size" , 4096),: Line is longer than 80 characters (found 94). We didn't need this change as the trailing whitespace is totally unrelated. The v8 patch is to address this; and the trailing whitespace is the only change from v7 patch. +1 on the v8 patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 45s trunk passed
          +1 compile 10m 52s trunk passed
          +1 checkstyle 1m 48s trunk passed
          +1 mvnsite 10m 48s trunk passed
          +1 mvneclipse 6m 47s trunk passed
          +1 findbugs 15m 29s trunk passed
          +1 javadoc 8m 31s trunk passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 7m 16s the patch passed
          +1 compile 11m 24s the patch passed
          +1 javac 11m 24s the patch passed
          -0 checkstyle 2m 6s root: The patch generated 1 new + 867 unchanged - 10 fixed = 868 total (was 877)
          +1 mvnsite 11m 42s the patch passed
          +1 mvneclipse 8m 0s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 16m 59s the patch passed
          +1 javadoc 9m 14s the patch passed
          +1 unit 8m 29s hadoop-common in the patch passed.
          +1 unit 1m 11s hadoop-hdfs-client in the patch passed.
          +1 unit 2m 33s hadoop-yarn-common in the patch passed.
          +1 unit 15m 6s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 3m 5s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 unit 0m 39s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 3m 14s hadoop-mapreduce-client-core in the patch passed.
          +1 unit 9m 13s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 24s hadoop-mapreduce-client-hs in the patch passed.
          +1 unit 0m 47s hadoop-mapreduce-examples in the patch passed.
          +1 unit 11m 5s hadoop-distcp in the patch passed.
          +1 unit 1m 4s hadoop-archives in the patch passed.
          +1 unit 0m 50s hadoop-archive-logs in the patch passed.
          +1 unit 0m 37s hadoop-rumen in the patch passed.
          +1 unit 0m 58s hadoop-extras in the patch passed.
          +1 unit 0m 31s hadoop-openstack in the patch passed.
          +1 unit 1m 37s hadoop-azure in the patch passed.
          +1 asflicense 0m 47s The patch does not generate ASF License warnings.
          221m 53s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13427
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838340/HADOOP-13427.007.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 78b08c163cbb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 86ac1ad
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11046/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11046/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11046/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 45s trunk passed +1 compile 10m 52s trunk passed +1 checkstyle 1m 48s trunk passed +1 mvnsite 10m 48s trunk passed +1 mvneclipse 6m 47s trunk passed +1 findbugs 15m 29s trunk passed +1 javadoc 8m 31s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 7m 16s the patch passed +1 compile 11m 24s the patch passed +1 javac 11m 24s the patch passed -0 checkstyle 2m 6s root: The patch generated 1 new + 867 unchanged - 10 fixed = 868 total (was 877) +1 mvnsite 11m 42s the patch passed +1 mvneclipse 8m 0s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 16m 59s the patch passed +1 javadoc 9m 14s the patch passed +1 unit 8m 29s hadoop-common in the patch passed. +1 unit 1m 11s hadoop-hdfs-client in the patch passed. +1 unit 2m 33s hadoop-yarn-common in the patch passed. +1 unit 15m 6s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 3m 5s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 unit 0m 39s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 3m 14s hadoop-mapreduce-client-core in the patch passed. +1 unit 9m 13s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 24s hadoop-mapreduce-client-hs in the patch passed. +1 unit 0m 47s hadoop-mapreduce-examples in the patch passed. +1 unit 11m 5s hadoop-distcp in the patch passed. +1 unit 1m 4s hadoop-archives in the patch passed. +1 unit 0m 50s hadoop-archive-logs in the patch passed. +1 unit 0m 37s hadoop-rumen in the patch passed. +1 unit 0m 58s hadoop-extras in the patch passed. +1 unit 0m 31s hadoop-openstack in the patch passed. +1 unit 1m 37s hadoop-azure in the patch passed. +1 asflicense 0m 47s The patch does not generate ASF License warnings. 221m 53s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13427 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838340/HADOOP-13427.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 78b08c163cbb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 86ac1ad Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11046/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11046/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11046/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          patch 007: patch 006 resubmitted for yetus to trigger again

          Show
          stevel@apache.org Steve Loughran added a comment - patch 007: patch 006 resubmitted for yetus to trigger again
          Hide
          stevel@apache.org Steve Loughran added a comment -

          looks like some wierd maven convergence issue. I'm going to D/L the patch, rename and resubmit to see if it's gone away

          Show
          stevel@apache.org Steve Loughran added a comment - looks like some wierd maven convergence issue. I'm going to D/L the patch, rename and resubmit to see if it's gone away
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 27s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 47s trunk passed
          +1 compile 10m 50s trunk passed
          +1 checkstyle 1m 48s trunk passed
          +1 mvnsite 10m 16s trunk passed
          +1 mvneclipse 7m 2s trunk passed
          +1 findbugs 14m 22s trunk passed
          +1 javadoc 9m 1s trunk passed
          0 mvndep 0m 50s Maven dependency ordering for patch
          -1 mvninstall 0m 32s hadoop-hdfs-client in the patch failed.
          -1 mvninstall 0m 28s hadoop-yarn-common in the patch failed.
          -1 mvninstall 0m 26s hadoop-yarn-server-nodemanager in the patch failed.
          -1 mvninstall 0m 19s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          -1 mvninstall 0m 26s hadoop-yarn-server-sharedcachemanager in the patch failed.
          -1 mvninstall 0m 25s hadoop-mapreduce-client-core in the patch failed.
          -1 mvninstall 0m 26s hadoop-mapreduce-client-app in the patch failed.
          -1 mvninstall 0m 20s hadoop-mapreduce-client-hs in the patch failed.
          -1 mvninstall 0m 19s hadoop-mapreduce-examples in the patch failed.
          -1 mvninstall 0m 20s hadoop-distcp in the patch failed.
          -1 mvninstall 0m 18s hadoop-archives in the patch failed.
          -1 mvninstall 0m 18s hadoop-archive-logs in the patch failed.
          -1 mvninstall 0m 20s hadoop-rumen in the patch failed.
          -1 mvninstall 0m 19s hadoop-extras in the patch failed.
          -1 mvninstall 0m 16s hadoop-openstack in the patch failed.
          +1 compile 9m 44s the patch passed
          +1 javac 9m 44s the patch passed
          -0 checkstyle 2m 0s root: The patch generated 1 new + 867 unchanged - 10 fixed = 868 total (was 877)
          +1 mvnsite 11m 27s the patch passed
          +1 mvneclipse 8m 1s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 18m 18s the patch passed
          +1 javadoc 9m 6s the patch passed
          +1 unit 8m 39s hadoop-common in the patch passed.
          +1 unit 1m 11s hadoop-hdfs-client in the patch passed.
          +1 unit 2m 34s hadoop-yarn-common in the patch passed.
          +1 unit 15m 17s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 3m 7s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 unit 0m 40s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 3m 8s hadoop-mapreduce-client-core in the patch passed.
          +1 unit 8m 59s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 29s hadoop-mapreduce-client-hs in the patch passed.
          +1 unit 0m 48s hadoop-mapreduce-examples in the patch passed.
          +1 unit 11m 30s hadoop-distcp in the patch passed.
          +1 unit 1m 4s hadoop-archives in the patch passed.
          +1 unit 0m 47s hadoop-archive-logs in the patch passed.
          +1 unit 0m 37s hadoop-rumen in the patch passed.
          +1 unit 0m 58s hadoop-extras in the patch passed.
          +1 unit 0m 33s hadoop-openstack in the patch passed.
          +1 unit 2m 4s hadoop-azure in the patch passed.
          +1 asflicense 1m 27s The patch does not generate ASF License warnings.
          221m 25s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13427
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838248/HADOOP-13427.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux af51cdacbff6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 59ee8b7
          Default Java 1.8.0_101
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-examples.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-distcp.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-archives.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-archive-logs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-rumen.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-extras.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-openstack.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 47s trunk passed +1 compile 10m 50s trunk passed +1 checkstyle 1m 48s trunk passed +1 mvnsite 10m 16s trunk passed +1 mvneclipse 7m 2s trunk passed +1 findbugs 14m 22s trunk passed +1 javadoc 9m 1s trunk passed 0 mvndep 0m 50s Maven dependency ordering for patch -1 mvninstall 0m 32s hadoop-hdfs-client in the patch failed. -1 mvninstall 0m 28s hadoop-yarn-common in the patch failed. -1 mvninstall 0m 26s hadoop-yarn-server-nodemanager in the patch failed. -1 mvninstall 0m 19s hadoop-yarn-server-applicationhistoryservice in the patch failed. -1 mvninstall 0m 26s hadoop-yarn-server-sharedcachemanager in the patch failed. -1 mvninstall 0m 25s hadoop-mapreduce-client-core in the patch failed. -1 mvninstall 0m 26s hadoop-mapreduce-client-app in the patch failed. -1 mvninstall 0m 20s hadoop-mapreduce-client-hs in the patch failed. -1 mvninstall 0m 19s hadoop-mapreduce-examples in the patch failed. -1 mvninstall 0m 20s hadoop-distcp in the patch failed. -1 mvninstall 0m 18s hadoop-archives in the patch failed. -1 mvninstall 0m 18s hadoop-archive-logs in the patch failed. -1 mvninstall 0m 20s hadoop-rumen in the patch failed. -1 mvninstall 0m 19s hadoop-extras in the patch failed. -1 mvninstall 0m 16s hadoop-openstack in the patch failed. +1 compile 9m 44s the patch passed +1 javac 9m 44s the patch passed -0 checkstyle 2m 0s root: The patch generated 1 new + 867 unchanged - 10 fixed = 868 total (was 877) +1 mvnsite 11m 27s the patch passed +1 mvneclipse 8m 1s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 18m 18s the patch passed +1 javadoc 9m 6s the patch passed +1 unit 8m 39s hadoop-common in the patch passed. +1 unit 1m 11s hadoop-hdfs-client in the patch passed. +1 unit 2m 34s hadoop-yarn-common in the patch passed. +1 unit 15m 17s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 3m 7s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 unit 0m 40s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 3m 8s hadoop-mapreduce-client-core in the patch passed. +1 unit 8m 59s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 29s hadoop-mapreduce-client-hs in the patch passed. +1 unit 0m 48s hadoop-mapreduce-examples in the patch passed. +1 unit 11m 30s hadoop-distcp in the patch passed. +1 unit 1m 4s hadoop-archives in the patch passed. +1 unit 0m 47s hadoop-archive-logs in the patch passed. +1 unit 0m 37s hadoop-rumen in the patch passed. +1 unit 0m 58s hadoop-extras in the patch passed. +1 unit 0m 33s hadoop-openstack in the patch passed. +1 unit 2m 4s hadoop-azure in the patch passed. +1 asflicense 1m 27s The patch does not generate ASF License warnings. 221m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13427 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838248/HADOOP-13427.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux af51cdacbff6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 59ee8b7 Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-examples.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-distcp.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-archives.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-archive-logs.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-rumen.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-extras.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-openstack.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11044/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          V6 patch is fix the checkstyle and findbugs warnings.

          Show
          liuml07 Mingliang Liu added a comment - V6 patch is fix the checkstyle and findbugs warnings.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 17s Maven dependency ordering for branch
          +1 mvninstall 8m 16s trunk passed
          +1 compile 11m 54s trunk passed
          +1 checkstyle 1m 52s trunk passed
          +1 mvnsite 10m 24s trunk passed
          +1 mvneclipse 7m 5s trunk passed
          +1 findbugs 13m 54s trunk passed
          +1 javadoc 8m 18s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 6m 23s the patch passed
          +1 compile 9m 23s the patch passed
          +1 javac 9m 23s the patch passed
          -0 checkstyle 1m 54s root: The patch generated 8 new + 870 unchanged - 10 fixed = 878 total (was 880)
          +1 mvnsite 11m 10s the patch passed
          +1 mvneclipse 8m 0s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 7s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 8m 18s the patch passed
          +1 unit 9m 2s hadoop-common in the patch passed.
          +1 unit 1m 14s hadoop-hdfs-client in the patch passed.
          +1 unit 2m 34s hadoop-yarn-common in the patch passed.
          +1 unit 14m 41s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 2m 59s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 unit 0m 42s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 3m 2s hadoop-mapreduce-client-core in the patch passed.
          +1 unit 8m 53s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 23s hadoop-mapreduce-client-hs in the patch passed.
          +1 unit 0m 47s hadoop-mapreduce-examples in the patch passed.
          +1 unit 11m 18s hadoop-distcp in the patch passed.
          +1 unit 1m 3s hadoop-archives in the patch passed.
          +1 unit 0m 51s hadoop-archive-logs in the patch passed.
          +1 unit 0m 36s hadoop-rumen in the patch passed.
          +1 unit 0m 59s hadoop-extras in the patch passed.
          +1 unit 0m 30s hadoop-openstack in the patch passed.
          +1 unit 1m 38s hadoop-azure in the patch passed.
          +1 asflicense 0m 47s The patch does not generate ASF License warnings.
          217m 55s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
            org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.sharedcache.SharedCacheUploader.deleteTempFile(Path) might ignore java.io.IOException At SharedCacheUploader.java:At SharedCacheUploader.java:[line 198]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13427
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838208/HADOOP-13427.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0c8e519ee118 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 822ae88
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11043/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/11043/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11043/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11043/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 8m 16s trunk passed +1 compile 11m 54s trunk passed +1 checkstyle 1m 52s trunk passed +1 mvnsite 10m 24s trunk passed +1 mvneclipse 7m 5s trunk passed +1 findbugs 13m 54s trunk passed +1 javadoc 8m 18s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 6m 23s the patch passed +1 compile 9m 23s the patch passed +1 javac 9m 23s the patch passed -0 checkstyle 1m 54s root: The patch generated 8 new + 870 unchanged - 10 fixed = 878 total (was 880) +1 mvnsite 11m 10s the patch passed +1 mvneclipse 8m 0s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 7s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 8m 18s the patch passed +1 unit 9m 2s hadoop-common in the patch passed. +1 unit 1m 14s hadoop-hdfs-client in the patch passed. +1 unit 2m 34s hadoop-yarn-common in the patch passed. +1 unit 14m 41s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 2m 59s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 unit 0m 42s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 3m 2s hadoop-mapreduce-client-core in the patch passed. +1 unit 8m 53s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 23s hadoop-mapreduce-client-hs in the patch passed. +1 unit 0m 47s hadoop-mapreduce-examples in the patch passed. +1 unit 11m 18s hadoop-distcp in the patch passed. +1 unit 1m 3s hadoop-archives in the patch passed. +1 unit 0m 51s hadoop-archive-logs in the patch passed. +1 unit 0m 36s hadoop-rumen in the patch passed. +1 unit 0m 59s hadoop-extras in the patch passed. +1 unit 0m 30s hadoop-openstack in the patch passed. +1 unit 1m 38s hadoop-azure in the patch passed. +1 asflicense 0m 47s The patch does not generate ASF License warnings. 217m 55s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager   org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.sharedcache.SharedCacheUploader.deleteTempFile(Path) might ignore java.io.IOException At SharedCacheUploader.java:At SharedCacheUploader.java: [line 198] Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13427 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838208/HADOOP-13427.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0c8e519ee118 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 822ae88 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11043/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/11043/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11043/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11043/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          old:

          116	    if (targetFS.exists(targetFinalPath) && targetFS.isFile(targetFinalPath)) {		
          117	      overWrite = true; // When target is an existing file, overwrite it.
          

          new:

          116	    try {
          117	      overWrite = targetFS.getFileStatus(targetFinalPath).isFile();
          118	    } catch (FileNotFoundException ignored) {
          118	    }
          

          If overWrite is true before this, we may overwrite it, which is not expected.

              try {
                overWrite = overWrite || targetFS.getFileStatus(targetFinalPath).isFile();
              } catch (FileNotFoundException ignored) {
              }
          

          This should heal the failing unit test hadoop.tools.TestIntegration, see v5 patch.

          Show
          liuml07 Mingliang Liu added a comment - old: 116 if (targetFS.exists(targetFinalPath) && targetFS.isFile(targetFinalPath)) { 117 overWrite = true ; // When target is an existing file, overwrite it. new: 116 try { 117 overWrite = targetFS.getFileStatus(targetFinalPath).isFile(); 118 } catch (FileNotFoundException ignored) { 118 } If overWrite is true before this, we may overwrite it, which is not expected. try { overWrite = overWrite || targetFS.getFileStatus(targetFinalPath).isFile(); } catch (FileNotFoundException ignored) { } This should heal the failing unit test hadoop.tools.TestIntegration , see v5 patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 40s trunk passed
          +1 compile 6m 55s trunk passed
          +1 checkstyle 1m 38s trunk passed
          +1 mvnsite 7m 28s trunk passed
          +1 mvneclipse 4m 16s trunk passed
          +1 findbugs 12m 20s trunk passed
          +1 javadoc 5m 27s trunk passed
          0 mvndep 0m 45s Maven dependency ordering for patch
          -1 mvninstall 0m 33s hadoop-hdfs-client in the patch failed.
          -1 mvninstall 0m 28s hadoop-yarn-common in the patch failed.
          -1 mvninstall 0m 26s hadoop-yarn-server-nodemanager in the patch failed.
          -1 mvninstall 0m 20s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          -1 mvninstall 0m 17s hadoop-yarn-server-sharedcachemanager in the patch failed.
          -1 mvninstall 0m 26s hadoop-mapreduce-client-core in the patch failed.
          -1 mvninstall 0m 25s hadoop-mapreduce-client-app in the patch failed.
          -1 mvninstall 0m 20s hadoop-mapreduce-client-hs in the patch failed.
          -1 mvninstall 0m 19s hadoop-mapreduce-examples in the patch failed.
          -1 mvninstall 0m 19s hadoop-distcp in the patch failed.
          -1 mvninstall 0m 18s hadoop-archives in the patch failed.
          -1 mvninstall 0m 18s hadoop-archive-logs in the patch failed.
          -1 mvninstall 0m 20s hadoop-rumen in the patch failed.
          -1 mvninstall 0m 17s hadoop-extras in the patch failed.
          -1 mvninstall 0m 16s hadoop-openstack in the patch failed.
          +1 compile 8m 9s the patch passed
          +1 javac 8m 9s the patch passed
          -0 checkstyle 1m 49s root: The patch generated 8 new + 871 unchanged - 10 fixed = 879 total (was 881)
          +1 mvnsite 8m 55s the patch passed
          +1 mvneclipse 5m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 57s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 6m 26s the patch passed
          +1 unit 8m 20s hadoop-common in the patch passed.
          +1 unit 1m 8s hadoop-hdfs-client in the patch passed.
          +1 unit 2m 38s hadoop-yarn-common in the patch passed.
          +1 unit 15m 3s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 2m 48s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 unit 0m 32s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 2m 51s hadoop-mapreduce-client-core in the patch passed.
          +1 unit 8m 48s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 12s hadoop-mapreduce-client-hs in the patch passed.
          +1 unit 0m 38s hadoop-mapreduce-examples in the patch passed.
          -1 unit 11m 18s hadoop-distcp in the patch failed.
          -1 unit 15m 23s hadoop-archives in the patch failed.
          +1 unit 0m 44s hadoop-archive-logs in the patch passed.
          +1 unit 0m 27s hadoop-rumen in the patch passed.
          +1 unit 0m 47s hadoop-extras in the patch passed.
          +1 unit 0m 22s hadoop-openstack in the patch passed.
          -1 unit 1m 46s hadoop-azure in the patch failed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          202m 7s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
            org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.sharedcache.SharedCacheUploader.deleteTempFile(Path) might ignore java.io.IOException At SharedCacheUploader.java:At SharedCacheUploader.java:[line 198]
          Failed junit tests hadoop.tools.TestIntegration
            hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked
          Timed out junit tests org.apache.hadoop.tools.TestHadoopArchives



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13427
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836682/HADOOP-13427.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c3486970957c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9b0c17f
          Default Java 1.8.0_101
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-examples.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-distcp.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-archives.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-archive-logs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-rumen.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-extras.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-openstack.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-distcp.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-archives.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 40s trunk passed +1 compile 6m 55s trunk passed +1 checkstyle 1m 38s trunk passed +1 mvnsite 7m 28s trunk passed +1 mvneclipse 4m 16s trunk passed +1 findbugs 12m 20s trunk passed +1 javadoc 5m 27s trunk passed 0 mvndep 0m 45s Maven dependency ordering for patch -1 mvninstall 0m 33s hadoop-hdfs-client in the patch failed. -1 mvninstall 0m 28s hadoop-yarn-common in the patch failed. -1 mvninstall 0m 26s hadoop-yarn-server-nodemanager in the patch failed. -1 mvninstall 0m 20s hadoop-yarn-server-applicationhistoryservice in the patch failed. -1 mvninstall 0m 17s hadoop-yarn-server-sharedcachemanager in the patch failed. -1 mvninstall 0m 26s hadoop-mapreduce-client-core in the patch failed. -1 mvninstall 0m 25s hadoop-mapreduce-client-app in the patch failed. -1 mvninstall 0m 20s hadoop-mapreduce-client-hs in the patch failed. -1 mvninstall 0m 19s hadoop-mapreduce-examples in the patch failed. -1 mvninstall 0m 19s hadoop-distcp in the patch failed. -1 mvninstall 0m 18s hadoop-archives in the patch failed. -1 mvninstall 0m 18s hadoop-archive-logs in the patch failed. -1 mvninstall 0m 20s hadoop-rumen in the patch failed. -1 mvninstall 0m 17s hadoop-extras in the patch failed. -1 mvninstall 0m 16s hadoop-openstack in the patch failed. +1 compile 8m 9s the patch passed +1 javac 8m 9s the patch passed -0 checkstyle 1m 49s root: The patch generated 8 new + 871 unchanged - 10 fixed = 879 total (was 881) +1 mvnsite 8m 55s the patch passed +1 mvneclipse 5m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 57s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 6m 26s the patch passed +1 unit 8m 20s hadoop-common in the patch passed. +1 unit 1m 8s hadoop-hdfs-client in the patch passed. +1 unit 2m 38s hadoop-yarn-common in the patch passed. +1 unit 15m 3s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 2m 48s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 unit 0m 32s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 2m 51s hadoop-mapreduce-client-core in the patch passed. +1 unit 8m 48s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 12s hadoop-mapreduce-client-hs in the patch passed. +1 unit 0m 38s hadoop-mapreduce-examples in the patch passed. -1 unit 11m 18s hadoop-distcp in the patch failed. -1 unit 15m 23s hadoop-archives in the patch failed. +1 unit 0m 44s hadoop-archive-logs in the patch passed. +1 unit 0m 27s hadoop-rumen in the patch passed. +1 unit 0m 47s hadoop-extras in the patch passed. +1 unit 0m 22s hadoop-openstack in the patch passed. -1 unit 1m 46s hadoop-azure in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 202m 7s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager   org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.sharedcache.SharedCacheUploader.deleteTempFile(Path) might ignore java.io.IOException At SharedCacheUploader.java:At SharedCacheUploader.java: [line 198] Failed junit tests hadoop.tools.TestIntegration   hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked Timed out junit tests org.apache.hadoop.tools.TestHadoopArchives Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13427 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836682/HADOOP-13427.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c3486970957c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9b0c17f Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-examples.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-distcp.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-archives.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-archive-logs.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-rumen.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-extras.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-openstack.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-distcp.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-archives.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10966/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          So we'll see less test failures with v4 patch? org.apache.hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked is failing without this patch. I posted comment in HADOOP-7352.

          Findbugs warnings are interesting. Seems existing behavior; will confirm this.

          Show
          liuml07 Mingliang Liu added a comment - So we'll see less test failures with v4 patch? org.apache.hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked is failing without this patch. I posted comment in HADOOP-7352 . Findbugs warnings are interesting. Seems existing behavior; will confirm this.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          both these cases are pushing into the exception handler what was was going on already; essentially: better diagnostics

          Show
          stevel@apache.org Steve Loughran added a comment - both these cases are pushing into the exception handler what was was going on already; essentially: better diagnostics
          Hide
          stevel@apache.org Steve Loughran added a comment -

          we can do a joint vote on the final patch, perhaps.

          tests are still failing though; we'll have to look at that

          Show
          stevel@apache.org Steve Loughran added a comment - we can do a joint vote on the final patch, perhaps. tests are still failing though; we'll have to look at that
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 24s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 8m 7s trunk passed
          +1 compile 6m 53s trunk passed
          +1 checkstyle 1m 37s trunk passed
          +1 mvnsite 7m 24s trunk passed
          +1 mvneclipse 4m 11s trunk passed
          +1 findbugs 10m 58s trunk passed
          +1 javadoc 5m 24s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 6m 51s the patch passed
          +1 compile 7m 30s the patch passed
          +1 javac 7m 30s the patch passed
          -0 checkstyle 1m 43s root: The patch generated 8 new + 850 unchanged - 10 fixed = 858 total (was 860)
          +1 mvnsite 8m 16s the patch passed
          +1 mvneclipse 5m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 6s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 findbugs 0m 52s hadoop-tools/hadoop-rumen generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 6m 39s the patch passed
          -1 unit 8m 40s hadoop-common in the patch failed.
          +1 unit 1m 15s hadoop-hdfs-client in the patch passed.
          -1 unit 2m 38s hadoop-yarn-common in the patch failed.
          +1 unit 15m 25s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 3m 23s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          +1 unit 0m 59s hadoop-yarn-server-sharedcachemanager in the patch passed.
          -1 unit 3m 13s hadoop-mapreduce-client-core in the patch failed.
          +1 unit 9m 43s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 43s hadoop-mapreduce-client-hs in the patch passed.
          +1 unit 0m 45s hadoop-mapreduce-examples in the patch passed.
          -1 unit 11m 6s hadoop-distcp in the patch failed.
          -1 unit 15m 23s hadoop-archives in the patch failed.
          +1 unit 0m 47s hadoop-archive-logs in the patch passed.
          +1 unit 0m 28s hadoop-rumen in the patch passed.
          +1 unit 0m 54s hadoop-extras in the patch passed.
          +1 unit 0m 22s hadoop-openstack in the patch passed.
          -1 unit 1m 44s hadoop-azure in the patch failed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          205m 36s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
            org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.sharedcache.SharedCacheUploader.deleteTempFile(Path) might ignore java.io.IOException At SharedCacheUploader.java:At SharedCacheUploader.java:[line 198]
          FindBugs module:hadoop-tools/hadoop-rumen
            Dead store to fs in org.apache.hadoop.tools.rumen.state.StatePool.reload() At StatePool.java:org.apache.hadoop.tools.rumen.state.StatePool.reload() At StatePool.java:[line 188]
          Failed junit tests hadoop.fs.TestLocalFileSystem
            hadoop.yarn.nodelabels.TestFileSystemNodeLabelsStore
            hadoop.yarn.server.applicationhistoryservice.TestFileSystemApplicationHistoryStore
            hadoop.mapreduce.lib.output.TestPreemptableFileOutputCommitter
            hadoop.tools.TestIntegration
            hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked
          Timed out junit tests org.apache.hadoop.tools.TestHadoopArchives



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13427
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836442/HADOOP-13427.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux be068b3912bd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 76893a4
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/new-findbugs-hadoop-tools_hadoop-rumen.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-distcp.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-archives.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 8m 7s trunk passed +1 compile 6m 53s trunk passed +1 checkstyle 1m 37s trunk passed +1 mvnsite 7m 24s trunk passed +1 mvneclipse 4m 11s trunk passed +1 findbugs 10m 58s trunk passed +1 javadoc 5m 24s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 6m 51s the patch passed +1 compile 7m 30s the patch passed +1 javac 7m 30s the patch passed -0 checkstyle 1m 43s root: The patch generated 8 new + 850 unchanged - 10 fixed = 858 total (was 860) +1 mvnsite 8m 16s the patch passed +1 mvneclipse 5m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 6s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 findbugs 0m 52s hadoop-tools/hadoop-rumen generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 6m 39s the patch passed -1 unit 8m 40s hadoop-common in the patch failed. +1 unit 1m 15s hadoop-hdfs-client in the patch passed. -1 unit 2m 38s hadoop-yarn-common in the patch failed. +1 unit 15m 25s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 3m 23s hadoop-yarn-server-applicationhistoryservice in the patch failed. +1 unit 0m 59s hadoop-yarn-server-sharedcachemanager in the patch passed. -1 unit 3m 13s hadoop-mapreduce-client-core in the patch failed. +1 unit 9m 43s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 43s hadoop-mapreduce-client-hs in the patch passed. +1 unit 0m 45s hadoop-mapreduce-examples in the patch passed. -1 unit 11m 6s hadoop-distcp in the patch failed. -1 unit 15m 23s hadoop-archives in the patch failed. +1 unit 0m 47s hadoop-archive-logs in the patch passed. +1 unit 0m 28s hadoop-rumen in the patch passed. +1 unit 0m 54s hadoop-extras in the patch passed. +1 unit 0m 22s hadoop-openstack in the patch passed. -1 unit 1m 44s hadoop-azure in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 205m 36s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager   org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.sharedcache.SharedCacheUploader.deleteTempFile(Path) might ignore java.io.IOException At SharedCacheUploader.java:At SharedCacheUploader.java: [line 198] FindBugs module:hadoop-tools/hadoop-rumen   Dead store to fs in org.apache.hadoop.tools.rumen.state.StatePool.reload() At StatePool.java:org.apache.hadoop.tools.rumen.state.StatePool.reload() At StatePool.java: [line 188] Failed junit tests hadoop.fs.TestLocalFileSystem   hadoop.yarn.nodelabels.TestFileSystemNodeLabelsStore   hadoop.yarn.server.applicationhistoryservice.TestFileSystemApplicationHistoryStore   hadoop.mapreduce.lib.output.TestPreemptableFileOutputCommitter   hadoop.tools.TestIntegration   hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked Timed out junit tests org.apache.hadoop.tools.TestHadoopArchives Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13427 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836442/HADOOP-13427.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux be068b3912bd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 76893a4 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/new-findbugs-hadoop-tools_hadoop-rumen.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-distcp.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-archives.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-azure.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10951/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          +1 the v2 patch.

          I rebased the patch from trunk branch as the v2 patch can not apply cleanly. It may be interesting if Steve Loughran can +1 for your own patch, see HADOOP-13427.003.patch.

          I don't quite get the following code snippet:

          SwiftTestUtils.java
          496	      throw (IOException)new FileNotFoundException(message + ": not found "
          497	          + path + " in " + path.getParent() + ": " + e + " -- "
          498	           + ls(fileSystem, path.getParent())).initCause(e);
          

          and

          FileSystemApplicationHistoryStore.java
          658	    try {
          659	      fs.getFileStatus(applicationHistoryFile);
          660	    } catch (FileNotFoundException e) {
          661	      throw (FileNotFoundException) new FileNotFoundException
          662	          ("History file for application " + appId + " is not found: " + e)
          663	          .initCause(e);
          
          Show
          liuml07 Mingliang Liu added a comment - +1 the v2 patch. I rebased the patch from trunk branch as the v2 patch can not apply cleanly. It may be interesting if Steve Loughran can +1 for your own patch, see HADOOP-13427.003.patch . I don't quite get the following code snippet: SwiftTestUtils.java 496 throw (IOException) new FileNotFoundException(message + ": not found " 497 + path + " in " + path.getParent() + ": " + e + " -- " 498 + ls(fileSystem, path.getParent())).initCause(e); and FileSystemApplicationHistoryStore.java 658 try { 659 fs.getFileStatus(applicationHistoryFile); 660 } catch (FileNotFoundException e) { 661 throw (FileNotFoundException) new FileNotFoundException 662 ( "History file for application " + appId + " is not found: " + e) 663 .initCause(e);
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 5s HADOOP-13427 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HADOOP-13427
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830700/HADOOP-13427-002.patch
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10949/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HADOOP-13427 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-13427 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830700/HADOOP-13427-002.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10949/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Patch 002: patch 001 rebased to trunk, to see what is failing.

          Show
          stevel@apache.org Steve Loughran added a comment - Patch 002: patch 001 rebased to trunk, to see what is failing.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 17s Maven dependency ordering for branch
          +1 mvninstall 7m 16s trunk passed
          +1 compile 8m 5s trunk passed
          +1 checkstyle 1m 37s trunk passed
          +1 mvnsite 8m 41s trunk passed
          +1 mvneclipse 4m 29s trunk passed
          +1 findbugs 13m 11s trunk passed
          +1 javadoc 6m 45s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 7m 52s the patch passed
          +1 compile 7m 46s the patch passed
          +1 javac 7m 46s the patch passed
          -0 checkstyle 1m 41s root: The patch generated 8 new + 861 unchanged - 10 fixed = 869 total (was 871)
          +1 mvnsite 9m 17s the patch passed
          +1 mvneclipse 5m 22s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 59s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 findbugs 0m 46s hadoop-tools/hadoop-rumen generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 7m 26s the patch passed
          -1 unit 7m 58s hadoop-common in the patch failed.
          +1 unit 1m 3s hadoop-hdfs-client in the patch passed.
          -1 unit 56m 17s hadoop-hdfs in the patch failed.
          -1 unit 2m 33s hadoop-yarn-common in the patch failed.
          +1 unit 13m 29s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 2m 56s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          +1 unit 0m 35s hadoop-yarn-server-sharedcachemanager in the patch passed.
          -1 unit 2m 15s hadoop-mapreduce-client-core in the patch failed.
          +1 unit 9m 3s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 6m 44s hadoop-mapreduce-client-hs in the patch passed.
          +1 unit 0m 40s hadoop-mapreduce-examples in the patch passed.
          -1 unit 9m 3s hadoop-distcp in the patch failed.
          +1 unit 0m 58s hadoop-archives in the patch passed.
          +1 unit 0m 43s hadoop-archive-logs in the patch passed.
          +1 unit 0m 28s hadoop-rumen in the patch passed.
          +1 unit 0m 59s hadoop-extras in the patch passed.
          +1 unit 0m 22s hadoop-openstack in the patch passed.
          +1 unit 1m 28s hadoop-azure in the patch passed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          252m 34s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
            org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.sharedcache.SharedCacheUploader.deleteTempFile(Path) might ignore java.io.IOException At SharedCacheUploader.java:At SharedCacheUploader.java:[line 198]
          FindBugs module:hadoop-tools/hadoop-rumen
            Dead store to fs in org.apache.hadoop.tools.rumen.state.StatePool.reload() At StatePool.java:org.apache.hadoop.tools.rumen.state.StatePool.reload() At StatePool.java:[line 190]
          Failed junit tests hadoop.fs.TestLocalFileSystem
            hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.web.TestWebHDFSForHA
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
            hadoop.hdfs.TestDFSInotifyEventInputStream
            hadoop.hdfs.TestDecommission
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.server.mover.TestMover
            hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler
            hadoop.hdfs.server.namenode.TestEditLogAutoroll
            hadoop.hdfs.server.namenode.ha.TestDNFencing
            hadoop.hdfs.TestRollingUpgradeDowngrade
            hadoop.hdfs.TestDFSShell
            hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
            hadoop.hdfs.TestDFSClientFailover
            hadoop.hdfs.tools.TestDFSHAAdminMiniCluster
            hadoop.hdfs.server.mover.TestStorageMover
            hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
            hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA
            hadoop.hdfs.server.namenode.ha.TestStandbyInProgressTail
            hadoop.hdfs.server.namenode.ha.TestHAFsck
            hadoop.hdfs.server.namenode.TestNamenodeRetryCache
            hadoop.hdfs.server.namenode.ha.TestNNHealthCheck
            hadoop.hdfs.TestMiniDFSCluster
            hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement
            hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
            hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled
            hadoop.hdfs.tools.TestDFSAdminWithHA
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
            hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
            hadoop.hdfs.server.namenode.ha.TestStateTransitionFailure
            hadoop.hdfs.server.namenode.ha.TestGetGroupsWithHA
            hadoop.hdfs.server.namenode.TestNameNodeMXBean
            hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages
            hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.TestEncryptionZonesWithHA
            hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
            hadoop.hdfs.TestRollingUpgradeRollback
            hadoop.hdfs.server.namenode.ha.TestQuotasWithHA
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.ha.TestHAMetrics
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir
            hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
            hadoop.hdfs.qjournal.TestNNWithQJM
            hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA
            hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.server.datanode.TestLargeBlockReport
            hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
            hadoop.yarn.nodelabels.TestFileSystemNodeLabelsStore
            hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices
            hadoop.yarn.server.applicationhistoryservice.TestFileSystemApplicationHistoryStore
            hadoop.mapreduce.lib.output.TestPreemptableFileOutputCommitter
            hadoop.tools.TestIntegration



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824612/HADOOP-13427-001.patch
          JIRA Issue HADOOP-13427
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux acae5eda1383 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 03a9343
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/new-findbugs-hadoop-tools_hadoop-rumen.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-distcp.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 7m 16s trunk passed +1 compile 8m 5s trunk passed +1 checkstyle 1m 37s trunk passed +1 mvnsite 8m 41s trunk passed +1 mvneclipse 4m 29s trunk passed +1 findbugs 13m 11s trunk passed +1 javadoc 6m 45s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 7m 52s the patch passed +1 compile 7m 46s the patch passed +1 javac 7m 46s the patch passed -0 checkstyle 1m 41s root: The patch generated 8 new + 861 unchanged - 10 fixed = 869 total (was 871) +1 mvnsite 9m 17s the patch passed +1 mvneclipse 5m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 59s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 findbugs 0m 46s hadoop-tools/hadoop-rumen generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 7m 26s the patch passed -1 unit 7m 58s hadoop-common in the patch failed. +1 unit 1m 3s hadoop-hdfs-client in the patch passed. -1 unit 56m 17s hadoop-hdfs in the patch failed. -1 unit 2m 33s hadoop-yarn-common in the patch failed. +1 unit 13m 29s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 2m 56s hadoop-yarn-server-applicationhistoryservice in the patch failed. +1 unit 0m 35s hadoop-yarn-server-sharedcachemanager in the patch passed. -1 unit 2m 15s hadoop-mapreduce-client-core in the patch failed. +1 unit 9m 3s hadoop-mapreduce-client-app in the patch passed. +1 unit 6m 44s hadoop-mapreduce-client-hs in the patch passed. +1 unit 0m 40s hadoop-mapreduce-examples in the patch passed. -1 unit 9m 3s hadoop-distcp in the patch failed. +1 unit 0m 58s hadoop-archives in the patch passed. +1 unit 0m 43s hadoop-archive-logs in the patch passed. +1 unit 0m 28s hadoop-rumen in the patch passed. +1 unit 0m 59s hadoop-extras in the patch passed. +1 unit 0m 22s hadoop-openstack in the patch passed. +1 unit 1m 28s hadoop-azure in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 252m 34s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager   org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.sharedcache.SharedCacheUploader.deleteTempFile(Path) might ignore java.io.IOException At SharedCacheUploader.java:At SharedCacheUploader.java: [line 198] FindBugs module:hadoop-tools/hadoop-rumen   Dead store to fs in org.apache.hadoop.tools.rumen.state.StatePool.reload() At StatePool.java:org.apache.hadoop.tools.rumen.state.StatePool.reload() At StatePool.java: [line 190] Failed junit tests hadoop.fs.TestLocalFileSystem   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.web.TestWebHDFSForHA   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits   hadoop.hdfs.TestDFSInotifyEventInputStream   hadoop.hdfs.TestDecommission   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.mover.TestMover   hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler   hadoop.hdfs.server.namenode.TestEditLogAutoroll   hadoop.hdfs.server.namenode.ha.TestDNFencing   hadoop.hdfs.TestRollingUpgradeDowngrade   hadoop.hdfs.TestDFSShell   hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication   hadoop.hdfs.TestDFSClientFailover   hadoop.hdfs.tools.TestDFSHAAdminMiniCluster   hadoop.hdfs.server.mover.TestStorageMover   hadoop.hdfs.server.namenode.ha.TestBootstrapStandby   hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA   hadoop.hdfs.server.namenode.ha.TestStandbyInProgressTail   hadoop.hdfs.server.namenode.ha.TestHAFsck   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.server.namenode.ha.TestNNHealthCheck   hadoop.hdfs.TestMiniDFSCluster   hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs   hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled   hadoop.hdfs.tools.TestDFSAdminWithHA   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.hdfs.server.namenode.ha.TestStateTransitionFailure   hadoop.hdfs.server.namenode.ha.TestGetGroupsWithHA   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages   hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.TestEncryptionZonesWithHA   hadoop.hdfs.server.namenode.ha.TestHAStateTransitions   hadoop.hdfs.TestRollingUpgradeRollback   hadoop.hdfs.server.namenode.ha.TestQuotasWithHA   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestHAMetrics   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir   hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics   hadoop.hdfs.qjournal.TestNNWithQJM   hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA   hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.datanode.TestLargeBlockReport   hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes   hadoop.yarn.nodelabels.TestFileSystemNodeLabelsStore   hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices   hadoop.yarn.server.applicationhistoryservice.TestFileSystemApplicationHistoryStore   hadoop.mapreduce.lib.output.TestPreemptableFileOutputCommitter   hadoop.tools.TestIntegration Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824612/HADOOP-13427-001.patch JIRA Issue HADOOP-13427 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux acae5eda1383 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 03a9343 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/new-findbugs-hadoop-tools_hadoop-rumen.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-distcp.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-distcp hadoop-tools/hadoop-archives hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-extras hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10310/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          useful utility operations which would simplify code

          1. a FileUtils.deleteQuietly(fs, Path...) which deletes all listed paths and swallows exceptions
          2. a FileUtils.deleteOrFail(fs, Path...) which raises an exception if a delete fails and there is a file leftover
          Show
          stevel@apache.org Steve Loughran added a comment - useful utility operations which would simplify code a FileUtils.deleteQuietly(fs, Path...) which deletes all listed paths and swallows exceptions a FileUtils.deleteOrFail(fs, Path...) which raises an exception if a delete fails and there is a file leftover
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Patch 001

          -replace exists calls with getFileStatus
          -remove exists checks before delete, rename when not needed
          -remove exists checks before mkdirs

          There's a few places which raise IO exceptions on nonexistence where getFileStatus() raises the FNFE exception anyway; I've retained those by having them generate the existing exception & text, but now with the inner exception included. We could just get rid of the wrapping entirely for cleaner code.

          Show
          stevel@apache.org Steve Loughran added a comment - Patch 001 -replace exists calls with getFileStatus -remove exists checks before delete, rename when not needed -remove exists checks before mkdirs There's a few places which raise IO exceptions on nonexistence where getFileStatus() raises the FNFE exception anyway; I've retained those by having them generate the existing exception & text, but now with the inner exception included. We could just get rid of the wrapping entirely for cleaner code.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Other plans

          No checks before a delete(), nor afterwards. delete() always deletes the path, except if there is a root path or other entry in "fs.protected.directories". If we really want that check then it would make sense to factor it out into a utility which raised an exception here

          Show
          stevel@apache.org Steve Loughran added a comment - Other plans No checks before a delete(), nor afterwards. delete() always deletes the path, except if there is a root path or other entry in "fs.protected.directories" . If we really want that check then it would make sense to factor it out into a utility which raised an exception here
          Hide
          stevel@apache.org Steve Loughran added a comment -

          noted during initial review (and related_, org.apache.hadoop.security.Credentials is catching and downgrading all IOE subclasses to IOEs. it shouldn't, and so FNFEs will continue to be raised as such

          Show
          stevel@apache.org Steve Loughran added a comment - noted during initial review (and related_, org.apache.hadoop.security.Credentials is catching and downgrading all IOE subclasses to IOEs. it shouldn't, and so FNFEs will continue to be raised as such

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development