Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      Fix compile warnings generated after migrating JDK8.

      This is a sub-task of HADOOP-13369.

      1. HADOOP-13417.03.patch
        4 kB
        Kai Sasaki
      2. HADOOP-13417.02.patch
        4 kB
        Kai Sasaki
      3. HADOOP-13417.01.patch
        4 kB
        Kai Sasaki

        Issue Links

          Activity

          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks for filing these jiras. I am converting them to subtasks of HADOOP-13369.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks for filing these jiras. I am converting them to subtasks of HADOOP-13369 .
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 47s trunk passed
          +1 compile 8m 50s trunk passed
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 19s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          +1 findbugs 0m 23s trunk passed
          +1 javadoc 0m 12s trunk passed
          +1 mvninstall 0m 16s the patch passed
          +1 compile 8m 31s the patch passed
          +1 javac 8m 31s root generated 0 new + 703 unchanged - 7 fixed = 703 total (was 710)
          -0 checkstyle 0m 14s hadoop-common-project/hadoop-auth: The patch generated 5 new + 24 unchanged - 7 fixed = 29 total (was 31)
          +1 mvnsite 0m 19s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 31s the patch passed
          +1 javadoc 0m 13s the patch passed
          +1 unit 3m 25s hadoop-auth in the patch passed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          34m 43s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821611/HADOOP-13417.01.patch
          JIRA Issue HADOOP-13417
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 799b8f1cff61 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7fc70c6
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10152/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-auth.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10152/testReport/
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10152/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 47s trunk passed +1 compile 8m 50s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 0m 23s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 8m 31s the patch passed +1 javac 8m 31s root generated 0 new + 703 unchanged - 7 fixed = 703 total (was 710) -0 checkstyle 0m 14s hadoop-common-project/hadoop-auth: The patch generated 5 new + 24 unchanged - 7 fixed = 29 total (was 31) +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 31s the patch passed +1 javadoc 0m 13s the patch passed +1 unit 3m 25s hadoop-auth in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 34m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821611/HADOOP-13417.01.patch JIRA Issue HADOOP-13417 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 799b8f1cff61 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7fc70c6 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10152/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-auth.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10152/testReport/ modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10152/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Kai Sasaki for cleaning up the code. One comment: The lambda statement can be cleaned up as follows:

              // Register auth schema
              builder.setDefaultAuthSchemeRegistry(s -> 
                  httpContext -> new SPNegoScheme(true, true)
              );
          
          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Kai Sasaki for cleaning up the code. One comment: The lambda statement can be cleaned up as follows: // Register auth schema builder.setDefaultAuthSchemeRegistry(s -> httpContext -> new SPNegoScheme( true , true ) );
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 51s trunk passed
          +1 compile 6m 59s trunk passed
          +1 checkstyle 0m 12s trunk passed
          +1 mvnsite 0m 16s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          +1 findbugs 0m 21s trunk passed
          +1 javadoc 0m 12s trunk passed
          +1 mvninstall 0m 12s the patch passed
          +1 compile 6m 52s the patch passed
          +1 javac 6m 52s root generated 0 new + 702 unchanged - 7 fixed = 702 total (was 709)
          +1 checkstyle 0m 12s hadoop-common-project/hadoop-auth: The patch generated 0 new + 24 unchanged - 7 fixed = 24 total (was 31)
          +1 mvnsite 0m 17s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 30s the patch passed
          +1 javadoc 0m 12s the patch passed
          +1 unit 3m 14s hadoop-auth in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          28m 36s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821781/HADOOP-13417.02.patch
          JIRA Issue HADOOP-13417
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 37e8d4263e45 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4ef1bc0
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10161/testReport/
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10161/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 51s trunk passed +1 compile 6m 59s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 16s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 0m 21s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 12s the patch passed +1 compile 6m 52s the patch passed +1 javac 6m 52s root generated 0 new + 702 unchanged - 7 fixed = 702 total (was 709) +1 checkstyle 0m 12s hadoop-common-project/hadoop-auth: The patch generated 0 new + 24 unchanged - 7 fixed = 24 total (was 31) +1 mvnsite 0m 17s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 3m 14s hadoop-auth in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 28m 36s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821781/HADOOP-13417.02.patch JIRA Issue HADOOP-13417 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 37e8d4263e45 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4ef1bc0 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10161/testReport/ modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10161/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          lewuathe Kai Sasaki added a comment -

          Akira Ajisaka Thanks for pointing out! I fixed that in addition to checkstyle issues.

          Show
          lewuathe Kai Sasaki added a comment - Akira Ajisaka Thanks for pointing out! I fixed that in addition to checkstyle issues.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The patch is not related to javadoc, so changed the title.

          Show
          ajisakaa Akira Ajisaka added a comment - The patch is not related to javadoc, so changed the title.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 22s trunk passed
          +1 compile 7m 23s trunk passed
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 17s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          +1 findbugs 0m 21s trunk passed
          +1 javadoc 0m 12s trunk passed
          +1 mvninstall 0m 12s the patch passed
          +1 compile 7m 8s the patch passed
          +1 javac 7m 8s root generated 0 new + 702 unchanged - 7 fixed = 702 total (was 709)
          -0 checkstyle 0m 12s hadoop-common-project/hadoop-auth: The patch generated 5 new + 24 unchanged - 7 fixed = 29 total (was 31)
          +1 mvnsite 0m 17s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 29s the patch passed
          +1 javadoc 0m 12s the patch passed
          +1 unit 3m 5s hadoop-auth in the patch passed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          29m 43s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13417
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833112/HADOOP-13417.03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b55896c443a9 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 901eca0
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10762/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-auth.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10762/testReport/
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10762/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 22s trunk passed +1 compile 7m 23s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 17s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 0m 21s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 12s the patch passed +1 compile 7m 8s the patch passed +1 javac 7m 8s root generated 0 new + 702 unchanged - 7 fixed = 702 total (was 709) -0 checkstyle 0m 12s hadoop-common-project/hadoop-auth: The patch generated 5 new + 24 unchanged - 7 fixed = 29 total (was 31) +1 mvnsite 0m 17s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 29s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 3m 5s hadoop-auth in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 29m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13417 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833112/HADOOP-13417.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b55896c443a9 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 901eca0 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10762/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-auth.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10762/testReport/ modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10762/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          03 patch looks to be the same as 01 patch. I'll commit 02 patch tomorrow if there are no objections.

          Show
          ajisakaa Akira Ajisaka added a comment - 03 patch looks to be the same as 01 patch. I'll commit 02 patch tomorrow if there are no objections.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Thanks Kai Sasaki for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Kai Sasaki for the contribution!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10609 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10609/)
          HADOOP-13417. Fix javac and checkstyle warnings in hadoop-auth package. (aajisaka: rev 5a5a724731b74df9eed2de5f3370bcb8023fa2eb)

          • (edit) hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/AuthenticatorTestCase.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10609 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10609/ ) HADOOP-13417 . Fix javac and checkstyle warnings in hadoop-auth package. (aajisaka: rev 5a5a724731b74df9eed2de5f3370bcb8023fa2eb) (edit) hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/client/AuthenticatorTestCase.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I forgot to add "Contributed by Kai Sasaki" to the commit message. Sorry for that.

          Show
          ajisakaa Akira Ajisaka added a comment - I forgot to add "Contributed by Kai Sasaki" to the commit message. Sorry for that.
          Hide
          lewuathe Kai Sasaki added a comment -

          Akira Ajisaka No problem. Thanks for taking care!

          Show
          lewuathe Kai Sasaki added a comment - Akira Ajisaka No problem. Thanks for taking care!

            People

            • Assignee:
              lewuathe Kai Sasaki
              Reporter:
              lewuathe Kai Sasaki
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development