Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13387

users always get told off for using S3 —even when not using it.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0
    • Component/s: fs/s3
    • Labels:
      None
    • Target Version/s:

      Description

      The warning telling people not to use s3 appears during filesystem initialization -even if you aren't using the FS. This is because it is printed during static initialization, and when the FS code loads all available filesystems, that static code is inited.

      It needs to be moved into the init() code of an instance

      1. HADOOP-13887-branch-2-002.patch
        2 kB
        Steve Loughran
      2. HADOOP-13887-branch-2-001.patch
        2 kB
        Steve Loughran

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          thanks, committed to branches 2.8 and 2. Not needed for trunk, obviously.

          Show
          stevel@apache.org Steve Loughran added a comment - thanks, committed to branches 2.8 and 2. Not needed for trunk, obviously.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 2s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 37s branch-2 passed
          +1 compile 0m 13s branch-2 passed with JDK v1.8.0_91
          +1 compile 0m 15s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 0m 15s branch-2 passed
          +1 mvnsite 0m 21s branch-2 passed
          +1 mvneclipse 0m 26s branch-2 passed
          +1 findbugs 0m 33s branch-2 passed
          +1 javadoc 0m 13s branch-2 passed with JDK v1.8.0_91
          +1 javadoc 0m 16s branch-2 passed with JDK v1.7.0_101
          +1 mvninstall 0m 14s the patch passed
          +1 compile 0m 11s the patch passed with JDK v1.8.0_91
          +1 javac 0m 11s the patch passed
          +1 compile 0m 13s the patch passed with JDK v1.7.0_101
          +1 javac 0m 13s the patch passed
          -0 checkstyle 0m 12s hadoop-tools/hadoop-aws: The patch generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48)
          +1 mvnsite 0m 18s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 42s the patch passed
          +1 javadoc 0m 11s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 13s the patch passed with JDK v1.7.0_101
          +1 unit 0m 14s hadoop-aws in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          27m 6s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818855/HADOOP-13887-branch-2-001.patch
          JIRA Issue HADOOP-13387
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b85e5ba93cc8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / ad8180f
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10027/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-aws.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10027/testReport/
          modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10027/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 2s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 37s branch-2 passed +1 compile 0m 13s branch-2 passed with JDK v1.8.0_91 +1 compile 0m 15s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 15s branch-2 passed +1 mvnsite 0m 21s branch-2 passed +1 mvneclipse 0m 26s branch-2 passed +1 findbugs 0m 33s branch-2 passed +1 javadoc 0m 13s branch-2 passed with JDK v1.8.0_91 +1 javadoc 0m 16s branch-2 passed with JDK v1.7.0_101 +1 mvninstall 0m 14s the patch passed +1 compile 0m 11s the patch passed with JDK v1.8.0_91 +1 javac 0m 11s the patch passed +1 compile 0m 13s the patch passed with JDK v1.7.0_101 +1 javac 0m 13s the patch passed -0 checkstyle 0m 12s hadoop-tools/hadoop-aws: The patch generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48) +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 42s the patch passed +1 javadoc 0m 11s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_101 +1 unit 0m 14s hadoop-aws in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 27m 6s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818855/HADOOP-13887-branch-2-001.patch JIRA Issue HADOOP-13387 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b85e5ba93cc8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / ad8180f Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10027/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-aws.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10027/testReport/ modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10027/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          I missed the cases when FS code loads all available filesystems when I tested the HADOOP-13239 manually. Thanks Steve Loughran for reporting this and providing a patch. The fix looks very good to me.

          Show
          liuml07 Mingliang Liu added a comment - I missed the cases when FS code loads all available filesystems when I tested the HADOOP-13239 manually. Thanks Steve Loughran for reporting this and providing a patch. The fix looks very good to me.
          Hide
          chris.douglas Chris Douglas added a comment -

          With the change to AtomicBoolean, warnDeprecation doesn't need to be synchronized.

          +1

          Show
          chris.douglas Chris Douglas added a comment - With the change to AtomicBoolean, warnDeprecation doesn't need to be synchronized. +1
          Hide
          stevel@apache.org Steve Loughran added a comment -

          tested against s3 ireland

          Show
          stevel@apache.org Steve Loughran added a comment - tested against s3 ireland
          Hide
          stevel@apache.org Steve Loughran added a comment -

          code, no tests.

          Evidence it works from the output of one of the tests

          2016-07-19 17:39:07,033 [Thread-0] WARN  fs.FileSystem (S3FileSystem.java:warnDeprecation(84)) - S3FileSystem is deprecated and will be removed in future releases. Use NativeS3FileSystem or S3AFileSystem instead.
          2016-07-19 17:39:07,105 [Thread-0] INFO  contract.AbstractFSContractTestBase (AbstractFSContractTestBase.java:setup(172)) - Test filesystem = s3://hwdev-steve-new implemented by org.apache.hadoop.fs.s3.S3FileSystem@79791d72
          2016-07-19 17:39:12,207 [Thread-0] INFO  contract.AbstractFSContractTestBase (AbstractFSContractTestBase.java:describe(240)) - readFully zero bytes from an offset past EOF
          2016-07-19 17:39:12,371 [Thread-0] INFO  contract.AbstractContractSeekTest (AbstractContractSeekTest.java:testReadFullyZeroBytebufferPastEOF(504)) - Filesystem short-circuits 0-byte reads
          

          The message is printed once only.

          Show
          stevel@apache.org Steve Loughran added a comment - code, no tests. Evidence it works from the output of one of the tests 2016-07-19 17:39:07,033 [ Thread -0] WARN fs.FileSystem (S3FileSystem.java:warnDeprecation(84)) - S3FileSystem is deprecated and will be removed in future releases. Use NativeS3FileSystem or S3AFileSystem instead. 2016-07-19 17:39:07,105 [ Thread -0] INFO contract.AbstractFSContractTestBase (AbstractFSContractTestBase.java:setup(172)) - Test filesystem = s3: //hwdev-steve- new implemented by org.apache.hadoop.fs.s3.S3FileSystem@79791d72 2016-07-19 17:39:12,207 [ Thread -0] INFO contract.AbstractFSContractTestBase (AbstractFSContractTestBase.java:describe(240)) - readFully zero bytes from an offset past EOF 2016-07-19 17:39:12,371 [ Thread -0] INFO contract.AbstractContractSeekTest (AbstractContractSeekTest.java:testReadFullyZeroBytebufferPastEOF(504)) - Filesystem short -circuits 0- byte reads The message is printed once only.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          example log

          Discovery starting.
          2016-07-19 16:07:43,375 INFO  s3.S3aIOSuite (Logging.scala:logInfo(54)) - Loading configuration from ../../cloud.xml
          2016-07-19 16:07:43,713 WARN  util.NativeCodeLoader (NativeCodeLoader.java:<clinit>(62)) - Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
          S3FileSystem is deprecated and will be removed in future releases. Use NativeS3FileSystem or S3AFileSystem instead.
          
          Show
          stevel@apache.org Steve Loughran added a comment - example log Discovery starting. 2016-07-19 16:07:43,375 INFO s3.S3aIOSuite (Logging.scala:logInfo(54)) - Loading configuration from ../../cloud.xml 2016-07-19 16:07:43,713 WARN util.NativeCodeLoader (NativeCodeLoader.java:<clinit>(62)) - Unable to load native -hadoop library for your platform... using builtin-java classes where applicable S3FileSystem is deprecated and will be removed in future releases. Use NativeS3FileSystem or S3AFileSystem instead.

            People

            • Assignee:
              stevel@apache.org Steve Loughran
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development