[HADOOP-13380] TestBasicDiskValidator should not write data to /tmp

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.9.0
• Fix Version/s: 2.9.0, 3.0.0-alpha1
• Target Version/s: 3.0.0-alpha2
• Assignee: Yufei Gu
• Reporter: Lei (Eddy) Xu
• Created: 15/Jul/16 21:52
• Updated: 12/Jun/18 17:17
• Resolved: 08/Aug/16 22:09

Description

In TestBasicDiskValidator, the following code is confusing

   File localDir = File.createTempFile("test", "tmp");
try {
   if (isDir) {
       // reuse the file path generated by File#createTempFile to create a dir
      localDir.delete();
       localDir.mkdir();
}

Btw, as suggested in https://wiki.apache.org/hadoop/CodeReviewChecklist, unit test should not write data into /tmp:

* unit tests do not write any temporary files to /tmp (instead, the tests should write to the location specified by the test.build.data system property)

Finally, should use Files in these file creation / deletion, so that any error can be thrown as IOE.

Issue Links

• duplicates: HADOOP-13254 Create framework for configurable disk checkers
• relates to: HADOOP-15532 TestBasicDiskValidator fails with NoSuchFileException