Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2, HADOOP-13341
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Hide
      Users:

      In Apache Hadoop 3.0.0-alpha1, verification required environment variables with the format of HADOOP_(subcommand)_USER where subcommand was lowercase applied globally. This changes the format to be (command)_(subcommand)_USER where all are uppercase to be consistent with the _OPTS functionality as well as being able to set per-command options. Additionally, the check is now happening sooner, which should make it faster to fail.

      Developers:

      This changes hadoop_verify_user to require the program's name as part of the function call. This is incompatible with Apache Hadoop 3.0.0-alpha1.
      Show
      Users: In Apache Hadoop 3.0.0-alpha1, verification required environment variables with the format of HADOOP_(subcommand)_USER where subcommand was lowercase applied globally. This changes the format to be (command)_(subcommand)_USER where all are uppercase to be consistent with the _OPTS functionality as well as being able to set per-command options. Additionally, the check is now happening sooner, which should make it faster to fail. Developers: This changes hadoop_verify_user to require the program's name as part of the function call. This is incompatible with Apache Hadoop 3.0.0-alpha1.

      Description

      hadoop_verify_user should be consistent with hadoop_subcommand_opts so that it looks/feels the same to end users.

        Activity

        Hide
        aw Allen Wittenauer added a comment -

        -00:

        • add the exec name param
        • uppercase
        • give an example
        • unit test code
        • move it to a location that's a bit faster to fail
        Show
        aw Allen Wittenauer added a comment - -00: add the exec name param uppercase give an example unit test code move it to a location that's a bit faster to fail
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 16s Maven dependency ordering for branch
        +1 mvninstall 6m 43s HADOOP-13341 passed
        +1 mvnsite 6m 39s HADOOP-13341 passed
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvnsite 6m 22s the patch passed
        +1 shellcheck 0m 12s There were no new shellcheck issues.
        +1 shelldocs 0m 10s There were no new shelldocs issues.
        -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 unit 1m 53s hadoop-common in the patch passed.
        +1 unit 0m 47s hadoop-hdfs in the patch passed.
        +1 unit 2m 18s hadoop-yarn in the patch passed.
        +1 unit 1m 41s hadoop-mapreduce-project in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        28m 23s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13361
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826241/HADOOP-13361-HADOOP-13341.00.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux db9c60fe4fe6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision HADOOP-13341 / b0e67da
        shellcheck v0.4.4
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10420/artifact/patchprocess/whitespace-eol.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10420/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10420/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 6m 43s HADOOP-13341 passed +1 mvnsite 6m 39s HADOOP-13341 passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvnsite 6m 22s the patch passed +1 shellcheck 0m 12s There were no new shellcheck issues. +1 shelldocs 0m 10s There were no new shelldocs issues. -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 unit 1m 53s hadoop-common in the patch passed. +1 unit 0m 47s hadoop-hdfs in the patch passed. +1 unit 2m 18s hadoop-yarn in the patch passed. +1 unit 1m 41s hadoop-mapreduce-project in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 28m 23s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13361 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826241/HADOOP-13361-HADOOP-13341.00.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux db9c60fe4fe6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision HADOOP-13341 / b0e67da shellcheck v0.4.4 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10420/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10420/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10420/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            aw Allen Wittenauer
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development