Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13333

testConf.xml ls comparators in wrong order

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: fs
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-13079 updated file hadoop-common-project/hadoop-common/src/test/resources/testConf.xml incorrectly by inserting a new comparator between 2 comparators for option -h:

              <comparator>
                <type>RegexpComparator</type>
                <expected-output>^\s*-h\s+Formats the sizes of files in a human-readable fashion( )*</expected-output>
              </comparator>
              <comparator>
                <type>RegexpComparator</type>
                <expected-output>^\s*-q\s+Print \? instead of non-printable characters\.( )*</expected-output>
              </comparator>
              <comparator>
                <type>RegexpComparator</type>
                <expected-output>^\s*rather than a number of bytes\.( )*</expected-output>
              </comparator>
      

        Activity

        Hide
        vrushalic Vrushali C added a comment -

        Hi John Zhuge
        Attaching patch v1. Is this the fix you had in mind?

        thanks
        Vrushali

        Show
        vrushalic Vrushali C added a comment - Hi John Zhuge Attaching patch v1. Is this the fix you had in mind? thanks Vrushali
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 58s trunk passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 unit 0m 38s hadoop-common in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        8m 32s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821955/HADOOP-13333.01.patch
        JIRA Issue HADOOP-13333
        Optional Tests asflicense unit xml
        uname Linux b8fc1e08d2c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a1f6564
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10172/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10172/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 58s trunk passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 unit 0m 38s hadoop-common in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 8m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821955/HADOOP-13333.01.patch JIRA Issue HADOOP-13333 Optional Tests asflicense unit xml uname Linux b8fc1e08d2c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a1f6564 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10172/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10172/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        Vrushali C Thanks for providing a patch. Looks good to me. (Nitpick) Three-digit version number is recommended.

        +1 (non-binding)

        Show
        jzhuge John Zhuge added a comment - Vrushali C Thanks for providing a patch. Looks good to me. (Nitpick) Three-digit version number is recommended. +1 (non-binding)
        Hide
        varun_saxena Varun Saxena added a comment -

        Committed to trunk, branch-2 and branch-2.8
        Thanks Vrushali for your contribution and John Zhuge for the reviews.

        Show
        varun_saxena Varun Saxena added a comment - Committed to trunk, branch-2 and branch-2.8 Thanks Vrushali for your contribution and John Zhuge for the reviews.
        Hide
        vrushalic Vrushali C added a comment -

        Thank you Varun Saxena and John Zhuge!

        Show
        vrushalic Vrushali C added a comment - Thank you Varun Saxena and John Zhuge !
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10275 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10275/)
        HADOOP-13333. testConf.xml ls comparators in wrong order (Vrushali C via (varunsaxena: rev d714030b5d4124f307c09d716d72a9f5a4a25995)

        • (edit) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10275 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10275/ ) HADOOP-13333 . testConf.xml ls comparators in wrong order (Vrushali C via (varunsaxena: rev d714030b5d4124f307c09d716d72a9f5a4a25995) (edit) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml

          People

          • Assignee:
            vrushalic Vrushali C
            Reporter:
            jzhuge John Zhuge
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development