Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13065 Add a new interface for retrieving FS and FC Statistics
  3. HADOOP-13291

Probing stats in DFSOpsCountStatistics/S3AStorageStatistics should be correctly implemented

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: fs
    • Labels:
      None

      Description

      To probe a stat in StorageStatistics, users can use the StorageStatistics#isTracked() API. Currently DFSOpsCountStatistics implements this function wrongly. S3AStorageStatistics borrowed the same idea and also has the same error.

      1. The isTracked() is not correctly implemented. I believe this was an omission in code.
      2. isTracked() checks a stat with operation symbol (instead of enum name). getLongStatistics() should return LongStatistics iterators with symbol as name, instead of the enum variable name. Or else, isTracked(getLongStatistics().next().getName()); returns false. This will lead to confusion.

        Attachments

        1. HADOOP-13291.000.patch
          2 kB
          Mingliang Liu
        2. HADOOP-13291.001.patch
          6 kB
          Mingliang Liu
        3. HADOOP-13291.002.patch
          6 kB
          Mingliang Liu

          Activity

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: