Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13289

Remove unused variables in TestFairCallQueue

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      1. Remove unused member alwaysZeroScheduler and related initialization in TestFairCallQueue
      2. Remove unused local vriable sched in testOfferSucceedsWhenScheduledLowPriority()

      And propagate to applicable release branches.

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 33s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 2s trunk passed
        +1 compile 7m 24s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 1m 0s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 27s trunk passed
        +1 javadoc 0m 48s trunk passed
        +1 mvninstall 0m 43s the patch passed
        +1 compile 7m 38s the patch passed
        +1 javac 7m 38s the patch passed
        +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 30 unchanged - 1 fixed = 30 total (was 31)
        +1 mvnsite 0m 56s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 39s the patch passed
        +1 javadoc 0m 48s the patch passed
        +1 unit 8m 34s hadoop-common in the patch passed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        42m 31s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817862/HADOOP-13289.001.patch
        JIRA Issue HADOOP-13289
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ae6950752ef6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 728bf7f
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9998/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9998/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 33s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 2s trunk passed +1 compile 7m 24s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 27s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 43s the patch passed +1 compile 7m 38s the patch passed +1 javac 7m 38s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 30 unchanged - 1 fixed = 30 total (was 31) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 39s the patch passed +1 javadoc 0m 48s the patch passed +1 unit 8m 34s hadoop-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 42m 31s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817862/HADOOP-13289.001.patch JIRA Issue HADOOP-13289 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ae6950752ef6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 728bf7f Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9998/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9998/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1.

        Show
        ajisakaa Akira Ajisaka added a comment - +1.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to branch-2.8 and above. Thanks Ye Zhou for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to branch-2.8 and above. Thanks Ye Zhou for the contribution.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Ye for the patch and Akira for reviewing / committing. I'd like to backport this to 2.6 but from 2.8 to 2.7 the cherry-pick is not clean.

        Ye Zhou Do you mind posting a patch for branch-2.7? Thanks.

        Show
        zhz Zhe Zhang added a comment - Thanks Ye for the patch and Akira for reviewing / committing. I'd like to backport this to 2.6 but from 2.8 to 2.7 the cherry-pick is not clean. Ye Zhou Do you mind posting a patch for branch-2.7? Thanks.

          People

          • Assignee:
            zhouyejoe Ye Zhou
            Reporter:
            shv Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development