Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13285

DecayRpcScheduler MXBean should only report decayed CallVolumeSummary

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-13197 added non-decayed call metrics in metrics2 source for DecayedRpcScheduler. However, CallVolumeSummary in MXBean was affected unexpectedly to include both decayed and non-decayed call volume. The root cause is Jackson ObjectMapper simply serialize all the content of the callCounts map which contains both non-decayed and decayed counter after HADOOP-13197. This ticket is opened to fix the CallVolumeSummary in MXBean to include only decayed call volume for backward compatibility and add unit test for DecayRpcScheduler MXBean to catch this in future.

      CallVolumeSummary JMX example before HADOOP-13197

      "CallVolumeSummary" : "{\"hbase\":1,\"mapred\":1}"
      

      CallVolumeSummary JMX example after HADOOP-13197

      "CallVolumeSummary" : "{\"user_x\":[1,2]}"
      

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 9s trunk passed
        +1 compile 6m 28s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 17s trunk passed
        +1 javadoc 0m 45s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 6m 20s the patch passed
        +1 javac 6m 20s the patch passed
        +1 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 0 new + 25 unchanged - 3 fixed = 25 total (was 28)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 25s the patch passed
        +1 javadoc 0m 46s the patch passed
        +1 unit 7m 45s hadoop-common in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        35m 50s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:e2f6409
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811227/HADOOP-13285.00.patch
        JIRA Issue HADOOP-13285
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b16481d3b8de 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 127d2c7
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9804/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9804/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 9s trunk passed +1 compile 6m 28s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 17s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 20s the patch passed +1 javac 6m 20s the patch passed +1 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 0 new + 25 unchanged - 3 fixed = 25 total (was 28) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 46s the patch passed +1 unit 7m 45s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 35m 50s Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811227/HADOOP-13285.00.patch JIRA Issue HADOOP-13285 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b16481d3b8de 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 127d2c7 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9804/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9804/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jnp Jitendra Nath Pandey added a comment -

        +1

        Show
        jnp Jitendra Nath Pandey added a comment - +1
        Hide
        xyao Xiaoyu Yao added a comment -

        Thank Jitendra Nath Pandey for the review. I've commit the patch to trunk, branch-2 and branch-2.8.

        Show
        xyao Xiaoyu Yao added a comment - Thank Jitendra Nath Pandey for the review. I've commit the patch to trunk, branch-2 and branch-2.8.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9980 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9980/)
        HADOOP-13285. DecayRpcScheduler MXBean should only report decayed (xyao: rev 0761379fe45898c44c8f161834c298ef932e4d8c)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestDecayRpcScheduler.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9980 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9980/ ) HADOOP-13285 . DecayRpcScheduler MXBean should only report decayed (xyao: rev 0761379fe45898c44c8f161834c298ef932e4d8c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestDecayRpcScheduler.java

          People

          • Assignee:
            xyao Xiaoyu Yao
            Reporter:
            nmaheshwari Namit Maheshwari
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development