[HADOOP-13244] o.a.h.ipc.Server#Server should honor handlerCount when queueSizePerHandler is specified in consturctor

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: ipc
• Hadoop Flags: Reviewed
• Assignee: Kai
• Reporter: Xiaoyu Yao
• Created: 07/Jun/16 06:43
• Updated: 30/Aug/16 01:13
• Resolved: 14/Jun/16 10:55

Description

In the code below, this.maxQueueSize = queueSizePerHandler; should be
{{ this.maxQueueSize = handlerCount * queueSizePerHandler;}}. Luckily, I search the code base and found most callers invoke the constructor with queueSizePerHandler=-1. This ticket is opened to make it correct for the case when queueSizePerHandler is not -1.

if (queueSizePerHandler != -1) {
      this.maxQueueSize = queueSizePerHandler;
    } else {
      this.maxQueueSize = handlerCount * conf.getInt(
          CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_KEY,
          CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_DEFAULT);      
    }