Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13244

o.a.h.ipc.Server#Server should honor handlerCount when queueSizePerHandler is specified in consturctor

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the code below, this.maxQueueSize = queueSizePerHandler; should be
      {{ this.maxQueueSize = handlerCount * queueSizePerHandler;}}. Luckily, I search the code base and found most callers invoke the constructor with queueSizePerHandler=-1. This ticket is opened to make it correct for the case when queueSizePerHandler is not -1.

      if (queueSizePerHandler != -1) {
            this.maxQueueSize = queueSizePerHandler;
          } else {
            this.maxQueueSize = handlerCount * conf.getInt(
                CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_KEY,
                CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_DEFAULT);      
          }
      

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 32s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 28s trunk passed
        +1 compile 8m 55s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 1m 11s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 46s trunk passed
        +1 javadoc 1m 2s trunk passed
        +1 mvninstall 0m 49s the patch passed
        +1 compile 8m 27s the patch passed
        +1 javac 8m 27s the patch passed
        +1 checkstyle 0m 29s the patch passed
        +1 mvnsite 1m 4s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 54s the patch passed
        +1 javadoc 1m 0s the patch passed
        -1 unit 9m 8s hadoop-common in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        46m 45s



        Reason Tests
        Failed junit tests hadoop.ipc.TestIPC



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808888/HADOOP-13244.01.patch
        JIRA Issue HADOOP-13244
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c72bad72d013 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 723432b
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9688/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9688/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9688/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 32s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 28s trunk passed +1 compile 8m 55s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 46s trunk passed +1 javadoc 1m 2s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 8m 27s the patch passed +1 javac 8m 27s the patch passed +1 checkstyle 0m 29s the patch passed +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 1m 0s the patch passed -1 unit 9m 8s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 46m 45s Reason Tests Failed junit tests hadoop.ipc.TestIPC Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808888/HADOOP-13244.01.patch JIRA Issue HADOOP-13244 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c72bad72d013 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 723432b Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9688/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9688/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9688/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        iwasakims Masatake Iwasaki added a comment -

        +1, checking this in.

        Luckily, I search the code base and found most callers invoke the constructor with queueSizePerHandler=-1.

        I could not find the code setting queueSizePerHandler except tests. I don't know the background why HADOOP-6764 added this. It might be better to be cleaned up in the follow-up.

        Show
        iwasakims Masatake Iwasaki added a comment - +1, checking this in. Luckily, I search the code base and found most callers invoke the constructor with queueSizePerHandler=-1. I could not find the code setting queueSizePerHandler except tests. I don't know the background why HADOOP-6764 added this. It might be better to be cleaned up in the follow-up.
        Hide
        iwasakims Masatake Iwasaki added a comment -

        Committed. Thanks, Kai Sasaki.

        Show
        iwasakims Masatake Iwasaki added a comment - Committed. Thanks, Kai Sasaki .

          People

          • Assignee:
            lewuathe Kai Sasaki
            Reporter:
            xyao Xiaoyu Yao
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development