Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13244

o.a.h.ipc.Server#Server should honor handlerCount when queueSizePerHandler is specified in consturctor

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the code below, this.maxQueueSize = queueSizePerHandler; should be
      {{ this.maxQueueSize = handlerCount * queueSizePerHandler;}}. Luckily, I search the code base and found most callers invoke the constructor with queueSizePerHandler=-1. This ticket is opened to make it correct for the case when queueSizePerHandler is not -1.

      if (queueSizePerHandler != -1) {
            this.maxQueueSize = queueSizePerHandler;
          } else {
            this.maxQueueSize = handlerCount * conf.getInt(
                CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_KEY,
                CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_DEFAULT);      
          }
      

        Attachments

          Activity

            People

            • Assignee:
              lewuathe Kai Sasaki
              Reporter:
              xyao Xiaoyu Yao
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: