Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13242

Authenticate to Azure Data Lake using client ID and keys

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: fs/adl
    • Labels:
      None
    • Environment:

      All

    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Adds support for Azure ActiveDirectory tokens using client ID and keys

      Description

      Current OAuth2 support (used by HADOOP-12666) supports getting a token using client creds. However, the client creds support does not pass the "resource" parameter required by Azure AD. This work adds support for the "resource" parameter when acquring the OAuth2 token from Azure AD, so the client credentials can be used to authenticate to Azure Data Lake.

      1. HDFS-10462-002.patch
        7 kB
        Atul Sikaria
      2. HDFS-10462-001.patch
        123 kB
        Atul Sikaria
      3. HADOOP-13242-006.patch
        10 kB
        Atul Sikaria
      4. HADOOP-13242-005.patch
        10 kB
        Atul Sikaria
      5. HADOOP-13242-004.patch
        10 kB
        Atul Sikaria
      6. HADOOP-13242-003.patch
        10 kB
        Atul Sikaria

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 44s Maven dependency ordering for branch
          +1 mvninstall 6m 8s trunk passed
          +1 compile 6m 35s trunk passed
          +1 checkstyle 1m 19s trunk passed
          +1 mvnsite 2m 42s trunk passed
          +1 mvneclipse 0m 50s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-tools/hadoop-tools-dist hadoop-tools
          +1 findbugs 1m 13s trunk passed
          +1 javadoc 1m 55s trunk passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 2m 10s the patch passed
          +1 compile 6m 12s the patch passed
          +1 javac 6m 12s the patch passed
          -1 checkstyle 1m 19s root: The patch generated 4 new + 5 unchanged - 0 fixed = 9 total (was 5)
          +1 mvnsite 3m 7s the patch passed
          +1 mvneclipse 1m 8s the patch passed
          -1 whitespace 0m 0s The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 0m 1s The patch 2 line(s) with tabs.
          +1 xml 0m 7s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-tools hadoop-tools/hadoop-tools-dist
          +1 findbugs 1m 56s the patch passed
          +1 javadoc 2m 12s the patch passed
          +1 unit 0m 8s hadoop-project in the patch passed.
          +1 unit 7m 25s hadoop-common in the patch passed.
          +1 unit 0m 14s hadoop-azure-datalake in the patch passed.
          +1 unit 34m 36s hadoop-tools in the patch passed.
          +1 unit 0m 11s hadoop-tools-dist in the patch passed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          83m 57s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807565/HDFS-10462-001.patch
          JIRA Issue HDFS-10462
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux e413bcfe034f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 16b1cc7
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15631/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15631/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15631/artifact/patchprocess/whitespace-tabs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15631/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure-datalake hadoop-tools hadoop-tools/hadoop-tools-dist U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15631/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 44s Maven dependency ordering for branch +1 mvninstall 6m 8s trunk passed +1 compile 6m 35s trunk passed +1 checkstyle 1m 19s trunk passed +1 mvnsite 2m 42s trunk passed +1 mvneclipse 0m 50s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-tools/hadoop-tools-dist hadoop-tools +1 findbugs 1m 13s trunk passed +1 javadoc 1m 55s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 2m 10s the patch passed +1 compile 6m 12s the patch passed +1 javac 6m 12s the patch passed -1 checkstyle 1m 19s root: The patch generated 4 new + 5 unchanged - 0 fixed = 9 total (was 5) +1 mvnsite 3m 7s the patch passed +1 mvneclipse 1m 8s the patch passed -1 whitespace 0m 0s The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 1s The patch 2 line(s) with tabs. +1 xml 0m 7s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-tools hadoop-tools/hadoop-tools-dist +1 findbugs 1m 56s the patch passed +1 javadoc 2m 12s the patch passed +1 unit 0m 8s hadoop-project in the patch passed. +1 unit 7m 25s hadoop-common in the patch passed. +1 unit 0m 14s hadoop-azure-datalake in the patch passed. +1 unit 34m 36s hadoop-tools in the patch passed. +1 unit 0m 11s hadoop-tools-dist in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 83m 57s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807565/HDFS-10462-001.patch JIRA Issue HDFS-10462 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux e413bcfe034f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 16b1cc7 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15631/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15631/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15631/artifact/patchprocess/whitespace-tabs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15631/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure-datalake hadoop-tools hadoop-tools/hadoop-tools-dist U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15631/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ASikaria Atul Sikaria added a comment -

          Separated out the changes of HADOOP-12666 from this patch. Now this patch just contains the changes that heed to go on top of HADOOP-12666.

          Show
          ASikaria Atul Sikaria added a comment - Separated out the changes of HADOOP-12666 from this patch. Now this patch just contains the changes that heed to go on top of HADOOP-12666 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 3s HDFS-10462 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807802/HDFS-10462-002.patch
          JIRA Issue HDFS-10462
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15636/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 3s HDFS-10462 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807802/HDFS-10462-002.patch JIRA Issue HDFS-10462 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15636/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HADOOP-13242 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807802/HDFS-10462-002.patch
          JIRA Issue HADOOP-13242
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9669/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-13242 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807802/HDFS-10462-002.patch JIRA Issue HADOOP-13242 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9669/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          I am canceling this patch until its pre-requisites are committed.

          Show
          cnauroth Chris Nauroth added a comment - I am canceling this patch until its pre-requisites are committed.
          Hide
          cnauroth Chris Nauroth added a comment -

          Atul Sikaria, thank you for the patch. I tried a full test run against an Azure Data Lake account, using the contract tests from HADOOP-12875. Everything worked great.

          I just have one further request. Would you please update the documentation in hadoop-tools/hadoop-azure-datalake/src/site/markdown/index.md to provide step-by-step instructions for testing with a client ID and keys?

          Show
          cnauroth Chris Nauroth added a comment - Atul Sikaria , thank you for the patch. I tried a full test run against an Azure Data Lake account, using the contract tests from HADOOP-12875 . Everything worked great. I just have one further request. Would you please update the documentation in hadoop-tools/hadoop-azure-datalake/src/site/markdown/index.md to provide step-by-step instructions for testing with a client ID and keys?
          Hide
          ASikaria Atul Sikaria added a comment -

          Updated with changes to index.md, as requested by Chris Nauroth. Also removed trailing spaces in other files.

          Show
          ASikaria Atul Sikaria added a comment - Updated with changes to index.md, as requested by Chris Nauroth. Also removed trailing spaces in other files.
          Hide
          cnauroth Chris Nauroth added a comment -

          Atul Sikaria, there are some invalid characters in patch 003. For example:

          Under �Browse�, look for Active Directory and click on it.

          Maybe your editor was configured to save in an unexpected encoding? It's simplest if the patch can stick to plain ASCII if there isn't a compelling need for multi-byte characters.

          Show
          cnauroth Chris Nauroth added a comment - Atul Sikaria , there are some invalid characters in patch 003. For example: Under �Browse�, look for Active Directory and click on it. Maybe your editor was configured to save in an unexpected encoding? It's simplest if the patch can stick to plain ASCII if there isn't a compelling need for multi-byte characters.
          Hide
          cnauroth Chris Nauroth added a comment -

          Atul Sikaria, patch 004 looks good to me. I built the site locally and reviewed the content. I confirmed that the contract tests work with those instructions. I am submitting the patch for a pre-commit build validation.

          Show
          cnauroth Chris Nauroth added a comment - Atul Sikaria , patch 004 looks good to me. I built the site locally and reviewed the content. I confirmed that the contract tests work with those instructions. I am submitting the patch for a pre-commit build validation.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 12s trunk passed
          +1 compile 0m 17s trunk passed
          +1 checkstyle 0m 11s trunk passed
          +1 mvnsite 0m 19s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 25s trunk passed
          +1 javadoc 0m 12s trunk passed
          +1 mvninstall 0m 19s the patch passed
          +1 compile 0m 16s the patch passed
          +1 javac 0m 16s the patch passed
          -1 checkstyle 0m 9s hadoop-tools/hadoop-azure-datalake: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
          +1 mvnsite 0m 17s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 0m 30s the patch passed
          +1 javadoc 0m 10s the patch passed
          +1 unit 2m 16s hadoop-azure-datalake in the patch passed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          14m 17s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e2f6409
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811204/HADOOP-13242-004.patch
          JIRA Issue HADOOP-13242
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 3dd418d3694b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 127d2c7
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9803/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure-datalake.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9803/artifact/patchprocess/whitespace-eol.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9803/testReport/
          modules C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9803/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 12s trunk passed +1 compile 0m 17s trunk passed +1 checkstyle 0m 11s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed -1 checkstyle 0m 9s hadoop-tools/hadoop-azure-datalake: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) +1 mvnsite 0m 17s the patch passed +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 10s the patch passed +1 unit 2m 16s hadoop-azure-datalake in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 14m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811204/HADOOP-13242-004.patch JIRA Issue HADOOP-13242 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 3dd418d3694b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 127d2c7 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9803/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure-datalake.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9803/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9803/testReport/ modules C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9803/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          Thank you to Checkstyle for making a significant catch here:

            private String OAUTH_CLIENT_ID_KEY = "dfs.webhdfs.oauth2.client.id";
            private String OAUTH_REFRESH_URL_KEY = "dfs.webhdfs.oauth2.refresh.url";
          

          Checkstyle is reporting that the variable names don't fit the coding standard, but really the problem is that these should be declared as constants. For each of these, please change private String to private static final String.

          Let's also remove the import of org.apache.hadoop.hdfs.web.oauth2.Utils, because it resides in the same package.

          I expect that will be the last round of nitpicks, and one more revision to address the above should finish it.

          Show
          cnauroth Chris Nauroth added a comment - Thank you to Checkstyle for making a significant catch here: private String OAUTH_CLIENT_ID_KEY = "dfs.webhdfs.oauth2.client.id" ; private String OAUTH_REFRESH_URL_KEY = "dfs.webhdfs.oauth2.refresh.url" ; Checkstyle is reporting that the variable names don't fit the coding standard, but really the problem is that these should be declared as constants. For each of these, please change private String to private static final String . Let's also remove the import of org.apache.hadoop.hdfs.web.oauth2.Utils , because it resides in the same package. I expect that will be the last round of nitpicks, and one more revision to address the above should finish it.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 42s trunk passed
          +1 compile 0m 15s trunk passed
          +1 checkstyle 0m 12s trunk passed
          +1 mvnsite 0m 18s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 32s trunk passed
          +1 javadoc 0m 11s trunk passed
          +1 mvninstall 0m 15s the patch passed
          +1 compile 0m 13s the patch passed
          +1 javac 0m 13s the patch passed
          +1 checkstyle 0m 9s the patch passed
          +1 mvnsite 0m 16s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 0m 28s the patch passed
          +1 javadoc 0m 9s the patch passed
          +1 unit 2m 22s hadoop-azure-datalake in the patch passed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          13m 47s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e2f6409
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811235/HADOOP-13242-005.patch
          JIRA Issue HADOOP-13242
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux d985b813fe79 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b1674ca
          Default Java 1.8.0_91
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9805/artifact/patchprocess/whitespace-eol.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9805/testReport/
          modules C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9805/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 42s trunk passed +1 compile 0m 15s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 18s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 32s trunk passed +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 15s the patch passed +1 compile 0m 13s the patch passed +1 javac 0m 13s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvnsite 0m 16s the patch passed +1 mvneclipse 0m 10s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 0m 28s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 2m 22s hadoop-azure-datalake in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 13m 47s Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811235/HADOOP-13242-005.patch JIRA Issue HADOOP-13242 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux d985b813fe79 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b1674ca Default Java 1.8.0_91 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9805/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9805/testReport/ modules C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9805/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 26s trunk passed
          +1 compile 0m 16s trunk passed
          +1 checkstyle 0m 12s trunk passed
          +1 mvnsite 0m 19s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 25s trunk passed
          +1 javadoc 0m 11s trunk passed
          +1 mvninstall 0m 14s the patch passed
          +1 compile 0m 13s the patch passed
          +1 javac 0m 13s the patch passed
          +1 checkstyle 0m 10s the patch passed
          +1 mvnsite 0m 16s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 0m 29s the patch passed
          +1 javadoc 0m 9s the patch passed
          +1 unit 2m 17s hadoop-azure-datalake in the patch passed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          14m 14s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e2f6409
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811253/HADOOP-13242-006.patch
          JIRA Issue HADOOP-13242
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 0222f67b609a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bf78040
          Default Java 1.8.0_91
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9807/testReport/
          modules C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9807/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 26s trunk passed +1 compile 0m 16s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 14s the patch passed +1 compile 0m 13s the patch passed +1 javac 0m 13s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 16s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 0m 29s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 2m 17s hadoop-azure-datalake in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 14m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811253/HADOOP-13242-006.patch JIRA Issue HADOOP-13242 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 0222f67b609a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bf78040 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9807/testReport/ modules C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9807/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for patch 006. I have committed this to trunk. Atul Sikaria, thank you for the contribution.

          Show
          cnauroth Chris Nauroth added a comment - +1 for patch 006. I have committed this to trunk. Atul Sikaria , thank you for the contribution.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9976 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9976/)
          HADOOP-13242. Authenticate to Azure Data Lake using client ID and keys. (cnauroth: rev 51d16e7b38d247f73b0ec2ffd8b2b02069c05a33)

          • hadoop-tools/hadoop-azure-datalake/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AzureADClientCredentialBasedAccesTokenProvider.java
          • hadoop-tools/hadoop-azure-datalake/src/site/markdown/index.md
          • hadoop-tools/hadoop-azure-datalake/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9976 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9976/ ) HADOOP-13242 . Authenticate to Azure Data Lake using client ID and keys. (cnauroth: rev 51d16e7b38d247f73b0ec2ffd8b2b02069c05a33) hadoop-tools/hadoop-azure-datalake/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AzureADClientCredentialBasedAccesTokenProvider.java hadoop-tools/hadoop-azure-datalake/src/site/markdown/index.md hadoop-tools/hadoop-azure-datalake/pom.xml

            People

            • Assignee:
              ASikaria Atul Sikaria
              Reporter:
              ASikaria Atul Sikaria
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 168h
                168h
                Remaining:
                Remaining Estimate - 168h
                168h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development