[HADOOP-13240] TestAclCommands.testSetfaclValidations fail

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.1, 2.7.1
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: test

Environment

hadoop 2.4.1,as6.5

• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: John Zhuge
• Reporter: linbao111
• Created: 06/Jun/16 12:06
• Updated: 02/Oct/19 17:14
• Resolved: 21/Jul/16 21:22

Description

mvn test -Djava.net.preferIPv4Stack=true -Dlog4j.rootLogger=DEBUG,console -Dtest=TestAclCommands#testSetfaclValidations failed with following message:
-------------------------------------------------------------------------------
Test set: org.apache.hadoop.fs.shell.TestAclCommands
-------------------------------------------------------------------------------
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.599 sec <<< FAILURE! - in org.apache.hadoop.fs.shell.TestAclCommands
testSetfaclValidations(org.apache.hadoop.fs.shell.TestAclCommands) Time elapsed: 0.534 sec <<< FAILURE!
java.lang.AssertionError: setfacl should fail ACL spec missing
at org.junit.Assert.fail(Assert.java:93)
at org.junit.Assert.assertTrue(Assert.java:43)
at org.junit.Assert.assertFalse(Assert.java:68)
at org.apache.hadoop.fs.shell.TestAclCommands.testSetfaclValidations(TestAclCommands.java:81)

i notice from HADOOP-10277,hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/AclEntry.java code changed

should hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.javabe changed to:
diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
index b14cd37..463bfcd
— a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
+++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
@@ -80,7 +80,7 @@ public void testSetfaclValidations() throws Exception

{ "/path" }

));
assertFalse("setfacl should fail ACL spec missing",
0 == runCommand(new String[]

{ "-setfacl", "-m", - "", "/path" }

));
+ ":", "/path" }));
}

@Test