Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13240

TestAclCommands.testSetfaclValidations fail

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1, 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Environment:

      hadoop 2.4.1,as6.5

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      mvn test -Djava.net.preferIPv4Stack=true -Dlog4j.rootLogger=DEBUG,console -Dtest=TestAclCommands#testSetfaclValidations failed with following message:
      -------------------------------------------------------------------------------
      Test set: org.apache.hadoop.fs.shell.TestAclCommands
      -------------------------------------------------------------------------------
      Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.599 sec <<< FAILURE! - in org.apache.hadoop.fs.shell.TestAclCommands
      testSetfaclValidations(org.apache.hadoop.fs.shell.TestAclCommands) Time elapsed: 0.534 sec <<< FAILURE!
      java.lang.AssertionError: setfacl should fail ACL spec missing
      at org.junit.Assert.fail(Assert.java:93)
      at org.junit.Assert.assertTrue(Assert.java:43)
      at org.junit.Assert.assertFalse(Assert.java:68)
      at org.apache.hadoop.fs.shell.TestAclCommands.testSetfaclValidations(TestAclCommands.java:81)

      i notice from HADOOP-10277,hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/AclEntry.java code changed

      should hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.javabe changed to:
      diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
      index b14cd37..463bfcd
      — a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
      +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
      @@ -80,7 +80,7 @@ public void testSetfaclValidations() throws Exception

      { "/path" }

      ));
      assertFalse("setfacl should fail ACL spec missing",
      0 == runCommand(new String[]

      { "-setfacl", "-m", - "", "/path" }

      ));
      + ":", "/path" }));
      }

      @Test

        Attachments

        1. HADOOP-13240.001.patch
          5 kB
          John Zhuge
        2. HADOOP-13240.002.patch
          5 kB
          John Zhuge
        3. HADOOP-13240.003.patch
          5 kB
          John Zhuge
        4. HADOOP-13240.004.patch
          5 kB
          John Zhuge

          Activity

            People

            • Assignee:
              jzhuge John Zhuge
              Reporter:
              linbao111 linbao111
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: