Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13236

truncate will fail when we use viewfilesystem

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      truncate will fail when use viewFS.

        @Override
        public boolean truncate(final Path f, final long newLength)
            throws IOException {
          InodeTree.ResolveResult<FileSystem> res =
              fsState.resolve(getUriPath(f), true);
          return res.targetFileSystem.truncate(f, newLength);
        }
        

      Path should be like below:
      return res.targetFileSystem.truncate(f, newLength); should be return res.targetFileSystem.truncate(res.remainingPath, newLength);

      1. HADOOP-13236-branch-2-003.patch
        6 kB
        Brahma Reddy Battula
      2. HADOOP-13236-003.patch
        6 kB
        Brahma Reddy Battula
      3. HADOOP-13236-002.patch
        6 kB
        Brahma Reddy Battula
      4. HADOOP-13236.patch
        7 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        white space unrelated..Pushed to branch-2,branch-2.8 and branch-2.7..Thanks all and sorry to bother you..

        Show
        brahmareddy Brahma Reddy Battula added a comment - white space unrelated..Pushed to branch-2,branch-2.8 and branch-2.7..Thanks all and sorry to bother you..
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 57s Maven dependency ordering for branch
        +1 mvninstall 7m 1s branch-2 passed
        +1 compile 6m 0s branch-2 passed with JDK v1.8.0_101
        +1 compile 6m 52s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 1m 41s branch-2 passed
        +1 mvnsite 2m 8s branch-2 passed
        +1 mvneclipse 0m 36s branch-2 passed
        +1 findbugs 4m 7s branch-2 passed
        +1 javadoc 1m 55s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 2m 57s branch-2 passed with JDK v1.7.0_111
        0 mvndep 0m 18s Maven dependency ordering for patch
        +1 mvninstall 1m 46s the patch passed
        +1 compile 7m 16s the patch passed with JDK v1.8.0_101
        +1 javac 7m 16s the patch passed
        +1 compile 7m 56s the patch passed with JDK v1.7.0_111
        +1 javac 7m 56s the patch passed
        +1 checkstyle 1m 34s the patch passed
        +1 mvnsite 2m 12s the patch passed
        +1 mvneclipse 0m 43s the patch passed
        -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 4m 43s the patch passed
        +1 javadoc 2m 0s the patch passed with JDK v1.8.0_101
        +1 javadoc 2m 41s the patch passed with JDK v1.7.0_111
        +1 unit 7m 57s hadoop-common in the patch passed with JDK v1.7.0_111.
        +1 unit 47m 51s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
        +1 asflicense 0m 30s The patch does not generate ASF License warnings.
        204m 13s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HADOOP-13236
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834595/HADOOP-13236-branch-2-003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2f8dd0a4938a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 440a632
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10851/artifact/patchprocess/whitespace-eol.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10851/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10851/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 57s Maven dependency ordering for branch +1 mvninstall 7m 1s branch-2 passed +1 compile 6m 0s branch-2 passed with JDK v1.8.0_101 +1 compile 6m 52s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 1m 41s branch-2 passed +1 mvnsite 2m 8s branch-2 passed +1 mvneclipse 0m 36s branch-2 passed +1 findbugs 4m 7s branch-2 passed +1 javadoc 1m 55s branch-2 passed with JDK v1.8.0_101 +1 javadoc 2m 57s branch-2 passed with JDK v1.7.0_111 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 1m 46s the patch passed +1 compile 7m 16s the patch passed with JDK v1.8.0_101 +1 javac 7m 16s the patch passed +1 compile 7m 56s the patch passed with JDK v1.7.0_111 +1 javac 7m 56s the patch passed +1 checkstyle 1m 34s the patch passed +1 mvnsite 2m 12s the patch passed +1 mvneclipse 0m 43s the patch passed -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 4m 43s the patch passed +1 javadoc 2m 0s the patch passed with JDK v1.8.0_101 +1 javadoc 2m 41s the patch passed with JDK v1.7.0_111 +1 unit 7m 57s hadoop-common in the patch passed with JDK v1.7.0_111. +1 unit 47m 51s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 204m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-13236 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834595/HADOOP-13236-branch-2-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2f8dd0a4938a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 440a632 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10851/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10851/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10851/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploading the patch for branch-2 which will applicable to branch-2.8 and branch-2.7..compare to HADOOP-13236-003.patch, "final" added to variable to run complie java7.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploading the patch for branch-2 which will applicable to branch-2.8 and branch-2.7..compare to HADOOP-13236 -003.patch, "final" added to variable to run complie java7.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Thanks to all.. Yes, it's problem with java-7, will change to final and push the code..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Thanks to all.. Yes, it's problem with java-7, will change to final and push the code..
        Hide
        stevel@apache.org Steve Loughran added a comment -

        reopening pending fix for branch-2

        Show
        stevel@apache.org Steve Loughran added a comment - reopening pending fix for branch-2
        Hide
        stevel@apache.org Steve Loughran added a comment -

        yeah, seen this. Problem is java-language-level 7 has different scoping rules related to closures; the field being waited for needs to be marked as final. you can get away with this in java 8.

        moral: to pick into branch-2 we need to get more into testing there first.

        Show
        stevel@apache.org Steve Loughran added a comment - yeah, seen this. Problem is java-language-level 7 has different scoping rules related to closures; the field being waited for needs to be marked as final. you can get away with this in java 8. moral: to pick into branch-2 we need to get more into testing there first.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Branch-2 does not compile either

        [INFO] BUILD FAILURE
        [INFO] ------------------------------------------------------------------------
        [INFO] Total time: 01:11 min
        [INFO] Finished at: 2016-10-20T10:54:51-07:00
        [INFO] Final Memory: 138M/1545M
        [INFO] ------------------------------------------------------------------------
        [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project hadoop-hdfs: Compilation failure
        [ERROR] /Users/weichiu/sandbox/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemWithTruncate.java:[112,58] local variable hdfFilepath is accessed from within inner class; needs to be declared final
        [ERROR] -> [Help 1]
        [ERROR]

        Show
        jojochuang Wei-Chiu Chuang added a comment - Branch-2 does not compile either [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:11 min [INFO] Finished at: 2016-10-20T10:54:51-07:00 [INFO] Final Memory: 138M/1545M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project hadoop-hdfs: Compilation failure [ERROR] /Users/weichiu/sandbox/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemWithTruncate.java: [112,58] local variable hdfFilepath is accessed from within inner class; needs to be declared final [ERROR] -> [Help 1] [ERROR]
        Hide
        shahrs87 Rushabh S Shah added a comment - - edited

        branch-2.8 build failed because of the following error:

        [ERROR] /home/yahoo/hudson-ws/workspace/Hadoop-Core-y-branch-2.8-Build/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemWithTruncate.java:[112,58] local variable hdfFilepath is accessed from within inner class; needs to be declared final
        [INFO] 1 error
        

        Arpit Agarwal/Brahma: can you guys take a look ?

        Show
        shahrs87 Rushabh S Shah added a comment - - edited branch-2.8 build failed because of the following error: [ERROR] /home/yahoo/hudson-ws/workspace/Hadoop-Core-y-branch-2.8-Build/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemWithTruncate.java:[112,58] local variable hdfFilepath is accessed from within inner class; needs to be declared final [INFO] 1 error Arpit Agarwal / Brahma : can you guys take a look ?
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10645 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10645/)
        HADOOP-13236. truncate will fail when we use viewfilesystem. Contributed (brahma: rev f872c6bc0390415f13e95b99749b0b1a690991b7)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
        • (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemWithTruncate.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10645 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10645/ ) HADOOP-13236 . truncate will fail when we use viewfilesystem. Contributed (brahma: rev f872c6bc0390415f13e95b99749b0b1a690991b7) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemWithTruncate.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Committed to trunk,branch-2,branch-2.8 and branch-2.7..

        Arpit Agarwal Thanks a lot for your review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Committed to trunk,branch-2,branch-2.8 and branch-2.7.. Arpit Agarwal Thanks a lot for your review..
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 for the v3 patch. Thanks Brahma Reddy Battula.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 for the v3 patch. Thanks Brahma Reddy Battula .
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 15s Maven dependency ordering for branch
        +1 mvninstall 6m 36s trunk passed
        +1 compile 6m 48s trunk passed
        +1 checkstyle 1m 26s trunk passed
        +1 mvnsite 1m 48s trunk passed
        +1 mvneclipse 0m 26s trunk passed
        +1 findbugs 3m 6s trunk passed
        +1 javadoc 1m 26s trunk passed
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 1m 27s the patch passed
        +1 compile 6m 50s the patch passed
        +1 javac 6m 50s the patch passed
        +1 checkstyle 1m 30s the patch passed
        +1 mvnsite 1m 52s the patch passed
        +1 mvneclipse 0m 32s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 30s the patch passed
        +1 javadoc 1m 32s the patch passed
        +1 unit 8m 10s hadoop-common in the patch passed.
        +1 unit 60m 42s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 30s The patch does not generate ASF License warnings.
        132m 29s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13236
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834337/HADOOP-13236-003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a27c512c5b02 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 73504b1
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10838/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10838/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 36s trunk passed +1 compile 6m 48s trunk passed +1 checkstyle 1m 26s trunk passed +1 mvnsite 1m 48s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 6s trunk passed +1 javadoc 1m 26s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 6m 50s the patch passed +1 javac 6m 50s the patch passed +1 checkstyle 1m 30s the patch passed +1 mvnsite 1m 52s the patch passed +1 mvneclipse 0m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 30s the patch passed +1 javadoc 1m 32s the patch passed +1 unit 8m 10s hadoop-common in the patch passed. +1 unit 60m 42s hadoop-hdfs in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 132m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13236 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834337/HADOOP-13236-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a27c512c5b02 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 73504b1 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10838/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10838/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Arpit Agarwal thanks a lot for your review..Uploaded the patch to address testcase nit pick..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Arpit Agarwal thanks a lot for your review..Uploaded the patch to address testcase nit pick..
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Nice catch. +1 for the patch except a test case nitpick. The recoveryTriggered parameter to waitForRecovery is not necessary. Also waitForRecovery can have return type void as caller never uses the return value. You can probably replace this function with GenericTestUtils#waitFor.

        Show
        arpitagarwal Arpit Agarwal added a comment - Nice catch. +1 for the patch except a test case nitpick. The recoveryTriggered parameter to waitForRecovery is not necessary. Also waitForRecovery can have return type void as caller never uses the return value. You can probably replace this function with GenericTestUtils#waitFor.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 1m 23s Maven dependency ordering for branch
        +1 mvninstall 6m 47s trunk passed
        +1 compile 6m 49s trunk passed
        +1 checkstyle 1m 26s trunk passed
        +1 mvnsite 1m 46s trunk passed
        +1 mvneclipse 0m 26s trunk passed
        +1 findbugs 3m 7s trunk passed
        +1 javadoc 1m 44s trunk passed
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 29s the patch passed
        +1 compile 6m 50s the patch passed
        +1 javac 6m 50s the patch passed
        +1 checkstyle 1m 29s the patch passed
        +1 mvnsite 1m 48s the patch passed
        +1 mvneclipse 0m 33s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 26s the patch passed
        +1 javadoc 1m 50s the patch passed
        +1 unit 8m 14s hadoop-common in the patch passed.
        +1 unit 58m 23s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 30s The patch does not generate ASF License warnings.
        132m 13s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13236
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810389/HADOOP-13236-002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9753072daa56 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 07650bc
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10445/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10445/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 23s Maven dependency ordering for branch +1 mvninstall 6m 47s trunk passed +1 compile 6m 49s trunk passed +1 checkstyle 1m 26s trunk passed +1 mvnsite 1m 46s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 7s trunk passed +1 javadoc 1m 44s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 29s the patch passed +1 compile 6m 50s the patch passed +1 javac 6m 50s the patch passed +1 checkstyle 1m 29s the patch passed +1 mvnsite 1m 48s the patch passed +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 26s the patch passed +1 javadoc 1m 50s the patch passed +1 unit 8m 14s hadoop-common in the patch passed. +1 unit 58m 23s hadoop-hdfs in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 132m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13236 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810389/HADOOP-13236-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9753072daa56 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 07650bc Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10445/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10445/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        Arpit Agarwal can you take look at last patch,if you find some time..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited Arpit Agarwal can you take look at last patch,if you find some time..?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        TestFailure is unrelated to this jira..

        Show
        brahmareddy Brahma Reddy Battula added a comment - TestFailure is unrelated to this jira..
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 30s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 35s Maven dependency ordering for branch
        +1 mvninstall 6m 25s trunk passed
        +1 compile 6m 52s trunk passed
        +1 checkstyle 1m 24s trunk passed
        +1 mvnsite 1m 59s trunk passed
        +1 mvneclipse 0m 23s trunk passed
        +1 findbugs 3m 2s trunk passed
        +1 javadoc 1m 50s trunk passed
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 1m 50s the patch passed
        +1 compile 8m 6s the patch passed
        +1 javac 8m 6s the patch passed
        +1 checkstyle 1m 27s the patch passed
        +1 mvnsite 2m 7s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 25s the patch passed
        +1 javadoc 1m 47s the patch passed
        +1 unit 8m 7s hadoop-common in the patch passed.
        -1 unit 76m 59s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        128m 47s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure170



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810389/HADOOP-13236-002.patch
        JIRA Issue HADOOP-13236
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6f6189252983 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8e8cb4c
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9769/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9769/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9769/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 30s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 35s Maven dependency ordering for branch +1 mvninstall 6m 25s trunk passed +1 compile 6m 52s trunk passed +1 checkstyle 1m 24s trunk passed +1 mvnsite 1m 59s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 3m 2s trunk passed +1 javadoc 1m 50s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 50s the patch passed +1 compile 8m 6s the patch passed +1 javac 8m 6s the patch passed +1 checkstyle 1m 27s the patch passed +1 mvnsite 2m 7s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 25s the patch passed +1 javadoc 1m 47s the patch passed +1 unit 8m 7s hadoop-common in the patch passed. -1 unit 76m 59s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 128m 47s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure170 Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810389/HADOOP-13236-002.patch JIRA Issue HADOOP-13236 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6f6189252983 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8e8cb4c Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9769/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9769/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9769/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch to fix the check-style issues. Testfailures are unrelated to this jira.

        hadoop.hdfs.TestAsyncHDFSWithHA

        HDFS-10497 is raised to track. And TestGangliaMetrics is passing locally.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch to fix the check-style issues. Testfailures are unrelated to this jira. hadoop.hdfs.TestAsyncHDFSWithHA HDFS-10497 is raised to track. And TestGangliaMetrics is passing locally.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 1m 25s Maven dependency ordering for branch
        +1 mvninstall 6m 46s trunk passed
        +1 compile 7m 27s trunk passed
        +1 checkstyle 1m 27s trunk passed
        +1 mvnsite 2m 5s trunk passed
        +1 mvneclipse 0m 25s trunk passed
        +1 findbugs 3m 37s trunk passed
        +1 javadoc 1m 48s trunk passed
        0 mvndep 0m 13s Maven dependency ordering for patch
        +1 mvninstall 1m 41s the patch passed
        +1 compile 7m 28s the patch passed
        +1 javac 7m 28s the patch passed
        -1 checkstyle 1m 28s root: The patch generated 10 new + 71 unchanged - 0 fixed = 81 total (was 71)
        +1 mvnsite 1m 57s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 41s the patch passed
        +1 javadoc 1m 49s the patch passed
        -1 unit 7m 42s hadoop-common in the patch failed.
        -1 unit 58m 26s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        111m 33s



        Reason Tests
        Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.hdfs.TestAsyncHDFSWithHA



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810366/HADOOP-13236.patch
        JIRA Issue HADOOP-13236
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3a06b605205d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 20b13d1
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9767/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9767/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9767/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9767/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9767/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 25s Maven dependency ordering for branch +1 mvninstall 6m 46s trunk passed +1 compile 7m 27s trunk passed +1 checkstyle 1m 27s trunk passed +1 mvnsite 2m 5s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 37s trunk passed +1 javadoc 1m 48s trunk passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 41s the patch passed +1 compile 7m 28s the patch passed +1 javac 7m 28s the patch passed -1 checkstyle 1m 28s root: The patch generated 10 new + 71 unchanged - 0 fixed = 81 total (was 71) +1 mvnsite 1m 57s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 41s the patch passed +1 javadoc 1m 49s the patch passed -1 unit 7m 42s hadoop-common in the patch failed. -1 unit 58m 26s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 111m 33s Reason Tests Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.hdfs.TestAsyncHDFSWithHA Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810366/HADOOP-13236.patch JIRA Issue HADOOP-13236 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3a06b605205d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 20b13d1 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9767/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9767/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9767/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9767/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9767/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch kindly review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch kindly review.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Arpit Agarwal thanks for taking a look..It's viewfilesystem.java

        Show
        brahmareddy Brahma Reddy Battula added a comment - Arpit Agarwal thanks for taking a look..It's viewfilesystem.java
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Hi Brahma Reddy Battula, which file/branch is that code snippet from? I see the following in ViewFs.java in trunk which looks correct.

          @Override
          public boolean truncate(final Path f, final long newLength)
              throws AccessControlException, FileNotFoundException,
              UnresolvedLinkException, IOException {
            InodeTree.ResolveResult<AbstractFileSystem> res =
                fsState.resolve(getUriPath(f), true);
            return res.targetFileSystem.truncate(res.remainingPath, newLength);
          }
        
        Show
        arpitagarwal Arpit Agarwal added a comment - Hi Brahma Reddy Battula , which file/branch is that code snippet from? I see the following in ViewFs.java in trunk which looks correct. @Override public boolean truncate( final Path f, final long newLength) throws AccessControlException, FileNotFoundException, UnresolvedLinkException, IOException { InodeTree.ResolveResult<AbstractFileSystem> res = fsState.resolve(getUriPath(f), true ); return res.targetFileSystem.truncate(res.remainingPath, newLength); }

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development