Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13213

Small Documentation bug with AuthenticatedURL in hadoop-auth

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Small documentation error in hadoop-auth.

      AuthenticatedURL doesn't have a constructor that takes URL and Token, these params are passed to openConnection(url, token).

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9947 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9947/)
          HADOOP-13213. Small Documentation bug with AuthenticatedURL in (aajisaka: rev 8a1dcceccea5cfe9fb0c94daa2517cd64a16b3c0)

          • hadoop-common-project/hadoop-auth/src/site/markdown/Examples.md
          • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/AuthenticatedURL.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9947 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9947/ ) HADOOP-13213 . Small Documentation bug with AuthenticatedURL in (aajisaka: rev 8a1dcceccea5cfe9fb0c94daa2517cd64a16b3c0) hadoop-common-project/hadoop-auth/src/site/markdown/Examples.md hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/AuthenticatedURL.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to branch-2.8 and above. Thanks Tom Ellis for the pull request and thanks Wei-Chiu Chuang for the review!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to branch-2.8 and above. Thanks Tom Ellis for the pull request and thanks Wei-Chiu Chuang for the review!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/hadoop/pull/97

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/hadoop/pull/97
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1.
          Hide
          tellisnz Tom Ellis added a comment -

          Is there anything else I need to do for this Wei-Chiu Chuang?

          Show
          tellisnz Tom Ellis added a comment - Is there anything else I need to do for this Wei-Chiu Chuang ?
          Hide
          tellisnz Tom Ellis added a comment - - edited

          No problem Wei-Chiu Chuang, but I dont seem to have privilges to assign the issue.

          Show
          tellisnz Tom Ellis added a comment - - edited No problem Wei-Chiu Chuang , but I dont seem to have privilges to assign the issue.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks for the contribution, Tom Ellis!
          The patch looks good to me, and I can verify the usage is correct. I had used AuthenticatedURL before and was confused by its Javadocs. Please assign yourself as the assignee.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks for the contribution, Tom Ellis ! The patch looks good to me, and I can verify the usage is correct. I had used AuthenticatedURL before and was confused by its Javadocs. Please assign yourself as the assignee.
          Hide
          tellisnz Tom Ellis added a comment -

          No tests added as simply a documentation change.

          Show
          tellisnz Tom Ellis added a comment - No tests added as simply a documentation change.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 35s trunk passed
          +1 compile 6m 49s trunk passed
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 16s trunk passed
          +1 mvneclipse 0m 9s trunk passed
          +1 findbugs 0m 19s trunk passed
          +1 javadoc 0m 11s trunk passed
          +1 mvninstall 0m 12s the patch passed
          +1 compile 6m 42s the patch passed
          +1 javac 6m 42s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 0m 16s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 29s the patch passed
          +1 javadoc 0m 15s the patch passed
          +1 unit 3m 15s hadoop-auth in the patch passed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          27m 20s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806886/HADOOP-13213.001.patch
          JIRA Issue HADOOP-13213
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3c79dbb923c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / f5ff05c
          Default Java 1.8.0_91
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9613/testReport/
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9613/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 35s trunk passed +1 compile 6m 49s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 16s trunk passed +1 mvneclipse 0m 9s trunk passed +1 findbugs 0m 19s trunk passed +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 12s the patch passed +1 compile 6m 42s the patch passed +1 javac 6m 42s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 16s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 29s the patch passed +1 javadoc 0m 15s the patch passed +1 unit 3m 15s hadoop-auth in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 27m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806886/HADOOP-13213.001.patch JIRA Issue HADOOP-13213 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3c79dbb923c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f5ff05c Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9613/testReport/ modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9613/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tellisnz opened a pull request:

          https://github.com/apache/hadoop/pull/97

          HADOOP-13213 - Fix documentation for hadoop-auth client.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tellisnz/hadoop HADOOP-13213

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/97.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #97


          commit f8a928a67116e1dbf146acfbffc59be000a70905
          Author: Tom Ellis <tellisnz@gmail.com>
          Date: 2016-05-29T13:57:31Z

          HADOOP-13213 - Fix documentation for hadoop-auth client.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tellisnz opened a pull request: https://github.com/apache/hadoop/pull/97 HADOOP-13213 - Fix documentation for hadoop-auth client. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tellisnz/hadoop HADOOP-13213 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/97.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #97 commit f8a928a67116e1dbf146acfbffc59be000a70905 Author: Tom Ellis <tellisnz@gmail.com> Date: 2016-05-29T13:57:31Z HADOOP-13213 - Fix documentation for hadoop-auth client.

            People

            • Assignee:
              tellisnz Tom Ellis
              Reporter:
              tellisnz Tom Ellis
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development