[HADOOP-13179] GenericOptionsParser is not thread-safe because commons-cli OptionBuilder is not thread-safe

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Hongbin Ma
• Reporter: Hongbin Ma
• Created: 19/May/16 01:59
• Updated: 30/Aug/16 01:14
• Resolved: 14/Jun/16 10:33

Description

I'm running into similar issues like http://stackoverflow.com/questions/22462665/is-hadoops-toorunner-thread-safe, the author's observation seem to make sense to me. However when I checked the hadoop github trunk I found the issue still not fixed.

Chris Nauroth further investigated this issue, here's his quote:

The root cause is that commons-cli OptionBuilder is not thread-safe.

https://commons.apache.org/proper/commons-cli/apidocs/org/apache/commons/cl
i/OptionBuilder.html

According to this issue, commons-cli doesn't plan to change that and
instead chose to document the lack of thread-safety.

https://issues.apache.org/jira/browse/CLI-209

I think we can solve this in Hadoop, probably with a one-line change to
make GenericOptionsParser#buildGeneralOptions a synchronized method.

I'll soon upload a patch for this

Issue Links

• is related to: HADOOP-13391 Make uses of OptionsBuilder synchronized on OptionsBuilder.class
• relates to: YARN-679 add an entry point that can start any Yarn service