Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      The hadoop-ant module in hadoop-tools has been removed.

      Description

      The hadoop-ant code is an ancient kludge unlikely to have any users, still. We can delete it from trunk as a "scream test" for 3.x.

        Activity

        Hide
        chris.douglas Chris Douglas added a comment -

        Jason Lowe, you restored this in HADOOP-11007. Does this still have users you're aware of?

        Show
        chris.douglas Chris Douglas added a comment - Jason Lowe , you restored this in HADOOP-11007 . Does this still have users you're aware of?
        Hide
        jlowe Jason Lowe added a comment -

        Yes, we have internal users that requested the functionality be restored. I'll mention that it is likely to go away in Apache Hadoop in 3.x and see how much backlash I get.

        Show
        jlowe Jason Lowe added a comment - Yes, we have internal users that requested the functionality be restored. I'll mention that it is likely to go away in Apache Hadoop in 3.x and see how much backlash I get.
        Hide
        chris.douglas Chris Douglas added a comment -

        Really? Wow, neat. OK, feel free to close as WONTFIX. I just assumed it was a forgotten fragment.

        Show
        chris.douglas Chris Douglas added a comment - Really? Wow, neat. OK, feel free to close as WONTFIX. I just assumed it was a forgotten fragment.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 14s Maven dependency ordering for branch
        +1 mvninstall 6m 27s trunk passed
        +1 compile 6m 31s trunk passed
        +1 checkstyle 1m 29s trunk passed
        +1 mvnsite 2m 6s trunk passed
        +1 mvneclipse 0m 53s trunk passed
        0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-tools/hadoop-tools-dist hadoop-tools
        +1 findbugs 0m 17s trunk passed
        +1 javadoc 1m 15s trunk passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 15s the patch passed
        +1 compile 6m 26s the patch passed
        +1 javac 6m 26s the patch passed
        +1 checkstyle 1m 22s root: The patch generated 0 new + 0 unchanged - 44 fixed = 0 total (was 44)
        +1 mvnsite 2m 0s the patch passed
        +1 mvneclipse 0m 39s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 4s The patch has no ill-formed XML file.
        0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-tools/hadoop-tools-dist hadoop-tools
        +1 findbugs 0m 0s the patch passed
        +1 javadoc 1m 2s the patch passed
        +1 unit 0m 10s hadoop-project in the patch passed.
        +1 unit 0m 11s hadoop-tools-dist in the patch passed.
        +1 unit 32m 29s hadoop-tools in the patch passed.
        -1 asflicense 0m 25s The patch generated 3 ASF License warnings.
        66m 20s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804714/HADOOP-13175.001.patch
        JIRA Issue HADOOP-13175
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
        uname Linux 37f1f39be0af 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f04c81c
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9494/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/9494/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-project hadoop-tools/hadoop-tools-dist hadoop-tools U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9494/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 27s trunk passed +1 compile 6m 31s trunk passed +1 checkstyle 1m 29s trunk passed +1 mvnsite 2m 6s trunk passed +1 mvneclipse 0m 53s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-tools/hadoop-tools-dist hadoop-tools +1 findbugs 0m 17s trunk passed +1 javadoc 1m 15s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 15s the patch passed +1 compile 6m 26s the patch passed +1 javac 6m 26s the patch passed +1 checkstyle 1m 22s root: The patch generated 0 new + 0 unchanged - 44 fixed = 0 total (was 44) +1 mvnsite 2m 0s the patch passed +1 mvneclipse 0m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 4s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-tools/hadoop-tools-dist hadoop-tools +1 findbugs 0m 0s the patch passed +1 javadoc 1m 2s the patch passed +1 unit 0m 10s hadoop-project in the patch passed. +1 unit 0m 11s hadoop-tools-dist in the patch passed. +1 unit 32m 29s hadoop-tools in the patch passed. -1 asflicense 0m 25s The patch generated 3 ASF License warnings. 66m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804714/HADOOP-13175.001.patch JIRA Issue HADOOP-13175 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 37f1f39be0af 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f04c81c Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9494/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/9494/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project hadoop-tools/hadoop-tools-dist hadoop-tools U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9494/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        Sorry for the delay. I haven't received final confirmation, but I believe this isn't going to be used internally by the time we move to 3.x. Even if it is it wouldn't be a huge burden to maintain it ourselves, so I'm OK with this going into trunk if desired.

        Show
        jlowe Jason Lowe added a comment - Sorry for the delay. I haven't received final confirmation, but I believe this isn't going to be used internally by the time we move to 3.x. Even if it is it wouldn't be a huge burden to maintain it ourselves, so I'm OK with this going into trunk if desired.
        Hide
        andrew.wang Andrew Wang added a comment -

        Reopening based on Jason's latest comment.

        FWIW patch LGTM +1. Chris, anything else we need to do before checking this in for 3.0?

        Show
        andrew.wang Andrew Wang added a comment - Reopening based on Jason's latest comment. FWIW patch LGTM +1. Chris, anything else we need to do before checking this in for 3.0?
        Hide
        chris.douglas Chris Douglas added a comment -

        anything else we need to do before checking this in for 3.0?

        No, I think we're set

        Show
        chris.douglas Chris Douglas added a comment - anything else we need to do before checking this in for 3.0? No, I think we're set
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1

        Show
        ajisakaa Akira Ajisaka added a comment - +1
        Hide
        andrew.wang Andrew Wang added a comment -

        Committed to trunk, thanks Chris for the patch, Jason and Akira for reviewing!

        Show
        andrew.wang Andrew Wang added a comment - Committed to trunk, thanks Chris for the patch, Jason and Akira for reviewing!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9939 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9939/)
        HADOOP-13175. Remove hadoop-ant from hadoop-tools. Contributed by Chris (wang: rev 58c3486850c0503aecdeae8b67bb7e6bc42b4da8)

        • hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsExists.java
        • hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsIsDir.java
        • hadoop-tools/hadoop-ant/pom.xml
        • hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/DfsTask.java
        • hadoop-tools/hadoop-ant/src/main/resources/org/apache/hadoop/ant/antlib.xml
        • hadoop-project/pom.xml
        • hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsZeroLen.java
        • hadoop-tools/pom.xml
        • hadoop-tools/hadoop-tools-dist/pom.xml
        • hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsBaseConditional.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9939 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9939/ ) HADOOP-13175 . Remove hadoop-ant from hadoop-tools. Contributed by Chris (wang: rev 58c3486850c0503aecdeae8b67bb7e6bc42b4da8) hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsExists.java hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsIsDir.java hadoop-tools/hadoop-ant/pom.xml hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/DfsTask.java hadoop-tools/hadoop-ant/src/main/resources/org/apache/hadoop/ant/antlib.xml hadoop-project/pom.xml hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsZeroLen.java hadoop-tools/pom.xml hadoop-tools/hadoop-tools-dist/pom.xml hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsBaseConditional.java

          People

          • Assignee:
            chris.douglas Chris Douglas
            Reporter:
            chris.douglas Chris Douglas
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development