Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13168

Support Future.get with timeout in ipc async calls

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently, the Future returned by ipc async call only support Future.get() but not Future.get(timeout, unit). We should support the latter as well.

      1. c13168_20160517.patch
        30 kB
        Tsz Wo Nicholas Sze
      2. c13168_20160518.patch
        31 kB
        Tsz Wo Nicholas Sze
      3. c13168_20160519.patch
        31 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        c13168_20160517.patch: 1st patch.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - c13168_20160517.patch: 1st patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 33s Maven dependency ordering for branch
        +1 mvninstall 6m 14s trunk passed
        +1 compile 6m 17s trunk passed
        +1 checkstyle 1m 21s trunk passed
        +1 mvnsite 1m 28s trunk passed
        +1 mvneclipse 0m 24s trunk passed
        +1 findbugs 2m 44s trunk passed
        +1 javadoc 1m 14s trunk passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 9s the patch passed
        +1 compile 6m 11s the patch passed
        +1 javac 6m 11s the patch passed
        -1 checkstyle 1m 21s root: The patch generated 32 new + 138 unchanged - 0 fixed = 170 total (was 138)
        +1 mvnsite 1m 25s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 57s the patch passed
        +1 javadoc 1m 13s the patch passed
        -1 unit 16m 33s hadoop-common in the patch failed.
        +1 unit 0m 53s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        53m 54s



        Reason Tests
        Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804566/c13168_20160517.patch
        JIRA Issue HADOOP-13168
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 55bcb53e1027 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8a9ecb7
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9479/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9479/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9479/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9479/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9479/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 33s Maven dependency ordering for branch +1 mvninstall 6m 14s trunk passed +1 compile 6m 17s trunk passed +1 checkstyle 1m 21s trunk passed +1 mvnsite 1m 28s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 2m 44s trunk passed +1 javadoc 1m 14s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 9s the patch passed +1 compile 6m 11s the patch passed +1 javac 6m 11s the patch passed -1 checkstyle 1m 21s root: The patch generated 32 new + 138 unchanged - 0 fixed = 170 total (was 138) +1 mvnsite 1m 25s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 57s the patch passed +1 javadoc 1m 13s the patch passed -1 unit 16m 33s hadoop-common in the patch failed. +1 unit 0m 53s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 53m 54s Reason Tests Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804566/c13168_20160517.patch JIRA Issue HADOOP-13168 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 55bcb53e1027 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8a9ecb7 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9479/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9479/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9479/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9479/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9479/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 35s Maven dependency ordering for branch
        +1 mvninstall 6m 37s trunk passed
        +1 compile 6m 33s trunk passed
        +1 checkstyle 1m 22s trunk passed
        +1 mvnsite 1m 34s trunk passed
        +1 mvneclipse 0m 24s trunk passed
        +1 findbugs 2m 56s trunk passed
        +1 javadoc 1m 15s trunk passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 10s the patch passed
        +1 compile 6m 40s the patch passed
        +1 javac 6m 40s the patch passed
        -1 checkstyle 1m 23s root: The patch generated 32 new + 138 unchanged - 0 fixed = 170 total (was 138)
        +1 mvnsite 1m 27s the patch passed
        +1 mvneclipse 0m 23s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 9s the patch passed
        +1 javadoc 1m 16s the patch passed
        +1 unit 7m 27s hadoop-common in the patch passed.
        +1 unit 0m 55s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        46m 37s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804566/c13168_20160517.patch
        JIRA Issue HADOOP-13168
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9a2dc2ce2d21 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8a9ecb7
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9484/artifact/patchprocess/diff-checkstyle-root.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9484/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9484/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 35s Maven dependency ordering for branch +1 mvninstall 6m 37s trunk passed +1 compile 6m 33s trunk passed +1 checkstyle 1m 22s trunk passed +1 mvnsite 1m 34s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 2m 56s trunk passed +1 javadoc 1m 15s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 10s the patch passed +1 compile 6m 40s the patch passed +1 javac 6m 40s the patch passed -1 checkstyle 1m 23s root: The patch generated 32 new + 138 unchanged - 0 fixed = 170 total (was 138) +1 mvnsite 1m 27s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 9s the patch passed +1 javadoc 1m 16s the patch passed +1 unit 7m 27s hadoop-common in the patch passed. +1 unit 0m 55s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 46m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804566/c13168_20160517.patch JIRA Issue HADOOP-13168 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9a2dc2ce2d21 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8a9ecb7 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9484/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9484/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9484/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        All of the checkstyle warnings are bogus, unfortunately.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - All of the checkstyle warnings are bogus, unfortunately.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        c13168_20160518.patch: revises javadoc and some other minor changes.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - c13168_20160518.patch: revises javadoc and some other minor changes.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thank you working on this. Some comments:

        1. AsyncGet
        For doc of AsyncGet#get, would 'When timeout == 0' better be 'When timeout = 0'?

        @return doc should be added for Util#asyncGetTimeout2WaitTimeout

        In Util#asyncGetTimeout2WaitTimeout, it returns 1 ms, is it possible to lead to overhead given huge number of calls? Can we use a smaller time unit? Object#wait(long timeout, int nanos) could be used in that case.

        2. ipc.Client
        In ipc.Client#call, make #get override has the same signature as AsyncGet#get, e.g.
        AsyncGet#get(long timeout, TimeUnit unit) throws IOException, TimeoutException, InterruptedException

        If getRpcResponse throws IOException, there's no chance to change done back

        3. ProtobufRpcEngine
        Similarly, make #get override has the same signature as AsyncGet#get

        Show
        xiaobingo Xiaobing Zhou added a comment - Thank you working on this. Some comments: 1. AsyncGet For doc of AsyncGet#get, would 'When timeout == 0' better be 'When timeout = 0'? @return doc should be added for Util#asyncGetTimeout2WaitTimeout In Util#asyncGetTimeout2WaitTimeout, it returns 1 ms, is it possible to lead to overhead given huge number of calls? Can we use a smaller time unit? Object#wait(long timeout, int nanos) could be used in that case. 2. ipc.Client In ipc.Client#call, make #get override has the same signature as AsyncGet#get, e.g. AsyncGet#get(long timeout, TimeUnit unit) throws IOException, TimeoutException, InterruptedException If getRpcResponse throws IOException, there's no chance to change done back 3. ProtobufRpcEngine Similarly, make #get override has the same signature as AsyncGet#get
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 13s Maven dependency ordering for branch
        +1 mvninstall 7m 12s trunk passed
        +1 compile 7m 18s trunk passed
        +1 checkstyle 1m 35s trunk passed
        +1 mvnsite 1m 47s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 3m 16s trunk passed
        +1 javadoc 1m 24s trunk passed
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 1m 28s the patch passed
        +1 compile 8m 12s the patch passed
        +1 javac 8m 12s the patch passed
        -1 checkstyle 1m 32s root: The patch generated 34 new + 138 unchanged - 0 fixed = 172 total (was 138)
        +1 mvnsite 1m 53s the patch passed
        +1 mvneclipse 0m 29s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 42s the patch passed
        +1 javadoc 1m 34s the patch passed
        +1 unit 14m 18s hadoop-common in the patch passed.
        +1 unit 1m 8s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 25s The patch does not generate ASF License warnings.
        59m 22s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804774/c13168_20160518.patch
        JIRA Issue HADOOP-13168
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ffb6896739cf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1597630
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9506/artifact/patchprocess/diff-checkstyle-root.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9506/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9506/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 7m 12s trunk passed +1 compile 7m 18s trunk passed +1 checkstyle 1m 35s trunk passed +1 mvnsite 1m 47s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 16s trunk passed +1 javadoc 1m 24s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 8m 12s the patch passed +1 javac 8m 12s the patch passed -1 checkstyle 1m 32s root: The patch generated 34 new + 138 unchanged - 0 fixed = 172 total (was 138) +1 mvnsite 1m 53s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 42s the patch passed +1 javadoc 1m 34s the patch passed +1 unit 14m 18s hadoop-common in the patch passed. +1 unit 1m 8s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 59m 22s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804774/c13168_20160518.patch JIRA Issue HADOOP-13168 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ffb6896739cf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1597630 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9506/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9506/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9506/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        Thanks for the comments.

        > For doc of AsyncGet#get, would 'When timeout == 0' better be 'When timeout = 0'?

        Indeed, == is more appropriate since = means assignmeent in Java.

        > @return doc should be added for Util#asyncGetTimeout2WaitTimeout

        Will revise the javadoc, although this is just an internal utility method.

        > In Util#asyncGetTimeout2WaitTimeout, it returns 1 ms, is it possible to lead to overhead given huge number of calls? ...

        It does not seem to cause any real problem. For simplicity, let's keep the current code. We may change it later if it is indeed a real problem.

        > In ipc.Client#call, make #get override has the same signature as AsyncGet#get, ...

        The current declaration is better since it throws fewer exceptions. Same applies to #3.

        > If getRpcResponse throws IOException, there's no chance to change done back

        When getRpcResponse throws IOException, the call is actually done, although it fails.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - Thanks for the comments. > For doc of AsyncGet#get, would 'When timeout == 0' better be 'When timeout = 0'? Indeed, == is more appropriate since = means assignmeent in Java. > @return doc should be added for Util#asyncGetTimeout2WaitTimeout Will revise the javadoc, although this is just an internal utility method. > In Util#asyncGetTimeout2WaitTimeout, it returns 1 ms, is it possible to lead to overhead given huge number of calls? ... It does not seem to cause any real problem. For simplicity, let's keep the current code. We may change it later if it is indeed a real problem. > In ipc.Client#call, make #get override has the same signature as AsyncGet#get, ... The current declaration is better since it throws fewer exceptions. Same applies to #3. > If getRpcResponse throws IOException, there's no chance to change done back When getRpcResponse throws IOException, the call is actually done, although it fails.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        c13168_20160519.patch: address Xiaobing's comments.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - c13168_20160519.patch: address Xiaobing's comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 11s Maven dependency ordering for branch
        +1 mvninstall 6m 26s trunk passed
        +1 compile 6m 40s trunk passed
        +1 checkstyle 1m 22s trunk passed
        +1 mvnsite 1m 31s trunk passed
        +1 mvneclipse 0m 24s trunk passed
        +1 findbugs 2m 55s trunk passed
        +1 javadoc 1m 15s trunk passed
        0 mvndep 0m 12s Maven dependency ordering for patch
        +1 mvninstall 1m 12s the patch passed
        +1 compile 6m 36s the patch passed
        +1 javac 6m 36s the patch passed
        -1 checkstyle 1m 23s root: The patch generated 34 new + 138 unchanged - 0 fixed = 172 total (was 138)
        +1 mvnsite 1m 26s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 13s the patch passed
        +1 javadoc 1m 17s the patch passed
        +1 unit 7m 25s hadoop-common in the patch passed.
        +1 unit 0m 57s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        46m 11s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804774/c13168_20160518.patch
        JIRA Issue HADOOP-13168
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cea3fcde0f42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / feb90ff
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9528/artifact/patchprocess/diff-checkstyle-root.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9528/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9528/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 6m 26s trunk passed +1 compile 6m 40s trunk passed +1 checkstyle 1m 22s trunk passed +1 mvnsite 1m 31s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 2m 55s trunk passed +1 javadoc 1m 15s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 12s the patch passed +1 compile 6m 36s the patch passed +1 javac 6m 36s the patch passed -1 checkstyle 1m 23s root: The patch generated 34 new + 138 unchanged - 0 fixed = 172 total (was 138) +1 mvnsite 1m 26s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 13s the patch passed +1 javadoc 1m 17s the patch passed +1 unit 7m 25s hadoop-common in the patch passed. +1 unit 0m 57s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 46m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804774/c13168_20160518.patch JIRA Issue HADOOP-13168 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cea3fcde0f42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / feb90ff Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9528/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9528/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9528/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 15s Maven dependency ordering for branch
        +1 mvninstall 6m 26s trunk passed
        +1 compile 6m 37s trunk passed
        +1 checkstyle 1m 23s trunk passed
        +1 mvnsite 1m 30s trunk passed
        +1 mvneclipse 0m 23s trunk passed
        +1 findbugs 2m 47s trunk passed
        +1 javadoc 1m 13s trunk passed
        0 mvndep 0m 12s Maven dependency ordering for patch
        +1 mvninstall 1m 11s the patch passed
        +1 compile 6m 33s the patch passed
        +1 javac 6m 33s the patch passed
        -1 checkstyle 1m 22s root: The patch generated 34 new + 138 unchanged - 0 fixed = 172 total (was 138)
        +1 mvnsite 1m 28s the patch passed
        +1 mvneclipse 0m 23s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 6s the patch passed
        +1 javadoc 1m 15s the patch passed
        +1 unit 8m 5s hadoop-common in the patch passed.
        +1 unit 0m 53s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        46m 27s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805044/c13168_20160519.patch
        JIRA Issue HADOOP-13168
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8049a6e4cbe7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 204de43
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9529/artifact/patchprocess/diff-checkstyle-root.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9529/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9529/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 26s trunk passed +1 compile 6m 37s trunk passed +1 checkstyle 1m 23s trunk passed +1 mvnsite 1m 30s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 2m 47s trunk passed +1 javadoc 1m 13s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 11s the patch passed +1 compile 6m 33s the patch passed +1 javac 6m 33s the patch passed -1 checkstyle 1m 22s root: The patch generated 34 new + 138 unchanged - 0 fixed = 172 total (was 138) +1 mvnsite 1m 28s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 6s the patch passed +1 javadoc 1m 15s the patch passed +1 unit 8m 5s hadoop-common in the patch passed. +1 unit 0m 53s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 46m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805044/c13168_20160519.patch JIRA Issue HADOOP-13168 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8049a6e4cbe7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 204de43 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9529/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9529/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9529/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jingzhao Jing Zhao added a comment -

        To support timeout will be useful. The patch looks good to me. +1.

        Show
        jingzhao Jing Zhao added a comment - To support timeout will be useful. The patch looks good to me. +1.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        +1, the new patch(c13168_20160519.patch) looks good.

        Show
        xiaobingo Xiaobing Zhou added a comment - +1, the new patch(c13168_20160519.patch) looks good.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9828 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9828/)
        HADOOP-13168. Support Future.get with timeout in ipc async calls. (szetszwo: rev 42c22f7e3d6e88bf1115f617f6e803288886d1ac)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/concurrent/AsyncGetFuture.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/concurrent/AsyncGet.java
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/AsyncDistributedFileSystem.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestAsyncIPC.java
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9828 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9828/ ) HADOOP-13168 . Support Future.get with timeout in ipc async calls. (szetszwo: rev 42c22f7e3d6e88bf1115f617f6e803288886d1ac) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/concurrent/AsyncGetFuture.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/concurrent/AsyncGet.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/AsyncDistributedFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestAsyncIPC.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        Thanks Xiaobing and Jing for reviewing the patches.

        I have committed this.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - Thanks Xiaobing and Jing for reviewing the patches. I have committed this.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9913 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9913/)
        Revert "HADOOP-13168. Support Future.get with timeout in ipc async (wang: rev e4450d47f19131818e1c040b6bd8d85ae8250475)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/AsyncDistributedFileSystem.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestAsyncIPC.java
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/concurrent/AsyncGet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/concurrent/AsyncGetFuture.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9913 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9913/ ) Revert " HADOOP-13168 . Support Future.get with timeout in ipc async (wang: rev e4450d47f19131818e1c040b6bd8d85ae8250475) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/AsyncDistributedFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestAsyncIPC.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/concurrent/AsyncGet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/concurrent/AsyncGetFuture.java

          People

          • Assignee:
            szetszwo Tsz Wo Nicholas Sze
            Reporter:
            szetszwo Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development