Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13157

Follow-on improvements to hadoop credential commands

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Target Version/s:

      Description

      Andrew Wang had some follow-up code review comments from HADOOP-12942. Hence this issue.

      Ping Larry McCay as well.

      The comments:

      Overall this looks okay, the only correctness question I have is about the difference in behavior when the pwfile doesn't exist.

      The rest are all nits, would be nice to do these cleanups though.

      File hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/JavaKeyStoreProvider.java:

      Line 147:
      Could this be a static helper?

      Line 161: new
      The javadoc says it returns null in this situation. This is also a difference from the implementation in the AbstractJKSP. Intentional?

      Line 175: private void locateKeystore() throws IOException {
      static helper? for the construct*Path methods too?

      File hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyShell.java:

      Line 50: @VisibleForTesting public static final String NO_VALID_PROVIDERS =
      FYI for the future, our coding style is to put annotations on their own separate line.

      File hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/AbstractJavaKeyStoreProvider.java:

      Line 326: private char[] locatePassword() throws IOException {
      this method looks very similar to the one in JavaKeyStoreProvider, except the env var it looks for is different, is there potential for code reuse?

      Line 394: " o In the environment variable " +
      Using a "*" is the usual way of doing a bullet point, e.g. markdown and wiki syntax.

      Line 399: "http://hadoop.apache.org/docs/current/hadoop-project-dist/" +
      This link is not tied to a version, so could be inaccurate.

      1. HADOOP-13157.001.patch
        21 kB
        Mike Yoder
      2. HADOOP-13157.002.patch
        21 kB
        Mike Yoder
      3. HADOOP-13157.003.branch-2.8.patch
        23 kB
        Mike Yoder
      4. HADOOP-13157.004.branch-2.patch
        23 kB
        Mike Yoder

        Issue Links

          Activity

          Hide
          lmccay Larry McCay added a comment -

          Andrew Wang - thanks for the additional review! I should have pulled you in earlier.

          Show
          lmccay Larry McCay added a comment - Andrew Wang - thanks for the additional review! I should have pulled you in earlier.
          Hide
          andrew.wang Andrew Wang added a comment -

          No worries, just some things I saw during internal review.

          Show
          andrew.wang Andrew Wang added a comment - No worries, just some things I saw during internal review.
          Hide
          yoderme Mike Yoder added a comment -

          Two questions:

          1. "locatePassword ... looks very similar to the one in JavaKeyStoreProvider ... potential for code reuse?" Sure, and this crossed my mind, too. But where would such a function live?
          2. "This link is not tied to a version..." Is there a canonical way of referring to links that we can use?
          Show
          yoderme Mike Yoder added a comment - Two questions: "locatePassword ... looks very similar to the one in JavaKeyStoreProvider ... potential for code reuse?" Sure, and this crossed my mind, too. But where would such a function live? "This link is not tied to a version..." Is there a canonical way of referring to links that we can use?
          Hide
          andrew.wang Andrew Wang added a comment -

          1. If we make it a static helper method, it can go pretty much anywhere. Larry knows this area of the code better than me, but I can search around if that'd help.
          2. I'd be happy if we just pin it to a given version of the docs. This is the URL for the 2.7.2 docs, you can expect the 2.8.0 docs to use the same URL format: http://hadoop.apache.org/docs/r2.7.2/

          Show
          andrew.wang Andrew Wang added a comment - 1. If we make it a static helper method, it can go pretty much anywhere. Larry knows this area of the code better than me, but I can search around if that'd help. 2. I'd be happy if we just pin it to a given version of the docs. This is the URL for the 2.7.2 docs, you can expect the 2.8.0 docs to use the same URL format: http://hadoop.apache.org/docs/r2.7.2/
          Hide
          lmccay Larry McCay added a comment -

          1. We can consider adding it to providerUtils: /hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ProviderUtils.java
          2. Wouldn't that require every release go and change the link? Perhaps we should change to just directing them to the page rather than providing an actual?

          Show
          lmccay Larry McCay added a comment - 1. We can consider adding it to providerUtils: /hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ProviderUtils.java 2. Wouldn't that require every release go and change the link? Perhaps we should change to just directing them to the page rather than providing an actual?
          Hide
          yoderme Mike Yoder added a comment -

          File hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/JavaKeyStoreProvider.java:
          Line 147:
          Could this be a static helper?

          Changed. Now the env var and filename are passed in.

          Line 161: new
          The javadoc says it returns null in this situation. This is also a difference from the implementation in the AbstractJKSP. Intentional?

          This line came in as a part of https://issues.apache.org/jira/browse/HADOOP-10224. With that work, the JavaKeyStoreProvider was given a more sophisticated old/new corruption prevention dance that the AbstractJKSP lacks. I'd lean towards leaving it alone and using this version for both.

          Line 175: private void locateKeystore() throws IOException {
          static helper? for the construct*Path methods too?

          locateKeystore hits a bunch of member variables: password, path, keyStore, fs, permissions... so please no. construct*Path() - sure, changed.

          File hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyShell.java:
          Line 50: @VisibleForTesting public static final String NO_VALID_PROVIDERS =
          FYI for the future, our coding style is to put annotations on their own separate line.
          File

          Done. Can this rule be added to the checkstyle rules?

          hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/AbstractJavaKeyStoreProvider.java:
          Line 326: private char[] locatePassword() throws IOException {
          this method looks very similar to the one in JavaKeyStoreProvider, except the env var it looks for is different, is there potential for code reuse?

          Yes. Moved to ProviderUtils along with some other stuff.

          Line 394: " o In the environment variable " +
          Using a "*" is the usual way of doing a bullet point, e.g. markdown and wiki syntax.

          Fixed, both here and JavaKeyStoreProvider

          Line 399: "http://hadoop.apache.org/docs/current/hadoop-project-dist/" +
          This link is not tied to a version, so could be inaccurate.

          Made generic without link.

          Show
          yoderme Mike Yoder added a comment - File hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/JavaKeyStoreProvider.java: Line 147: Could this be a static helper? Changed. Now the env var and filename are passed in. Line 161: new The javadoc says it returns null in this situation. This is also a difference from the implementation in the AbstractJKSP. Intentional? This line came in as a part of https://issues.apache.org/jira/browse/HADOOP-10224 . With that work, the JavaKeyStoreProvider was given a more sophisticated old/new corruption prevention dance that the AbstractJKSP lacks. I'd lean towards leaving it alone and using this version for both. Line 175: private void locateKeystore() throws IOException { static helper? for the construct*Path methods too? locateKeystore hits a bunch of member variables: password, path, keyStore, fs, permissions... so please no. construct*Path() - sure, changed. File hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyShell.java: Line 50: @VisibleForTesting public static final String NO_VALID_PROVIDERS = FYI for the future, our coding style is to put annotations on their own separate line. File Done. Can this rule be added to the checkstyle rules? hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/AbstractJavaKeyStoreProvider.java: Line 326: private char[] locatePassword() throws IOException { this method looks very similar to the one in JavaKeyStoreProvider, except the env var it looks for is different, is there potential for code reuse? Yes. Moved to ProviderUtils along with some other stuff. Line 394: " o In the environment variable " + Using a "*" is the usual way of doing a bullet point, e.g. markdown and wiki syntax. Fixed, both here and JavaKeyStoreProvider Line 399: "http://hadoop.apache.org/docs/current/hadoop-project-dist/" + This link is not tied to a version, so could be inaccurate. Made generic without link.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          -1 mvninstall 0m 8s root in trunk failed.
          +1 compile 6m 55s trunk passed with JDK v1.8.0_91
          -1 compile 0m 10s root in trunk failed with JDK v1.7.0_95.
          +1 checkstyle 0m 43s trunk passed
          -1 mvnsite 0m 17s hadoop-common in trunk failed.
          +1 mvneclipse 0m 18s trunk passed
          -1 findbugs 0m 11s hadoop-common in trunk failed.
          +1 javadoc 0m 57s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 4s trunk passed with JDK v1.7.0_95
          -1 mvninstall 0m 12s hadoop-common in the patch failed.
          +1 compile 6m 59s the patch passed with JDK v1.8.0_91
          +1 javac 6m 59s the patch passed
          -1 compile 0m 9s root in the patch failed with JDK v1.7.0_95.
          -1 javac 0m 9s root in the patch failed with JDK v1.7.0_95.
          +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 59 unchanged - 2 fixed = 59 total (was 61)
          -1 mvnsite 0m 14s hadoop-common in the patch failed.
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 11s hadoop-common in the patch failed.
          +1 javadoc 0m 55s the patch passed with JDK v1.8.0_91
          -1 javadoc 0m 12s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 unit 8m 32s hadoop-common in the patch passed with JDK v1.8.0_91.
          -1 unit 0m 11s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          30m 19s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804308/HADOOP-13157.001.patch
          JIRA Issue HADOOP-13157
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 565ab8e9dd1a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 730bc74
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/branch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/branch-compile-root-jdk1.7.0_95.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. -1 mvninstall 0m 8s root in trunk failed. +1 compile 6m 55s trunk passed with JDK v1.8.0_91 -1 compile 0m 10s root in trunk failed with JDK v1.7.0_95. +1 checkstyle 0m 43s trunk passed -1 mvnsite 0m 17s hadoop-common in trunk failed. +1 mvneclipse 0m 18s trunk passed -1 findbugs 0m 11s hadoop-common in trunk failed. +1 javadoc 0m 57s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 4s trunk passed with JDK v1.7.0_95 -1 mvninstall 0m 12s hadoop-common in the patch failed. +1 compile 6m 59s the patch passed with JDK v1.8.0_91 +1 javac 6m 59s the patch passed -1 compile 0m 9s root in the patch failed with JDK v1.7.0_95. -1 javac 0m 9s root in the patch failed with JDK v1.7.0_95. +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 59 unchanged - 2 fixed = 59 total (was 61) -1 mvnsite 0m 14s hadoop-common in the patch failed. +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 11s hadoop-common in the patch failed. +1 javadoc 0m 55s the patch passed with JDK v1.8.0_91 -1 javadoc 0m 12s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 8m 32s hadoop-common in the patch passed with JDK v1.8.0_91. -1 unit 0m 11s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 30m 19s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804308/HADOOP-13157.001.patch JIRA Issue HADOOP-13157 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 565ab8e9dd1a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 730bc74 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/branch-compile-root-jdk1.7.0_95.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9451/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          pulling JIRA ref out of title into link; replacing title with something which would be meaningful in release notes.

          Mike: now that we're autogenerating release notes, JIRA titles must be something people can read and at least get an idea of what the patch did. Thanks.

          Show
          stevel@apache.org Steve Loughran added a comment - pulling JIRA ref out of title into link; replacing title with something which would be meaningful in release notes. Mike: now that we're autogenerating release notes, JIRA titles must be something people can read and at least get an idea of what the patch did. Thanks.
          Hide
          yoderme Mike Yoder added a comment -

          OK, I agree your title is much better.

          Show
          yoderme Mike Yoder added a comment - OK, I agree your title is much better.
          Hide
          yoderme Mike Yoder added a comment -

          Andrew Wang - I take it that there's something amiss with the build/test infrastructure? My failures are all:

          Detected JDK Version: 1.7.0-95 is not in the allowed range [1.8,).
          
          Show
          yoderme Mike Yoder added a comment - Andrew Wang - I take it that there's something amiss with the build/test infrastructure? My failures are all: Detected JDK Version: 1.7.0-95 is not in the allowed range [1.8,).
          Hide
          andrew.wang Andrew Wang added a comment -

          Yea, probably related to the JDK8 bump we just did. I think Allen just fixed it, so I retriggered the build.

          Show
          andrew.wang Andrew Wang added a comment - Yea, probably related to the JDK8 bump we just did. I think Allen just fixed it, so I retriggered the build.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 21s trunk passed
          +1 compile 6m 23s trunk passed
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 1m 9s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 18s trunk passed
          +1 javadoc 0m 54s trunk passed
          +1 mvninstall 0m 49s the patch passed
          +1 compile 7m 42s the patch passed
          +1 javac 7m 42s the patch passed
          +1 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 0 new + 58 unchanged - 2 fixed = 58 total (was 60)
          +1 mvnsite 1m 7s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 39s the patch passed
          +1 javadoc 0m 53s the patch passed
          -1 unit 8m 30s hadoop-common in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          39m 8s



          Reason Tests
          Failed junit tests hadoop.ipc.TestIPC



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804308/HADOOP-13157.001.patch
          JIRA Issue HADOOP-13157
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 77f50f2bb295 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 34fddd1
          Default Java 1.8.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9469/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9469/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9469/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9469/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 21s trunk passed +1 compile 6m 23s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 9s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 54s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 7m 42s the patch passed +1 javac 7m 42s the patch passed +1 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 0 new + 58 unchanged - 2 fixed = 58 total (was 60) +1 mvnsite 1m 7s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 39s the patch passed +1 javadoc 0m 53s the patch passed -1 unit 8m 30s hadoop-common in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 39m 8s Reason Tests Failed junit tests hadoop.ipc.TestIPC Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804308/HADOOP-13157.001.patch JIRA Issue HADOOP-13157 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 77f50f2bb295 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34fddd1 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9469/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9469/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9469/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9469/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          yoderme Mike Yoder added a comment -

          Failure was

          TestIPC.testConnectionIdleTimeouts:941 expected:<7> but was:<4>
          

          Hard to see how this code has anything to do with that...

          Show
          yoderme Mike Yoder added a comment - Failure was TestIPC.testConnectionIdleTimeouts:941 expected:<7> but was:<4> Hard to see how this code has anything to do with that...
          Hide
          andrew.wang Andrew Wang added a comment -

          LGTM, only small nit is that now we've settled on the exception vs. null behavior for the pwfile, shall we update the relevant parent class Javadocs to explain the behavior?

          Show
          andrew.wang Andrew Wang added a comment - LGTM, only small nit is that now we've settled on the exception vs. null behavior for the pwfile, shall we update the relevant parent class Javadocs to explain the behavior?
          Hide
          yoderme Mike Yoder added a comment -

          Added this in patch 2.

          Show
          yoderme Mike Yoder added a comment - Added this in patch 2.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 38s trunk passed
          +1 compile 7m 41s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 27s trunk passed
          +1 javadoc 0m 55s trunk passed
          +1 mvninstall 0m 42s the patch passed
          +1 compile 7m 9s the patch passed
          +1 javac 7m 9s the patch passed
          +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 59 unchanged - 2 fixed = 59 total (was 61)
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 42s the patch passed
          +1 javadoc 0m 55s the patch passed
          +1 unit 7m 53s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          40m 37s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804524/HADOOP-13157.002.patch
          JIRA Issue HADOOP-13157
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9004c95f2598 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0c6726e
          Default Java 1.8.0_91
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9473/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9473/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 38s trunk passed +1 compile 7m 41s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 27s trunk passed +1 javadoc 0m 55s trunk passed +1 mvninstall 0m 42s the patch passed +1 compile 7m 9s the patch passed +1 javac 7m 9s the patch passed +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 59 unchanged - 2 fixed = 59 total (was 61) +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 42s the patch passed +1 javadoc 0m 55s the patch passed +1 unit 7m 53s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 40m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804524/HADOOP-13157.002.patch JIRA Issue HADOOP-13157 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9004c95f2598 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0c6726e Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9473/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9473/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          +1 let's get it in, thanks for working on this Mike Yoder!

          Show
          andrew.wang Andrew Wang added a comment - +1 let's get it in, thanks for working on this Mike Yoder !
          Hide
          andrew.wang Andrew Wang added a comment -

          I've committed this to trunk and branch-2, branch-2.8 wasn't clean and fails with a compile error in Shell.java.

          Mike, do you mind preparing a branch-2.8 patch as well? Thanks.

          Show
          andrew.wang Andrew Wang added a comment - I've committed this to trunk and branch-2, branch-2.8 wasn't clean and fails with a compile error in Shell.java. Mike, do you mind preparing a branch-2.8 patch as well? Thanks.
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Hadoop-trunk-Commit #9811 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9811/)
          HADOOP-13157. Follow-on improvements to hadoop credential commands. (wang: rev 7154ace71212e9fb9dd6209a92165fb075df7806)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ProviderUtils.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/JavaKeyStoreProvider.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/alias/TestCredShell.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/AbstractJavaKeyStoreProvider.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyShell.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialShell.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyShell.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Hadoop-trunk-Commit #9811 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9811/ ) HADOOP-13157 . Follow-on improvements to hadoop credential commands. (wang: rev 7154ace71212e9fb9dd6209a92165fb075df7806) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ProviderUtils.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/JavaKeyStoreProvider.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/alias/TestCredShell.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/AbstractJavaKeyStoreProvider.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyShell.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialShell.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyShell.java
          Hide
          yoderme Mike Yoder added a comment -

          Attaching HADOOP-13157.003.branch-2.8.patch for branch-2.8. Looks like I ran into Robert's environment removal change.

          Show
          yoderme Mike Yoder added a comment - Attaching HADOOP-13157 .003.branch-2.8.patch for branch-2.8. Looks like I ran into Robert's environment removal change.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 10m 0s branch-2.8 passed
          +1 compile 7m 19s branch-2.8 passed with JDK v1.8.0_91
          +1 compile 7m 38s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 0m 28s branch-2.8 passed
          +1 mvnsite 1m 7s branch-2.8 passed
          +1 mvneclipse 0m 21s branch-2.8 passed
          +1 findbugs 1m 57s branch-2.8 passed
          +1 javadoc 1m 9s branch-2.8 passed with JDK v1.8.0_91
          +1 javadoc 1m 11s branch-2.8 passed with JDK v1.7.0_101
          +1 mvninstall 0m 46s the patch passed
          +1 compile 7m 10s the patch passed with JDK v1.8.0_91
          +1 javac 7m 10s the patch passed
          +1 compile 7m 25s the patch passed with JDK v1.7.0_101
          +1 javac 7m 25s the patch passed
          +1 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 0 new + 63 unchanged - 2 fixed = 63 total (was 65)
          +1 mvnsite 1m 1s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 2m 2s the patch passed
          +1 javadoc 1m 5s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 13s the patch passed with JDK v1.7.0_101
          -1 unit 8m 19s hadoop-common in the patch failed with JDK v1.8.0_91.
          -1 unit 7m 56s hadoop-common in the patch failed with JDK v1.7.0_101.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          70m 37s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager
          JDK v1.7.0_101 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c60792e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804587/HADOOP-13157.003.branch-2.8.patch
          JIRA Issue HADOOP-13157
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b2aac4c0672a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 2bcf1eb
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 10m 0s branch-2.8 passed +1 compile 7m 19s branch-2.8 passed with JDK v1.8.0_91 +1 compile 7m 38s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 0m 28s branch-2.8 passed +1 mvnsite 1m 7s branch-2.8 passed +1 mvneclipse 0m 21s branch-2.8 passed +1 findbugs 1m 57s branch-2.8 passed +1 javadoc 1m 9s branch-2.8 passed with JDK v1.8.0_91 +1 javadoc 1m 11s branch-2.8 passed with JDK v1.7.0_101 +1 mvninstall 0m 46s the patch passed +1 compile 7m 10s the patch passed with JDK v1.8.0_91 +1 javac 7m 10s the patch passed +1 compile 7m 25s the patch passed with JDK v1.7.0_101 +1 javac 7m 25s the patch passed +1 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 0 new + 63 unchanged - 2 fixed = 63 total (was 65) +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 2m 2s the patch passed +1 javadoc 1m 5s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 13s the patch passed with JDK v1.7.0_101 -1 unit 8m 19s hadoop-common in the patch failed with JDK v1.8.0_91. -1 unit 7m 56s hadoop-common in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 70m 37s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager JDK v1.7.0_101 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:c60792e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804587/HADOOP-13157.003.branch-2.8.patch JIRA Issue HADOOP-13157 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b2aac4c0672a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 2bcf1eb Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9476/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I reverted this commit from branch-2 because of the following compilation error.

          [ERROR] /Users/aajisaka/git/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:[872,39] cannot find symbol
          [ERROR] symbol:   variable CREDENTIAL_PASSWORD_NAME
          [ERROR] location: class org.apache.hadoop.security.alias.AbstractJavaKeyStoreProvider
          

          Hi Mike Yoder, would you rebase the patch for branch-2 as well?

          Show
          ajisakaa Akira Ajisaka added a comment - I reverted this commit from branch-2 because of the following compilation error. [ERROR] /Users/aajisaka/git/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:[872,39] cannot find symbol [ERROR] symbol: variable CREDENTIAL_PASSWORD_NAME [ERROR] location: class org.apache.hadoop.security.alias.AbstractJavaKeyStoreProvider Hi Mike Yoder , would you rebase the patch for branch-2 as well?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 1s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 14m 40s branch-2.8 passed
          +1 compile 11m 47s branch-2.8 passed with JDK v1.8.0_91
          +1 compile 9m 37s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 0m 37s branch-2.8 passed
          +1 mvnsite 1m 21s branch-2.8 passed
          +1 mvneclipse 0m 27s branch-2.8 passed
          +1 findbugs 2m 29s branch-2.8 passed
          +1 javadoc 1m 35s branch-2.8 passed with JDK v1.8.0_91
          +1 javadoc 1m 31s branch-2.8 passed with JDK v1.7.0_101
          +1 mvninstall 0m 59s the patch passed
          +1 compile 11m 21s the patch passed with JDK v1.8.0_91
          +1 javac 11m 21s the patch passed
          +1 compile 9m 57s the patch passed with JDK v1.7.0_101
          +1 javac 9m 57s the patch passed
          +1 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 0 new + 62 unchanged - 2 fixed = 62 total (was 64)
          +1 mvnsite 1m 13s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 2m 28s the patch passed
          +1 javadoc 1m 24s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 29s the patch passed with JDK v1.7.0_101
          -1 unit 12m 4s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 13m 49s hadoop-common in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 31s The patch does not generate ASF License warnings.
          102m 0s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.ipc.TestIPC



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c60792e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804587/HADOOP-13157.003.branch-2.8.patch
          JIRA Issue HADOOP-13157
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b6cb509c35b7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 2bcf1eb
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9482/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9482/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9482/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9482/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9482/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 14m 40s branch-2.8 passed +1 compile 11m 47s branch-2.8 passed with JDK v1.8.0_91 +1 compile 9m 37s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 0m 37s branch-2.8 passed +1 mvnsite 1m 21s branch-2.8 passed +1 mvneclipse 0m 27s branch-2.8 passed +1 findbugs 2m 29s branch-2.8 passed +1 javadoc 1m 35s branch-2.8 passed with JDK v1.8.0_91 +1 javadoc 1m 31s branch-2.8 passed with JDK v1.7.0_101 +1 mvninstall 0m 59s the patch passed +1 compile 11m 21s the patch passed with JDK v1.8.0_91 +1 javac 11m 21s the patch passed +1 compile 9m 57s the patch passed with JDK v1.7.0_101 +1 javac 9m 57s the patch passed +1 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 0 new + 62 unchanged - 2 fixed = 62 total (was 64) +1 mvnsite 1m 13s the patch passed +1 mvneclipse 0m 18s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 2m 28s the patch passed +1 javadoc 1m 24s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 29s the patch passed with JDK v1.7.0_101 -1 unit 12m 4s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 13m 49s hadoop-common in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 102m 0s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.ipc.TestIPC Subsystem Report/Notes Docker Image:yetus/hadoop:c60792e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804587/HADOOP-13157.003.branch-2.8.patch JIRA Issue HADOOP-13157 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b6cb509c35b7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 2bcf1eb Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9482/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9482/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9482/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9482/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9482/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          yoderme Mike Yoder added a comment -

          Attaching patch 4 for branch-2. Sorry for the trouble.

          Show
          yoderme Mike Yoder added a comment - Attaching patch 4 for branch-2. Sorry for the trouble.
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks Mike for the branch-2* patches, and to Akira for catching my mistake with the branch-2 commit. Committed respective patches to branch-2 and 2.8.

          Show
          andrew.wang Andrew Wang added a comment - Thanks Mike for the branch-2* patches, and to Akira for catching my mistake with the branch-2 commit. Committed respective patches to branch-2 and 2.8.

            People

            • Assignee:
              yoderme Mike Yoder
              Reporter:
              yoderme Mike Yoder
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development