Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: io
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      • The exception handling is quite long. It is better to refactor it to a separated method.
      • The failover logic and synchronization can be moved to a new inner class.
      1. c13146_20160513.patch
        17 kB
        Tsz Wo Nicholas Sze
      2. c13146_20160513b.patch
        17 kB
        Tsz Wo Nicholas Sze
      3. c13146_20160514.patch
        19 kB
        Tsz Wo Nicholas Sze
      4. c13146_20160514b.patch
        22 kB
        Tsz Wo Nicholas Sze
      5. c13146_20160516.patch
        22 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          c13146_20160513.patch: 1st patch.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - c13146_20160513.patch: 1st patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 6s HADOOP-13146 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803993/c13146_20160513.patch
          JIRA Issue HADOOP-13146
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9422/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s HADOOP-13146 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803993/c13146_20160513.patch JIRA Issue HADOOP-13146 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9422/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          c13146_20160513b.patch: sync'ed with trunk.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - c13146_20160513b.patch: sync'ed with trunk.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 41s trunk passed
          +1 compile 6m 11s trunk passed with JDK v1.8.0_91
          +1 compile 6m 56s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 35s trunk passed
          +1 javadoc 0m 52s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 6m 1s the patch passed with JDK v1.8.0_91
          +1 javac 6m 1s the patch passed
          +1 compile 6m 47s the patch passed with JDK v1.7.0_95
          +1 javac 6m 47s the patch passed
          -1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 4 new + 7 unchanged - 4 fixed = 11 total (was 11)
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95
          -1 unit 7m 47s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 8m 20s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          61m 40s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803999/c13146_20160513b.patch
          JIRA Issue HADOOP-13146
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 536afcbbb6a4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3fa1380
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9423/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9423/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9423/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9423/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9423/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 41s trunk passed +1 compile 6m 11s trunk passed with JDK v1.8.0_91 +1 compile 6m 56s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 35s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 6m 1s the patch passed with JDK v1.8.0_91 +1 javac 6m 1s the patch passed +1 compile 6m 47s the patch passed with JDK v1.7.0_95 +1 javac 6m 47s the patch passed -1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 4 new + 7 unchanged - 4 fixed = 11 total (was 11) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95 -1 unit 7m 47s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 8m 20s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 61m 40s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803999/c13146_20160513b.patch JIRA Issue HADOOP-13146 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 536afcbbb6a4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3fa1380 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9423/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9423/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9423/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9423/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9423/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          c13146_20160514.patch: fix some checkstyle warnings.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - c13146_20160514.patch: fix some checkstyle warnings.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 27s trunk passed
          +1 compile 5m 40s trunk passed with JDK v1.8.0_91
          +1 compile 6m 35s trunk passed with JDK v1.7.0_101
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 58s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 33s trunk passed
          +1 javadoc 0m 53s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 3s trunk passed with JDK v1.7.0_101
          +1 mvninstall 0m 41s the patch passed
          +1 compile 5m 38s the patch passed with JDK v1.8.0_91
          +1 javac 5m 38s the patch passed
          +1 compile 6m 37s the patch passed with JDK v1.7.0_101
          +1 javac 6m 37s the patch passed
          -1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 2 new + 44 unchanged - 5 fixed = 46 total (was 49)
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 48s the patch passed
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 2s the patch passed with JDK v1.7.0_101
          -1 unit 16m 22s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 7m 11s hadoop-common in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          67m 18s



          Reason Tests
          JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804043/c13146_20160514.patch
          JIRA Issue HADOOP-13146
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 40ccd911161b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7be53b6
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9430/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9430/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9430/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9430/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9430/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 27s trunk passed +1 compile 5m 40s trunk passed with JDK v1.8.0_91 +1 compile 6m 35s trunk passed with JDK v1.7.0_101 +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 53s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_101 +1 mvninstall 0m 41s the patch passed +1 compile 5m 38s the patch passed with JDK v1.8.0_91 +1 javac 5m 38s the patch passed +1 compile 6m 37s the patch passed with JDK v1.7.0_101 +1 javac 6m 37s the patch passed -1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 2 new + 44 unchanged - 5 fixed = 46 total (was 49) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_101 -1 unit 16m 22s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 7m 11s hadoop-common in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 67m 18s Reason Tests JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804043/c13146_20160514.patch JIRA Issue HADOOP-13146 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 40ccd911161b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7be53b6 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9430/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9430/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9430/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9430/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9430/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          c13146_20160514b.patch: fixes more checkstyle warnings.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - c13146_20160514b.patch: fixes more checkstyle warnings.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 1s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 35s trunk passed
          +1 compile 6m 33s trunk passed with JDK v1.8.0_91
          +1 compile 7m 25s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 34s trunk passed
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 4s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 6m 0s the patch passed with JDK v1.8.0_91
          +1 javac 6m 0s the patch passed
          +1 compile 6m 47s the patch passed with JDK v1.7.0_95
          +1 javac 6m 47s the patch passed
          +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 43 unchanged - 5 fixed = 43 total (was 48)
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 56s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95
          +1 unit 8m 10s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 8m 12s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          62m 41s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804045/c13146_20160514b.patch
          JIRA Issue HADOOP-13146
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4e5990e539dd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7be53b6
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9431/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9431/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 35s trunk passed +1 compile 6m 33s trunk passed with JDK v1.8.0_91 +1 compile 7m 25s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 55s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 4s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 6m 0s the patch passed with JDK v1.8.0_91 +1 javac 6m 0s the patch passed +1 compile 6m 47s the patch passed with JDK v1.7.0_95 +1 javac 6m 47s the patch passed +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 43 unchanged - 5 fixed = 43 total (was 48) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95 +1 unit 8m 10s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 8m 12s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 62m 41s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804045/c13146_20160514b.patch JIRA Issue HADOOP-13146 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4e5990e539dd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7be53b6 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9431/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9431/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for the refactoring, Nicholas! The patch looks pretty good to me. Just two minor comments:

          1. We can use Collections.singletonList instead of Arrays.asList in the following code.
            117	      final Iterable<Exception> exceptions = e instanceof MultiException ?
            118	          ((MultiException) e).getExceptions().values() : Arrays.asList(e);
            
          2. The follow java comment can be moved into the failover method.
                  // Make sure that concurrent failed method invocations only cause a
                  // single actual fail over.
            

          +1 after addressing the comments.

          Show
          jingzhao Jing Zhao added a comment - Thanks for the refactoring, Nicholas! The patch looks pretty good to me. Just two minor comments: We can use Collections.singletonList instead of Arrays.asList in the following code. 117 final Iterable<Exception> exceptions = e instanceof MultiException ? 118 ((MultiException) e).getExceptions().values() : Arrays.asList(e); The follow java comment can be moved into the failover method. // Make sure that concurrent failed method invocations only cause a // single actual fail over. +1 after addressing the comments.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Thanks Jing for the review. Updated patch to address your comments.

          c13146_20160516.patch

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Thanks Jing for the review. Updated patch to address your comments. c13146_20160516.patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 51s trunk passed
          +1 compile 6m 11s trunk passed with JDK v1.8.0_91
          +1 compile 6m 49s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 41s trunk passed
          +1 javadoc 0m 59s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 48s the patch passed
          +1 compile 6m 44s the patch passed with JDK v1.8.0_91
          +1 javac 6m 44s the patch passed
          +1 compile 7m 35s the patch passed with JDK v1.7.0_95
          +1 javac 7m 35s the patch passed
          -1 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 1 new + 44 unchanged - 5 fixed = 45 total (was 49)
          +1 mvnsite 1m 1s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 0s the patch passed
          +1 javadoc 0m 57s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 10s the patch passed with JDK v1.7.0_95
          +1 unit 8m 48s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 8m 34s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          65m 24s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804249/c13146_20160516.patch
          JIRA Issue HADOOP-13146
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 739e9571022e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1217c8f
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9445/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9445/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9445/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 51s trunk passed +1 compile 6m 11s trunk passed with JDK v1.8.0_91 +1 compile 6m 49s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 41s trunk passed +1 javadoc 0m 59s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 48s the patch passed +1 compile 6m 44s the patch passed with JDK v1.8.0_91 +1 javac 6m 44s the patch passed +1 compile 7m 35s the patch passed with JDK v1.7.0_95 +1 javac 7m 35s the patch passed -1 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 1 new + 44 unchanged - 5 fixed = 45 total (was 49) +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 0s the patch passed +1 javadoc 0m 57s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 10s the patch passed with JDK v1.7.0_95 +1 unit 8m 48s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 8m 34s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 65m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804249/c13146_20160516.patch JIRA Issue HADOOP-13146 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 739e9571022e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1217c8f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9445/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9445/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9445/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          +1 for the latest patch.

          Show
          jingzhao Jing Zhao added a comment - +1 for the latest patch.
          Hide
          jingzhao Jing Zhao added a comment -

          I've committed this to trunk and branch-2. Thanks Nicholas for the contribution!

          Show
          jingzhao Jing Zhao added a comment - I've committed this to trunk and branch-2. Thanks Nicholas for the contribution!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9769 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9769/)
          HADOOP-13146. Refactor RetryInvocationHandler. Contributed by Tsz Wo (jing9: rev a9a8297cad4122961b34265c0a31d87134a4a028)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/FailoverProxyProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9769 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9769/ ) HADOOP-13146 . Refactor RetryInvocationHandler. Contributed by Tsz Wo (jing9: rev a9a8297cad4122961b34265c0a31d87134a4a028) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/FailoverProxyProvider.java
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Merged to 2.8.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Merged to 2.8.

            People

            • Assignee:
              szetszwo Tsz Wo Nicholas Sze
              Reporter:
              szetszwo Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development