Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13139

Branch-2: S3a to use thread pool that blocks clients

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0
    • Component/s: fs/s3
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Hide
      The configuration option 'fs.s3a.threads.core' is no longer supported. The string is still defined in org.apache.hadoop.fs.s3a.Constants.CORE_THREADS, however its value is ignored. If it is set, a warning message will be printed when initializing the S3A filesystem
      Show
      The configuration option 'fs.s3a.threads.core' is no longer supported. The string is still defined in org.apache.hadoop.fs.s3a.Constants.CORE_THREADS, however its value is ignored. If it is set, a warning message will be printed when initializing the S3A filesystem

      Description

      HADOOP-11684 is accepted into trunk, but was not applied to branch-2. I will attach a patch applicable to branch-2.

      It should be noted in CHANGES-2.8.0.txt that the config parameter 'fs.s3a.threads.core' has been been removed and the behavior of the ThreadPool for s3a has been changed.

      1. HADOOP-13139-001.patch
        28 kB
        Pieter Reuse
      2. HADOOP-13139-branch-2.001.patch
        28 kB
        Pieter Reuse
      3. HADOOP-13139-branch-2.002.patch
        28 kB
        Pieter Reuse
      4. HADOOP-13139-branch-2-003.patch
        29 kB
        Steve Loughran
      5. HADOOP-13139-branch-2-004.patch
        29 kB
        Steve Loughran
      6. HADOOP-13139-branch-2-005.patch
        29 kB
        Steve Loughran
      7. HADOOP-13139-branch-2-006.patch
        29 kB
        Steve Loughran

        Issue Links

          Activity

          Hide
          PieterReuse Pieter Reuse added a comment -

          Added patch 001

          Show
          PieterReuse Pieter Reuse added a comment - Added patch 001
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HADOOP-13139 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803637/HADOOP-13139-001.patch
          JIRA Issue HADOOP-13139
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9377/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-13139 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803637/HADOOP-13139-001.patch JIRA Issue HADOOP-13139 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9377/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          This would be great for helping cross version merges too.

          Pieter, can you name the patch HADOOP-13139-branch-001.patch? That will let yetus know the branch to work with

          Show
          stevel@apache.org Steve Loughran added a comment - This would be great for helping cross version merges too. Pieter, can you name the patch HADOOP-13139 -branch-001.patch? That will let yetus know the branch to work with
          Hide
          PieterReuse Pieter Reuse added a comment -

          Changed name to HADOOP-13139-branch-2.001.patch

          Show
          PieterReuse Pieter Reuse added a comment - Changed name to HADOOP-13139 -branch-2.001.patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 1m 5s Maven dependency ordering for branch
          +1 mvninstall 6m 42s branch-2 passed
          +1 compile 5m 56s branch-2 passed with JDK v1.8.0_91
          +1 compile 6m 20s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 1m 24s branch-2 passed
          +1 mvnsite 1m 13s branch-2 passed
          +1 mvneclipse 0m 25s branch-2 passed
          +1 findbugs 2m 4s branch-2 passed
          +1 javadoc 1m 8s branch-2 passed with JDK v1.8.0_91
          +1 javadoc 1m 20s branch-2 passed with JDK v1.7.0_101
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 0m 54s the patch passed
          +1 compile 5m 53s the patch passed with JDK v1.8.0_91
          +1 javac 5m 53s the patch passed
          +1 compile 6m 21s the patch passed with JDK v1.7.0_101
          +1 javac 6m 21s the patch passed
          -1 checkstyle 1m 22s root: The patch generated 6 new + 49 unchanged - 8 fixed = 55 total (was 57)
          +1 mvnsite 1m 13s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 29s the patch passed
          -1 javadoc 0m 12s hadoop-aws in the patch failed with JDK v1.8.0_91.
          +1 javadoc 1m 18s the patch passed with JDK v1.7.0_101
          +1 unit 8m 13s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 0m 11s hadoop-aws in the patch passed with JDK v1.8.0_91.
          +1 unit 8m 22s hadoop-common in the patch passed with JDK v1.7.0_101.
          +1 unit 0m 13s hadoop-aws in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          67m 52s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:babe025
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803638/HADOOP-13139-branch-2.001.patch
          JIRA Issue HADOOP-13139
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 92522dfcd742 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 257b2f5
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9378/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9378/artifact/patchprocess/whitespace-eol.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/9378/artifact/patchprocess/patch-javadoc-hadoop-tools_hadoop-aws-jdk1.8.0_91.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9378/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9378/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 5s Maven dependency ordering for branch +1 mvninstall 6m 42s branch-2 passed +1 compile 5m 56s branch-2 passed with JDK v1.8.0_91 +1 compile 6m 20s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 1m 24s branch-2 passed +1 mvnsite 1m 13s branch-2 passed +1 mvneclipse 0m 25s branch-2 passed +1 findbugs 2m 4s branch-2 passed +1 javadoc 1m 8s branch-2 passed with JDK v1.8.0_91 +1 javadoc 1m 20s branch-2 passed with JDK v1.7.0_101 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 0m 54s the patch passed +1 compile 5m 53s the patch passed with JDK v1.8.0_91 +1 javac 5m 53s the patch passed +1 compile 6m 21s the patch passed with JDK v1.7.0_101 +1 javac 6m 21s the patch passed -1 checkstyle 1m 22s root: The patch generated 6 new + 49 unchanged - 8 fixed = 55 total (was 57) +1 mvnsite 1m 13s the patch passed +1 mvneclipse 0m 25s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 29s the patch passed -1 javadoc 0m 12s hadoop-aws in the patch failed with JDK v1.8.0_91. +1 javadoc 1m 18s the patch passed with JDK v1.7.0_101 +1 unit 8m 13s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 0m 11s hadoop-aws in the patch passed with JDK v1.8.0_91. +1 unit 8m 22s hadoop-common in the patch passed with JDK v1.7.0_101. +1 unit 0m 13s hadoop-aws in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 67m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803638/HADOOP-13139-branch-2.001.patch JIRA Issue HADOOP-13139 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 92522dfcd742 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 257b2f5 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9378/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9378/artifact/patchprocess/whitespace-eol.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/9378/artifact/patchprocess/patch-javadoc-hadoop-tools_hadoop-aws-jdk1.8.0_91.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9378/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9378/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I suspect I've just broken your patch with the User Agent and metrics patches. Can you do a new one against branch-2, also looking at the checkstyles and the javadocs. I think, the first checkstyle warning is because the field should be marked as final

          Show
          stevel@apache.org Steve Loughran added a comment - I suspect I've just broken your patch with the User Agent and metrics patches. Can you do a new one against branch-2, also looking at the checkstyles and the javadocs. I think, the first checkstyle warning is because the field should be marked as final
          Hide
          PieterReuse Pieter Reuse added a comment -

          Uploaded patch 002: changed patch w.r.t. HADOOP-13028, fixed the checkstyle issues and copied HADOOP-12553 to fix the javadoc error.

          Show
          PieterReuse Pieter Reuse added a comment - Uploaded patch 002: changed patch w.r.t. HADOOP-13028 , fixed the checkstyle issues and copied HADOOP-12553 to fix the javadoc error.
          Hide
          andrew.wang Andrew Wang added a comment -

          Fix version shouldn't be set until the patch is committed.

          Could you also add whatever user information is required in the release note field?

          Show
          andrew.wang Andrew Wang added a comment - Fix version shouldn't be set until the patch is committed. Could you also add whatever user information is required in the release note field?
          Hide
          andrew.wang Andrew Wang added a comment -

          Given this is an incompatible change we're targeting for branch-2 (and we're sure we really want to go through with this), I'd also like to see a log WARN if the removed config key is set, explaining what to configure instead. That'd be a good improvement even for trunk too.

          Show
          andrew.wang Andrew Wang added a comment - Given this is an incompatible change we're targeting for branch-2 (and we're sure we really want to go through with this), I'd also like to see a log WARN if the removed config key is set, explaining what to configure instead. That'd be a good improvement even for trunk too.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          do you think maybe putting it in as a deprecated key would be enough?

          Show
          stevel@apache.org Steve Loughran added a comment - do you think maybe putting it in as a deprecated key would be enough?
          Hide
          andrew.wang Andrew Wang added a comment -

          Possibly, but I thought deprecated keys forwarded to a new config key? Since this value is being removed, there's no new config key to forward to.

          Show
          andrew.wang Andrew Wang added a comment - Possibly, but I thought deprecated keys forwarded to a new config key? Since this value is being removed, there's no new config key to forward to.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          that's why its deprecated

          There's one nice thing about deprecation: There's a special log, which if you set to WARN, stops telling you off

          Show
          stevel@apache.org Steve Loughran added a comment - that's why its deprecated There's one nice thing about deprecation: There's a special log, which if you set to WARN, stops telling you off
          Hide
          andrew.wang Andrew Wang added a comment -

          I meant that the DeprecationDelta class expects a new key, so it can forward the value. Since there is no new key, I don't think we can use DeprecationDelta.

          In the past for situations like this, I've just added a WARN.

          Show
          andrew.wang Andrew Wang added a comment - I meant that the DeprecationDelta class expects a new key, so it can forward the value. Since there is no new key, I don't think we can use DeprecationDelta. In the past for situations like this, I've just added a WARN.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Actually, what may be good is for this to appear @ info in the deprecation log, that is, "org.apache.hadoop.conf.Configuration.deprecation" . That way, it's got specific text, but anyone who turns off deprecation complaints doesn't get the message. And with a custom log entry, no confusion about what to do

          Show
          stevel@apache.org Steve Loughran added a comment - Actually, what may be good is for this to appear @ info in the deprecation log, that is, "org.apache.hadoop.conf.Configuration.deprecation" . That way, it's got specific text, but anyone who turns off deprecation complaints doesn't get the message. And with a custom log entry, no confusion about what to do
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Andrew Wang what do you think about my proposal to use the deprecation list. And if so, INFO vs WARN?

          Show
          stevel@apache.org Steve Loughran added a comment - Andrew Wang what do you think about my proposal to use the deprecation list. And if so, INFO vs WARN?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          HADOOP-13139 patch 003

          -in sync with branch-2
          -diff with trunk is now at near-minimum
          -log @ warn to Configuration.deprecated if the deprecated credential spotted.
          -reinstated constant; tagged as deprecated.

          Show
          stevel@apache.org Steve Loughran added a comment - HADOOP-13139 patch 003 -in sync with branch-2 -diff with trunk is now at near-minimum -log @ warn to Configuration.deprecated if the deprecated credential spotted. -reinstated constant; tagged as deprecated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          -1 to patch 003

          the problem I'm seeing is that as soon

          mvn test -Dtest=TestS3A\*  -Pparallel-tests -DtestsThreadCount=2
          ...
          

          I don't what's happening, but if it's happening here, it's presumably happening in trunk too...just nobody is doing parallel tests there.

          While it's easy to dismiss this as one of the "not so good to run in parallel" tests, we need to understand more why this is. I suspect it may just be that the parallel test is initing the same object store during the test, as as multipart purge is set to true + 0; that's enough to break things.

          Notable that we're getting 404 as a failure here, which is being remapped to an FNFE in our code. Is that the right reaction?

          Running org.apache.hadoop.fs.s3a.TestS3ABlockingThreadPool
          Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 18.818 sec <<< FAILURE! - in org.apache.hadoop.fs.s3a.TestS3ABlockingThreadPool
          testRegularMultiPartUpload(org.apache.hadoop.fs.s3a.TestS3ABlockingThreadPool)  Time elapsed: 7.491 sec  <<< ERROR!
          org.apache.hadoop.fs.s3a.AWSClientIOException: saving output on tests3a/1a868efc-3a49-4407-9b36-9265743b5db6: com.amazonaws.AmazonClientException: Unable to complete multi-part upload. Individual part upload failed : The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchUpload; Request ID: ED572BAB993A2DC4): Unable to complete multi-part upload. Individual part upload failed : The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchUpload; Request ID: ED572BAB993A2DC4)
          	at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:84)
          	at org.apache.hadoop.fs.s3a.S3AOutputStream.close(S3AOutputStream.java:123)
          	at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:72)
          	at org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:106)
          	at org.apache.hadoop.fs.contract.ContractTestUtils.generateTestFile(ContractTestUtils.java:864)
          	at org.apache.hadoop.fs.contract.ContractTestUtils.createAndVerifyFile(ContractTestUtils.java:892)
          	at org.apache.hadoop.fs.s3a.TestS3ABlockingThreadPool.testRegularMultiPartUpload(TestS3ABlockingThreadPool.java:68)
          Caused by: com.amazonaws.AmazonClientException: Unable to complete multi-part upload. Individual part upload failed : The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchUpload; Request ID: ED572BAB993A2DC4)
          	at com.amazonaws.services.s3.transfer.internal.CompleteMultipartUpload.collectPartETags(CompleteMultipartUpload.java:122)
          	at com.amazonaws.services.s3.transfer.internal.CompleteMultipartUpload.call(CompleteMultipartUpload.java:85)
          	at com.amazonaws.services.s3.transfer.internal.CompleteMultipartUpload.call(CompleteMultipartUpload.java:38)
          	at org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService$CallableWithPermitRelease.call(BlockingThreadPoolExecutorService.java:239)
          	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
          	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
          	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
          	at java.lang.Thread.run(Thread.java:745)
          Caused by: com.amazonaws.services.s3.model.AmazonS3Exception: The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchUpload; Request ID: ED572BAB993A2DC4)
          	at com.amazonaws.http.AmazonHttpClient.handleErrorResponse(AmazonHttpClient.java:1182)
          	at com.amazonaws.http.AmazonHttpClient.executeOneRequest(AmazonHttpClient.java:770)
          	at com.amazonaws.http.AmazonHttpClient.executeHelper(AmazonHttpClient.java:489)
          	at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:310)
          	at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:3785)
          	at com.amazonaws.services.s3.AmazonS3Client.doUploadPart(AmazonS3Client.java:2921)
          	at com.amazonaws.services.s3.AmazonS3Client.uploadPart(AmazonS3Client.java:2906)
          	at com.amazonaws.services.s3.transfer.internal.UploadPartCallable.call(UploadPartCallable.java:33)
          	at com.amazonaws.services.s3.transfer.internal.UploadPartCallable.call(UploadPartCallable.java:23)
          	at org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService$CallableWithPermitRelease.call(BlockingThreadPoolExecutorService.java:239)
          	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
          	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
          	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
          	at java.lang.Thread.run(Thread.java:745)
          
          testFastMultiPartUpload(org.apache.hadoop.fs.s3a.TestS3ABlockingThreadPool)  Time elapsed: 11.249 sec  <<< ERROR!
          java.io.FileNotFoundException: Multi-part upload with id 'jFO63Jn9nnLWYp17xOMOXlZE6A3kBHLNfRydOFYkd1TJKESP7ZgLCE4OPWhV2rluUdKysiC4XsnxFxYfMmXIqg--' on tests3a/5f2bd5c5-5482-4e57-8836-8ec228e87a61: com.amazonaws.services.s3.model.AmazonS3Exception: The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchUpload; Request ID: ADFB4ECB8AA92906), S3 Extended Request ID: IPOATzKHoEoWXlgogqfM3PB9x8m8TNwlqywNjE1f8JvPNn6RdQqxoxzhFTa5fTAbk4M3ef7XEGw=
          	at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:106)
          	at org.apache.hadoop.fs.s3a.S3AUtils.extractException(S3AUtils.java:141)
          	at org.apache.hadoop.fs.s3a.S3AFastOutputStream$MultiPartUpload.waitForAllPartUploads(S3AFastOutputStream.java:365)
          	at org.apache.hadoop.fs.s3a.S3AFastOutputStream$MultiPartUpload.access$100(S3AFastOutputStream.java:319)
          	at org.apache.hadoop.fs.s3a.S3AFastOutputStream.close(S3AFastOutputStream.java:254)
          	at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:72)
          	at org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:106)
          
          Show
          stevel@apache.org Steve Loughran added a comment - -1 to patch 003 the problem I'm seeing is that as soon mvn test -Dtest=TestS3A\* -Pparallel-tests -DtestsThreadCount=2 ... I don't what's happening, but if it's happening here, it's presumably happening in trunk too...just nobody is doing parallel tests there. While it's easy to dismiss this as one of the "not so good to run in parallel" tests, we need to understand more why this is. I suspect it may just be that the parallel test is initing the same object store during the test, as as multipart purge is set to true + 0; that's enough to break things. Notable that we're getting 404 as a failure here, which is being remapped to an FNFE in our code. Is that the right reaction? Running org.apache.hadoop.fs.s3a.TestS3ABlockingThreadPool Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 18.818 sec <<< FAILURE! - in org.apache.hadoop.fs.s3a.TestS3ABlockingThreadPool testRegularMultiPartUpload(org.apache.hadoop.fs.s3a.TestS3ABlockingThreadPool) Time elapsed: 7.491 sec <<< ERROR! org.apache.hadoop.fs.s3a.AWSClientIOException: saving output on tests3a/1a868efc-3a49-4407-9b36-9265743b5db6: com.amazonaws.AmazonClientException: Unable to complete multi-part upload. Individual part upload failed : The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchUpload; Request ID: ED572BAB993A2DC4): Unable to complete multi-part upload. Individual part upload failed : The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchUpload; Request ID: ED572BAB993A2DC4) at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:84) at org.apache.hadoop.fs.s3a.S3AOutputStream.close(S3AOutputStream.java:123) at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:72) at org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:106) at org.apache.hadoop.fs.contract.ContractTestUtils.generateTestFile(ContractTestUtils.java:864) at org.apache.hadoop.fs.contract.ContractTestUtils.createAndVerifyFile(ContractTestUtils.java:892) at org.apache.hadoop.fs.s3a.TestS3ABlockingThreadPool.testRegularMultiPartUpload(TestS3ABlockingThreadPool.java:68) Caused by: com.amazonaws.AmazonClientException: Unable to complete multi-part upload. Individual part upload failed : The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchUpload; Request ID: ED572BAB993A2DC4) at com.amazonaws.services.s3.transfer.internal.CompleteMultipartUpload.collectPartETags(CompleteMultipartUpload.java:122) at com.amazonaws.services.s3.transfer.internal.CompleteMultipartUpload.call(CompleteMultipartUpload.java:85) at com.amazonaws.services.s3.transfer.internal.CompleteMultipartUpload.call(CompleteMultipartUpload.java:38) at org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService$CallableWithPermitRelease.call(BlockingThreadPoolExecutorService.java:239) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang. Thread .run( Thread .java:745) Caused by: com.amazonaws.services.s3.model.AmazonS3Exception: The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchUpload; Request ID: ED572BAB993A2DC4) at com.amazonaws.http.AmazonHttpClient.handleErrorResponse(AmazonHttpClient.java:1182) at com.amazonaws.http.AmazonHttpClient.executeOneRequest(AmazonHttpClient.java:770) at com.amazonaws.http.AmazonHttpClient.executeHelper(AmazonHttpClient.java:489) at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:310) at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:3785) at com.amazonaws.services.s3.AmazonS3Client.doUploadPart(AmazonS3Client.java:2921) at com.amazonaws.services.s3.AmazonS3Client.uploadPart(AmazonS3Client.java:2906) at com.amazonaws.services.s3.transfer.internal.UploadPartCallable.call(UploadPartCallable.java:33) at com.amazonaws.services.s3.transfer.internal.UploadPartCallable.call(UploadPartCallable.java:23) at org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService$CallableWithPermitRelease.call(BlockingThreadPoolExecutorService.java:239) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang. Thread .run( Thread .java:745) testFastMultiPartUpload(org.apache.hadoop.fs.s3a.TestS3ABlockingThreadPool) Time elapsed: 11.249 sec <<< ERROR! java.io.FileNotFoundException: Multi-part upload with id 'jFO63Jn9nnLWYp17xOMOXlZE6A3kBHLNfRydOFYkd1TJKESP7ZgLCE4OPWhV2rluUdKysiC4XsnxFxYfMmXIqg--' on tests3a/5f2bd5c5-5482-4e57-8836-8ec228e87a61: com.amazonaws.services.s3.model.AmazonS3Exception: The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchUpload; Request ID: ADFB4ECB8AA92906), S3 Extended Request ID: IPOATzKHoEoWXlgogqfM3PB9x8m8TNwlqywNjE1f8JvPNn6RdQqxoxzhFTa5fTAbk4M3ef7XEGw= at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:106) at org.apache.hadoop.fs.s3a.S3AUtils.extractException(S3AUtils.java:141) at org.apache.hadoop.fs.s3a.S3AFastOutputStream$MultiPartUpload.waitForAllPartUploads(S3AFastOutputStream.java:365) at org.apache.hadoop.fs.s3a.S3AFastOutputStream$MultiPartUpload.access$100(S3AFastOutputStream.java:319) at org.apache.hadoop.fs.s3a.S3AFastOutputStream.close(S3AFastOutputStream.java:254) at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:72) at org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:106)
          Hide
          stevel@apache.org Steve Loughran added a comment -

          HADOOP-13262 covers the extension of multipart cleanup delays; that patch makes the test work. I'm filing it separately so that it can be applied to trunk

          Show
          stevel@apache.org Steve Loughran added a comment - HADOOP-13262 covers the extension of multipart cleanup delays; that patch makes the test work. I'm filing it separately so that it can be applied to trunk
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 27s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 29s branch-2 passed
          +1 compile 5m 42s branch-2 passed with JDK v1.8.0_91
          +1 compile 6m 21s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 1m 21s branch-2 passed
          +1 mvnsite 1m 18s branch-2 passed
          +1 mvneclipse 0m 28s branch-2 passed
          +1 findbugs 2m 6s branch-2 passed
          +1 javadoc 0m 58s branch-2 passed with JDK v1.8.0_91
          +1 javadoc 1m 13s branch-2 passed with JDK v1.7.0_101
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 0m 57s the patch passed
          +1 compile 6m 7s the patch passed with JDK v1.8.0_91
          -1 javac 6m 7s root-jdk1.8.0_91 with JDK v1.8.0_91 generated 3 new + 823 unchanged - 0 fixed = 826 total (was 823)
          +1 compile 7m 41s the patch passed with JDK v1.7.0_101
          -1 javac 7m 41s root-jdk1.7.0_101 with JDK v1.7.0_101 generated 3 new + 908 unchanged - 0 fixed = 911 total (was 908)
          -1 checkstyle 1m 29s root: The patch generated 2 new + 14 unchanged - 3 fixed = 16 total (was 17)
          +1 mvnsite 1m 21s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 2m 57s the patch passed
          +1 javadoc 1m 1s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 18s the patch passed with JDK v1.7.0_101
          +1 unit 9m 44s hadoop-common in the patch passed with JDK v1.7.0_101.
          +1 unit 0m 15s hadoop-aws in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          72m 3s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:babe025
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809854/HADOOP-13139-branch-2-003.patch
          JIRA Issue HADOOP-13139
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 01e05c7a81fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / c540b9b
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9760/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_91.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9760/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_101.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9760/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9760/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9760/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9760/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 29s branch-2 passed +1 compile 5m 42s branch-2 passed with JDK v1.8.0_91 +1 compile 6m 21s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 1m 21s branch-2 passed +1 mvnsite 1m 18s branch-2 passed +1 mvneclipse 0m 28s branch-2 passed +1 findbugs 2m 6s branch-2 passed +1 javadoc 0m 58s branch-2 passed with JDK v1.8.0_91 +1 javadoc 1m 13s branch-2 passed with JDK v1.7.0_101 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 0m 57s the patch passed +1 compile 6m 7s the patch passed with JDK v1.8.0_91 -1 javac 6m 7s root-jdk1.8.0_91 with JDK v1.8.0_91 generated 3 new + 823 unchanged - 0 fixed = 826 total (was 823) +1 compile 7m 41s the patch passed with JDK v1.7.0_101 -1 javac 7m 41s root-jdk1.7.0_101 with JDK v1.7.0_101 generated 3 new + 908 unchanged - 0 fixed = 911 total (was 908) -1 checkstyle 1m 29s root: The patch generated 2 new + 14 unchanged - 3 fixed = 16 total (was 17) +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 30s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 2m 57s the patch passed +1 javadoc 1m 1s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 18s the patch passed with JDK v1.7.0_101 +1 unit 9m 44s hadoop-common in the patch passed with JDK v1.7.0_101. +1 unit 0m 15s hadoop-aws in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 72m 3s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809854/HADOOP-13139-branch-2-003.patch JIRA Issue HADOOP-13139 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 01e05c7a81fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / c540b9b Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9760/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_91.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9760/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_101.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9760/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9760/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9760/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9760/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -
          mvn test -Dtest=TestS3A*  -Pparallel-tests -DtestsThreadCount=2
          

          Steve Loughran, when you pass a -Dtest= argument, you are overriding the <includes> list passed to Surefire during the build. Passing TestS3A* matches all the S3A test suites, including the ones I listed in <excludes> to prevent parallel execution. I just tested this, and it looks like if Surefire finds the same test matching both the whitelist and the blacklist, then the whitelist wins. Therefore, tests that can't handle parallel execution end up running in the parallel phase.

          Unfortunately, I think this means you can't reliably do both -Pparallel-tests and -Dtest=TestS3A* in the same mvn run. I had flagged all multi-part upload tests to run outside the parallel phase because of the abort-existing-uploads-on-init logic, so I wouldn't expect them to work well in the parallel phase.

          It would be nice to be able to run only S3A tests in parallel for more rapid iterations on patches that touch only S3A code. I think we'd need to use some other naming convention on all non-parallel-safe test suite classes to support that, so that you could specify a wildcard to -Dtest= that wouldn't match those suites.

          Show
          cnauroth Chris Nauroth added a comment - mvn test -Dtest=TestS3A* -Pparallel-tests -DtestsThreadCount=2 Steve Loughran , when you pass a -Dtest= argument, you are overriding the <includes> list passed to Surefire during the build. Passing TestS3A* matches all the S3A test suites, including the ones I listed in <excludes> to prevent parallel execution. I just tested this, and it looks like if Surefire finds the same test matching both the whitelist and the blacklist, then the whitelist wins. Therefore, tests that can't handle parallel execution end up running in the parallel phase. Unfortunately, I think this means you can't reliably do both -Pparallel-tests and -Dtest=TestS3A* in the same mvn run. I had flagged all multi-part upload tests to run outside the parallel phase because of the abort-existing-uploads-on-init logic, so I wouldn't expect them to work well in the parallel phase. It would be nice to be able to run only S3A tests in parallel for more rapid iterations on patches that touch only S3A code. I think we'd need to use some other naming convention on all non-parallel-safe test suite classes to support that, so that you could specify a wildcard to -Dtest= that wouldn't match those suites.
          Hide
          andrew.wang Andrew Wang added a comment -

          Steve Loughran I'm not picky as long as there is some type of log message. I'd prefer a WARN since in this case the user should really fix their config, but will leave it up to you.

          Show
          andrew.wang Andrew Wang added a comment - Steve Loughran I'm not picky as long as there is some type of log message. I'd prefer a WARN since in this case the user should really fix their config, but will leave it up to you.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Chris, thanks for that explanation. Explains why a test run against 2.8 ran everything in parallel; I'd left off the wildcard.

          Setting the multipart cleanup timeout to 5 minutes makes these tests work; the root ops still fail.

          Actually, there's another way to parallelise safely.

          1. the tests runner sets a property about whether things are running parallel/serial
          2. tests which only run in serial do an assume about the property, so will skip in a parallel run
          3. for the contract root tests, they can change the contract options in a parallel run
          Show
          stevel@apache.org Steve Loughran added a comment - Chris, thanks for that explanation. Explains why a test run against 2.8 ran everything in parallel; I'd left off the wildcard. Setting the multipart cleanup timeout to 5 minutes makes these tests work; the root ops still fail. Actually, there's another way to parallelise safely. the tests runner sets a property about whether things are running parallel/serial tests which only run in serial do an assume about the property, so will skip in a parallel run for the contract root tests, they can change the contract options in a parallel run
          Hide
          stevel@apache.org Steve Loughran added a comment -

          IT's a WARN

          Show
          stevel@apache.org Steve Loughran added a comment - IT's a WARN
          Hide
          stevel@apache.org Steve Loughran added a comment -

          patch 004. Address compiler warnings which don't introduce a diff between trunk and branch-2

          Show
          stevel@apache.org Steve Loughran added a comment - patch 004. Address compiler warnings which don't introduce a diff between trunk and branch-2
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 10m 33s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 34s Maven dependency ordering for branch
          +1 mvninstall 6m 35s branch-2 passed
          +1 compile 5m 37s branch-2 passed with JDK v1.8.0_91
          +1 compile 6m 30s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 1m 22s branch-2 passed
          +1 mvnsite 1m 20s branch-2 passed
          +1 mvneclipse 0m 31s branch-2 passed
          +1 findbugs 2m 11s branch-2 passed
          +1 javadoc 0m 57s branch-2 passed with JDK v1.8.0_91
          +1 javadoc 1m 9s branch-2 passed with JDK v1.7.0_101
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 0m 57s the patch passed
          +1 compile 5m 21s the patch passed with JDK v1.8.0_91
          +1 javac 5m 21s the patch passed
          +1 compile 6m 23s the patch passed with JDK v1.7.0_101
          +1 javac 6m 23s the patch passed
          -1 checkstyle 1m 23s root: The patch generated 1 new + 14 unchanged - 3 fixed = 15 total (was 17)
          +1 mvnsite 1m 19s the patch passed
          +1 mvneclipse 0m 31s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 2m 42s the patch passed
          +1 javadoc 0m 58s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 12s the patch passed with JDK v1.7.0_101
          +1 unit 8m 8s hadoop-common in the patch passed with JDK v1.7.0_101.
          +1 unit 0m 17s hadoop-aws in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          77m 3s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:d1c475d
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811094/HADOOP-13139-branch-2-004.patch
          JIRA Issue HADOOP-13139
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 9aabb78efee6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 6ab1f54
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9797/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9797/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9797/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9797/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 33s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 34s Maven dependency ordering for branch +1 mvninstall 6m 35s branch-2 passed +1 compile 5m 37s branch-2 passed with JDK v1.8.0_91 +1 compile 6m 30s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 1m 22s branch-2 passed +1 mvnsite 1m 20s branch-2 passed +1 mvneclipse 0m 31s branch-2 passed +1 findbugs 2m 11s branch-2 passed +1 javadoc 0m 57s branch-2 passed with JDK v1.8.0_91 +1 javadoc 1m 9s branch-2 passed with JDK v1.7.0_101 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 0m 57s the patch passed +1 compile 5m 21s the patch passed with JDK v1.8.0_91 +1 javac 5m 21s the patch passed +1 compile 6m 23s the patch passed with JDK v1.7.0_101 +1 javac 6m 23s the patch passed -1 checkstyle 1m 23s root: The patch generated 1 new + 14 unchanged - 3 fixed = 15 total (was 17) +1 mvnsite 1m 19s the patch passed +1 mvneclipse 0m 31s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 2m 42s the patch passed +1 javadoc 0m 58s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 12s the patch passed with JDK v1.7.0_101 +1 unit 8m 8s hadoop-common in the patch passed with JDK v1.7.0_101. +1 unit 0m 17s hadoop-aws in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 77m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:d1c475d JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811094/HADOOP-13139-branch-2-004.patch JIRA Issue HADOOP-13139 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 9aabb78efee6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 6ab1f54 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9797/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9797/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9797/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9797/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Cancelling patch. I want to change the logging to only log once on deprecation, no matter how many FS instances are created

          Show
          stevel@apache.org Steve Loughran added a comment - Cancelling patch. I want to change the logging to only log once on deprecation, no matter how many FS instances are created
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Patch 005 config option ignored warning message is logged only once

          Show
          stevel@apache.org Steve Loughran added a comment - Patch 005 config option ignored warning message is logged only once
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 33s Maven dependency ordering for branch
          +1 mvninstall 6m 34s branch-2 passed
          +1 compile 5m 28s branch-2 passed with JDK v1.8.0_91
          +1 compile 6m 23s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 1m 20s branch-2 passed
          +1 mvnsite 1m 20s branch-2 passed
          +1 mvneclipse 0m 30s branch-2 passed
          +1 findbugs 2m 10s branch-2 passed
          +1 javadoc 0m 57s branch-2 passed with JDK v1.8.0_91
          +1 javadoc 1m 11s branch-2 passed with JDK v1.7.0_101
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 0m 56s the patch passed
          +1 compile 5m 30s the patch passed with JDK v1.8.0_91
          +1 javac 5m 30s the patch passed
          +1 compile 6m 29s the patch passed with JDK v1.7.0_101
          +1 javac 6m 29s the patch passed
          -1 checkstyle 1m 20s root: The patch generated 2 new + 14 unchanged - 3 fixed = 16 total (was 17)
          +1 mvnsite 1m 20s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 2m 38s the patch passed
          +1 javadoc 0m 56s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 11s the patch passed with JDK v1.7.0_101
          +1 unit 7m 44s hadoop-common in the patch passed with JDK v1.7.0_101.
          +1 unit 0m 17s hadoop-aws in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          65m 37s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:d1c475d
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811792/HADOOP-13139-branch-2-005.patch
          JIRA Issue HADOOP-13139
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux bbf9a825cf03 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 39ea089
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9833/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9833/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9833/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9833/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 33s Maven dependency ordering for branch +1 mvninstall 6m 34s branch-2 passed +1 compile 5m 28s branch-2 passed with JDK v1.8.0_91 +1 compile 6m 23s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 1m 20s branch-2 passed +1 mvnsite 1m 20s branch-2 passed +1 mvneclipse 0m 30s branch-2 passed +1 findbugs 2m 10s branch-2 passed +1 javadoc 0m 57s branch-2 passed with JDK v1.8.0_91 +1 javadoc 1m 11s branch-2 passed with JDK v1.7.0_101 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 0m 56s the patch passed +1 compile 5m 30s the patch passed with JDK v1.8.0_91 +1 javac 5m 30s the patch passed +1 compile 6m 29s the patch passed with JDK v1.7.0_101 +1 javac 6m 29s the patch passed -1 checkstyle 1m 20s root: The patch generated 2 new + 14 unchanged - 3 fixed = 16 total (was 17) +1 mvnsite 1m 20s the patch passed +1 mvneclipse 0m 30s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 2m 38s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 11s the patch passed with JDK v1.7.0_101 +1 unit 7m 44s hadoop-common in the patch passed with JDK v1.7.0_101. +1 unit 0m 17s hadoop-aws in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 65m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:d1c475d JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811792/HADOOP-13139-branch-2-005.patch JIRA Issue HADOOP-13139 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux bbf9a825cf03 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 39ea089 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9833/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9833/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9833/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9833/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Patch 006. rebased to branch-2.

          Tested: S3 ireland.

          If yetus is happy, I'm going to +1 this. I know my hands have got it dirty in the logging, but that's my only contribution other than keeping it in sync with trunk.

          If anyone has any objections to that plan —now is the time to make your opinions known

          Show
          stevel@apache.org Steve Loughran added a comment - Patch 006. rebased to branch-2. Tested: S3 ireland. If yetus is happy, I'm going to +1 this. I know my hands have got it dirty in the logging, but that's my only contribution other than keeping it in sync with trunk. If anyone has any objections to that plan —now is the time to make your opinions known
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 16m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 45s Maven dependency ordering for branch
          +1 mvninstall 7m 59s branch-2 passed
          +1 compile 7m 15s branch-2 passed with JDK v1.8.0_91
          +1 compile 7m 40s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 1m 25s branch-2 passed
          +1 mvnsite 1m 31s branch-2 passed
          +1 mvneclipse 0m 34s branch-2 passed
          +1 findbugs 2m 34s branch-2 passed
          +1 javadoc 1m 13s branch-2 passed with JDK v1.8.0_91
          +1 javadoc 1m 25s branch-2 passed with JDK v1.7.0_101
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 8s the patch passed
          +1 compile 7m 2s the patch passed with JDK v1.8.0_91
          +1 javac 7m 2s the patch passed
          +1 compile 7m 48s the patch passed with JDK v1.7.0_101
          +1 javac 7m 48s the patch passed
          -0 checkstyle 1m 25s root: The patch generated 2 new + 14 unchanged - 3 fixed = 16 total (was 17)
          +1 mvnsite 1m 28s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 49s the patch passed
          +1 javadoc 1m 8s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 24s the patch passed with JDK v1.7.0_101
          +1 unit 7m 54s hadoop-common in the patch passed with JDK v1.7.0_101.
          +1 unit 0m 23s hadoop-aws in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          116m 9s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814698/HADOOP-13139-branch-2-006.patch
          JIRA Issue HADOOP-13139
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 2ce853100d43 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / a82ea92
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9898/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9898/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9898/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9898/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 16m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 45s Maven dependency ordering for branch +1 mvninstall 7m 59s branch-2 passed +1 compile 7m 15s branch-2 passed with JDK v1.8.0_91 +1 compile 7m 40s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 1m 25s branch-2 passed +1 mvnsite 1m 31s branch-2 passed +1 mvneclipse 0m 34s branch-2 passed +1 findbugs 2m 34s branch-2 passed +1 javadoc 1m 13s branch-2 passed with JDK v1.8.0_91 +1 javadoc 1m 25s branch-2 passed with JDK v1.7.0_101 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 8s the patch passed +1 compile 7m 2s the patch passed with JDK v1.8.0_91 +1 javac 7m 2s the patch passed +1 compile 7m 48s the patch passed with JDK v1.7.0_101 +1 javac 7m 48s the patch passed -0 checkstyle 1m 25s root: The patch generated 2 new + 14 unchanged - 3 fixed = 16 total (was 17) +1 mvnsite 1m 28s the patch passed +1 mvneclipse 0m 38s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 49s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 24s the patch passed with JDK v1.7.0_101 +1 unit 7m 54s hadoop-common in the patch passed with JDK v1.7.0_101. +1 unit 0m 23s hadoop-aws in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 116m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814698/HADOOP-13139-branch-2-006.patch JIRA Issue HADOOP-13139 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 2ce853100d43 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / a82ea92 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9898/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9898/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9898/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9898/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1. committing to 2.8 and branch-2, not trunk, obviously.

          Show
          stevel@apache.org Steve Loughran added a comment - +1. committing to 2.8 and branch-2, not trunk, obviously.
          Hide
          PieterReuse Pieter Reuse added a comment -

          Great that this feature is now in branch-2 as well! Thank you for working on this, Steve Loughran. Thanks for the input on this backport, Andrew Wang and Chris Nauroth. But of course most of the work was done by Thomas Demoor and Aaron Fabbri on the original patch.

          Show
          PieterReuse Pieter Reuse added a comment - Great that this feature is now in branch-2 as well! Thank you for working on this, Steve Loughran . Thanks for the input on this backport, Andrew Wang and Chris Nauroth . But of course most of the work was done by Thomas Demoor and Aaron Fabbri on the original patch.

            People

            • Assignee:
              PieterReuse Pieter Reuse
              Reporter:
              PieterReuse Pieter Reuse
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development