Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13132

Handle ClassCastException on AuthenticationException in LoadBalancingKMSClientProvider

    Details

      Description

      An Oozie job with a single shell action fails (may not be important, but if you needs the exact details I can provide them) with an error message coming from NodeManager:

      2016-05-10 11:10:14,290 ERROR org.apache.hadoop.yarn.YarnUncaughtExceptionHandler: Thread Thread[LogAggregationService #652,5,main] threw an Exception.
      java.lang.ClassCastException: org.apache.hadoop.security.authentication.client.AuthenticationException cannot be cast to java.security.GeneralSecurityException
      at org.apache.hadoop.crypto.key.kms.LoadBalancingKMSClientProvider.decryptEncryptedKey(LoadBalancingKMSClientProvider.java:189)
      at org.apache.hadoop.crypto.key.KeyProviderCryptoExtension.decryptEncryptedKey(KeyProviderCryptoExtension.java:388)
      at org.apache.hadoop.hdfs.DFSClient.decryptEncryptedDataEncryptionKey(DFSClient.java:1419)
      at org.apache.hadoop.hdfs.DFSClient.createWrappedOutputStream(DFSClient.java:1521)
      at org.apache.hadoop.fs.Hdfs.createInternal(Hdfs.java:108)
      at org.apache.hadoop.fs.Hdfs.createInternal(Hdfs.java:59)
      at org.apache.hadoop.fs.AbstractFileSystem.create(AbstractFileSystem.java:577)
      at org.apache.hadoop.fs.FileContext$3.next(FileContext.java:683)
      at org.apache.hadoop.fs.FileContext$3.next(FileContext.java:679)
      at org.apache.hadoop.fs.FSLinkResolver.resolve(FSLinkResolver.java:90)
      at org.apache.hadoop.fs.FileContext.create(FileContext.java:679)
      at org.apache.hadoop.yarn.logaggregation.AggregatedLogFormat$LogWriter$1.run(AggregatedLogFormat.java:382)
      at org.apache.hadoop.yarn.logaggregation.AggregatedLogFormat$LogWriter$1.run(AggregatedLogFormat.java:377)
      at java.security.AccessController.doPrivileged(Native Method)
      at javax.security.auth.Subject.doAs(Subject.java:422)
      at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1671)
      at org.apache.hadoop.yarn.logaggregation.AggregatedLogFormat$LogWriter.<init>(AggregatedLogFormat.java:376)
      at org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.AppLogAggregatorImpl.uploadLogsForContainers(AppLogAggregatorImpl.java:246)
      at org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.AppLogAggregatorImpl.doAppLogAggregation(AppLogAggregatorImpl.java:456)
      at org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.AppLogAggregatorImpl.run(AppLogAggregatorImpl.java:421)
      at org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.LogAggregationService$2.run(LogAggregationService.java:384)
      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
      at java.lang.Thread.run(Thread.java:745)
      

      The unsafe cast is here:
      https://github.com/apache/hadoop/blob/2e1d0ff4e901b8313c8d71869735b94ed8bc40a0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/LoadBalancingKMSClientProvider.java#L189

      Because of this ClassCastException:

      • an uncaught exception is raised
      • we do not see the exact "caused by" exception/message
      • the oozie job fails
      • YARN logs are not reported/saved
      1. HADOOP-13132.001.patch
        2 kB
        Wei-Chiu Chuang
      2. HADOOP-13132.002.patch
        7 kB
        Wei-Chiu Chuang
      3. HADOOP-13132.003.patch
        7 kB
        Wei-Chiu Chuang
      4. HADOOP-13132.004.patch
        6 kB
        Wei-Chiu Chuang

        Activity

        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Submit the patch for precommit validation.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Submit the patch for precommit validation.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 25s trunk passed
        +1 compile 7m 41s trunk passed with JDK v1.8.0_91
        +1 compile 6m 58s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 59s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 34s trunk passed
        +1 javadoc 0m 56s trunk passed with JDK v1.8.0_91
        +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 42s the patch passed
        +1 compile 6m 42s the patch passed with JDK v1.8.0_91
        +1 javac 6m 42s the patch passed
        +1 compile 6m 49s the patch passed with JDK v1.7.0_95
        +1 javac 6m 49s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 57s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 47s the patch passed
        +1 javadoc 0m 55s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95
        +1 unit 8m 3s hadoop-common in the patch passed with JDK v1.8.0_91.
        +1 unit 8m 11s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        64m 49s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803856/HADOOP-13132.001.patch
        JIRA Issue HADOOP-13132
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c7f2cded1c16 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ad94411
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9438/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9438/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 25s trunk passed +1 compile 7m 41s trunk passed with JDK v1.8.0_91 +1 compile 6m 58s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 56s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 42s the patch passed +1 compile 6m 42s the patch passed with JDK v1.8.0_91 +1 javac 6m 42s the patch passed +1 compile 6m 49s the patch passed with JDK v1.7.0_95 +1 javac 6m 49s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 55s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95 +1 unit 8m 3s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 8m 11s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 64m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803856/HADOOP-13132.001.patch JIRA Issue HADOOP-13132 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c7f2cded1c16 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ad94411 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9438/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9438/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks for the patch Wei-Chiu Chuang, LGTM.
        One minor ask is, maybe we can add a log when the wrapped exception is not a GSE? Since that's the assumption of the original code.

        Show
        xiaochen Xiao Chen added a comment - Thanks for the patch Wei-Chiu Chuang , LGTM. One minor ask is, maybe we can add a log when the wrapped exception is not a GSE? Since that's the assumption of the original code.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks Xiao Chen for the suggestion. I attached a new patch which includes your suggestion. In addition, this patch adds a test case

        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks Xiao Chen for the suggestion. I attached a new patch which includes your suggestion. In addition, this patch adds a test case
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 32s trunk passed
        +1 compile 6m 52s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 22s trunk passed
        +1 javadoc 0m 55s trunk passed
        +1 mvninstall 0m 40s the patch passed
        +1 compile 6m 44s the patch passed
        +1 javac 6m 44s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 54s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 30s the patch passed
        +1 javadoc 0m 56s the patch passed
        +1 unit 7m 49s hadoop-common in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        37m 33s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804555/HADOOP-13132.002.patch
        JIRA Issue HADOOP-13132
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f8864f715e47 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8a9ecb7
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9477/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9477/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 32s trunk passed +1 compile 6m 52s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 22s trunk passed +1 javadoc 0m 55s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 6m 44s the patch passed +1 javac 6m 44s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 30s the patch passed +1 javadoc 0m 56s the patch passed +1 unit 7m 49s hadoop-common in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 37m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804555/HADOOP-13132.002.patch JIRA Issue HADOOP-13132 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f8864f715e47 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8a9ecb7 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9477/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9477/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 49s trunk passed
        +1 compile 7m 8s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 0m 58s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 21s trunk passed
        +1 javadoc 0m 57s trunk passed
        +1 mvninstall 0m 41s the patch passed
        +1 compile 6m 55s the patch passed
        +1 javac 6m 55s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 40s the patch passed
        +1 javadoc 0m 55s the patch passed
        +1 unit 8m 11s hadoop-common in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        38m 58s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804555/HADOOP-13132.002.patch
        JIRA Issue HADOOP-13132
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cfa7c0503542 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8a9ecb7
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9481/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9481/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 49s trunk passed +1 compile 7m 8s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 21s trunk passed +1 javadoc 0m 57s trunk passed +1 mvninstall 0m 41s the patch passed +1 compile 6m 55s the patch passed +1 javac 6m 55s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 40s the patch passed +1 javadoc 0m 55s the patch passed +1 unit 8m 11s hadoop-common in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 38m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804555/HADOOP-13132.002.patch JIRA Issue HADOOP-13132 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cfa7c0503542 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8a9ecb7 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9481/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9481/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hi Andrew Wang and Harsh J, would you mind to review the latest patch?
        Thank you very much!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Hi Andrew Wang and Harsh J , would you mind to review the latest patch? Thank you very much!
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        v03: I looked at a similar jira (HADOOP-13180) and finally understood why it is possible to throw AuthenticationException in KMSClientProvider#decryptEncryptedKey, which can only throw IOException and GeneralSecurityException:

        there is a dirty trick in the code that cheats Java compiler and which throws AuthenticationException as an unchecked RuntimeException! Then, in LoadBalancingKMSClientProvider#doOp, because AuthenticationException is not a RuntimeException subclass, it is rethrown in a WrapperException, which causes the type cast in LoadBalancingKMSClientProvider#decryptEncryptedKey to fail. The v3 patch reproduces how it is done. (More specifically, the exception is thrown in HttpExceptionUtils#validateResponse).

        Please review again, thanks!

        Show
        jojochuang Wei-Chiu Chuang added a comment - v03: I looked at a similar jira ( HADOOP-13180 ) and finally understood why it is possible to throw AuthenticationException in KMSClientProvider#decryptEncryptedKey , which can only throw IOException and GeneralSecurityException: there is a dirty trick in the code that cheats Java compiler and which throws AuthenticationException as an unchecked RuntimeException! Then, in LoadBalancingKMSClientProvider#doOp , because AuthenticationException is not a RuntimeException subclass, it is rethrown in a WrapperException , which causes the type cast in LoadBalancingKMSClientProvider#decryptEncryptedKey to fail. The v3 patch reproduces how it is done. (More specifically, the exception is thrown in HttpExceptionUtils#validateResponse ). Please review again, thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 24s trunk passed
        +1 compile 6m 24s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 22s trunk passed
        +1 javadoc 0m 56s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 6m 39s the patch passed
        +1 javac 6m 40s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 28s the patch passed
        +1 javadoc 0m 52s the patch passed
        -1 unit 7m 38s hadoop-common in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        36m 34s



        Reason Tests
        Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804864/HADOOP-13132.003.patch
        JIRA Issue HADOOP-13132
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 862c32419661 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1597630
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9500/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9500/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9500/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9500/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 24s trunk passed +1 compile 6m 24s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 22s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 6m 39s the patch passed +1 javac 6m 40s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 28s the patch passed +1 javadoc 0m 52s the patch passed -1 unit 7m 38s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 36m 34s Reason Tests Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804864/HADOOP-13132.003.patch JIRA Issue HADOOP-13132 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 862c32419661 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1597630 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9500/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9500/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9500/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9500/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        The failed test is a known flaky test.

        Show
        jojochuang Wei-Chiu Chuang added a comment - The failed test is a known flaky test.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 23s trunk passed
        +1 compile 6m 25s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 21s trunk passed
        +1 javadoc 0m 53s trunk passed
        +1 mvninstall 0m 38s the patch passed
        +1 compile 6m 24s the patch passed
        +1 javac 6m 24s the patch passed
        +1 checkstyle 0m 31s the patch passed
        +1 mvnsite 1m 7s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 30s the patch passed
        +1 javadoc 0m 55s the patch passed
        +1 unit 7m 44s hadoop-common in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        36m 45s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804864/HADOOP-13132.003.patch
        JIRA Issue HADOOP-13132
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7bf5ba3672d2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 141873c
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9511/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9511/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 23s trunk passed +1 compile 6m 25s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 21s trunk passed +1 javadoc 0m 53s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 6m 24s the patch passed +1 javac 6m 24s the patch passed +1 checkstyle 0m 31s the patch passed +1 mvnsite 1m 7s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 30s the patch passed +1 javadoc 0m 55s the patch passed +1 unit 7m 44s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 36m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804864/HADOOP-13132.003.patch JIRA Issue HADOOP-13132 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7bf5ba3672d2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 141873c Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9511/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9511/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Ping. Andrew Wang can you review it? Thanks very much!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Ping. Andrew Wang can you review it? Thanks very much!
        Hide
        andrew.wang Andrew Wang added a comment -

        Wow, that is a pretty dirty trick for throwException. Thanks for digging in here Wei-Chiu.

        Patch looks fine overall, but do we really need those new LOG lines? The caller will very likely have appropriate logic to handle the IOException.

        Show
        andrew.wang Andrew Wang added a comment - Wow, that is a pretty dirty trick for throwException. Thanks for digging in here Wei-Chiu. Patch looks fine overall, but do we really need those new LOG lines? The caller will very likely have appropriate logic to handle the IOException.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hi Andrew, thanks for the comment.
        Yeah, the caller should already have the logic to deal with the IOExceptions. Posted a new patch to remove the log. Please review again. Thanks!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Hi Andrew, thanks for the comment. Yeah, the caller should already have the logic to deal with the IOExceptions. Posted a new patch to remove the log. Please review again. Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 32s trunk passed
        +1 compile 6m 53s trunk passed
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 10s trunk passed
        +1 findbugs 1m 27s trunk passed
        +1 javadoc 0m 56s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 6m 48s the patch passed
        +1 javac 6m 48s the patch passed
        +1 checkstyle 0m 22s the patch passed
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 30s the patch passed
        +1 javadoc 1m 0s the patch passed
        -1 unit 8m 2s hadoop-common in the patch failed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        38m 8s



        Reason Tests
        Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.net.TestDNS



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807140/HADOOP-13132.004.patch
        JIRA Issue HADOOP-13132
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0dff262239cf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 93d8a7f
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9620/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9620/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9620/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9620/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 32s trunk passed +1 compile 6m 53s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 10s trunk passed +1 findbugs 1m 27s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 6m 48s the patch passed +1 javac 6m 48s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 30s the patch passed +1 javadoc 1m 0s the patch passed -1 unit 8m 2s hadoop-common in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 38m 8s Reason Tests Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807140/HADOOP-13132.004.patch JIRA Issue HADOOP-13132 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0dff262239cf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 93d8a7f Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9620/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9620/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9620/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9620/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        LGTM, committed for 2.8.0, thanks for the contribution Wei-Chiu and the review Xiao!

        Show
        andrew.wang Andrew Wang added a comment - LGTM, committed for 2.8.0, thanks for the contribution Wei-Chiu and the review Xiao!
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Many thanks to Andrew Wang and Xiao Chen for the review!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Many thanks to Andrew Wang and Xiao Chen for the review!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9888 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9888/)
        HADOOP-13132. Handle ClassCastException on AuthenticationException in (wang: rev bca31fe276ccf7d02b13f25d43c81cca0b0b905b)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/kms/TestLoadBalancingKMSClientProvider.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/LoadBalancingKMSClientProvider.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9888 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9888/ ) HADOOP-13132 . Handle ClassCastException on AuthenticationException in (wang: rev bca31fe276ccf7d02b13f25d43c81cca0b0b905b) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/kms/TestLoadBalancingKMSClientProvider.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/LoadBalancingKMSClientProvider.java

          People

          • Assignee:
            jojochuang Wei-Chiu Chuang
            Reporter:
            mszurap Miklos Szurap
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development