Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13098

Dynamic LogLevel setting page should accept case-insensitive log level string

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Our current logLevel settings: http://deamon_web_service_address/logLevel only accept full Upper Case string of log level that means "Debug" or "debug" is treated as bad log level in setting. I think we should enhance the tools to ignore upper/lower cases.

      1. HADOOP-13098-v3.patch
        5 kB
        Junping Du
      2. HADOOP-13098-v2.patch
        5 kB
        Junping Du
      3. HADOOP-13098.patch
        3 kB
        Junping Du

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9727 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9727/)
        HADOOP-13098. Dynamic LogLevel setting page should accept (xyao: rev 4e5e87ddd4a47dbea2b23387782e7cd47dec560e)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/log/TestLogLevel.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9727 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9727/ ) HADOOP-13098 . Dynamic LogLevel setting page should accept (xyao: rev 4e5e87ddd4a47dbea2b23387782e7cd47dec560e) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/log/TestLogLevel.java
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Junping Du for the contribution and Mingliang Liu for the code review. I've committed the patch to trunk, branch-2 and branch-2.8.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Junping Du for the contribution and Mingliang Liu for the code review. I've committed the patch to trunk, branch-2 and branch-2.8.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 30s trunk passed
        +1 compile 8m 6s trunk passed with JDK v1.8.0_91
        +1 compile 7m 10s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 59s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 35s trunk passed
        +1 javadoc 0m 57s trunk passed with JDK v1.8.0_91
        +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 44s the patch passed
        +1 compile 6m 55s the patch passed with JDK v1.8.0_91
        +1 javac 6m 55s the patch passed
        +1 compile 6m 53s the patch passed with JDK v1.7.0_95
        +1 javac 6m 53s the patch passed
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 49s the patch passed
        +1 javadoc 0m 56s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 8s the patch passed with JDK v1.7.0_95
        -1 unit 8m 20s hadoop-common in the patch failed with JDK v1.8.0_91.
        -1 unit 7m 54s hadoop-common in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        65m 49s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS
        JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802461/HADOOP-13098-v3.patch
        JIRA Issue HADOOP-13098
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 072d8734cf1c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d0da132
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9292/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9292/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9292/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9292/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9292/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9292/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 30s trunk passed +1 compile 8m 6s trunk passed with JDK v1.8.0_91 +1 compile 7m 10s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 35s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 6m 55s the patch passed with JDK v1.8.0_91 +1 javac 6m 55s the patch passed +1 compile 6m 53s the patch passed with JDK v1.7.0_95 +1 javac 6m 53s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 8s the patch passed with JDK v1.7.0_95 -1 unit 8m 20s hadoop-common in the patch failed with JDK v1.8.0_91. -1 unit 7m 54s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 65m 49s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802461/HADOOP-13098-v3.patch JIRA Issue HADOOP-13098 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 072d8734cf1c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d0da132 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9292/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9292/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9292/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9292/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9292/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9292/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        +1 (non-binding)

        Show
        liuml07 Mingliang Liu added a comment - +1 (non-binding)
        Hide
        xyao Xiaoyu Yao added a comment -

        +1 for Patch v3 pending Jenkins. I've opened HADOOP-13101 for the TestDNS issue. This is just another instance of it.

        Show
        xyao Xiaoyu Yao added a comment - +1 for Patch v3 pending Jenkins. I've opened HADOOP-13101 for the TestDNS issue. This is just another instance of it.
        Hide
        djp Junping Du added a comment -

        Thanks for reviewing this, Xiaoyu Yao! Fix this silly issue in v3 patch. Also, a UT failure reported by Mr. Jenkins is not related to patch but an environment issue.

        Show
        djp Junping Du added a comment - Thanks for reviewing this, Xiaoyu Yao ! Fix this silly issue in v3 patch. Also, a UT failure reported by Mr. Jenkins is not related to patch but an environment issue.
        Hide
        xyao Xiaoyu Yao added a comment - - edited

        Patch v2 looks good to me. Only one minor issue in the test as shown below. +1 after that is addressed.

        46	      Assert.assertNotEquals("Get default Log Level which shouldn't be ERROR.",
        47	          Level.ERROR.equals(log.getEffectiveLevel()));
        

        should be

        46	      Assert.assertNotEquals("Get default Log Level which shouldn't be ERROR.",
        47	          Level.ERROR, log.getEffectiveLevel());
        
        Show
        xyao Xiaoyu Yao added a comment - - edited Patch v2 looks good to me. Only one minor issue in the test as shown below. +1 after that is addressed. 46 Assert.assertNotEquals( "Get default Log Level which shouldn't be ERROR." , 47 Level.ERROR.equals(log.getEffectiveLevel())); should be 46 Assert.assertNotEquals( "Get default Log Level which shouldn't be ERROR." , 47 Level.ERROR, log.getEffectiveLevel());
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 49s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 12m 6s trunk passed
        +1 compile 9m 39s trunk passed with JDK v1.8.0_91
        +1 compile 7m 43s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 1m 4s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 38s trunk passed
        +1 javadoc 1m 11s trunk passed with JDK v1.8.0_91
        +1 javadoc 1m 11s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 45s the patch passed
        +1 compile 9m 3s the patch passed with JDK v1.8.0_91
        +1 javac 9m 3s the patch passed
        +1 compile 7m 46s the patch passed with JDK v1.7.0_95
        +1 javac 7m 46s the patch passed
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 1m 0s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 56s the patch passed
        +1 javadoc 1m 6s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 12s the patch passed with JDK v1.7.0_95
        -1 unit 10m 6s hadoop-common in the patch failed with JDK v1.8.0_91.
        +1 unit 9m 58s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        81m 4s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802425/HADOOP-13098-v2.patch
        JIRA Issue HADOOP-13098
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7085ec054f37 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d0da132
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9290/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9290/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9290/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9290/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 49s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 6s trunk passed +1 compile 9m 39s trunk passed with JDK v1.8.0_91 +1 compile 7m 43s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 38s trunk passed +1 javadoc 1m 11s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 11s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 9m 3s the patch passed with JDK v1.8.0_91 +1 javac 9m 3s the patch passed +1 compile 7m 46s the patch passed with JDK v1.7.0_95 +1 javac 7m 46s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 56s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 12s the patch passed with JDK v1.7.0_95 -1 unit 10m 6s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 9m 58s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 81m 4s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802425/HADOOP-13098-v2.patch JIRA Issue HADOOP-13098 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7085ec054f37 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d0da132 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9290/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9290/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9290/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9290/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        djp Junping Du added a comment -

        Thanks Mingliang Liu for review! v2 patch incorporate your comments above.

        Show
        djp Junping Du added a comment - Thanks Mingliang Liu for review! v2 patch incorporate your comments above.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 32s trunk passed
        +1 compile 9m 8s trunk passed with JDK v1.8.0_91
        +1 compile 8m 49s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 1m 13s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 58s trunk passed
        +1 javadoc 1m 15s trunk passed with JDK v1.8.0_91
        +1 javadoc 1m 21s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 53s the patch passed
        +1 compile 9m 5s the patch passed with JDK v1.8.0_91
        +1 javac 9m 5s the patch passed
        +1 compile 9m 3s the patch passed with JDK v1.7.0_95
        +1 javac 9m 3s the patch passed
        +1 checkstyle 0m 26s the patch passed
        +1 mvnsite 1m 11s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 13s the patch passed
        +1 javadoc 1m 12s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 20s the patch passed with JDK v1.7.0_95
        -1 unit 9m 58s hadoop-common in the patch failed with JDK v1.8.0_91.
        -1 unit 9m 33s hadoop-common in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 27s The patch does not generate ASF License warnings.
        80m 7s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS
        JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802313/HADOOP-13098.patch
        JIRA Issue HADOOP-13098
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6d94a00a8c44 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1268cf5
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9284/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9284/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9284/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9284/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9284/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9284/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 32s trunk passed +1 compile 9m 8s trunk passed with JDK v1.8.0_91 +1 compile 8m 49s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 13s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 58s trunk passed +1 javadoc 1m 15s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 21s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 53s the patch passed +1 compile 9m 5s the patch passed with JDK v1.8.0_91 +1 javac 9m 5s the patch passed +1 compile 9m 3s the patch passed with JDK v1.7.0_95 +1 javac 9m 3s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 1m 11s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 13s the patch passed +1 javadoc 1m 12s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 20s the patch passed with JDK v1.7.0_95 -1 unit 9m 58s hadoop-common in the patch failed with JDK v1.8.0_91. -1 unit 9m 33s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 80m 7s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802313/HADOOP-13098.patch JIRA Issue HADOOP-13098 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6d94a00a8c44 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1268cf5 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9284/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9284/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9284/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9284/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9284/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9284/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks for filing this, Junping Du.

        1. I'm not favor of assertTrue(Level.ERROR.equals(log.getEffectiveLevel()));. IMHO assertEquals("some case specific error message", Level.ERROR, log.getEffectiveLevel()); seems better.
        2. My minor concern is that, in case of invalid argument, the error message should better include the original user-provided level. Or else, if the user provides inffo, and we report error message saying Bad level : INFFO. The user may be confused as she's pretty sure she did not input any uppercase char.
        3. That said, org.apache.log4j.Level.toLevel() accepts mixing upper/lower-case string. We can simply replace the level.equals() with level.equalsIgnoreCase(). Changing the input to uppercase should work just work fine. java.util.logging.Logger seems different.

        +1 (non-binding) after the comments above are considered/addressed.

        Show
        liuml07 Mingliang Liu added a comment - Thanks for filing this, Junping Du . I'm not favor of assertTrue(Level.ERROR.equals(log.getEffectiveLevel())); . IMHO assertEquals("some case specific error message", Level.ERROR, log.getEffectiveLevel()); seems better. My minor concern is that, in case of invalid argument, the error message should better include the original user-provided level . Or else, if the user provides inffo , and we report error message saying Bad level : INFFO . The user may be confused as she's pretty sure she did not input any uppercase char. That said, org.apache.log4j.Level.toLevel() accepts mixing upper/lower-case string. We can simply replace the level.equals() with level.equalsIgnoreCase() . Changing the input to uppercase should work just work fine. java.util.logging.Logger seems different. +1 (non-binding) after the comments above are considered/addressed.
        Hide
        djp Junping Du added a comment -

        Put a patch to fix this issue.

        Show
        djp Junping Du added a comment - Put a patch to fix this issue.

          People

          • Assignee:
            djp Junping Du
            Reporter:
            djp Junping Du
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development