Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13083

The number of javadocs warnings is limited to 100

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We are generating a lot of javadoc warnings with jdk 1.8. Right now the number is limited to 100. Enlarge this limitation can probably reveal more problems in one batch for our javadoc generation process.

      1. YARN-4978.001.patch
        0.5 kB
        Gergely Novák

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 33s trunk passed
          +1 compile 0m 8s trunk passed with JDK v1.8.0_91
          +1 compile 0m 9s trunk passed with JDK v1.7.0_95
          +1 mvnsite 0m 12s trunk passed
          +1 mvneclipse 0m 10s trunk passed
          +1 javadoc 0m 8s trunk passed with JDK v1.8.0_91
          +1 javadoc 0m 10s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 7s the patch passed
          +1 compile 0m 5s the patch passed with JDK v1.8.0_91
          +1 javac 0m 5s the patch passed
          +1 compile 0m 6s the patch passed with JDK v1.7.0_95
          +1 javac 0m 7s the patch passed
          +1 mvnsite 0m 8s the patch passed
          +1 mvneclipse 0m 8s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 javadoc 0m 6s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 8s the patch passed with JDK v1.7.0_95
          +1 unit 0m 5s hadoop-project in the patch passed with JDK v1.8.0_91.
          +1 unit 0m 6s hadoop-project in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          9m 51s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801760/YARN-4978.001.patch
          JIRA Issue YARN-4978
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux f51531fec476 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 971af60
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11306/testReport/
          modules C: hadoop-project U: hadoop-project
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11306/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 33s trunk passed +1 compile 0m 8s trunk passed with JDK v1.8.0_91 +1 compile 0m 9s trunk passed with JDK v1.7.0_95 +1 mvnsite 0m 12s trunk passed +1 mvneclipse 0m 10s trunk passed +1 javadoc 0m 8s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 10s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 7s the patch passed +1 compile 0m 5s the patch passed with JDK v1.8.0_91 +1 javac 0m 5s the patch passed +1 compile 0m 6s the patch passed with JDK v1.7.0_95 +1 javac 0m 7s the patch passed +1 mvnsite 0m 8s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 0m 6s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 8s the patch passed with JDK v1.7.0_95 +1 unit 0m 5s hadoop-project in the patch passed with JDK v1.8.0_91. +1 unit 0m 6s hadoop-project in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 9m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801760/YARN-4978.001.patch JIRA Issue YARN-4978 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux f51531fec476 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 971af60 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11306/testReport/ modules C: hadoop-project U: hadoop-project Console output https://builds.apache.org/job/PreCommit-YARN-Build/11306/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          GergelyNovak Gergely Novák added a comment -

          Uploaded patch #001, it increases the limit of the javadoc warnings to 10 000.

          I don't see how this could be unit tested, an example for manual verification is using mvn javadoc:javadoc from hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api with JDK 1.8; before the patch this gives 100 warnings, after the patch it gives 5406 ones.

          Show
          GergelyNovak Gergely Novák added a comment - Uploaded patch #001, it increases the limit of the javadoc warnings to 10 000. I don't see how this could be unit tested, an example for manual verification is using mvn javadoc:javadoc from hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api with JDK 1.8; before the patch this gives 100 warnings, after the patch it gives 5406 ones.
          Hide
          gtCarrera9 Li Lu added a comment -

          Thanks for the work Gergely Novák! I tried the patch locally and we're definitely fixing the problem. I saw the fix is on the Hadoop side so let me move this to hadoop common projects. The fix looks fine on the YARN side but let's make sure we're not affecting other components before moving forward. Thanks!

          Show
          gtCarrera9 Li Lu added a comment - Thanks for the work Gergely Novák ! I tried the patch locally and we're definitely fixing the problem. I saw the fix is on the Hadoop side so let me move this to hadoop common projects. The fix looks fine on the YARN side but let's make sure we're not affecting other components before moving forward. Thanks!
          Hide
          gtCarrera9 Li Lu added a comment -

          Moved the patch to HADOOP. The fix looks good to me but I would like to check if this will break anything on common and/or HDFS.

          Show
          gtCarrera9 Li Lu added a comment - Moved the patch to HADOOP. The fix looks good to me but I would like to check if this will break anything on common and/or HDFS.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 51s trunk passed
          +1 compile 0m 8s trunk passed with JDK v1.8.0_91
          +1 compile 0m 9s trunk passed with JDK v1.7.0_95
          +1 mvnsite 0m 12s trunk passed
          +1 mvneclipse 0m 10s trunk passed
          +1 javadoc 0m 9s trunk passed with JDK v1.8.0_91
          +1 javadoc 0m 10s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 7s the patch passed
          +1 compile 0m 6s the patch passed with JDK v1.8.0_91
          +1 javac 0m 6s the patch passed
          +1 compile 0m 7s the patch passed with JDK v1.7.0_95
          +1 javac 0m 7s the patch passed
          +1 mvnsite 0m 9s the patch passed
          +1 mvneclipse 0m 8s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 javadoc 0m 6s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 7s the patch passed with JDK v1.7.0_95
          +1 unit 0m 5s hadoop-project in the patch passed with JDK v1.8.0_91.
          +1 unit 0m 6s hadoop-project in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          10m 11s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801760/YARN-4978.001.patch
          JIRA Issue HADOOP-13083
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 0ec5fe45f61d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ed54f5f
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9267/testReport/
          modules C: hadoop-project U: hadoop-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9267/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 51s trunk passed +1 compile 0m 8s trunk passed with JDK v1.8.0_91 +1 compile 0m 9s trunk passed with JDK v1.7.0_95 +1 mvnsite 0m 12s trunk passed +1 mvneclipse 0m 10s trunk passed +1 javadoc 0m 9s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 10s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 7s the patch passed +1 compile 0m 6s the patch passed with JDK v1.8.0_91 +1 javac 0m 6s the patch passed +1 compile 0m 7s the patch passed with JDK v1.7.0_95 +1 javac 0m 7s the patch passed +1 mvnsite 0m 9s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 0m 6s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 7s the patch passed with JDK v1.7.0_95 +1 unit 0m 5s hadoop-project in the patch passed with JDK v1.8.0_91. +1 unit 0m 6s hadoop-project in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 10m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801760/YARN-4978.001.patch JIRA Issue HADOOP-13083 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 0ec5fe45f61d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ed54f5f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9267/testReport/ modules C: hadoop-project U: hadoop-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9267/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          LGTM +1. Only possible danger I see is increased output, but seems like our build handled that fine.

          Show
          andrew.wang Andrew Wang added a comment - LGTM +1. Only possible danger I see is increased output, but seems like our build handled that fine.
          Hide
          gtCarrera9 Li Lu added a comment -

          Thanks Andrew Wang. I'll wait 24 hrs and then commit this fix.

          Show
          gtCarrera9 Li Lu added a comment - Thanks Andrew Wang . I'll wait 24 hrs and then commit this fix.
          Hide
          gtCarrera9 Li Lu added a comment -

          +1. Will commit shortly.

          Show
          gtCarrera9 Li Lu added a comment - +1. Will commit shortly.
          Hide
          gtCarrera9 Li Lu added a comment -

          Committed to trunk, branch-2, and branch-2.8. Thanks Gergely Novák for the patch and Andrew Wang for the review!

          Show
          gtCarrera9 Li Lu added a comment - Committed to trunk, branch-2, and branch-2.8. Thanks Gergely Novák for the patch and Andrew Wang for the review!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9761 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9761/)
          HADOOP-13083. The number of javadocs warnings is limited to 100. (gtcarrera9: rev 3fa1380c221b9d659fb82c42284505ef19da38d0)

          • hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9761 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9761/ ) HADOOP-13083 . The number of javadocs warnings is limited to 100. (gtcarrera9: rev 3fa1380c221b9d659fb82c42284505ef19da38d0) hadoop-project/pom.xml

            People

            • Assignee:
              GergelyNovak Gergely Novák
              Reporter:
              gtCarrera9 Li Lu
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development