Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13080

Refresh time in SysInfoWindows is in nanoseconds

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: util
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      SysInfoWindows gets the current time in nanonseconds but assumes milliseconds.

      1. HADOOP-13080-v0.patch
        0.9 kB
        Íñigo Goiri
      2. HADOOP-13080-v1.patch
        0.6 kB
        Íñigo Goiri

        Issue Links

          Activity

          Hide
          elgoiri Íñigo Goiri added a comment -

          When moving WindowsResourceCalculatorPlugin from YARN to Commons, the way to get the time changed. My proposal is to use Time.monotonicNow() which already does the translation from ns to ms.

          Show
          elgoiri Íñigo Goiri added a comment - When moving WindowsResourceCalculatorPlugin from YARN to Commons, the way to get the time changed. My proposal is to use Time.monotonicNow() which already does the translation from ns to ms.
          Hide
          elgoiri Íñigo Goiri added a comment -

          First version of the patch to move ns into ms.

          Show
          elgoiri Íñigo Goiri added a comment - First version of the patch to move ns into ms.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Chris Douglas, Karthik Kambatla as you guys were involved in HADOOP-12180, do you mind taking a look?
          Not sure if there's a point on adding a unit test for this as it wouldn't run on Windows.

          Show
          elgoiri Íñigo Goiri added a comment - Chris Douglas , Karthik Kambatla as you guys were involved in HADOOP-12180 , do you mind taking a look? Not sure if there's a point on adding a unit test for this as it wouldn't run on Windows.
          Hide
          chris.douglas Chris Douglas added a comment -

          +1 lgtm. Agree this doesn't require a unit test; ran the TestSysInfo* tests, they passed on trunk/branch-2/branch-2.8.

          Will commit when Jenkins comes back.

          Show
          chris.douglas Chris Douglas added a comment - +1 lgtm. Agree this doesn't require a unit test; ran the TestSysInfo* tests, they passed on trunk/branch-2/branch-2.8. Will commit when Jenkins comes back.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 11m 33s trunk passed
          +1 compile 9m 9s trunk passed with JDK v1.8.0_91
          +1 compile 8m 54s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 1m 17s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 2m 6s trunk passed
          +1 javadoc 1m 14s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 20s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 52s the patch passed
          +1 compile 9m 7s the patch passed with JDK v1.8.0_91
          +1 javac 9m 7s the patch passed
          +1 compile 8m 43s the patch passed with JDK v1.7.0_95
          +1 javac 8m 43s the patch passed
          -1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 mvnsite 1m 9s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 findbugs 2m 12s the patch passed
          +1 javadoc 1m 13s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 19s the patch passed with JDK v1.7.0_95
          +1 unit 10m 25s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 10m 1s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          84m 17s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801795/HADOOP-13080-v0.patch
          JIRA Issue HADOOP-13080
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 32fc86f19786 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9e8411d
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9253/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9253/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9253/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 11m 33s trunk passed +1 compile 9m 9s trunk passed with JDK v1.8.0_91 +1 compile 8m 54s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 17s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 2m 6s trunk passed +1 javadoc 1m 14s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 20s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 52s the patch passed +1 compile 9m 7s the patch passed with JDK v1.8.0_91 +1 javac 9m 7s the patch passed +1 compile 8m 43s the patch passed with JDK v1.7.0_95 +1 javac 8m 43s the patch passed -1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 mvnsite 1m 9s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 2m 12s the patch passed +1 javadoc 1m 13s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 19s the patch passed with JDK v1.7.0_95 +1 unit 10m 25s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 10m 1s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 84m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801795/HADOOP-13080-v0.patch JIRA Issue HADOOP-13080 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 32fc86f19786 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9e8411d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9253/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9253/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9253/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixing checkstyle.

          Show
          elgoiri Íñigo Goiri added a comment - Fixing checkstyle.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 55s trunk passed
          +1 compile 5m 50s trunk passed with JDK v1.8.0_91
          +1 compile 6m 53s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 1m 2s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 36s trunk passed
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 42s the patch passed
          +1 compile 5m 56s the patch passed with JDK v1.8.0_91
          +1 javac 5m 56s the patch passed
          +1 compile 6m 52s the patch passed with JDK v1.7.0_95
          +1 javac 6m 52s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 51s the patch passed
          +1 javadoc 0m 52s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95
          +1 unit 7m 2s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 7m 24s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          59m 51s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801868/HADOOP-13080-v1.patch
          JIRA Issue HADOOP-13080
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux dc8f1e715a05 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4ee4e5c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9256/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9256/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 55s trunk passed +1 compile 5m 50s trunk passed with JDK v1.8.0_91 +1 compile 6m 53s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 36s trunk passed +1 javadoc 0m 55s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 42s the patch passed +1 compile 5m 56s the patch passed with JDK v1.8.0_91 +1 javac 5m 56s the patch passed +1 compile 6m 52s the patch passed with JDK v1.7.0_95 +1 javac 6m 52s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 51s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95 +1 unit 7m 2s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 7m 24s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 59m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801868/HADOOP-13080-v1.patch JIRA Issue HADOOP-13080 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dc8f1e715a05 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4ee4e5c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9256/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9256/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          chris.douglas Chris Douglas added a comment -

          I committed this. Thanks Inigo

          Show
          chris.douglas Chris Douglas added a comment - I committed this. Thanks Inigo
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9705 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9705/)
          HADOOP-13080. Refresh time in SysInfoWindows is in nanoseconds. (cdouglas: rev c1cc6ac667e9e1b2ed58f16cb9fa1584ea54f0ac)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SysInfoWindows.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9705 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9705/ ) HADOOP-13080 . Refresh time in SysInfoWindows is in nanoseconds. (cdouglas: rev c1cc6ac667e9e1b2ed58f16cb9fa1584ea54f0ac) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SysInfoWindows.java
          Hide
          elgoiri Íñigo Goiri added a comment -

          Thanks you Chris Douglas!

          Show
          elgoiri Íñigo Goiri added a comment - Thanks you Chris Douglas !

            People

            • Assignee:
              elgoiri Íñigo Goiri
              Reporter:
              elgoiri Íñigo Goiri
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development