Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13072

WindowsGetSpaceUsed constructor should be public

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Target Version/s:

      Description

      WindowsGetSpaceUsed constructor should be made public.
      Otherwise building using builder will not work.

      2016-04-29 12:49:37,455 [Thread-108] WARN  fs.GetSpaceUsed$Builder (GetSpaceUsed.java:build(127)) - Doesn't look like the class class org.apache.hadoop.fs.WindowsGetSpaceUsed have the needed constructor
      java.lang.NoSuchMethodException: org.apache.hadoop.fs.WindowsGetSpaceUsed.<init>(org.apache.hadoop.fs.GetSpaceUsed$Builder)
      	at java.lang.Class.getConstructor0(Unknown Source)
      	at java.lang.Class.getConstructor(Unknown Source)
      	at org.apache.hadoop.fs.GetSpaceUsed$Builder.build(GetSpaceUsed.java:118)
      	at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.BlockPoolSlice.<init>(BlockPoolSlice.java:165)
      	at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsVolumeImpl.addBlockPool(FsVolumeImpl.java:915)
      	at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsVolumeImpl.addBlockPool(FsVolumeImpl.java:907)
      	at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsVolumeList$2.run(FsVolumeList.java:413)
      
      1. HADOOP-13072-02.patch
        0.9 kB
        Vinayakumar B
      2. HADOOP-13072-01.patch
        0.9 kB
        Vinayakumar B

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9700 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9700/)
        HADOOP-13072. WindowsGetSpaceUsed constructor should be public (cmccabe: rev 2beedead72ee9efb69218aaf587de585158d6a1c)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/WindowsGetSpaceUsed.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9700 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9700/ ) HADOOP-13072 . WindowsGetSpaceUsed constructor should be public (cmccabe: rev 2beedead72ee9efb69218aaf587de585158d6a1c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/WindowsGetSpaceUsed.java
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1. Thanks, Vinayakumar B.

        Show
        cmccabe Colin P. McCabe added a comment - +1. Thanks, Vinayakumar B .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 40s trunk passed
        +1 compile 6m 34s trunk passed with JDK v1.8.0_92
        +1 compile 6m 44s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 58s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 34s trunk passed
        +1 javadoc 0m 53s trunk passed with JDK v1.8.0_92
        +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 42s the patch passed
        +1 compile 5m 51s the patch passed with JDK v1.8.0_92
        +1 javac 5m 51s the patch passed
        +1 compile 6m 43s the patch passed with JDK v1.7.0_95
        +1 javac 6m 43s the patch passed
        +1 checkstyle 0m 21s the patch passed
        +1 mvnsite 0m 56s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 50s the patch passed
        +1 javadoc 0m 54s the patch passed with JDK v1.8.0_92
        +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95
        +1 unit 8m 7s hadoop-common in the patch passed with JDK v1.8.0_92.
        +1 unit 8m 9s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        61m 35s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801696/HADOOP-13072-02.patch
        JIRA Issue HADOOP-13072
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9d2d5309972a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 971af60
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9249/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9249/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 40s trunk passed +1 compile 6m 34s trunk passed with JDK v1.8.0_92 +1 compile 6m 44s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 53s trunk passed with JDK v1.8.0_92 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 42s the patch passed +1 compile 5m 51s the patch passed with JDK v1.8.0_92 +1 javac 5m 51s the patch passed +1 compile 6m 43s the patch passed with JDK v1.7.0_95 +1 javac 6m 43s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_92 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95 +1 unit 8m 7s hadoop-common in the patch passed with JDK v1.8.0_92. +1 unit 8m 9s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 61m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801696/HADOOP-13072-02.patch JIRA Issue HADOOP-13072 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9d2d5309972a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 971af60 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9249/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9249/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Updated patch to trim to 80 chars.

        Show
        vinayrpet Vinayakumar B added a comment - Updated patch to trim to 80 chars.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Thanks, Vinayakumar B and Steve Loughran.

        +1 once the line is trimmed to 80 characters and jenkins has run.

        Show
        cmccabe Colin P. McCabe added a comment - Thanks, Vinayakumar B and Steve Loughran . +1 once the line is trimmed to 80 characters and jenkins has run.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        make sense, though you'll need to chop down the line to keep checkstyle happy

        Show
        stevel@apache.org Steve Loughran added a comment - make sense, though you'll need to chop down the line to keep checkstyle happy
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 47s trunk passed
        +1 compile 7m 16s trunk passed with JDK v1.8.0_92
        +1 compile 7m 39s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 36s trunk passed
        +1 javadoc 0m 53s trunk passed with JDK v1.8.0_92
        +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 43s the patch passed
        +1 compile 6m 18s the patch passed with JDK v1.8.0_92
        +1 javac 6m 18s the patch passed
        +1 compile 6m 55s the patch passed with JDK v1.7.0_95
        +1 javac 6m 55s the patch passed
        -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 49s the patch passed
        +1 javadoc 0m 54s the patch passed with JDK v1.8.0_92
        +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95
        -1 unit 19m 49s hadoop-common in the patch failed with JDK v1.8.0_92.
        +1 unit 7m 50s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        76m 30s



        Reason Tests
        JDK v1.8.0_92 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801408/HADOOP-13072-01.patch
        JIRA Issue HADOOP-13072
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9a01ddf82d8a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4a85085
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9224/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9224/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9224/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9224/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9224/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 47s trunk passed +1 compile 7m 16s trunk passed with JDK v1.8.0_92 +1 compile 7m 39s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 36s trunk passed +1 javadoc 0m 53s trunk passed with JDK v1.8.0_92 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 43s the patch passed +1 compile 6m 18s the patch passed with JDK v1.8.0_92 +1 javac 6m 18s the patch passed +1 compile 6m 55s the patch passed with JDK v1.7.0_95 +1 javac 6m 55s the patch passed -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_92 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95 -1 unit 19m 49s hadoop-common in the patch failed with JDK v1.8.0_92. +1 unit 7m 50s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 76m 30s Reason Tests JDK v1.8.0_92 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801408/HADOOP-13072-01.patch JIRA Issue HADOOP-13072 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9a01ddf82d8a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4a85085 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9224/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9224/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9224/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9224/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9224/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            vinayrpet Vinayakumar B
            Reporter:
            vinayrpet Vinayakumar B
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development