Details
Major
Description
None of our bundled javascript dependencies are mentioned in LICENSE.txt. Let's fix that.
Issue Links
- is depended upon by
-
HADOOP-12893
Verify LICENSE.txt and NOTICE.txt
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
I found some "js.gz" files in yarn-common that I missed in the first iteration, and found we have a copy of the d3 license checked in so used a pointer. Also caught some CSS files.
 +1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 11s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | whitespace | 0m 0s | Patch has no whitespace issues. |
| +1 | asflicense | 0m 25s | Patch does not generate ASF License warnings. |
| 0m 48s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:fbe3e86 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12799863/hadoop-13043.002.patch |
| JIRA Issue | |
| Optional Tests | asflicense |
| uname | Linux 9a23a93c8995 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 63ac2db |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/9133/console |
| Powered by | Apache Yetus 0.2.0 http://yetus.apache.org |
This message was automatically generated.
+1
Pushed to all the branches, thanks Steve. I made appropriate edits based on the contents of each branch.
FAILURE: Integrated in Hadoop-trunk-Commit #9649 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9649/)
HADOOP-13043. Add LICENSE.txt entries for bundled javascript (wang: rev 08b7efa95202b6d6ada143cab9369fac4ebb4c49)
- LICENSE.txt
Andrew Wang, this never made it to branch-2.7 or branch-2.7.3, even though it is in branch-2.6.
The merge conflicts seem a little involved, can you please help address them for the 2.7.3 release? Tx.
Seems like I forgot to "git push" just branch-2.7 when I committed this. Sorry.
On looking further, it looks like Akira's later backport of HADOOP-12893 to branch-2.7 fixed this up. It looks like this was also carried forward to branch-2.7.3.
Should I make a dummy commit so grepping "git log" works?
Andrew Wang For what it is worth, I ran into this "missing commit message" while grepping "git log" for 2.6.5. It was fairly easy to figure out what was going on based on your above comment. That being said, it was the only commit that showed up in branch-2.6 and not in branch-2.7 for the time range I compared (since 1/26/2016).
Closing the JIRA as part of 2.7.3 release.
Patch attached. I did find . -name "*.js" to find all the bundled JS files. Went through all of them and added their licenses to LICENSE.txt.
The only odd ones out was json-bignum.js which is in the public domain. I take it that means it doesn't have any license requirements.
Some entries might need to be deleted for branches going backwards, I only looked at it for trunk.