Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13018

Make Kdiag check whether hadoop.token.files points to existent and valid files

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Steve proposed that KDiag should fail fast to help debug the case that hadoop.token.files points to a file not found. This JIRA is to affect that.

      1. HADOOP-13018.01.patch
        3 kB
        Ravi Prakash
      2. HADOOP-13018.02.patch
        6 kB
        Ravi Prakash
      3. HADOOP-13018.03.patch
        5 kB
        Ravi Prakash
      4. HADOOP-13018.04.patch
        5 kB
        Ravi Prakash

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          this should target whichever hadoop version added hadoop.token.files

          Show
          stevel@apache.org Steve Loughran added a comment - this should target whichever hadoop version added hadoop.token.files
          Hide
          raviprak Ravi Prakash added a comment -

          This patch improves Kdiag so that it checks the existence and validity of hadoop.token.files

          Show
          raviprak Ravi Prakash added a comment - This patch improves Kdiag so that it checks the existence and validity of hadoop.token.files
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 14s trunk passed
          +1 compile 5m 41s trunk passed with JDK v1.8.0_77
          +1 compile 6m 16s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 29s trunk passed
          +1 javadoc 0m 51s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 2s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 38s the patch passed
          +1 compile 5m 57s the patch passed with JDK v1.8.0_77
          +1 javac 5m 57s the patch passed
          +1 compile 6m 14s the patch passed with JDK v1.7.0_95
          +1 javac 6m 14s the patch passed
          -1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 6 new + 80 unchanged - 0 fixed = 86 total (was 80)
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 48s the patch passed
          +1 javadoc 0m 56s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95
          -1 unit 7m 32s hadoop-common in the patch failed with JDK v1.8.0_77.
          +1 unit 7m 50s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          58m 4s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800141/HADOOP-13018.01.patch
          JIRA Issue HADOOP-13018
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9f59b571bf40 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7149cdb
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9148/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9148/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9148/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9148/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9148/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 14s trunk passed +1 compile 5m 41s trunk passed with JDK v1.8.0_77 +1 compile 6m 16s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 29s trunk passed +1 javadoc 0m 51s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 38s the patch passed +1 compile 5m 57s the patch passed with JDK v1.8.0_77 +1 javac 5m 57s the patch passed +1 compile 6m 14s the patch passed with JDK v1.7.0_95 +1 javac 6m 14s the patch passed -1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 6 new + 80 unchanged - 0 fixed = 86 total (was 80) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95 -1 unit 7m 32s hadoop-common in the patch failed with JDK v1.8.0_77. +1 unit 7m 50s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 58m 4s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800141/HADOOP-13018.01.patch JIRA Issue HADOOP-13018 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9f59b571bf40 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7149cdb Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9148/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9148/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9148/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9148/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9148/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -
          1. you can use verifyFileIsValid is to validate the existence/file-ness of the token file; it will return true if the code should carry on on with the validation
          2. if there is problems with the file, should the validation just log or exit? The verify() method makes that decision for conditions; there isn't an equivalent for exception catch & rethrow ... this might be time. to add that.

          I know that the UGI stuff should now fail meaningfully if there are problems with the token file ... if we are confident that this holds then maybe your policy: log-but-continue is the right one.

          Testing: how about setting things up with an invalid path to the token file and see how kdiag reacts?

          Show
          stevel@apache.org Steve Loughran added a comment - you can use verifyFileIsValid is to validate the existence/file-ness of the token file; it will return true if the code should carry on on with the validation if there is problems with the file, should the validation just log or exit? The verify() method makes that decision for conditions; there isn't an equivalent for exception catch & rethrow ... this might be time. to add that. I know that the UGI stuff should now fail meaningfully if there are problems with the token file ... if we are confident that this holds then maybe your policy: log-but-continue is the right one. Testing: how about setting things up with an invalid path to the token file and see how kdiag reacts?
          Hide
          raviprak Ravi Prakash added a comment -

          Thanks for the review Steve! Here's another patch. Is this what you had in mind?

          Show
          raviprak Ravi Prakash added a comment - Thanks for the review Steve! Here's another patch. Is this what you had in mind?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 24s trunk passed
          +1 compile 5m 43s trunk passed with JDK v1.8.0_77
          +1 compile 6m 31s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 31s trunk passed
          +1 javadoc 0m 52s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 2s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 40s the patch passed
          +1 compile 5m 43s the patch passed with JDK v1.8.0_77
          +1 javac 5m 43s the patch passed
          +1 compile 6m 33s the patch passed with JDK v1.7.0_95
          +1 javac 6m 33s the patch passed
          -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 9 new + 80 unchanged - 0 fixed = 89 total (was 80)
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 46s the patch passed
          +1 javadoc 0m 52s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 3s the patch passed with JDK v1.7.0_95
          -1 unit 16m 52s hadoop-common in the patch failed with JDK v1.8.0_77.
          +1 unit 8m 27s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          68m 32s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.security.TestKDiagNoKDC
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800403/HADOOP-13018.02.patch
          JIRA Issue HADOOP-13018
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux de849f93698d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6fcde2e
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9163/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9163/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9163/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9163/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9163/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 24s trunk passed +1 compile 5m 43s trunk passed with JDK v1.8.0_77 +1 compile 6m 31s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 31s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 40s the patch passed +1 compile 5m 43s the patch passed with JDK v1.8.0_77 +1 javac 5m 43s the patch passed +1 compile 6m 33s the patch passed with JDK v1.7.0_95 +1 javac 6m 33s the patch passed -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 9 new + 80 unchanged - 0 fixed = 89 total (was 80) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 3s the patch passed with JDK v1.7.0_95 -1 unit 16m 52s hadoop-common in the patch failed with JDK v1.8.0_77. +1 unit 8m 27s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 68m 32s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.security.TestKDiagNoKDC JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800403/HADOOP-13018.02.patch JIRA Issue HADOOP-13018 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux de849f93698d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6fcde2e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9163/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9163/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9163/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9163/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9163/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Looks great!

          One question: why the reflection? There's nothing that can be done with class casting?

          Show
          stevel@apache.org Steve Loughran added a comment - Looks great! One question: why the reflection? There's nothing that can be done with class casting?
          Hide
          raviprak Ravi Prakash added a comment -

          Hi Steve! I felt verify shouldn't be Method specific. I'm calling Credentials.readTokenStorageFile and checking it doesn't throw any exceptions. Perhaps in the future, we'd want some other Method? Did you have something else in mind?

          Show
          raviprak Ravi Prakash added a comment - Hi Steve! I felt verify shouldn't be Method specific. I'm calling Credentials.readTokenStorageFile and checking it doesn't throw any exceptions. Perhaps in the future, we'd want some other Method? Did you have something else in mind?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I'm just trying to understand why you have to go through reflection, and not call Credentials itself?

          Admittedly I just don't understand these bits of the hadoop auth codebase properly...

          Show
          stevel@apache.org Steve Loughran added a comment - I'm just trying to understand why you have to go through reflection, and not call Credentials itself? Admittedly I just don't understand these bits of the hadoop auth codebase properly...
          Hide
          raviprak Ravi Prakash added a comment -

          Do you mean this instead?

               if (tokenFileLocation != null) {
                for (String tokenFileName:
                  StringUtils.getTrimmedStrings(tokenFileLocation)) {
                  if (tokenFileName.length() > 0) {
                    File tokenFile = new File(tokenFileName);
                    if (verifyFileIsValid(tokenFile, CAT_TOKEN, "token")) {
                      if(verify(tokenFile, conf, CAT_TOKEN, "token")) {
                        println("Successfully read credentials from " + tokenFile);
                      } else {
                        println("Failed to read credentials from " + tokenFile);
                      }
                    } else {
                      println("tokenFile("+tokenFileName+") does not exist");
                    }
                  }
                }
              }
            }
            
            private boolean verify(File tokenFile, Configuration conf, String category, String message) throws KerberosDiagsFailure {
              try {
                Credentials.readTokenStorageFile(tokenFile, conf);
              } catch(Exception e) {
                if (!nofail) {
                  fail(category, message);
                } else {
                  error(category, message);
                }
                return false;
              }
              return true;
            }
          

          I was trying to avoid verify be specific to the method call it is trying to verify

          Show
          raviprak Ravi Prakash added a comment - Do you mean this instead? if (tokenFileLocation != null ) { for ( String tokenFileName: StringUtils.getTrimmedStrings(tokenFileLocation)) { if (tokenFileName.length() > 0) { File tokenFile = new File(tokenFileName); if (verifyFileIsValid(tokenFile, CAT_TOKEN, "token" )) { if (verify(tokenFile, conf, CAT_TOKEN, "token" )) { println( "Successfully read credentials from " + tokenFile); } else { println( "Failed to read credentials from " + tokenFile); } } else { println( "tokenFile(" +tokenFileName+ ") does not exist" ); } } } } } private boolean verify(File tokenFile, Configuration conf, String category, String message) throws KerberosDiagsFailure { try { Credentials.readTokenStorageFile(tokenFile, conf); } catch (Exception e) { if (!nofail) { fail(category, message); } else { error(category, message); } return false ; } return true ; } I was trying to avoid verify be specific to the method call it is trying to verify
          Hide
          stevel@apache.org Steve Loughran added a comment -

          lets do the specific one, as it catches anything related to compilation and signature changes. Reflection is something to preserve for emergencies, as not only is it hard to work with, it's hard to debug problems

          Show
          stevel@apache.org Steve Loughran added a comment - lets do the specific one, as it catches anything related to compilation and signature changes. Reflection is something to preserve for emergencies, as not only is it hard to work with, it's hard to debug problems
          Hide
          raviprak Ravi Prakash added a comment -

          Ok Steve. Here's #3.

          Show
          raviprak Ravi Prakash added a comment - Ok Steve. Here's #3.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 4s trunk passed
          +1 compile 11m 9s trunk passed with JDK v1.8.0_92
          +1 compile 8m 58s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 50s trunk passed
          +1 mvnsite 1m 21s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 58s trunk passed
          +1 javadoc 1m 20s trunk passed with JDK v1.8.0_92
          +1 javadoc 1m 22s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 56s the patch passed
          +1 compile 12m 53s the patch passed with JDK v1.8.0_92
          +1 javac 12m 53s the patch passed
          +1 compile 9m 54s the patch passed with JDK v1.7.0_95
          +1 javac 9m 54s the patch passed
          -1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 7 new + 80 unchanged - 0 fixed = 87 total (was 80)
          +1 mvnsite 1m 16s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 17s the patch passed
          +1 javadoc 1m 16s the patch passed with JDK v1.8.0_92
          +1 javadoc 1m 23s the patch passed with JDK v1.7.0_95
          -1 unit 12m 50s hadoop-common in the patch failed with JDK v1.8.0_92.
          +1 unit 12m 0s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          93m 58s



          Reason Tests
          JDK v1.8.0_92 Failed junit tests hadoop.security.TestKDiagNoKDC
            hadoop.ipc.TestRPCWaitForProxy



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802006/HADOOP-13018.03.patch
          JIRA Issue HADOOP-13018
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 52ea76702e48 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c6b4839
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9263/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9263/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9263/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9263/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9263/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 4s trunk passed +1 compile 11m 9s trunk passed with JDK v1.8.0_92 +1 compile 8m 58s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 50s trunk passed +1 mvnsite 1m 21s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 58s trunk passed +1 javadoc 1m 20s trunk passed with JDK v1.8.0_92 +1 javadoc 1m 22s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 56s the patch passed +1 compile 12m 53s the patch passed with JDK v1.8.0_92 +1 javac 12m 53s the patch passed +1 compile 9m 54s the patch passed with JDK v1.7.0_95 +1 javac 9m 54s the patch passed -1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 7 new + 80 unchanged - 0 fixed = 87 total (was 80) +1 mvnsite 1m 16s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 17s the patch passed +1 javadoc 1m 16s the patch passed with JDK v1.8.0_92 +1 javadoc 1m 23s the patch passed with JDK v1.7.0_95 -1 unit 12m 50s hadoop-common in the patch failed with JDK v1.8.0_92. +1 unit 12m 0s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 93m 58s Reason Tests JDK v1.8.0_92 Failed junit tests hadoop.security.TestKDiagNoKDC   hadoop.ipc.TestRPCWaitForProxy Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802006/HADOOP-13018.03.patch JIRA Issue HADOOP-13018 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 52ea76702e48 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c6b4839 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9263/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9263/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9263/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9263/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9263/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -
          • checkstyle is fussing about indentation and a javadoc lacking a "."; easy and nice to fix
          • test failure is, presumably, related

          The test details are not appearing in the logs as its only failing on java 8, and the test results are for java 7 The unit test logs are more informative

          Tests in error: 
            TestKDiagNoKDC.testTokenFile:128->kdiagFailure:84 ? KerberosDiagsFailure JVM: ...
            TestKDiagNoKDC.testKDiagStandalone:107->kdiagFailure:84 ? KerberosDiagsFailure
            TestRPCWaitForProxy.testInterruptedWaitForProxy:74->Object.wait:-2 ?  test tim...
          

          ...

          Looks like one is JCE settings, the other a failure of the new code.

          testTokenFile(org.apache.hadoop.security.TestKDiagNoKDC)  Time elapsed: 0.07 sec  <<< ERROR!
          org.apache.hadoop.security.KDiag$KerberosDiagsFailure: JVM: Java Cryptography Extensions are not installed on this JVM. Maximum supported key length 128 - minimum required 256
          	at org.apache.hadoop.security.KDiag.fail(KDiag.java:884)
          	at org.apache.hadoop.security.KDiag.verify(KDiag.java:911)
          	at org.apache.hadoop.security.KDiag.validateKeyLength(KDiag.java:419)
          	at org.apache.hadoop.security.KDiag.execute(KDiag.java:277)
          	at org.apache.hadoop.security.KDiag.run(KDiag.java:224)
          	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
          	at org.apache.hadoop.security.KDiag.exec(KDiag.java:993)
          	at org.apache.hadoop.security.TestKDiagNoKDC.kdiagFailure(TestKDiagNoKDC.java:84)
          	at org.apache.hadoop.security.TestKDiagNoKDC.testTokenFile(TestKDiagNoKDC.java:128)
          
          testKDiagStandalone(org.apache.hadoop.security.TestKDiagNoKDC)  Time elapsed: 0.059 sec  <<< ERROR!
          org.apache.hadoop.security.KDiag$KerberosDiagsFailure: TOKEN: token file does not exist: SomeNonExistentFile
          	at org.apache.hadoop.security.KDiag.fail(KDiag.java:884)
          	at org.apache.hadoop.security.KDiag.verify(KDiag.java:911)
          	at org.apache.hadoop.security.KDiag.verifyFileIsValid(KDiag.java:735)
          	at org.apache.hadoop.security.KDiag.validateHadoopTokenFiles(KDiag.java:496)
          	at org.apache.hadoop.security.KDiag.execute(KDiag.java:362)
          	at org.apache.hadoop.security.KDiag.run(KDiag.java:224)
          	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
          	at org.apache.hadoop.security.KDiag.exec(KDiag.java:993)
          	at org.apache.hadoop.security.TestKDiagNoKDC.kdiagFailure(TestKDiagNoKDC.java:84)
          	at org.apache.hadoop.security.TestKDiagNoKDC.testKDiagStandalone(TestKDiagNoKDC.java:107)
          

          You need to downgrade the key length in the cli command, the way the other tests do. Then lets see what happens to those tests

          Show
          stevel@apache.org Steve Loughran added a comment - checkstyle is fussing about indentation and a javadoc lacking a "."; easy and nice to fix test failure is, presumably, related The test details are not appearing in the logs as its only failing on java 8, and the test results are for java 7 The unit test logs are more informative Tests in error: TestKDiagNoKDC.testTokenFile:128->kdiagFailure:84 ? KerberosDiagsFailure JVM: ... TestKDiagNoKDC.testKDiagStandalone:107->kdiagFailure:84 ? KerberosDiagsFailure TestRPCWaitForProxy.testInterruptedWaitForProxy:74-> Object .wait:-2 ? test tim... ... Looks like one is JCE settings, the other a failure of the new code. testTokenFile(org.apache.hadoop.security.TestKDiagNoKDC) Time elapsed: 0.07 sec <<< ERROR! org.apache.hadoop.security.KDiag$KerberosDiagsFailure: JVM: Java Cryptography Extensions are not installed on this JVM. Maximum supported key length 128 - minimum required 256 at org.apache.hadoop.security.KDiag.fail(KDiag.java:884) at org.apache.hadoop.security.KDiag.verify(KDiag.java:911) at org.apache.hadoop.security.KDiag.validateKeyLength(KDiag.java:419) at org.apache.hadoop.security.KDiag.execute(KDiag.java:277) at org.apache.hadoop.security.KDiag.run(KDiag.java:224) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.security.KDiag.exec(KDiag.java:993) at org.apache.hadoop.security.TestKDiagNoKDC.kdiagFailure(TestKDiagNoKDC.java:84) at org.apache.hadoop.security.TestKDiagNoKDC.testTokenFile(TestKDiagNoKDC.java:128) testKDiagStandalone(org.apache.hadoop.security.TestKDiagNoKDC) Time elapsed: 0.059 sec <<< ERROR! org.apache.hadoop.security.KDiag$KerberosDiagsFailure: TOKEN: token file does not exist: SomeNonExistentFile at org.apache.hadoop.security.KDiag.fail(KDiag.java:884) at org.apache.hadoop.security.KDiag.verify(KDiag.java:911) at org.apache.hadoop.security.KDiag.verifyFileIsValid(KDiag.java:735) at org.apache.hadoop.security.KDiag.validateHadoopTokenFiles(KDiag.java:496) at org.apache.hadoop.security.KDiag.execute(KDiag.java:362) at org.apache.hadoop.security.KDiag.run(KDiag.java:224) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.security.KDiag.exec(KDiag.java:993) at org.apache.hadoop.security.TestKDiagNoKDC.kdiagFailure(TestKDiagNoKDC.java:84) at org.apache.hadoop.security.TestKDiagNoKDC.testKDiagStandalone(TestKDiagNoKDC.java:107) You need to downgrade the key length in the cli command, the way the other tests do. Then lets see what happens to those tests
          Hide
          raviprak Ravi Prakash added a comment -

          Thanks for the review Steve! Here's an updated patch.

          Checkstyle is becoming a bit grammar nazi . And I thought we used 2 spaces for indentation. But I'm not going to fight it.
          Thanks for the pointer about avoiding the JCE. I wrongly assumed there was no way around the test failure on the jenkins slaves. Thanks.

          Let's see if the Gods like this patch

          Show
          raviprak Ravi Prakash added a comment - Thanks for the review Steve! Here's an updated patch. Checkstyle is becoming a bit grammar nazi . And I thought we used 2 spaces for indentation. But I'm not going to fight it. Thanks for the pointer about avoiding the JCE. I wrongly assumed there was no way around the test failure on the jenkins slaves. Thanks. Let's see if the Gods like this patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 45s trunk passed
          +1 compile 6m 2s trunk passed with JDK v1.8.0_91
          +1 compile 6m 52s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 1m 1s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 35s trunk passed
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 8s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 6m 9s the patch passed with JDK v1.8.0_91
          +1 javac 6m 9s the patch passed
          +1 compile 6m 53s the patch passed with JDK v1.7.0_95
          +1 javac 6m 53s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 55s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95
          -1 unit 7m 11s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 7m 31s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          60m 27s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802265/HADOOP-13018.04.patch
          JIRA Issue HADOOP-13018
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 71a496226bbd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7bd418e
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9280/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9280/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9280/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9280/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 45s trunk passed +1 compile 6m 2s trunk passed with JDK v1.8.0_91 +1 compile 6m 52s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 35s trunk passed +1 javadoc 0m 55s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 8s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 6m 9s the patch passed with JDK v1.8.0_91 +1 javac 6m 9s the patch passed +1 compile 6m 53s the patch passed with JDK v1.7.0_95 +1 javac 6m 53s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 55s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95 -1 unit 7m 11s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 7m 31s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 60m 27s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802265/HADOOP-13018.04.patch JIRA Issue HADOOP-13018 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 71a496226bbd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7bd418e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9280/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9280/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9280/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9280/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -
          1. I agree with your sentiments on the checkstyle, but if you ever come across the scalastyle module for spark, you will appreciate it its light touch and the fact that it still allows you to do a local build which violates its standards about maximum line width
          2. code LGTM

          There's one thing left, adding the extra docs to hadoop-common-project/hadoop-common/src/site/markdown/SecureMode.md.

          Show
          stevel@apache.org Steve Loughran added a comment - I agree with your sentiments on the checkstyle, but if you ever come across the scalastyle module for spark, you will appreciate it its light touch and the fact that it still allows you to do a local build which violates its standards about maximum line width code LGTM There's one thing left, adding the extra docs to hadoop-common-project/hadoop-common/src/site/markdown/SecureMode.md .
          Hide
          raviprak Ravi Prakash added a comment -

          Hi Steve!

          I'm not sure what to add to the document. The various options have been enumerated and briefly described. However, I haven't added a new option. Its just another check, and I don't think the details of the report have been (or need to be) documented.

          Show
          raviprak Ravi Prakash added a comment - Hi Steve! I'm not sure what to add to the document. The various options have been enumerated and briefly described. However, I haven't added a new option. Its just another check, and I don't think the details of the report have been (or need to be) documented.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 2s trunk passed
          +1 compile 8m 22s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 35s trunk passed
          +1 javadoc 0m 47s trunk passed
          +1 mvninstall 0m 48s the patch passed
          +1 compile 8m 27s the patch passed
          +1 javac 8m 27s the patch passed
          +1 checkstyle 0m 26s the patch passed
          +1 mvnsite 1m 2s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 findbugs 1m 46s the patch passed
          +1 javadoc 0m 48s the patch passed
          -1 unit 8m 31s hadoop-common in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          44m 23s



          Reason Tests
          Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802265/HADOOP-13018.04.patch
          JIRA Issue HADOOP-13018
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5b585171b76a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a1890c3
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10114/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10114/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10114/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 2s trunk passed +1 compile 8m 22s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 35s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 8m 27s the patch passed +1 javac 8m 27s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 48s the patch passed -1 unit 8m 31s hadoop-common in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 44m 23s Reason Tests Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802265/HADOOP-13018.04.patch JIRA Issue HADOOP-13018 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5b585171b76a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a1890c3 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10114/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10114/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10114/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          LTGM
          +1

          Show
          stevel@apache.org Steve Loughran added a comment - LTGM +1
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Applied to branch-2; Apologies; I'd missed this patch completely. Feel free to ping me if you think I'm neglecting something

          Show
          stevel@apache.org Steve Loughran added a comment - Applied to branch-2; Apologies; I'd missed this patch completely. Feel free to ping me if you think I'm neglecting something
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10888 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10888/)
          HADOOP-13018. Make Kdiag check whether hadoop.token.files points to (stevel: rev abb9fa7fc69ec7b25f1c44e17c4c7dd17f5de16a)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/KDiag.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestKDiagNoKDC.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10888 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10888/ ) HADOOP-13018 . Make Kdiag check whether hadoop.token.files points to (stevel: rev abb9fa7fc69ec7b25f1c44e17c4c7dd17f5de16a) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/KDiag.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestKDiagNoKDC.java
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 59s trunk passed
          +1 compile 10m 57s trunk passed
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 1m 4s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 1m 39s trunk passed
          +1 javadoc 0m 51s trunk passed
          +1 mvninstall 0m 43s the patch passed
          +1 compile 10m 46s the patch passed
          +1 javac 10m 46s the patch passed
          +1 checkstyle 0m 34s the patch passed
          +1 mvnsite 1m 3s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 36s the patch passed
          +1 javadoc 0m 53s the patch passed
          +1 unit 9m 33s hadoop-common in the patch passed.
          +1 asflicense 0m 32s The patch does not generate ASF License warnings.
          51m 24s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13018
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802265/HADOOP-13018.04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a0f5dc39f47f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eb0a483
          Default Java 1.8.0_111
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11132/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11132/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 59s trunk passed +1 compile 10m 57s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 39s trunk passed +1 javadoc 0m 51s trunk passed +1 mvninstall 0m 43s the patch passed +1 compile 10m 46s the patch passed +1 javac 10m 46s the patch passed +1 checkstyle 0m 34s the patch passed +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 36s the patch passed +1 javadoc 0m 53s the patch passed +1 unit 9m 33s hadoop-common in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 51m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13018 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802265/HADOOP-13018.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a0f5dc39f47f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eb0a483 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11132/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11132/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              raviprak Ravi Prakash
              Reporter:
              raviprak Ravi Prakash
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development