Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12982

Document missing S3A and S3 properties

        Details

          Description

          • S3:
            • fs.s3.buffer.dir, fs.s3.maxRetries, fs.s3.sleepTimeSeconds, fs.s3.block.size not in the documentation
            • Note that fs.s3.buffer.dir, fs.s3.maxRetries, fs.s3.sleepTimeSeconds are also used by S3N.
          • S3A:
            • fs.s3a.server-side-encryption-algorithm and fs.s3a.block.size are missing in core-default.xml and the documentation.
          1. Text File
            HADOOP-12982.001.patch
            9 kB
            Wei-Chiu Chuang
          2. Text File
            HADOOP-12982.002.patch
            8 kB
            Wei-Chiu Chuang
          3. Text File
            HADOOP-12982.003.patch
            8 kB
            Wei-Chiu Chuang

            Issue Links

            is depended upon by

            Improvement - An improvement or enhancement to an existing feature or task. HADOOP-11694 Über-jira: S3a phase II: robustness, scale and performance

            • Major - Major loss of function.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. HADOOP-12671 Inconsistent s3a configuration values and incorrect comments

            • Major - Major loss of function.
            • Patch Available

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              v01: added missing S3/S3A properties into documentation and core-default.xml.
              Additionally, prettify the doc, make it more structural.

              Show
              jojochuang Wei-Chiu Chuang added a comment - v01: added missing S3/S3A properties into documentation and core-default.xml. Additionally, prettify the doc, make it more structural.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 15s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              0 mvndep 0m 15s Maven dependency ordering for branch
              +1 mvninstall 6m 39s trunk passed
              +1 compile 5m 49s trunk passed with JDK v1.8.0_74
              +1 compile 6m 48s trunk passed with JDK v1.7.0_95
              +1 mvnsite 1m 15s trunk passed
              +1 mvneclipse 0m 28s trunk passed
              +1 javadoc 1m 4s trunk passed with JDK v1.8.0_74
              +1 javadoc 1m 20s trunk passed with JDK v1.7.0_95
              0 mvndep 0m 15s Maven dependency ordering for patch
              +1 mvninstall 0m 56s the patch passed
              +1 compile 5m 48s the patch passed with JDK v1.8.0_74
              +1 javac 5m 48s the patch passed
              +1 compile 6m 40s the patch passed with JDK v1.7.0_95
              +1 javac 6m 40s the patch passed
              +1 mvnsite 1m 14s the patch passed
              +1 mvneclipse 0m 27s the patch passed
              -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
              +1 xml 0m 0s The patch has no ill-formed XML file.
              +1 javadoc 1m 5s the patch passed with JDK v1.8.0_74
              +1 javadoc 1m 17s the patch passed with JDK v1.7.0_95
              -1 unit 6m 36s hadoop-common in the patch failed with JDK v1.8.0_74.
              +1 unit 0m 13s hadoop-aws in the patch passed with JDK v1.8.0_74.
              -1 unit 6m 54s hadoop-common in the patch failed with JDK v1.7.0_95.
              +1 unit 0m 14s hadoop-aws in the patch passed with JDK v1.7.0_95.
              -1 asflicense 0m 24s Patch generated 3 ASF License warnings.
              56m 51s



              Reason Tests
              JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
              JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:fbe3e86
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796175/HADOOP-12982.001.patch
              JIRA Issue HADOOP-12982
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
              uname Linux 84b97002e59e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / e4fc609
              Default Java 1.7.0_95
              Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
              whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/artifact/patchprocess/whitespace-eol.txt
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
              unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
              JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/testReport/
              asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/artifact/patchprocess/patch-asflicense-problems.txt
              modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/console
              Powered by Apache Yetus 0.2.0 http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 39s trunk passed +1 compile 5m 49s trunk passed with JDK v1.8.0_74 +1 compile 6m 48s trunk passed with JDK v1.7.0_95 +1 mvnsite 1m 15s trunk passed +1 mvneclipse 0m 28s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 20s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 0m 56s the patch passed +1 compile 5m 48s the patch passed with JDK v1.8.0_74 +1 javac 5m 48s the patch passed +1 compile 6m 40s the patch passed with JDK v1.7.0_95 +1 javac 6m 40s the patch passed +1 mvnsite 1m 14s the patch passed +1 mvneclipse 0m 27s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 1m 5s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 17s the patch passed with JDK v1.7.0_95 -1 unit 6m 36s hadoop-common in the patch failed with JDK v1.8.0_74. +1 unit 0m 13s hadoop-aws in the patch passed with JDK v1.8.0_74. -1 unit 6m 54s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 0m 14s hadoop-aws in the patch passed with JDK v1.7.0_95. -1 asflicense 0m 24s Patch generated 3 ASF License warnings. 56m 51s Reason Tests JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796175/HADOOP-12982.001.patch JIRA Issue HADOOP-12982 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 84b97002e59e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e4fc609 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8976/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              stevel@apache.org Steve Loughran added a comment -

              good to see these things being documented

              1. revert the replacements of ## with ---, # with = . # and ## are valid. If you want to change depth, add or remove # count.
              2. maybe mention that if you have multipartition size == block size, you may get better IO performance
              3. please use lower case, s3a:// and s3n:// for referring to filesystems
              4. s3:// is going/gone out of trunk. Don't mention it at all
              <description>Specify a server-side encryption algorithm for S3A.
  The default is NULL, and the only other currently allowable value is AES256.
</description>

              Not "NULl"; that encourages people to set the value to NULL. Better to say "unset by default, the only allowed value is AES256"

              Show
              stevel@apache.org Steve Loughran added a comment - good to see these things being documented revert the replacements of ## with ---, # with = . # and ## are valid. If you want to change depth, add or remove # count. maybe mention that if you have multipartition size == block size, you may get better IO performance please use lower case, s3a:// and s3n:// for referring to filesystems s3:// is going/gone out of trunk. Don't mention it at all <description>Specify a server-side encryption algorithm for S3A. The default is NULL, and the only other currently allowable value is AES256. </description> Not "NULl"; that encourages people to set the value to NULL. Better to say "unset by default, the only allowed value is AES256"
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              Thanks Steve Loughran,
              could you give more details about s3 file system going out of trunk?
              I'm not seeing this mentioned elsewhere, at least not in Roadmap: https://wiki.apache.org/hadoop/Roadmap or https://wiki.apache.org/hadoop/AmazonS3

              Show
              jojochuang Wei-Chiu Chuang added a comment - Thanks Steve Loughran , could you give more details about s3 file system going out of trunk? I'm not seeing this mentioned elsewhere, at least not in Roadmap: https://wiki.apache.org/hadoop/Roadmap or https://wiki.apache.org/hadoop/AmazonS3
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              Patch 002. This revision added notice that s3: is being phased out.

              Show
              jojochuang Wei-Chiu Chuang added a comment - Patch 002. This revision added notice that s3: is being phased out.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 9s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              0 mvndep 0m 47s Maven dependency ordering for branch
              +1 mvninstall 7m 15s trunk passed
              +1 compile 6m 54s trunk passed with JDK v1.8.0_77
              +1 compile 7m 30s trunk passed with JDK v1.7.0_95
              +1 mvnsite 1m 25s trunk passed
              +1 mvneclipse 0m 29s trunk passed
              +1 javadoc 1m 9s trunk passed with JDK v1.8.0_77
              +1 javadoc 1m 27s trunk passed with JDK v1.7.0_95
              0 mvndep 0m 15s Maven dependency ordering for patch
              +1 mvninstall 1m 0s the patch passed
              +1 compile 6m 39s the patch passed with JDK v1.8.0_77
              +1 javac 6m 39s the patch passed
              +1 compile 7m 8s the patch passed with JDK v1.7.0_95
              +1 javac 7m 8s the patch passed
              +1 mvnsite 1m 19s the patch passed
              +1 mvneclipse 0m 28s the patch passed
              +1 whitespace 0m 0s Patch has no whitespace issues.
              +1 xml 0m 0s The patch has no ill-formed XML file.
              +1 javadoc 1m 6s the patch passed with JDK v1.8.0_77
              +1 javadoc 1m 20s the patch passed with JDK v1.7.0_95
              +1 unit 8m 34s hadoop-common in the patch passed with JDK v1.8.0_77.
              +1 unit 0m 13s hadoop-aws in the patch passed with JDK v1.8.0_77.
              +1 unit 8m 37s hadoop-common in the patch passed with JDK v1.7.0_95.
              +1 unit 0m 14s hadoop-aws in the patch passed with JDK v1.7.0_95.
              +1 asflicense 0m 25s Patch does not generate ASF License warnings.
              65m 20s



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:fbe3e86
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797553/HADOOP-12982.002.patch
              JIRA Issue HADOOP-12982
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
              uname Linux 8f207d862b1b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / a62637a
              Default Java 1.7.0_95
              Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
              JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9039/testReport/
              modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9039/console
              Powered by Apache Yetus 0.2.0 http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 47s Maven dependency ordering for branch +1 mvninstall 7m 15s trunk passed +1 compile 6m 54s trunk passed with JDK v1.8.0_77 +1 compile 7m 30s trunk passed with JDK v1.7.0_95 +1 mvnsite 1m 25s trunk passed +1 mvneclipse 0m 29s trunk passed +1 javadoc 1m 9s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 27s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 0s the patch passed +1 compile 6m 39s the patch passed with JDK v1.8.0_77 +1 javac 6m 39s the patch passed +1 compile 7m 8s the patch passed with JDK v1.7.0_95 +1 javac 7m 8s the patch passed +1 mvnsite 1m 19s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 1m 6s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 20s the patch passed with JDK v1.7.0_95 +1 unit 8m 34s hadoop-common in the patch passed with JDK v1.8.0_77. +1 unit 0m 13s hadoop-aws in the patch passed with JDK v1.8.0_77. +1 unit 8m 37s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 0m 14s hadoop-aws in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 65m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797553/HADOOP-12982.002.patch JIRA Issue HADOOP-12982 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 8f207d862b1b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a62637a Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9039/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9039/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              eddyxu Lei (Eddy) Xu added a comment -

              Wei-Chiu Chuang Thanks a lot for addressing the docs.

              <name>fs.s3.buffer.dir</name>
<value>${hadoop.tmp.dir}/s3</value>
<description>Determines where on the local filesystem the S3 filesystem....

              Would it be better to say "local filesystem the s3: and s3n: filesystems..."?

              +1 pending to address the above comments.

              Thanks.

              Show
              eddyxu Lei (Eddy) Xu added a comment - Wei-Chiu Chuang Thanks a lot for addressing the docs. <name>fs.s3.buffer.dir</name> <value>${hadoop.tmp.dir}/s3</value> <description>Determines where on the local filesystem the S3 filesystem.... Would it be better to say "local filesystem the s3: and s3n: filesystems..."? +1 pending to address the above comments. Thanks.
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              v03: Thanks Lei (Eddy) Xu. Attached a new patch to address that issue.

              Show
              jojochuang Wei-Chiu Chuang added a comment - v03: Thanks Lei (Eddy) Xu . Attached a new patch to address that issue.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 7s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              0 mvndep 0m 14s Maven dependency ordering for branch
              +1 mvninstall 6m 33s trunk passed
              +1 compile 5m 52s trunk passed with JDK v1.8.0_77
              +1 compile 6m 40s trunk passed with JDK v1.7.0_95
              +1 mvnsite 1m 14s trunk passed
              +1 mvneclipse 0m 27s trunk passed
              +1 javadoc 1m 5s trunk passed with JDK v1.8.0_77
              +1 javadoc 1m 18s trunk passed with JDK v1.7.0_95
              0 mvndep 0m 15s Maven dependency ordering for patch
              +1 mvninstall 0m 57s the patch passed
              +1 compile 5m 41s the patch passed with JDK v1.8.0_77
              +1 javac 5m 41s the patch passed
              +1 compile 6m 50s the patch passed with JDK v1.7.0_95
              +1 javac 6m 50s the patch passed
              +1 mvnsite 1m 17s the patch passed
              +1 mvneclipse 0m 26s the patch passed
              +1 whitespace 0m 0s Patch has no whitespace issues.
              +1 xml 0m 0s The patch has no ill-formed XML file.
              +1 javadoc 1m 12s the patch passed with JDK v1.8.0_77
              +1 javadoc 1m 21s the patch passed with JDK v1.7.0_95
              -1 unit 7m 58s hadoop-common in the patch failed with JDK v1.8.0_77.
              +1 unit 0m 12s hadoop-aws in the patch passed with JDK v1.8.0_77.
              -1 unit 7m 48s hadoop-common in the patch failed with JDK v1.7.0_95.
              +1 unit 0m 14s hadoop-aws in the patch passed with JDK v1.7.0_95.
              +1 asflicense 0m 21s Patch does not generate ASF License warnings.
              58m 59s



              Reason Tests
              JDK v1.8.0_77 Failed junit tests hadoop.net.TestDNS
              JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:fbe3e86
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797714/HADOOP-12982.003.patch
              JIRA Issue HADOOP-12982
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
              uname Linux 2102f335cf19 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / 6791221
              Default Java 1.7.0_95
              Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9045/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9045/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
              unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9045/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9045/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
              JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9045/testReport/
              modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9045/console
              Powered by Apache Yetus 0.2.0 http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 33s trunk passed +1 compile 5m 52s trunk passed with JDK v1.8.0_77 +1 compile 6m 40s trunk passed with JDK v1.7.0_95 +1 mvnsite 1m 14s trunk passed +1 mvneclipse 0m 27s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 18s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 0m 57s the patch passed +1 compile 5m 41s the patch passed with JDK v1.8.0_77 +1 javac 5m 41s the patch passed +1 compile 6m 50s the patch passed with JDK v1.7.0_95 +1 javac 6m 50s the patch passed +1 mvnsite 1m 17s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 1m 12s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 21s the patch passed with JDK v1.7.0_95 -1 unit 7m 58s hadoop-common in the patch failed with JDK v1.8.0_77. +1 unit 0m 12s hadoop-aws in the patch passed with JDK v1.8.0_77. -1 unit 7m 48s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 0m 14s hadoop-aws in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 58m 59s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.net.TestDNS JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797714/HADOOP-12982.003.patch JIRA Issue HADOOP-12982 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 2102f335cf19 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6791221 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9045/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9045/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9045/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9045/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9045/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9045/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              stevel@apache.org Steve Loughran added a comment -

              looks like HADOOP-12671 is similar here

              Show
              stevel@apache.org Steve Loughran added a comment - looks like HADOOP-12671 is similar here
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              Both are similar, but documents different properties. I posted a quick review there.

              Show
              jojochuang Wei-Chiu Chuang added a comment - Both are similar, but documents different properties. I posted a quick review there.
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              Hi Lei (Eddy) Xu and Steve Loughran would you mind to review this patch again if you got a chance? Thank you!

              Show
              jojochuang Wei-Chiu Chuang added a comment - Hi Lei (Eddy) Xu and Steve Loughran would you mind to review this patch again if you got a chance? Thank you!
              Hide
              Permalink
              stevel@apache.org Steve Loughran added a comment -

              the patch doesn't apply any more; could you bring it up to sync?

              Show
              stevel@apache.org Steve Loughran added a comment - the patch doesn't apply any more; could you bring it up to sync?
              Hide
              Permalink
              stevel@apache.org Steve Loughran added a comment -

              cancel that last comment. it applies to trunk but not branch-2

              Show
              stevel@apache.org Steve Loughran added a comment - cancel that last comment. it applies to trunk but not branch-2
              Hide
              Permalink
              stevel@apache.org Steve Loughran added a comment -

              +1: committed to trunk as is, merged in to branch-2 with a bit of editing

              Show
              stevel@apache.org Steve Loughran added a comment - +1: committed to trunk as is, merged in to branch-2 with a bit of editing
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              Thank you Steve Loughran! Didn't realize it needed to rebase. Also thanks to Eddy for reviewing it.

              Show
              jojochuang Wei-Chiu Chuang added a comment - Thank you Steve Loughran ! Didn't realize it needed to rebase. Also thanks to Eddy for reviewing it.
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-trunk-Commit #9741 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9741/)
              HADOOP-12982 Document missing S3A and S3 properties. (Wei-Chiu Chuang (stevel: rev 025219b12fca8b106a30e5504d1ae08c569fb30d)

              • hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md
              • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9741 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9741/ ) HADOOP-12982 Document missing S3A and S3 properties. (Wei-Chiu Chuang (stevel: rev 025219b12fca8b106a30e5504d1ae08c569fb30d) hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md hadoop-common-project/hadoop-common/src/main/resources/core-default.xml

                People

                • Assignee:
                  jojochuang Wei-Chiu Chuang
                  Reporter:
                  jojochuang Wei-Chiu Chuang
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development