Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12969

Mark IPC.Client and IPC.Server as @Public, @Evolving

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None

      Description

      Per the discussion in HADOOP-12909, this is to propose marking IPC.Client and IPC.Server as @Public, @Evolving as a result of HADOOP-12909

      1. HADOOP-12969.000..patch
        3 kB
        Xiaobing Zhou
      2. HADOOP-12969.001.patch
        3 kB
        Xiaobing Zhou
      3. HADOOP-12969.002.patch
        3 kB
        Xiaobing Zhou
      4. HADOOP-12969.003.patch
        3 kB
        Xiaobing Zhou

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9609 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9609/)
          HADOOP-12969 Mark IPC.Client and IPC.Server as @Public, @Evolving (stevel: rev 40211d1f0a3e4546eab076e10be8937853490e5e)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9609 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9609/ ) HADOOP-12969 Mark IPC.Client and IPC.Server as @Public, @Evolving (stevel: rev 40211d1f0a3e4546eab076e10be8937853490e5e) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1, committed. Thanks!

          Show
          stevel@apache.org Steve Loughran added a comment - +1, committed. Thanks!
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          There is no need to add unit tests since it's a change of mark. Could anyone help to commit it? Thanks.

          Show
          xiaobingo Xiaobing Zhou added a comment - There is no need to add unit tests since it's a change of mark. Could anyone help to commit it? Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 44s trunk passed
          +1 compile 5m 58s trunk passed with JDK v1.8.0_77
          +1 compile 6m 52s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 55s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 33s trunk passed
          +1 javadoc 0m 54s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 42s the patch passed
          +1 compile 5m 51s the patch passed with JDK v1.8.0_77
          +1 javac 5m 51s the patch passed
          +1 compile 6m 55s the patch passed with JDK v1.7.0_95
          +1 javac 6m 55s the patch passed
          +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: patch generated 0 new + 282 unchanged - 2 fixed = 282 total (was 284)
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 51s the patch passed
          +1 javadoc 0m 56s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95
          +1 unit 7m 20s hadoop-common in the patch passed with JDK v1.8.0_77.
          +1 unit 7m 37s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          60m 25s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798306/HADOOP-12969.003.patch
          JIRA Issue HADOOP-12969
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 43f6f43d776c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 437e9d6
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9067/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9067/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 44s trunk passed +1 compile 5m 58s trunk passed with JDK v1.8.0_77 +1 compile 6m 52s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 54s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 42s the patch passed +1 compile 5m 51s the patch passed with JDK v1.8.0_77 +1 javac 5m 51s the patch passed +1 compile 6m 55s the patch passed with JDK v1.7.0_95 +1 javac 6m 55s the patch passed +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: patch generated 0 new + 282 unchanged - 2 fixed = 282 total (was 284) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 51s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95 +1 unit 7m 20s hadoop-common in the patch passed with JDK v1.8.0_77. +1 unit 7m 37s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 60m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798306/HADOOP-12969.003.patch JIRA Issue HADOOP-12969 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 43f6f43d776c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 437e9d6 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9067/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9067/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Akira Ajisaka thanks, v003 is rebased on trunk. Thanks everyone for review.

          Show
          xiaobingo Xiaobing Zhou added a comment - Akira Ajisaka thanks, v003 is rebased on trunk. Thanks everyone for review.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I agree with Steve. Hi Xiaobing Zhou, would you rebase the patch?

          Show
          ajisakaa Akira Ajisaka added a comment - I agree with Steve. Hi Xiaobing Zhou , would you rebase the patch?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HADOOP-12969 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797150/HADOOP-12969.002.patch
          JIRA Issue HADOOP-12969
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9062/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-12969 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797150/HADOOP-12969.002.patch JIRA Issue HADOOP-12969 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9062/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          HADOOP-8813 didn't mention the logic why they must be @InterfaceAudience.LimitedPrivate. It is good to make them public as Steve Loughran explained.

          Show
          xiaobingo Xiaobing Zhou added a comment - HADOOP-8813 didn't mention the logic why they must be @InterfaceAudience.LimitedPrivate. It is good to make them public as Steve Loughran explained.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Hadoop IPC is invaluable on YARN apps; you may as well assume that if something is marked as for MapReduce, it means [MapReduce, Tez, +anything which runs on a YARN cluster that hasn't implemented their own IPC and don't want to worry about kerberos auth.

          Show
          stevel@apache.org Steve Loughran added a comment - Hadoop IPC is invaluable on YARN apps; you may as well assume that if something is marked as for MapReduce, it means [MapReduce, Tez, +anything which runs on a YARN cluster that hasn't implemented their own IPC and don't want to worry about kerberos auth.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment - - edited

          Indeed, Client and Server are currently annotated as @InterfaceAudience.LimitedPrivate and @InterfaceStability.Evolving; see HADOOP-8813. I think we don't need to change them to public.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - - edited Indeed, Client and Server are currently annotated as @InterfaceAudience.LimitedPrivate and @InterfaceStability.Evolving; see HADOOP-8813 . I think we don't need to change them to public.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Thank you every one for review. Akira Ajisaka that's fixed in v002, thanks.

          Show
          xiaobingo Xiaobing Zhou added a comment - Thank you every one for review. Akira Ajisaka that's fixed in v002, thanks.
          Hide
          ajisakaa Akira Ajisaka added a comment -
          [WARNING] /testptch/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:445: warning - @return tag has no arguments.
          

          The warning (javadoc) is related because only @Public classes generates javadoc. Would you fix it?

          Show
          ajisakaa Akira Ajisaka added a comment - [WARNING] /testptch/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:445: warning - @return tag has no arguments. The warning (javadoc) is related because only @Public classes generates javadoc. Would you fix it?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 9m 18s trunk passed
          +1 compile 11m 50s trunk passed with JDK v1.8.0_74
          +1 compile 8m 49s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 20s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 2m 15s trunk passed
          +1 javadoc 1m 32s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 36s trunk passed with JDK v1.7.0_95
          +1 mvninstall 1m 7s the patch passed
          +1 compile 18m 58s the patch passed with JDK v1.8.0_74
          +1 javac 18m 58s the patch passed
          +1 compile 14m 41s the patch passed with JDK v1.7.0_95
          +1 javac 14m 41s the patch passed
          +1 checkstyle 0m 46s hadoop-common-project/hadoop-common: patch generated 0 new + 281 unchanged - 2 fixed = 281 total (was 283)
          +1 mvnsite 1m 57s the patch passed
          +1 mvneclipse 0m 20s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 36s the patch passed
          -1 javadoc 4m 38s hadoop-common-project_hadoop-common-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
          +1 javadoc 1m 31s the patch passed with JDK v1.8.0_74
          -1 javadoc 6m 38s hadoop-common-project_hadoop-common-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
          +1 javadoc 1m 29s the patch passed with JDK v1.7.0_95
          -1 unit 12m 10s hadoop-common in the patch failed with JDK v1.8.0_74.
          +1 unit 11m 51s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 40s Patch does not generate ASF License warnings.
          107m 37s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.ipc.TestRPCWaitForProxy



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796452/HADOOP-12969.001.patch
          JIRA Issue HADOOP-12969
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 49dc1c0744ad 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / aac4d65
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javadoc hadoop-common-project_hadoop-common-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HADOOP-Build/8995/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          javadoc hadoop-common-project_hadoop-common-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8995/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8995/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8995/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8995/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8995/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 18s trunk passed +1 compile 11m 50s trunk passed with JDK v1.8.0_74 +1 compile 8m 49s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 20s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 2m 15s trunk passed +1 javadoc 1m 32s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 36s trunk passed with JDK v1.7.0_95 +1 mvninstall 1m 7s the patch passed +1 compile 18m 58s the patch passed with JDK v1.8.0_74 +1 javac 18m 58s the patch passed +1 compile 14m 41s the patch passed with JDK v1.7.0_95 +1 javac 14m 41s the patch passed +1 checkstyle 0m 46s hadoop-common-project/hadoop-common: patch generated 0 new + 281 unchanged - 2 fixed = 281 total (was 283) +1 mvnsite 1m 57s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 36s the patch passed -1 javadoc 4m 38s hadoop-common-project_hadoop-common-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) +1 javadoc 1m 31s the patch passed with JDK v1.8.0_74 -1 javadoc 6m 38s hadoop-common-project_hadoop-common-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13) +1 javadoc 1m 29s the patch passed with JDK v1.7.0_95 -1 unit 12m 10s hadoop-common in the patch failed with JDK v1.8.0_74. +1 unit 11m 51s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 40s Patch does not generate ASF License warnings. 107m 37s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.ipc.TestRPCWaitForProxy Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796452/HADOOP-12969.001.patch JIRA Issue HADOOP-12969 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 49dc1c0744ad 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / aac4d65 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javadoc hadoop-common-project_hadoop-common-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HADOOP-Build/8995/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt javadoc hadoop-common-project_hadoop-common-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8995/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8995/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8995/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8995/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8995/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          v002 removed LimitedPrivate, thanks Akira Ajisaka for review.

          Show
          xiaobingo Xiaobing Zhou added a comment - v002 removed LimitedPrivate, thanks Akira Ajisaka for review.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Hi Xiaobing Zhou, would you remove @InterfaceAudience.LimitedPrivate?

          Show
          ajisakaa Akira Ajisaka added a comment - Hi Xiaobing Zhou , would you remove @InterfaceAudience.LimitedPrivate ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 55s trunk passed
          +1 compile 6m 32s trunk passed with JDK v1.8.0_77
          +1 compile 7m 16s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 40s trunk passed
          +1 javadoc 0m 57s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 5m 37s the patch passed with JDK v1.8.0_77
          +1 javac 5m 37s the patch passed
          +1 compile 6m 35s the patch passed with JDK v1.7.0_95
          +1 javac 6m 35s the patch passed
          +1 checkstyle 0m 24s the patch passed
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 48s the patch passed
          +1 javadoc 0m 53s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 2s the patch passed with JDK v1.7.0_95
          -1 unit 16m 50s hadoop-common in the patch failed with JDK v1.8.0_77.
          -1 unit 7m 21s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 22s Patch generated 2 ASF License warnings.
          70m 6s



          Reason Tests
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
            org.apache.hadoop.http.TestHttpServerLifecycle
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796168/HADOOP-12969.000..patch
          JIRA Issue HADOOP-12969
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 95efab1cd19a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0064cba
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 55s trunk passed +1 compile 6m 32s trunk passed with JDK v1.8.0_77 +1 compile 7m 16s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 5m 37s the patch passed with JDK v1.8.0_77 +1 javac 5m 37s the patch passed +1 compile 6m 35s the patch passed with JDK v1.7.0_95 +1 javac 6m 35s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_95 -1 unit 16m 50s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 7m 21s hadoop-common in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 22s Patch generated 2 ASF License warnings. 70m 6s Reason Tests JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker   org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796168/HADOOP-12969.000..patch JIRA Issue HADOOP-12969 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 95efab1cd19a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0064cba Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8990/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          I posted a simple patch for review. They are already marked as @Evoling.

          Show
          xiaobingo Xiaobing Zhou added a comment - I posted a simple patch for review. They are already marked as @Evoling.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          IPC client is used in YARN apps as it gives you kerberos IPC;

          You can't do REST to a YARN app as the RM proxy gets in the way. So it's Hadoop RPC or roll your own non-kerberized IPC mechanism.

          Show
          stevel@apache.org Steve Loughran added a comment - IPC client is used in YARN apps as it gives you kerberos IPC; You can't do REST to a YARN app as the RM proxy gets in the way. So it's Hadoop RPC or roll your own non-kerberized IPC mechanism.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          I didn't see any direct references to o.a.h.ipc.server in HBase, Hive etc. but it looks like Tez and Slider are using it.

          Show
          arpitagarwal Arpit Agarwal added a comment - I didn't see any direct references to o.a.h.ipc.server in HBase, Hive etc. but it looks like Tez and Slider are using it.
          Hide
          hitesh Hitesh Shah added a comment -

          Anyone using hadoop rpc ( HBase, Tez, etc. ) for client-server communication are already using this regardless of it being private.

          Show
          hitesh Hitesh Shah added a comment - Anyone using hadoop rpc ( HBase, Tez, etc. ) for client-server communication are already using this regardless of it being private.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Is IPC.Server used by any other components outside of HDFS, YARN and MR? What is the benefit of making it @Public?

          Show
          arpitagarwal Arpit Agarwal added a comment - Is IPC.Server used by any other components outside of HDFS, YARN and MR? What is the benefit of making it @Public?

            People

            • Assignee:
              xiaobingo Xiaobing Zhou
              Reporter:
              xiaobingo Xiaobing Zhou
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development