Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12928

Update netty to 3.10.5.Final to sync with zookeeper

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.7.2
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None

      Description

      Update netty to 3.7.1.Final because hadoop-client 2.7.2 depends on zookeeper 3.4.6 which depends on netty 3.7.x. Related to HADOOP-12927

      Pull request: https://github.com/apache/hadoop/pull/85

      1. HADOOP-12928.01.patch
        5 kB
        Lei (Eddy) Xu
      2. HADOOP-12928.02.patch
        5 kB
        Lei (Eddy) Xu
      3. HADOOP-12928.03.patch
        0.5 kB
        Lei (Eddy) Xu
      4. HADOOP-12928-branch-2.00.patch
        0.4 kB
        Lei (Eddy) Xu
      5. HADOOP-12928-branch-2.01.patch
        8 kB
        Lei (Eddy) Xu
      6. HADOOP-12928-branch-2.02.patch
        8 kB
        Lei (Eddy) Xu
      7. HDFS-12928.00.patch
        5 kB
        Lei (Eddy) Xu

        Issue Links

          Activity

          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Hi, Tsuyoshi Ozawa

          Sorry for late reply. I've tested ZKFC case, and updated both trunk and branch-2 patches with Zookeeper 3.4.9.

          One caveat was that, after Akira Ajisaka +1ed the trunk patch, I've already committed that patch (w/o Zookeeper 3.4.9) into trunk, and then in the middle of committing, received your comments. So this new trunk patch only updates the zookeeper version, and branch-2 patch carries the actual changes in branch-2.

          Could you take another look?

          Show
          eddyxu Lei (Eddy) Xu added a comment - Hi, Tsuyoshi Ozawa Sorry for late reply. I've tested ZKFC case, and updated both trunk and branch-2 patches with Zookeeper 3.4.9. One caveat was that, after Akira Ajisaka +1ed the trunk patch, I've already committed that patch (w/o Zookeeper 3.4.9) into trunk, and then in the middle of committing, received your comments. So this new trunk patch only updates the zookeeper version, and branch-2 patch carries the actual changes in branch-2 . Could you take another look?
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Hi, Tsuyoshi Ozawa Sure. Will check against ZK-FC.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Hi, Tsuyoshi Ozawa Sure. Will check against ZK-FC.
          Hide
          ozawa Tsuyoshi Ozawa added a comment - - edited

          Lei (Eddy) Xu Thanks for your patch, my review comment is as follows:

          1. Let's update zookeeper.version to 3.4.9 to sync with netty's version. It's compatible change, according to changelog of ZK. https://zookeeper.apache.org/doc/r3.4.9/releasenotes.html
          2. Let's check ZK-FC and RM-HA work well after the dependency update, including the zk dependency upgrade as I mentioned 1. I will check RM-HA's behavior, so could you check ZK-FC change?

          Show
          ozawa Tsuyoshi Ozawa added a comment - - edited Lei (Eddy) Xu Thanks for your patch, my review comment is as follows: 1. Let's update zookeeper.version to 3.4.9 to sync with netty's version. It's compatible change, according to changelog of ZK. https://zookeeper.apache.org/doc/r3.4.9/releasenotes.html 2. Let's check ZK-FC and RM-HA work well after the dependency update, including the zk dependency upgrade as I mentioned 1. I will check RM-HA's behavior, so could you check ZK-FC change?
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Andrew Wang Thanks for your ping!
          Lei (Eddy) Xu OK, I will check it.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Andrew Wang Thanks for your ping! Lei (Eddy) Xu OK, I will check it.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 14m 47s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 20s Maven dependency ordering for branch
          +1 mvninstall 7m 27s branch-2 passed
          +1 compile 6m 44s branch-2 passed with JDK v1.8.0_111
          +1 compile 7m 3s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 1m 34s branch-2 passed
          +1 mvnsite 1m 29s branch-2 passed
          +1 mvneclipse 0m 42s branch-2 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 2m 29s branch-2 passed
          +1 javadoc 1m 22s branch-2 passed with JDK v1.8.0_111
          +1 javadoc 2m 8s branch-2 passed with JDK v1.7.0_111
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 1m 14s the patch passed
          +1 compile 5m 33s the patch passed with JDK v1.8.0_111
          +1 javac 5m 33s the patch passed
          +1 compile 6m 33s the patch passed with JDK v1.7.0_111
          +1 javac 6m 33s the patch passed
          -0 checkstyle 1m 30s root: The patch generated 1 new + 89 unchanged - 1 fixed = 90 total (was 90)
          +1 mvnsite 1m 36s the patch passed
          +1 mvneclipse 0m 52s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 3m 3s the patch passed
          +1 javadoc 1m 33s the patch passed with JDK v1.8.0_111
          +1 javadoc 2m 18s the patch passed with JDK v1.7.0_111
          +1 unit 0m 17s hadoop-project in the patch passed with JDK v1.7.0_111.
          +1 unit 49m 13s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
          -1 unit 0m 29s hadoop-mapreduce-client-shuffle in the patch failed with JDK v1.7.0_111.
          +1 asflicense 0m 31s The patch does not generate ASF License warnings.
          198m 43s



          Reason Tests
          JDK v1.8.0_111 Failed junit tests hadoop.mapred.TestShuffleHandler
          JDK v1.7.0_111 Failed junit tests hadoop.mapred.TestShuffleHandler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HADOOP-12928
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836476/HADOOP-12928-branch-2.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 54e1de0f89a7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 92fff7d
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10956/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10956/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10956/testReport/
          modules C: hadoop-project hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10956/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 14m 47s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 20s Maven dependency ordering for branch +1 mvninstall 7m 27s branch-2 passed +1 compile 6m 44s branch-2 passed with JDK v1.8.0_111 +1 compile 7m 3s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 1m 34s branch-2 passed +1 mvnsite 1m 29s branch-2 passed +1 mvneclipse 0m 42s branch-2 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 2m 29s branch-2 passed +1 javadoc 1m 22s branch-2 passed with JDK v1.8.0_111 +1 javadoc 2m 8s branch-2 passed with JDK v1.7.0_111 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 1m 14s the patch passed +1 compile 5m 33s the patch passed with JDK v1.8.0_111 +1 javac 5m 33s the patch passed +1 compile 6m 33s the patch passed with JDK v1.7.0_111 +1 javac 6m 33s the patch passed -0 checkstyle 1m 30s root: The patch generated 1 new + 89 unchanged - 1 fixed = 90 total (was 90) +1 mvnsite 1m 36s the patch passed +1 mvneclipse 0m 52s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 3m 3s the patch passed +1 javadoc 1m 33s the patch passed with JDK v1.8.0_111 +1 javadoc 2m 18s the patch passed with JDK v1.7.0_111 +1 unit 0m 17s hadoop-project in the patch passed with JDK v1.7.0_111. +1 unit 49m 13s hadoop-hdfs in the patch passed with JDK v1.7.0_111. -1 unit 0m 29s hadoop-mapreduce-client-shuffle in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 198m 43s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.mapred.TestShuffleHandler JDK v1.7.0_111 Failed junit tests hadoop.mapred.TestShuffleHandler Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-12928 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836476/HADOOP-12928-branch-2.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 54e1de0f89a7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 92fff7d Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10956/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10956/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10956/testReport/ modules C: hadoop-project hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10956/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Hi, Tsuyoshi Ozawa, Zookeeper 3.4.9 and 3.5.0 have been released. Would you take a look of branch-2 patch to see whether it is ok to commit?

          Thanks!

          Show
          eddyxu Lei (Eddy) Xu added a comment - Hi, Tsuyoshi Ozawa , Zookeeper 3.4.9 and 3.5.0 have been released. Would you take a look of branch-2 patch to see whether it is ok to commit? Thanks!
          Hide
          andrew.wang Andrew Wang added a comment -

          Also as an FYI, I see that ZK 3.4.9 has been released, so maybe we can do the bumps that Tsuyoshi proposed.

          Show
          andrew.wang Andrew Wang added a comment - Also as an FYI, I see that ZK 3.4.9 has been released, so maybe we can do the bumps that Tsuyoshi proposed.
          Hide
          andrew.wang Andrew Wang added a comment -

          Looking at git log, it looks like this was in fact included in 3.0.0-alpha1 but the fix version wasn't set. That release already went out so the changelog will be inaccurate, but we can at least correct it here.

          Show
          andrew.wang Andrew Wang added a comment - Looking at git log, it looks like this was in fact included in 3.0.0-alpha1 but the fix version wasn't set. That release already went out so the changelog will be inaccurate, but we can at least correct it here.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Tsuyoshi Ozawa Thanks for helping with this. Let me know if you need anything.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Tsuyoshi Ozawa Thanks for helping with this. Let me know if you need anything.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Lei (Eddy) Xu thanks for the clarification.

          Zookeeper recently changed netty to 3.10.5.Final as well..

          The ZooKeeper's version which includes the change is 3.4.9. It's been not released(http://zookeeper.apache.org/releases.html). I prefer to update ZooKeeper to 3.4.9 and netty to 3.10.5.Final at the same time after the release of ZooKeeper 3.4.9. It's because netty-3.10.final is binary-incompatible with 3.7.1.final which ZooKeeper 3.4.7, and Hadoop 3.0.0-alpha will be released soon: Hadoop 3.0.0 alpha is the version for getting feedbacks by early adapters, so we should make it stable as possible as we can.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Lei (Eddy) Xu thanks for the clarification. Zookeeper recently changed netty to 3.10.5.Final as well.. The ZooKeeper's version which includes the change is 3.4.9. It's been not released( http://zookeeper.apache.org/releases.html ). I prefer to update ZooKeeper to 3.4.9 and netty to 3.10.5.Final at the same time after the release of ZooKeeper 3.4.9. It's because netty-3.10.final is binary-incompatible with 3.7.1.final which ZooKeeper 3.4.7, and Hadoop 3.0.0-alpha will be released soon: Hadoop 3.0.0 alpha is the version for getting feedbacks by early adapters, so we should make it stable as possible as we can.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Hi, Tsuyoshi Ozawa

          Zookeeper recently changed netty to 3.10.5.Final as well..

          https://issues.apache.org/jira/browse/ZOOKEEPER-2450.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Hi, Tsuyoshi Ozawa Zookeeper recently changed netty to 3.10.5.Final as well.. https://issues.apache.org/jira/browse/ZOOKEEPER-2450 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 20m 52s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 11m 53s branch-2 passed
          +1 compile 0m 12s branch-2 passed with JDK v1.8.0_91
          +1 compile 0m 13s branch-2 passed with JDK v1.7.0_101
          +1 mvnsite 0m 19s branch-2 passed
          +1 mvneclipse 0m 18s branch-2 passed
          +1 javadoc 0m 14s branch-2 passed with JDK v1.8.0_91
          +1 javadoc 0m 12s branch-2 passed with JDK v1.7.0_101
          +1 mvninstall 0m 9s the patch passed
          +1 compile 0m 8s the patch passed with JDK v1.8.0_91
          +1 javac 0m 8s the patch passed
          +1 compile 0m 8s the patch passed with JDK v1.7.0_101
          +1 javac 0m 8s the patch passed
          +1 mvnsite 0m 11s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 8s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 9s the patch passed with JDK v1.7.0_101
          +1 unit 0m 8s hadoop-project in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          37m 3s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819257/HADOOP-12928-branch-2.00.patch
          JIRA Issue HADOOP-12928
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 91eced9d370e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 2bf5c4e
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10049/testReport/
          modules C: hadoop-project U: hadoop-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10049/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 20m 52s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 11m 53s branch-2 passed +1 compile 0m 12s branch-2 passed with JDK v1.8.0_91 +1 compile 0m 13s branch-2 passed with JDK v1.7.0_101 +1 mvnsite 0m 19s branch-2 passed +1 mvneclipse 0m 18s branch-2 passed +1 javadoc 0m 14s branch-2 passed with JDK v1.8.0_91 +1 javadoc 0m 12s branch-2 passed with JDK v1.7.0_101 +1 mvninstall 0m 9s the patch passed +1 compile 0m 8s the patch passed with JDK v1.8.0_91 +1 javac 0m 8s the patch passed +1 compile 0m 8s the patch passed with JDK v1.7.0_101 +1 javac 0m 8s the patch passed +1 mvnsite 0m 11s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 8s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 9s the patch passed with JDK v1.7.0_101 +1 unit 0m 8s hadoop-project in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 37m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819257/HADOOP-12928-branch-2.00.patch JIRA Issue HADOOP-12928 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 91eced9d370e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 2bf5c4e Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10049/testReport/ modules C: hadoop-project U: hadoop-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10049/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment - - edited

          Lei (Eddy) Xu I'm sorry for delay of the review, but I haven't taken look at the patch against trunk.
          My concern is that netty-3.10.final conflicts with 3.7.1.final(ZK is using the version) whose version is not binary compatible with 3.10.x.

          Could you check following points on trunk?

          • RM HA with ZKRMStateStore works correctly.
          • ZK FC works correctly.

          I'm +1 if both of them passed. Steve Loughran, do you have additional concern?

          Show
          ozawa Tsuyoshi Ozawa added a comment - - edited Lei (Eddy) Xu I'm sorry for delay of the review, but I haven't taken look at the patch against trunk. My concern is that netty-3.10.final conflicts with 3.7.1.final(ZK is using the version) whose version is not binary compatible with 3.10.x. Could you check following points on trunk? RM HA with ZKRMStateStore works correctly. ZK FC works correctly. I'm +1 if both of them passed. Steve Loughran , do you have additional concern?
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #10128 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10128/)
          HADOOP-12928. Update netty to 3.10.5.Final to sync with zookeeper. (lei) (lei: rev 521f34317a2f94ea7e60f3d59db335cef3358e5b)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
          • hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10128 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10128/ ) HADOOP-12928 . Update netty to 3.10.5.Final to sync with zookeeper. (lei) (lei: rev 521f34317a2f94ea7e60f3d59db335cef3358e5b) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java hadoop-project/pom.xml
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Add branch-2 patch, Akira Ajisaka Tsuyoshi Ozawa Would you mind to give a review? Much appreciated.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Add branch-2 patch, Akira Ajisaka Tsuyoshi Ozawa Would you mind to give a review? Much appreciated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Not sure why there are multiple results for the same 02 patch. But this failed one should because that the patch has been committed.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Not sure why there are multiple results for the same 02 patch. But this failed one should because that the patch has been committed.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HADOOP-12928 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819203/HADOOP-12928.02.patch
          JIRA Issue HADOOP-12928
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10048/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-12928 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819203/HADOOP-12928.02.patch JIRA Issue HADOOP-12928 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10048/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Thanks, Akira Ajisaka Yes you are right, 3.10 has moved several functions, that was why that I have changed ShuffleHandler.

          I will commit it to trunk for now and mark it incompatible.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Thanks, Akira Ajisaka Yes you are right, 3.10 has moved several functions, that was why that I have changed ShuffleHandler . I will commit it to trunk for now and mark it incompatible.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Tsuyoshi Ozawa thanks for the suggestions. 3.7.x still has CVE-2014-3488.

          I will create a branch-2 patch on 3.7.x for compatibility concerns for now. More inputs are welcome.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Tsuyoshi Ozawa thanks for the suggestions. 3.7.x still has CVE-2014-3488. I will create a branch-2 patch on 3.7.x for compatibility concerns for now. More inputs are welcome.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 1m 42s Maven dependency ordering for branch
          +1 mvninstall 7m 50s trunk passed
          +1 compile 7m 53s trunk passed
          +1 checkstyle 1m 35s trunk passed
          +1 mvnsite 0m 32s trunk passed
          +1 mvneclipse 0m 24s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 0m 28s trunk passed
          +1 javadoc 0m 28s trunk passed
          0 mvndep 0m 20s Maven dependency ordering for patch
          +1 mvninstall 0m 26s the patch passed
          +1 compile 8m 16s the patch passed
          +1 javac 8m 16s the patch passed
          +1 checkstyle 1m 40s root: The patch generated 0 new + 63 unchanged - 1 fixed = 63 total (was 64)
          +1 mvnsite 0m 40s the patch passed
          +1 mvneclipse 0m 31s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 0m 44s the patch passed
          +1 javadoc 0m 34s the patch passed
          +1 unit 0m 15s hadoop-project in the patch passed.
          +1 unit 0m 26s hadoop-mapreduce-client-shuffle in the patch passed.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          58m 42s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819203/HADOOP-12928.02.patch
          JIRA Issue HADOOP-12928
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 867b7850185f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e340064
          Default Java 1.8.0_91
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10046/testReport/
          modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10046/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 42s Maven dependency ordering for branch +1 mvninstall 7m 50s trunk passed +1 compile 7m 53s trunk passed +1 checkstyle 1m 35s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 24s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 28s trunk passed +1 javadoc 0m 28s trunk passed 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 0m 26s the patch passed +1 compile 8m 16s the patch passed +1 javac 8m 16s the patch passed +1 checkstyle 1m 40s root: The patch generated 0 new + 63 unchanged - 1 fixed = 63 total (was 64) +1 mvnsite 0m 40s the patch passed +1 mvneclipse 0m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 44s the patch passed +1 javadoc 0m 34s the patch passed +1 unit 0m 15s hadoop-project in the patch passed. +1 unit 0m 26s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 58m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819203/HADOOP-12928.02.patch JIRA Issue HADOOP-12928 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 867b7850185f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e340064 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10046/testReport/ modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10046/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 44s Maven dependency ordering for branch
          +1 mvninstall 7m 54s trunk passed
          +1 compile 8m 13s trunk passed
          +1 checkstyle 1m 29s trunk passed
          +1 mvnsite 0m 34s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 26s trunk passed
          0 mvndep 0m 21s Maven dependency ordering for patch
          +1 mvninstall 0m 28s the patch passed
          +1 compile 8m 21s the patch passed
          +1 javac 8m 21s the patch passed
          +1 checkstyle 1m 41s root: The patch generated 0 new + 63 unchanged - 1 fixed = 63 total (was 64)
          +1 mvnsite 0m 39s the patch passed
          +1 mvneclipse 0m 31s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 0m 40s the patch passed
          +1 javadoc 0m 36s the patch passed
          +1 unit 0m 14s hadoop-project in the patch passed.
          +1 unit 0m 28s hadoop-mapreduce-client-shuffle in the patch passed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          58m 8s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819203/HADOOP-12928.02.patch
          JIRA Issue HADOOP-12928
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 185ffcaef68b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e340064
          Default Java 1.8.0_91
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10043/testReport/
          modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10043/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 44s Maven dependency ordering for branch +1 mvninstall 7m 54s trunk passed +1 compile 8m 13s trunk passed +1 checkstyle 1m 29s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 25s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 27s trunk passed +1 javadoc 0m 26s trunk passed 0 mvndep 0m 21s Maven dependency ordering for patch +1 mvninstall 0m 28s the patch passed +1 compile 8m 21s the patch passed +1 javac 8m 21s the patch passed +1 checkstyle 1m 41s root: The patch generated 0 new + 63 unchanged - 1 fixed = 63 total (was 64) +1 mvnsite 0m 39s the patch passed +1 mvneclipse 0m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 40s the patch passed +1 javadoc 0m 36s the patch passed +1 unit 0m 14s hadoop-project in the patch passed. +1 unit 0m 28s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 58m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819203/HADOOP-12928.02.patch JIRA Issue HADOOP-12928 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 185ffcaef68b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e340064 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10043/testReport/ modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10043/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          IIUC, it's more safe to update it to 3.7.x for branch-2 since zookeeper 3.4.6 depends on 3.7.0.Final.

          FYI: http://netty.io/news/2013/08/27/semantic-versioning.html

          Show
          ozawa Tsuyoshi Ozawa added a comment - IIUC, it's more safe to update it to 3.7.x for branch-2 since zookeeper 3.4.6 depends on 3.7.0.Final. FYI: http://netty.io/news/2013/08/27/semantic-versioning.html
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 5s trunk passed
          +1 compile 6m 52s trunk passed
          +1 checkstyle 1m 25s trunk passed
          +1 mvnsite 0m 31s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 0m 37s trunk passed
          +1 javadoc 0m 29s trunk passed
          0 mvndep 0m 39s Maven dependency ordering for patch
          +1 mvninstall 0m 27s the patch passed
          +1 compile 7m 40s the patch passed
          +1 javac 7m 40s the patch passed
          +1 checkstyle 1m 32s root: The patch generated 0 new + 63 unchanged - 1 fixed = 63 total (was 64)
          +1 mvnsite 0m 39s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 0m 42s the patch passed
          +1 javadoc 0m 35s the patch passed
          +1 unit 0m 15s hadoop-project in the patch passed.
          +1 unit 0m 26s hadoop-mapreduce-client-shuffle in the patch passed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          54m 58s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819203/HADOOP-12928.02.patch
          JIRA Issue HADOOP-12928
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux e484aa48e791 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 38128ba
          Default Java 1.8.0_91
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10042/testReport/
          modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10042/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 5s trunk passed +1 compile 6m 52s trunk passed +1 checkstyle 1m 25s trunk passed +1 mvnsite 0m 31s trunk passed +1 mvneclipse 0m 23s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 37s trunk passed +1 javadoc 0m 29s trunk passed 0 mvndep 0m 39s Maven dependency ordering for patch +1 mvninstall 0m 27s the patch passed +1 compile 7m 40s the patch passed +1 javac 7m 40s the patch passed +1 checkstyle 1m 32s root: The patch generated 0 new + 63 unchanged - 1 fixed = 63 total (was 64) +1 mvnsite 0m 39s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 42s the patch passed +1 javadoc 0m 35s the patch passed +1 unit 0m 15s hadoop-project in the patch passed. +1 unit 0m 26s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 54m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819203/HADOOP-12928.02.patch JIRA Issue HADOOP-12928 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux e484aa48e791 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 38128ba Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10042/testReport/ modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10042/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          In Netty 3.10.0, deprecated fields, methods, and classes were removed.
          http://netty.io/news/2014/12/17/3-9-6-Final-and-3-10-0-Final.html
          I'm +1 for trunk only.

          Show
          ajisakaa Akira Ajisaka added a comment - In Netty 3.10.0, deprecated fields, methods, and classes were removed. http://netty.io/news/2014/12/17/3-9-6-Final-and-3-10-0-Final.html I'm +1 for trunk only.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Lei (Eddy) Xu. +1 for trunk.
          Is there any incompatible API changes between Netty 3.6.2 and 3.10.5? I'm +1 for branch-2 and branch-2.8 if there are no incompatible changes.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Lei (Eddy) Xu . +1 for trunk. Is there any incompatible API changes between Netty 3.6.2 and 3.10.5? I'm +1 for branch-2 and branch-2.8 if there are no incompatible changes.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 52s trunk passed
          +1 compile 6m 54s trunk passed
          +1 checkstyle 1m 24s trunk passed
          +1 mvnsite 0m 31s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 0m 24s trunk passed
          +1 javadoc 0m 28s trunk passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 0m 25s the patch passed
          +1 compile 6m 47s the patch passed
          +1 javac 6m 47s the patch passed
          +1 checkstyle 1m 34s root: The patch generated 0 new + 63 unchanged - 1 fixed = 63 total (was 64)
          +1 mvnsite 0m 38s the patch passed
          +1 mvneclipse 0m 32s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 0m 37s the patch passed
          +1 javadoc 0m 44s the patch passed
          +1 unit 0m 16s hadoop-project in the patch passed.
          +1 unit 0m 29s hadoop-mapreduce-client-shuffle in the patch passed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          53m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819203/HADOOP-12928.02.patch
          JIRA Issue HADOOP-12928
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 507a704dd75f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 38128ba
          Default Java 1.8.0_91
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10041/testReport/
          modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10041/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 52s trunk passed +1 compile 6m 54s trunk passed +1 checkstyle 1m 24s trunk passed +1 mvnsite 0m 31s trunk passed +1 mvneclipse 0m 25s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 24s trunk passed +1 javadoc 0m 28s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 0m 25s the patch passed +1 compile 6m 47s the patch passed +1 javac 6m 47s the patch passed +1 checkstyle 1m 34s root: The patch generated 0 new + 63 unchanged - 1 fixed = 63 total (was 64) +1 mvnsite 0m 38s the patch passed +1 mvneclipse 0m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 37s the patch passed +1 javadoc 0m 44s the patch passed +1 unit 0m 16s hadoop-project in the patch passed. +1 unit 0m 29s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 53m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819203/HADOOP-12928.02.patch JIRA Issue HADOOP-12928 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 507a704dd75f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 38128ba Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10041/testReport/ modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10041/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Update the patch to address check warnings.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Update the patch to address check warnings.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 8m 39s trunk passed
          +1 compile 8m 49s trunk passed
          +1 checkstyle 1m 30s trunk passed
          +1 mvnsite 0m 34s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 0m 25s trunk passed
          +1 javadoc 0m 27s trunk passed
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 0m 26s the patch passed
          +1 compile 6m 56s the patch passed
          +1 javac 6m 56s the patch passed
          -0 checkstyle 1m 30s root: The patch generated 3 new + 64 unchanged - 1 fixed = 67 total (was 65)
          +1 mvnsite 0m 36s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 0m 38s the patch passed
          +1 javadoc 0m 32s the patch passed
          +1 unit 0m 12s hadoop-project in the patch passed.
          +1 unit 0m 28s hadoop-mapreduce-client-shuffle in the patch passed.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          56m 33s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818875/HADOOP-12928.01.patch
          JIRA Issue HADOOP-12928
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 9f8e5fc6915e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 38128ba
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10034/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10034/testReport/
          modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10034/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 8m 39s trunk passed +1 compile 8m 49s trunk passed +1 checkstyle 1m 30s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 26s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 25s trunk passed +1 javadoc 0m 27s trunk passed 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 0m 26s the patch passed +1 compile 6m 56s the patch passed +1 javac 6m 56s the patch passed -0 checkstyle 1m 30s root: The patch generated 3 new + 64 unchanged - 1 fixed = 67 total (was 65) +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 38s the patch passed +1 javadoc 0m 32s the patch passed +1 unit 0m 12s hadoop-project in the patch passed. +1 unit 0m 28s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 56m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818875/HADOOP-12928.01.patch JIRA Issue HADOOP-12928 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 9f8e5fc6915e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 38128ba Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10034/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10034/testReport/ modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10034/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Updated the patch to address the test failure.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Updated the patch to address the test failure.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 27s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 2m 45s Maven dependency ordering for branch
          +1 mvninstall 7m 20s trunk passed
          +1 compile 7m 5s trunk passed
          +1 checkstyle 1m 27s trunk passed
          +1 mvnsite 0m 31s trunk passed
          +1 mvneclipse 0m 24s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 0m 26s trunk passed
          +1 javadoc 0m 26s trunk passed
          0 mvndep 0m 20s Maven dependency ordering for patch
          +1 mvninstall 0m 27s the patch passed
          +1 compile 7m 6s the patch passed
          +1 javac 7m 6s the patch passed
          -0 checkstyle 1m 27s root: The patch generated 2 new + 64 unchanged - 1 fixed = 66 total (was 65)
          +1 mvnsite 0m 36s the patch passed
          +1 mvneclipse 0m 31s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 0m 40s the patch passed
          +1 javadoc 0m 34s the patch passed
          +1 unit 0m 13s hadoop-project in the patch passed.
          -1 unit 0m 30s hadoop-mapreduce-client-shuffle in the patch failed.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          56m 45s



          Reason Tests
          Failed junit tests hadoop.mapred.TestShuffleHandler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818688/HDFS-12928.00.patch
          JIRA Issue HADOOP-12928
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux f6a3eaf35a5c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 92fe2db
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10022/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10022/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10022/testReport/
          modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10022/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 2m 45s Maven dependency ordering for branch +1 mvninstall 7m 20s trunk passed +1 compile 7m 5s trunk passed +1 checkstyle 1m 27s trunk passed +1 mvnsite 0m 31s trunk passed +1 mvneclipse 0m 24s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 26s trunk passed +1 javadoc 0m 26s trunk passed 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 0m 27s the patch passed +1 compile 7m 6s the patch passed +1 javac 7m 6s the patch passed -0 checkstyle 1m 27s root: The patch generated 2 new + 64 unchanged - 1 fixed = 66 total (was 65) +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 40s the patch passed +1 javadoc 0m 34s the patch passed +1 unit 0m 13s hadoop-project in the patch passed. -1 unit 0m 30s hadoop-mapreduce-client-shuffle in the patch failed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 56m 45s Reason Tests Failed junit tests hadoop.mapred.TestShuffleHandler Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818688/HDFS-12928.00.patch JIRA Issue HADOOP-12928 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux f6a3eaf35a5c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 92fe2db Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10022/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10022/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10022/testReport/ modules C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10022/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Hi, Hendy Irawan Thanks for reporting this.

          Zookeeper has upgraded netty to 3.10.5 final. So I updated the patch to sync with newest version.

          This version also fixes the security vulnerabilities:
          CVE-2014-3488

          Show
          eddyxu Lei (Eddy) Xu added a comment - Hi, Hendy Irawan Thanks for reporting this. Zookeeper has upgraded netty to 3.10.5 final . So I updated the patch to sync with newest version. This version also fixes the security vulnerabilities: CVE-2014-3488

            People

            • Assignee:
              eddyxu Lei (Eddy) Xu
              Reporter:
              ceefour Hendy Irawan
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:

                Development