Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12902

JavaDocs for SignerSecretProvider are out-of-date in AuthenticationFilter

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The Javadocs in AuthenticationFilter say:

       * Out of the box it provides 3 signer secret provider implementations:
       * "string", "random", and "zookeeper"
      

      However, the "string" implementation is no longer available because HADOOP-11748 moved it to be a test-only artifact. This also doesn't mention anything about the file-backed secret provider (FileSignerSecretProvider).

      1. HADOOP-12902.4.patch
        5 kB
        Gabor Liptak
      2. HADOOP-12902.3.patch
        5 kB
        Gabor Liptak
      3. HADOOP-12902.2.patch
        4 kB
        Gabor Liptak
      4. HADOOP-12902.1.patch
        4 kB
        Gabor Liptak

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9531 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9531/)
          HADOOP-12902. JavaDocs for SignerSecretProvider are out-of-date in (aajisaka: rev acca149ec96f2932bebc492452a63a159de9ce47)

          • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/AuthenticationFilter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9531 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9531/ ) HADOOP-12902 . JavaDocs for SignerSecretProvider are out-of-date in (aajisaka: rev acca149ec96f2932bebc492452a63a159de9ce47) hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/AuthenticationFilter.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to branch-2.7 and above. Thanks Gabor Liptak for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to branch-2.7 and above. Thanks Gabor Liptak for the contribution!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, committing this.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 1s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 41s trunk passed
          +1 compile 5m 42s trunk passed with JDK v1.8.0_77
          +1 compile 6m 48s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 0m 19s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 26s trunk passed
          +1 javadoc 0m 12s trunk passed with JDK v1.8.0_77
          +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 15s the patch passed
          +1 compile 5m 46s the patch passed with JDK v1.8.0_77
          +1 javac 5m 46s the patch passed
          +1 compile 6m 44s the patch passed with JDK v1.7.0_95
          +1 javac 6m 44s the patch passed
          +1 checkstyle 0m 13s the patch passed
          +1 mvnsite 0m 19s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 37s the patch passed
          +1 javadoc 0m 11s the patch passed with JDK v1.8.0_77
          +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95
          +1 unit 3m 36s hadoop-auth in the patch passed with JDK v1.8.0_77.
          +1 unit 3m 59s hadoop-auth in the patch passed with JDK v1.7.0_95.
          -1 asflicense 0m 21s Patch generated 1 ASF License warnings.
          44m 29s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795988/HADOOP-12902.4.patch
          JIRA Issue HADOOP-12902
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ff5c941f44d1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8286270
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8962/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8962/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8962/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 41s trunk passed +1 compile 5m 42s trunk passed with JDK v1.8.0_77 +1 compile 6m 48s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 26s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_77 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 15s the patch passed +1 compile 5m 46s the patch passed with JDK v1.8.0_77 +1 javac 5m 46s the patch passed +1 compile 6m 44s the patch passed with JDK v1.7.0_95 +1 javac 6m 44s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 37s the patch passed +1 javadoc 0m 11s the patch passed with JDK v1.8.0_77 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95 +1 unit 3m 36s hadoop-auth in the patch passed with JDK v1.8.0_77. +1 unit 3m 59s hadoop-auth in the patch passed with JDK v1.7.0_95. -1 asflicense 0m 21s Patch generated 1 ASF License warnings. 44m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795988/HADOOP-12902.4.patch JIRA Issue HADOOP-12902 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ff5c941f44d1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8286270 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8962/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8962/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8962/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Would you fix the checkstyle warning? I'm +1 if that is addressed.

          Show
          ajisakaa Akira Ajisaka added a comment - Would you fix the checkstyle warning? I'm +1 if that is addressed.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 44s trunk passed
          +1 compile 5m 59s trunk passed with JDK v1.8.0_74
          +1 compile 6m 36s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 19s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 29s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_74
          +1 javadoc 0m 13s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 15s the patch passed
          +1 compile 5m 49s the patch passed with JDK v1.8.0_74
          +1 javac 5m 49s the patch passed
          +1 compile 6m 47s the patch passed with JDK v1.7.0_95
          +1 javac 6m 47s the patch passed
          -1 checkstyle 0m 13s hadoop-common-project/hadoop-auth: patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39)
          +1 mvnsite 0m 19s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 38s the patch passed
          +1 javadoc 0m 11s the patch passed with JDK v1.8.0_74
          +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95
          +1 unit 3m 40s hadoop-auth in the patch passed with JDK v1.8.0_74.
          +1 unit 4m 2s hadoop-auth in the patch passed with JDK v1.7.0_95.
          -1 asflicense 0m 24s Patch generated 1 ASF License warnings.
          45m 4s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795709/HADOOP-12902.3.patch
          JIRA Issue HADOOP-12902
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b25f457e718d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 948b758
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8947/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-auth.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8947/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8947/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8947/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 44s trunk passed +1 compile 5m 59s trunk passed with JDK v1.8.0_74 +1 compile 6m 36s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 13s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 15s the patch passed +1 compile 5m 49s the patch passed with JDK v1.8.0_74 +1 javac 5m 49s the patch passed +1 compile 6m 47s the patch passed with JDK v1.7.0_95 +1 javac 6m 47s the patch passed -1 checkstyle 0m 13s hadoop-common-project/hadoop-auth: patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39) +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 11s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95 +1 unit 3m 40s hadoop-auth in the patch passed with JDK v1.8.0_74. +1 unit 4m 2s hadoop-auth in the patch passed with JDK v1.7.0_95. -1 asflicense 0m 24s Patch generated 1 ASF License warnings. 45m 4s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795709/HADOOP-12902.3.patch JIRA Issue HADOOP-12902 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b25f457e718d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 948b758 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8947/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-auth.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8947/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8947/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8947/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          gliptak Gabor Liptak added a comment -

          Done.

          Show
          gliptak Gabor Liptak added a comment - Done.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Gabor Liptak for updating the patch! 3 comments:

          - * <li>[#PREFIX#.]signature.secret: When the "string" implementation is
          + * <li>[#PREFIX#.]signature.secret: When the "file" implementation is
            * specified, this value is used as the secret.</li>
          

          1. Would you fix the above as well?

          -   * Possible values are: "string", "random", "zookeeper", or a classname.
          -   * If not specified, the "string" implementation will be used with
          +   * Possible values are: "file", "random", "zookeeper", or a classname.
          +   * If not specified, the "file" implementation will be used with
              * SIGNATURE_SECRET; and if that's not specified, the "random" implementation
          

          2. SIGNATURE_SECRET should be SIGNATURE_SECRET_FILE.
          3. Would you fix the checkstyle warning?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Gabor Liptak for updating the patch! 3 comments: - * <li>[#PREFIX#.]signature.secret: When the "string" implementation is + * <li>[#PREFIX#.]signature.secret: When the "file" implementation is * specified, this value is used as the secret.</li> 1. Would you fix the above as well? - * Possible values are: "string" , "random" , "zookeeper" , or a classname. - * If not specified, the "string" implementation will be used with + * Possible values are: "file" , "random" , "zookeeper" , or a classname. + * If not specified, the "file" implementation will be used with * SIGNATURE_SECRET; and if that's not specified, the "random" implementation 2. SIGNATURE_SECRET should be SIGNATURE_SECRET_FILE . 3. Would you fix the checkstyle warning?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 45s trunk passed
          +1 compile 6m 1s trunk passed with JDK v1.8.0_74
          +1 compile 6m 47s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 20s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 25s trunk passed
          +1 javadoc 0m 12s trunk passed with JDK v1.8.0_74
          +1 javadoc 0m 13s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 16s the patch passed
          +1 compile 5m 45s the patch passed with JDK v1.8.0_74
          +1 javac 5m 45s the patch passed
          +1 compile 6m 45s the patch passed with JDK v1.7.0_95
          +1 javac 6m 45s the patch passed
          -1 checkstyle 0m 13s hadoop-common-project/hadoop-auth: patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39)
          +1 mvnsite 0m 18s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 38s the patch passed
          +1 javadoc 0m 12s the patch passed with JDK v1.8.0_74
          +1 javadoc 0m 14s the patch passed with JDK v1.7.0_95
          +1 unit 3m 35s hadoop-auth in the patch passed with JDK v1.8.0_74.
          +1 unit 4m 6s hadoop-auth in the patch passed with JDK v1.7.0_95.
          -1 asflicense 0m 22s Patch generated 1 ASF License warnings.
          45m 1s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795561/HADOOP-12902.2.patch
          JIRA Issue HADOOP-12902
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux eaa3f925e032 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 49ff54c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8937/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-auth.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8937/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8937/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8937/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 45s trunk passed +1 compile 6m 1s trunk passed with JDK v1.8.0_74 +1 compile 6m 47s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 20s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 13s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 16s the patch passed +1 compile 5m 45s the patch passed with JDK v1.8.0_74 +1 javac 5m 45s the patch passed +1 compile 6m 45s the patch passed with JDK v1.7.0_95 +1 javac 6m 45s the patch passed -1 checkstyle 0m 13s hadoop-common-project/hadoop-auth: patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39) +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 14s the patch passed with JDK v1.7.0_95 +1 unit 3m 35s hadoop-auth in the patch passed with JDK v1.8.0_74. +1 unit 4m 6s hadoop-auth in the patch passed with JDK v1.7.0_95. -1 asflicense 0m 22s Patch generated 1 ASF License warnings. 45m 1s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795561/HADOOP-12902.2.patch JIRA Issue HADOOP-12902 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux eaa3f925e032 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 49ff54c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8937/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-auth.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8937/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8937/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8937/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          gliptak Gabor Liptak added a comment -

          Akira Ajisaka Thank you for your review. I uploaded the updated patch.

          Show
          gliptak Gabor Liptak added a comment - Akira Ajisaka Thank you for your review. I uploaded the updated patch.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Gabor Liptak for creating the patch.

            * <li>[#PREFIX#.]signature.secret: when signer.secret.provider is set to
          - * "string" or not specified, this is the value for the secret used to sign the
          + * "file" or not specified, this is the value for the secret used to sign the
          

          Reading the source code, it seems that [#PREFIX#.]signature.secret is not valid now. When "file" is specified, [#PREFIX#.]signature.secret.file is the file path which the secret is loaded from. Would you update the patch to document [#PREFIX#.]signature.secret.file?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Gabor Liptak for creating the patch. * <li>[#PREFIX#.]signature.secret: when signer.secret.provider is set to - * "string" or not specified, this is the value for the secret used to sign the + * "file" or not specified, this is the value for the secret used to sign the Reading the source code, it seems that [#PREFIX#.]signature.secret is not valid now. When "file" is specified, [#PREFIX#.]signature.secret.file is the file path which the secret is loaded from. Would you update the patch to document [#PREFIX#.]signature.secret.file ?
          Hide
          gliptak Gabor Liptak added a comment -

          Test failures are likely unrelated.

          Show
          gliptak Gabor Liptak added a comment - Test failures are likely unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 33s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 21s trunk passed
          +1 compile 8m 35s trunk passed with JDK v1.8.0_74
          +1 compile 7m 28s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 19s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 14s trunk passed with JDK v1.8.0_74
          +1 javadoc 0m 13s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 15s the patch passed
          +1 compile 8m 14s the patch passed with JDK v1.8.0_74
          +1 javac 8m 14s the patch passed
          +1 compile 7m 32s the patch passed with JDK v1.7.0_95
          +1 javac 7m 32s the patch passed
          -1 checkstyle 0m 14s hadoop-common-project/hadoop-auth: patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39)
          +1 mvnsite 0m 23s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 42s the patch passed
          +1 javadoc 0m 17s the patch passed with JDK v1.8.0_74
          +1 javadoc 0m 15s the patch passed with JDK v1.7.0_95
          -1 unit 16m 52s hadoop-auth in the patch failed with JDK v1.8.0_74.
          -1 unit 12m 55s hadoop-auth in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          75m 11s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.security.authentication.util.TestZKSignerSecretProvider
          JDK v1.7.0_95 Failed junit tests hadoop.security.authentication.util.TestZKSignerSecretProvider



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794382/HADOOP-12902.1.patch
          JIRA Issue HADOOP-12902
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 817bef7f2fd2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / cd8b688
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-auth.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/testReport/
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 33s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 21s trunk passed +1 compile 8m 35s trunk passed with JDK v1.8.0_74 +1 compile 7m 28s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 14s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 13s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 15s the patch passed +1 compile 8m 14s the patch passed with JDK v1.8.0_74 +1 javac 8m 14s the patch passed +1 compile 7m 32s the patch passed with JDK v1.7.0_95 +1 javac 7m 32s the patch passed -1 checkstyle 0m 14s hadoop-common-project/hadoop-auth: patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39) +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 42s the patch passed +1 javadoc 0m 17s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 15s the patch passed with JDK v1.7.0_95 -1 unit 16m 52s hadoop-auth in the patch failed with JDK v1.8.0_74. -1 unit 12m 55s hadoop-auth in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 75m 11s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.security.authentication.util.TestZKSignerSecretProvider JDK v1.7.0_95 Failed junit tests hadoop.security.authentication.util.TestZKSignerSecretProvider Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794382/HADOOP-12902.1.patch JIRA Issue HADOOP-12902 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 817bef7f2fd2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cd8b688 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-auth.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/testReport/ modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8881/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              gliptak Gabor Liptak
              Reporter:
              rkanter Robert Kanter
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development