Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: tools
    • Labels:
      None
    • Target Version/s:

      Description

      gridmix shouldn't require a raw java command line to run.

      1. HADOOP-12866.01.patch
        3 kB
        Kai Sasaki
      2. HADOOP-12866.02.patch
        4 kB
        Kai Sasaki

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9730 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9730/)
          HADOOP-12866. add a subcommand for gridmix (Kai Sasaki via aw) (aw: rev 1c5bbf64993ff9c6b5bfe1566b794b5ae45bc636)

          • hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop
          • hadoop-tools/hadoop-gridmix/src/site/markdown/GridMix.md.vm
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9730 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9730/ ) HADOOP-12866 . add a subcommand for gridmix (Kai Sasaki via aw) (aw: rev 1c5bbf64993ff9c6b5bfe1566b794b5ae45bc636) hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md hadoop-common-project/hadoop-common/src/main/bin/hadoop hadoop-tools/hadoop-gridmix/src/site/markdown/GridMix.md.vm
          Hide
          aw Allen Wittenauer added a comment -

          +1 committed to trunk

          thanks!

          Show
          aw Allen Wittenauer added a comment - +1 committed to trunk thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 6m 40s trunk passed
          +1 mvnsite 1m 28s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvnsite 1m 19s the patch passed
          +1 shellcheck 0m 10s There were no new shellcheck issues.
          +1 shelldocs 0m 8s There were no new shelldocs issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 unit 1m 40s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 0m 18s hadoop-gridmix in the patch passed with JDK v1.8.0_91.
          +1 unit 1m 46s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 17s hadoop-gridmix in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          15m 7s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802634/HADOOP-12866.02.patch
          JIRA Issue HADOOP-12866
          Optional Tests asflicense mvnsite unit shellcheck shelldocs
          uname Linux 34afefa61293 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2835f14
          shellcheck v0.4.3
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9302/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-gridmix U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9302/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 6m 40s trunk passed +1 mvnsite 1m 28s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvnsite 1m 19s the patch passed +1 shellcheck 0m 10s There were no new shellcheck issues. +1 shelldocs 0m 8s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 1m 40s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 0m 18s hadoop-gridmix in the patch passed with JDK v1.8.0_91. +1 unit 1m 46s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 0m 17s hadoop-gridmix in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 15m 7s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802634/HADOOP-12866.02.patch JIRA Issue HADOOP-12866 Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 34afefa61293 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2835f14 shellcheck v0.4.3 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9302/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-gridmix U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9302/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          OK, looks like it is.

          But the documentation fix is slightly incomplete. This whole section should just get removed since hadoop gridmix takes care of it all:

          GridMix expects certain library *JARs* to be present in  the *CLASSPATH*.
          One simple way to run GridMix is to use `hadoop jar` command to run it.
          You also need to add the JAR of Rumen to classpath for both of client and tasks
          as example shown below.
          
          ```
          HADOOP_CLASSPATH=$HADOOP_HOME/share/hadoop/tools/lib/hadoop-rumen-2.5.1.jar \
            $HADOOP_HOME/bin/hadoop jar $HADOOP_HOME/share/hadoop/tools/lib/hadoop-gridmix-2.5.1.jar \
              -libjars $HADOOP_HOME/share/hadoop/tools/lib/hadoop-rumen-2.5.1.jar \
              [-generate <size>] [-users <users-list>] <iopath> <trace>
          ```
          
          Show
          aw Allen Wittenauer added a comment - OK, looks like it is. But the documentation fix is slightly incomplete. This whole section should just get removed since hadoop gridmix takes care of it all: GridMix expects certain library *JARs* to be present in the *CLASSPATH*. One simple way to run GridMix is to use `hadoop jar` command to run it. You also need to add the JAR of Rumen to classpath for both of client and tasks as example shown below. ``` HADOOP_CLASSPATH=$HADOOP_HOME/share/hadoop/tools/lib/hadoop-rumen-2.5.1.jar \ $HADOOP_HOME/bin/hadoop jar $HADOOP_HOME/share/hadoop/tools/lib/hadoop-gridmix-2.5.1.jar \ -libjars $HADOOP_HOME/share/hadoop/tools/lib/hadoop-rumen-2.5.1.jar \ [-generate <size>] [-users <users-list>] <iopath> <trace> ```
          Hide
          aw Allen Wittenauer added a comment -
          +    hadoop_add_to_classpath_tools hadoop-rumen
          

          Is that actually required?

          Show
          aw Allen Wittenauer added a comment - + hadoop_add_to_classpath_tools hadoop-rumen Is that actually required?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          0 shelldocs 0m 5s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 44s trunk passed
          +1 mvnsite 1m 19s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvnsite 1m 13s the patch passed
          +1 shellcheck 0m 9s There were no new shellcheck issues.
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 unit 1m 33s hadoop-common in the patch passed with JDK v1.8.0_77.
          +1 unit 0m 14s hadoop-gridmix in the patch passed with JDK v1.8.0_77.
          +1 unit 1m 36s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 15s hadoop-gridmix in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          14m 19s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799983/HADOOP-12866.01.patch
          JIRA Issue HADOOP-12866
          Optional Tests asflicense mvnsite unit shellcheck shelldocs
          uname Linux 0a40b3366e6c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7da5847
          shellcheck v0.4.3
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9141/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-gridmix U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9141/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. 0 shelldocs 0m 5s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 44s trunk passed +1 mvnsite 1m 19s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvnsite 1m 13s the patch passed +1 shellcheck 0m 9s There were no new shellcheck issues. +1 whitespace 0m 0s Patch has no whitespace issues. +1 unit 1m 33s hadoop-common in the patch passed with JDK v1.8.0_77. +1 unit 0m 14s hadoop-gridmix in the patch passed with JDK v1.8.0_77. +1 unit 1m 36s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 0m 15s hadoop-gridmix in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 14m 19s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799983/HADOOP-12866.01.patch JIRA Issue HADOOP-12866 Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 0a40b3366e6c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7da5847 shellcheck v0.4.3 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9141/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-gridmix U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9141/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              lewuathe Kai Sasaki
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development