Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.2, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Logging slow name resolutions would be useful in identifying DNS performance issues in a cluster. Most resolutions go through org.apache.hadoop.security.SecurityUtil.getByName ( see attached call graph ). Adding additional logging to this method would expose such issues.

      1. getByName-call-graph.txt
        50 kB
        Sidharta Seethana
      2. HADOOP-12825.001.patch
        5 kB
        Sidharta Seethana
      3. HADOOP-12825.002.patch
        5 kB
        Sidharta Seethana

        Activity

        Hide
        sidharta-s Sidharta Seethana added a comment -

        Forgot to attach the call graph - doing this now.

        Show
        sidharta-s Sidharta Seethana added a comment - Forgot to attach the call graph - doing this now.
        Hide
        sidharta-s Sidharta Seethana added a comment -

        Uploaded a patch that logs slows name resolutions, if enabled.

        Show
        sidharta-s Sidharta Seethana added a comment - Uploaded a patch that logs slows name resolutions, if enabled.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 4s trunk passed
        +1 compile 6m 32s trunk passed with JDK v1.8.0_72
        +1 compile 7m 13s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 1m 6s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 39s trunk passed
        +1 javadoc 0m 56s trunk passed with JDK v1.8.0_72
        +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 45s the patch passed
        +1 compile 6m 31s the patch passed with JDK v1.8.0_72
        +1 javac 6m 31s the patch passed
        +1 compile 7m 14s the patch passed with JDK v1.7.0_95
        +1 javac 7m 14s the patch passed
        -1 checkstyle 0m 23s hadoop-common-project/hadoop-common: patch generated 3 new + 105 unchanged - 0 fixed = 108 total (was 105)
        +1 mvnsite 1m 5s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        +1 findbugs 1m 58s the patch passed
        +1 javadoc 0m 56s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95
        -1 unit 8m 27s hadoop-common in the patch failed with JDK v1.8.0_72.
        +1 unit 8m 41s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        65m 14s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.ha.TestZKFailoverController



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788806/HADOOP-12825.001.patch
        JIRA Issue HADOOP-12825
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 9c8d4f11d292 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 342c957
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8680/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8680/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8680/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8680/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8680/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 4s trunk passed +1 compile 6m 32s trunk passed with JDK v1.8.0_72 +1 compile 7m 13s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 39s trunk passed +1 javadoc 0m 56s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 6m 31s the patch passed with JDK v1.8.0_72 +1 javac 6m 31s the patch passed +1 compile 7m 14s the patch passed with JDK v1.7.0_95 +1 javac 7m 14s the patch passed -1 checkstyle 0m 23s hadoop-common-project/hadoop-common: patch generated 3 new + 105 unchanged - 0 fixed = 108 total (was 105) +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 1m 58s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95 -1 unit 8m 27s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 8m 41s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 65m 14s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788806/HADOOP-12825.001.patch JIRA Issue HADOOP-12825 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 9c8d4f11d292 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 342c957 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8680/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8680/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8680/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8680/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8680/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 33s trunk passed
        +1 compile 5m 35s trunk passed with JDK v1.8.0_72
        +1 compile 6m 35s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 32s trunk passed
        +1 javadoc 0m 52s trunk passed with JDK v1.8.0_72
        +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 40s the patch passed
        +1 compile 5m 34s the patch passed with JDK v1.8.0_72
        +1 javac 5m 34s the patch passed
        +1 compile 6m 32s the patch passed with JDK v1.7.0_95
        +1 javac 6m 32s the patch passed
        -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 3 new + 105 unchanged - 0 fixed = 108 total (was 105)
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 1m 46s the patch passed
        +1 javadoc 0m 53s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 2s the patch passed with JDK v1.7.0_95
        +1 unit 7m 19s hadoop-common in the patch passed with JDK v1.8.0_72.
        -1 unit 7m 6s hadoop-common in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        58m 3s



        Reason Tests
        JDK v1.7.0_95 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788806/HADOOP-12825.001.patch
        JIRA Issue HADOOP-12825
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux ac028a5f65b3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5e7d4d5
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8682/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8682/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8682/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8682/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8682/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 33s trunk passed +1 compile 5m 35s trunk passed with JDK v1.8.0_72 +1 compile 6m 35s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 32s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 40s the patch passed +1 compile 5m 34s the patch passed with JDK v1.8.0_72 +1 javac 5m 34s the patch passed +1 compile 6m 32s the patch passed with JDK v1.7.0_95 +1 javac 6m 32s the patch passed -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 3 new + 105 unchanged - 0 fixed = 108 total (was 105) +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_95 +1 unit 7m 19s hadoop-common in the patch passed with JDK v1.8.0_72. -1 unit 7m 6s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 58m 3s Reason Tests JDK v1.7.0_95 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788806/HADOOP-12825.001.patch JIRA Issue HADOOP-12825 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux ac028a5f65b3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5e7d4d5 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8682/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8682/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8682/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8682/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8682/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Not with Guava stopwatch; that 's one of the classes that isn't forwards compatible. Use org.apache.hadoop.util.StopWatch

        Show
        stevel@apache.org Steve Loughran added a comment - Not with Guava stopwatch; that 's one of the classes that isn't forwards compatible. Use org.apache.hadoop.util.StopWatch
        Hide
        sidharta-s Sidharta Seethana added a comment -

        Thanks, Steve Loughran - I didn't realize that the constructors were deprecated in a recent version of guava. I have made the changes you mentioned and uploaded a new patch - could you please take a look?

        thanks,
        -Sidharta

        Show
        sidharta-s Sidharta Seethana added a comment - Thanks, Steve Loughran - I didn't realize that the constructors were deprecated in a recent version of guava. I have made the changes you mentioned and uploaded a new patch - could you please take a look? thanks, -Sidharta
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 8s trunk passed
        +1 compile 8m 6s trunk passed with JDK v1.8.0_72
        +1 compile 7m 19s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 1m 5s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 36s trunk passed
        +1 javadoc 1m 4s trunk passed with JDK v1.8.0_72
        +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 44s the patch passed
        +1 compile 8m 34s the patch passed with JDK v1.8.0_72
        +1 javac 8m 34s the patch passed
        +1 compile 7m 22s the patch passed with JDK v1.7.0_95
        +1 javac 7m 22s the patch passed
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 1m 2s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        +1 findbugs 1m 49s the patch passed
        +1 javadoc 1m 1s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95
        -1 unit 8m 17s hadoop-common in the patch failed with JDK v1.8.0_72.
        +1 unit 8m 33s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        68m 37s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.ha.TestZKFailoverController



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789067/HADOOP-12825.002.patch
        JIRA Issue HADOOP-12825
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 5014370251b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a2fdfff
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8688/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8688/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8688/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8688/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 8s trunk passed +1 compile 8m 6s trunk passed with JDK v1.8.0_72 +1 compile 7m 19s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 5s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 36s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 8m 34s the patch passed with JDK v1.8.0_72 +1 javac 8m 34s the patch passed +1 compile 7m 22s the patch passed with JDK v1.7.0_95 +1 javac 7m 22s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 1m 49s the patch passed +1 javadoc 1m 1s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95 -1 unit 8m 17s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 8m 33s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 68m 37s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789067/HADOOP-12825.002.patch JIRA Issue HADOOP-12825 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 5014370251b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a2fdfff Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8688/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8688/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8688/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8688/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sidharta-s Sidharta Seethana added a comment -

        The test failure is unrelated to this patch.

        Show
        sidharta-s Sidharta Seethana added a comment - The test failure is unrelated to this patch.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        LGTM.

        +1

        A future feature would be some metric counting what's going on, with percentiles, but that would be something to think about under a generic network performance metric suite, wouldn't it?

        Show
        stevel@apache.org Steve Loughran added a comment - LGTM. +1 A future feature would be some metric counting what's going on, with percentiles, but that would be something to think about under a generic network performance metric suite, wouldn't it?
        Hide
        sidharta-s Sidharta Seethana added a comment -

        Thanks, Steve Loughran . Yes, I think so too - that would make sense along with other network performance metrics.

        Show
        sidharta-s Sidharta Seethana added a comment - Thanks, Steve Loughran . Yes, I think so too - that would make sense along with other network performance metrics.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9382 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9382/)
        HADOOP-12825. Log slow name resolutions. (Sidharta Seethana via stevel) (stevel: rev 03cfb454fe5a1351e283e4678ad1b432ed231485)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9382 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9382/ ) HADOOP-12825 . Log slow name resolutions. (Sidharta Seethana via stevel) (stevel: rev 03cfb454fe5a1351e283e4678ad1b432ed231485) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        cnauroth Chris Nauroth added a comment -

        I see in git log that this patch has been committed to trunk, branch-2 and branch-2.8. Can we resolve the issue, or is there some other work remaining?

        Show
        cnauroth Chris Nauroth added a comment - I see in git log that this patch has been committed to trunk, branch-2 and branch-2.8. Can we resolve the issue, or is there some other work remaining?
        Hide
        stevel@apache.org Steve Loughran added a comment -

        sorry chris; forgot about closing the JIRA. Done

        Show
        stevel@apache.org Steve Loughran added a comment - sorry chris; forgot about closing the JIRA. Done

          People

          • Assignee:
            sidharta-s Sidharta Seethana
            Reporter:
            sidharta-s Sidharta Seethana
          • Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development