Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12824

Collect network and disk usage on the node running Windows

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-12210 collects the node network usage for Linux; this JIRA does it for Windows.

      1. HADOOP-12824-v000.patch
        10 kB
        Íñigo Goiri
      2. HADOOP-12824-v001.patch
        8 kB
        Íñigo Goiri
      3. HADOOP-12824-v002.patch
        9 kB
        Íñigo Goiri
      4. HADOOP-12824-v003.patch
        13 kB
        Íñigo Goiri
      5. HADOOP-12824-v004.patch
        13 kB
        Íñigo Goiri

        Issue Links

          Activity

          Hide
          elgoiri Íñigo Goiri added a comment -

          The proposal is to extend winutils/systeminfo.c to collect network usage using PDH.
          The performance counter to collect will be the summation of \Network Interface(_Total)\Bytes Total/Sec.
          I think that HADOOP-12210 uses this rate value; otherwise, we will have to figure some other performance counter.

          Reference to PDH: https://msdn.microsoft.com/en-us/library/windows/desktop/aa373214(v=vs.85).aspx

          Show
          elgoiri Íñigo Goiri added a comment - The proposal is to extend winutils/systeminfo.c to collect network usage using PDH. The performance counter to collect will be the summation of \Network Interface(_Total)\Bytes Total/Sec. I think that HADOOP-12210 uses this rate value; otherwise, we will have to figure some other performance counter. Reference to PDH: https://msdn.microsoft.com/en-us/library/windows/desktop/aa373214(v=vs.85).aspx
          Hide
          elgoiri Íñigo Goiri added a comment -

          After checking HADOOP-12210, it looks like it is actually reporting total bytes while PDH only reports rates.
          I propose to add methods getNetworkBytesPerSecBytesRead() and getNetworkBytesPerSecWritten() to SysInfo.
          We could implement them in Linux in SysInfoLinux.
          Thoughts?

          Show
          elgoiri Íñigo Goiri added a comment - After checking HADOOP-12210 , it looks like it is actually reporting total bytes while PDH only reports rates. I propose to add methods getNetworkBytesPerSecBytesRead() and getNetworkBytesPerSecWritten() to SysInfo . We could implement them in Linux in SysInfoLinux . Thoughts?
          Hide
          elgoiri Íñigo Goiri added a comment -

          Proposal to collect network and disk rates using PDH.
          Problem: it requires a sleep of something 1sec to capture rates.

          Show
          elgoiri Íñigo Goiri added a comment - Proposal to collect network and disk rates using PDH. Problem: it requires a sleep of something 1sec to capture rates.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixing console output

          Show
          elgoiri Íñigo Goiri added a comment - Fixing console output
          Hide
          elgoiri Íñigo Goiri added a comment -

          Chris Nauroth, I think you were the one implementing the CPU and memory data collection for Windows; do you mind taking a look?
          I couldn't find a better interface for collecting Network/Disk other than PDH.

          Show
          elgoiri Íñigo Goiri added a comment - Chris Nauroth , I think you were the one implementing the CPU and memory data collection for Windows; do you mind taking a look? I couldn't find a better interface for collecting Network/Disk other than PDH.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Returning absolute values matching the Linux interface.

          Show
          elgoiri Íñigo Goiri added a comment - Returning absolute values matching the Linux interface.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Minor visibility fix.

          Show
          elgoiri Íñigo Goiri added a comment - Minor visibility fix.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 10s trunk passed
          +1 compile 9m 4s trunk passed with JDK v1.8.0_72
          +1 compile 7m 45s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 13s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 44s trunk passed
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 12s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 47s the patch passed
          +1 compile 8m 50s the patch passed with JDK v1.8.0_72
          +1 cc 8m 50s the patch passed
          +1 javac 8m 50s the patch passed
          +1 compile 7m 48s the patch passed with JDK v1.7.0_95
          +1 cc 7m 48s the patch passed
          +1 javac 7m 48s the patch passed
          +1 checkstyle 0m 21s the patch passed
          +1 mvnsite 1m 7s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 58s the patch passed
          +1 javadoc 1m 6s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95
          -1 unit 10m 6s hadoop-common in the patch failed with JDK v1.8.0_72.
          -1 unit 9m 28s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          75m 38s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.net.TestClusterTopology
            hadoop.util.TestSysInfoWindows
          JDK v1.7.0_95 Failed junit tests hadoop.util.TestSysInfoWindows
            hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789367/HADOOP-12824-v001.patch
          JIRA Issue HADOOP-12824
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 49e426ee7d11 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3369a4f
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8702/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8702/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8702/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8702/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8702/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8702/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 10s trunk passed +1 compile 9m 4s trunk passed with JDK v1.8.0_72 +1 compile 7m 45s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 13s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 12s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 47s the patch passed +1 compile 8m 50s the patch passed with JDK v1.8.0_72 +1 cc 8m 50s the patch passed +1 javac 8m 50s the patch passed +1 compile 7m 48s the patch passed with JDK v1.7.0_95 +1 cc 7m 48s the patch passed +1 javac 7m 48s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 1m 7s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 58s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95 -1 unit 10m 6s hadoop-common in the patch failed with JDK v1.8.0_72. -1 unit 9m 28s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 75m 38s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.net.TestClusterTopology   hadoop.util.TestSysInfoWindows JDK v1.7.0_95 Failed junit tests hadoop.util.TestSysInfoWindows   hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789367/HADOOP-12824-v001.patch JIRA Issue HADOOP-12824 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 49e426ee7d11 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3369a4f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8702/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8702/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8702/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8702/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8702/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8702/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Íñigo Goiri, thanks for working on this. The patch looks good overall, a few comments below:

          1. The title needs to be updated to match with the patch, which collects both total network and disk usage.

          2. Potential memory leak in ReadTotalCounter() due to the direct return below. Suggest to bailout with goto to ensure pItems is freed before the multiple returns in this function.

          status = PdhGetRawCounterArray(hCounter, &dwBufferSize, &dwItemCount, NULL);
          248	  if (PDH_MORE_DATA == status)
          249	  {
          250	    pItems = (PDH_RAW_COUNTER_ITEM *) malloc(dwBufferSize);
          251	    if (pItems)
          252	    {
          253	      // Actually query the counter
          254	      status = PdhGetRawCounterArray(hCounter, &dwBufferSize, &dwItemCount, pItems);
          255	      if (ERROR_SUCCESS == status) {
          256	        for (i = 0; i < dwItemCount; i++) {
          257	          if (wcscmp(L"_Total", pItems[i].szName) == 0) {
          258	            totalFound = 1;
          259	            *ret = pItems[i].RawValue.FirstValue;
          260	          } else if (!totalFound) {
          261	            *ret += pItems[i].RawValue.FirstValue;
          262	          }
          263	        }
          264	      } else {
          265	        return status;
          266	      }
          

          3. I see usage of SAL2 style annotations in the second parameter of ReadTotalCounter() but not other new functions added. I suggest we should use it consistently.

          	PDH_STATUS ReadTotalCounter(PDH_HCOUNTER hCounter, _Out_ LONGLONG* ret)
          
          Show
          xyao Xiaoyu Yao added a comment - Íñigo Goiri , thanks for working on this. The patch looks good overall, a few comments below: 1. The title needs to be updated to match with the patch, which collects both total network and disk usage. 2. Potential memory leak in ReadTotalCounter() due to the direct return below. Suggest to bailout with goto to ensure pItems is freed before the multiple returns in this function. status = PdhGetRawCounterArray(hCounter, &dwBufferSize, &dwItemCount, NULL); 248 if (PDH_MORE_DATA == status) 249 { 250 pItems = (PDH_RAW_COUNTER_ITEM *) malloc(dwBufferSize); 251 if (pItems) 252 { 253 // Actually query the counter 254 status = PdhGetRawCounterArray(hCounter, &dwBufferSize, &dwItemCount, pItems); 255 if (ERROR_SUCCESS == status) { 256 for (i = 0; i < dwItemCount; i++) { 257 if (wcscmp(L "_Total" , pItems[i].szName) == 0) { 258 totalFound = 1; 259 *ret = pItems[i].RawValue.FirstValue; 260 } else if (!totalFound) { 261 *ret += pItems[i].RawValue.FirstValue; 262 } 263 } 264 } else { 265 return status; 266 } 3. I see usage of SAL2 style annotations in the second parameter of ReadTotalCounter() but not other new functions added. I suggest we should use it consistently. PDH_STATUS ReadTotalCounter(PDH_HCOUNTER hCounter, _Out_ LONGLONG* ret)
          Hide
          elgoiri Íñigo Goiri added a comment -

          Regarding 1, I'll do everything together here and close HADOOP-12823.

          Show
          elgoiri Íñigo Goiri added a comment - Regarding 1, I'll do everything together here and close HADOOP-12823 .
          Hide
          elgoiri Íñigo Goiri added a comment -

          Tackling Xiaoyu Yao comments.

          Show
          elgoiri Íñigo Goiri added a comment - Tackling Xiaoyu Yao comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 6s trunk passed
          +1 compile 7m 6s trunk passed with JDK v1.8.0_72
          +1 compile 7m 18s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 1m 6s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 40s trunk passed
          +1 javadoc 0m 58s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 44s the patch passed
          +1 compile 6m 38s the patch passed with JDK v1.8.0_72
          +1 cc 6m 38s the patch passed
          +1 javac 6m 38s the patch passed
          +1 compile 7m 21s the patch passed with JDK v1.7.0_95
          +1 cc 7m 21s the patch passed
          +1 javac 7m 21s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 1m 5s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 55s the patch passed
          +1 javadoc 0m 57s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 8s the patch passed with JDK v1.7.0_95
          -1 unit 8m 6s hadoop-common in the patch failed with JDK v1.8.0_72.
          -1 unit 8m 5s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          65m 13s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.util.TestSysInfoWindows
          JDK v1.7.0_95 Failed junit tests hadoop.util.TestSysInfoWindows



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789632/HADOOP-12824-v002.patch
          JIRA Issue HADOOP-12824
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 19e13f468166 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2e76c2f
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8708/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8708/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8708/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8708/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8708/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8708/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 6s trunk passed +1 compile 7m 6s trunk passed with JDK v1.8.0_72 +1 compile 7m 18s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 58s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 6m 38s the patch passed with JDK v1.8.0_72 +1 cc 6m 38s the patch passed +1 javac 6m 38s the patch passed +1 compile 7m 21s the patch passed with JDK v1.7.0_95 +1 cc 7m 21s the patch passed +1 javac 7m 21s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 55s the patch passed +1 javadoc 0m 57s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 8s the patch passed with JDK v1.7.0_95 -1 unit 8m 6s hadoop-common in the patch failed with JDK v1.8.0_72. -1 unit 8m 5s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 65m 13s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.util.TestSysInfoWindows JDK v1.7.0_95 Failed junit tests hadoop.util.TestSysInfoWindows Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789632/HADOOP-12824-v002.patch JIRA Issue HADOOP-12824 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 19e13f468166 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2e76c2f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8708/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8708/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8708/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8708/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8708/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8708/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Adding unit tests.

          Show
          elgoiri Íñigo Goiri added a comment - Adding unit tests.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixed unit tests.

          Show
          elgoiri Íñigo Goiri added a comment - Fixed unit tests.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixed unit tests.

          Show
          elgoiri Íñigo Goiri added a comment - Fixed unit tests.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 12s trunk passed
          +1 compile 6m 47s trunk passed with JDK v1.8.0_72
          +1 compile 7m 29s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 10s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 44s trunk passed
          +1 javadoc 1m 1s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 8s trunk passed with JDK v1.7.0_95
          -1 mvninstall 0m 27s hadoop-common in the patch failed.
          -1 compile 0m 44s root in the patch failed with JDK v1.8.0_72.
          -1 cc 0m 44s root in the patch failed with JDK v1.8.0_72.
          -1 javac 0m 44s root in the patch failed with JDK v1.8.0_72.
          -1 compile 0m 49s root in the patch failed with JDK v1.7.0_95.
          -1 cc 0m 49s root in the patch failed with JDK v1.7.0_95.
          -1 javac 0m 49s root in the patch failed with JDK v1.7.0_95.
          +1 checkstyle 0m 20s the patch passed
          -1 mvnsite 0m 30s hadoop-common in the patch failed.
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 0m 19s hadoop-common in the patch failed.
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 8s the patch passed with JDK v1.7.0_95
          -1 unit 0m 30s hadoop-common in the patch failed with JDK v1.8.0_72.
          -1 unit 0m 33s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          34m 58s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789809/HADOOP-12824-v003.patch
          JIRA Issue HADOOP-12824
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 62de082db78f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dbbfc58
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt
          cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 12s trunk passed +1 compile 6m 47s trunk passed with JDK v1.8.0_72 +1 compile 7m 29s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 1m 1s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 8s trunk passed with JDK v1.7.0_95 -1 mvninstall 0m 27s hadoop-common in the patch failed. -1 compile 0m 44s root in the patch failed with JDK v1.8.0_72. -1 cc 0m 44s root in the patch failed with JDK v1.8.0_72. -1 javac 0m 44s root in the patch failed with JDK v1.8.0_72. -1 compile 0m 49s root in the patch failed with JDK v1.7.0_95. -1 cc 0m 49s root in the patch failed with JDK v1.7.0_95. -1 javac 0m 49s root in the patch failed with JDK v1.7.0_95. +1 checkstyle 0m 20s the patch passed -1 mvnsite 0m 30s hadoop-common in the patch failed. +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 19s hadoop-common in the patch failed. +1 javadoc 0m 54s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 8s the patch passed with JDK v1.7.0_95 -1 unit 0m 30s hadoop-common in the patch failed with JDK v1.8.0_72. -1 unit 0m 33s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 34m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789809/HADOOP-12824-v003.patch JIRA Issue HADOOP-12824 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 62de082db78f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbbfc58 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt cc https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8710/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixing parsing error.

          Show
          elgoiri Íñigo Goiri added a comment - Fixing parsing error.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 54s trunk passed
          +1 compile 5m 59s trunk passed with JDK v1.8.0_72
          +1 compile 6m 42s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 32s trunk passed
          +1 javadoc 0m 58s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 5m 58s the patch passed with JDK v1.8.0_72
          +1 cc 5m 58s the patch passed
          +1 javac 5m 58s the patch passed
          +1 compile 6m 56s the patch passed with JDK v1.7.0_95
          +1 cc 6m 56s the patch passed
          +1 javac 6m 56s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 1m 1s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 8s the patch passed with JDK v1.7.0_95
          +1 unit 7m 8s hadoop-common in the patch passed with JDK v1.8.0_72.
          +1 unit 7m 22s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          60m 15s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789835/HADOOP-12824-v003.patch
          JIRA Issue HADOOP-12824
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux cc205c417183 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dbbfc58
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8713/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8713/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 54s trunk passed +1 compile 5m 59s trunk passed with JDK v1.8.0_72 +1 compile 6m 42s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 32s trunk passed +1 javadoc 0m 58s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 5m 58s the patch passed with JDK v1.8.0_72 +1 cc 5m 58s the patch passed +1 javac 5m 58s the patch passed +1 compile 6m 56s the patch passed with JDK v1.7.0_95 +1 cc 6m 56s the patch passed +1 javac 6m 56s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 8s the patch passed with JDK v1.7.0_95 +1 unit 7m 8s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 7m 22s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 60m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789835/HADOOP-12824-v003.patch JIRA Issue HADOOP-12824 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux cc205c417183 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbbfc58 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8713/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8713/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Íñigo Goiri for updating the patch and adding the unit tests.
          One NIT: you can eliminate local variable totalFound by break out of the loop if "_Total" is ever found from the returned items.

          256	        for (i = 0; i < dwItemCount; i++) {
          257	          if (wcscmp(L"_Total", pItems[i].szName) == 0) { 
          259	            *ret = pItems[i].RawValue.FirstValue;
                              break;
          260	          } else {
          261	            *ret += pItems[i].RawValue.FirstValue;
          262	          }
          263	        }
          
          Show
          xyao Xiaoyu Yao added a comment - Thanks Íñigo Goiri for updating the patch and adding the unit tests. One NIT: you can eliminate local variable totalFound by break out of the loop if "_Total" is ever found from the returned items. 256 for (i = 0; i < dwItemCount; i++) { 257 if (wcscmp(L "_Total" , pItems[i].szName) == 0) { 259 *ret = pItems[i].RawValue.FirstValue; break ; 260 } else { 261 *ret += pItems[i].RawValue.FirstValue; 262 } 263 }
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixing nit from Xiaoyu Yao.

          Show
          elgoiri Íñigo Goiri added a comment - Fixing nit from Xiaoyu Yao .
          Hide
          elgoiri Íñigo Goiri added a comment -

          Fixing nit.

          Show
          elgoiri Íñigo Goiri added a comment - Fixing nit.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 10s trunk passed
          +1 compile 6m 12s trunk passed with JDK v1.8.0_72
          +1 compile 7m 7s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 1m 7s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 43s trunk passed
          +1 javadoc 0m 57s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 43s the patch passed
          +1 compile 6m 11s the patch passed with JDK v1.8.0_72
          +1 cc 6m 11s the patch passed
          +1 javac 6m 11s the patch passed
          +1 compile 7m 1s the patch passed with JDK v1.7.0_95
          +1 cc 7m 1s the patch passed
          +1 javac 7m 1s the patch passed
          +1 checkstyle 0m 21s the patch passed
          +1 mvnsite 1m 5s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 56s the patch passed
          +1 javadoc 0m 58s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 2s the patch passed with JDK v1.7.0_95
          -1 unit 7m 45s hadoop-common in the patch failed with JDK v1.8.0_72.
          +1 unit 7m 43s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          62m 45s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790003/HADOOP-12824-v004.patch
          JIRA Issue HADOOP-12824
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux a30d1e53be57 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c4d4df8
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8723/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8723/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8723/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8723/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 10s trunk passed +1 compile 6m 12s trunk passed with JDK v1.8.0_72 +1 compile 7m 7s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 43s the patch passed +1 compile 6m 11s the patch passed with JDK v1.8.0_72 +1 cc 6m 11s the patch passed +1 javac 6m 11s the patch passed +1 compile 7m 1s the patch passed with JDK v1.7.0_95 +1 cc 7m 1s the patch passed +1 javac 7m 1s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 56s the patch passed +1 javadoc 0m 58s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_95 -1 unit 7m 45s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 7m 43s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 62m 45s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790003/HADOOP-12824-v004.patch JIRA Issue HADOOP-12824 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux a30d1e53be57 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c4d4df8 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8723/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8723/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8723/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8723/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          +1 for patch v004, I will commit it shortly.

          Show
          xyao Xiaoyu Yao added a comment - +1 for patch v004, I will commit it shortly.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Íñigo Goiri for the contribution. I've commit the patch to trunk, branch-2 and branch-2.8.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Íñigo Goiri for the contribution. I've commit the patch to trunk, branch-2 and branch-2.8.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9371 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9371/)
          HADOOP-12824. Collect network and disk usage on the node running (xyao: rev b2951f9fbccee8aeab04c1f5ee3fc6db1ef6b2da)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestSysInfoWindows.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SysInfoWindows.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/winutils/systeminfo.c
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9371 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9371/ ) HADOOP-12824 . Collect network and disk usage on the node running (xyao: rev b2951f9fbccee8aeab04c1f5ee3fc6db1ef6b2da) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestSysInfoWindows.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SysInfoWindows.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/winutils/systeminfo.c
          Hide
          elgoiri Íñigo Goiri added a comment -

          Thank you very much Xiaoyu Yao for the review and the commit!

          Show
          elgoiri Íñigo Goiri added a comment - Thank you very much Xiaoyu Yao for the review and the commit!

            People

            • Assignee:
              elgoiri Íñigo Goiri
              Reporter:
              elgoiri Íñigo Goiri
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development