Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12765

HttpServer2 should switch to using the non-blocking SslSelectChannelConnector to prevent performance degradation when handling SSL connections

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.2, 2.6.3
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The current implementation uses the blocking SslSocketConnector which takes the default maxIdleTime as 200 seconds. We noticed in our cluster that when users use a custom client that accesses the WebHDFS REST APIs through https, it could block all the 250 handler threads in NN jetty server, causing severe performance degradation for accessing WebHDFS and NN web UI. Attached screenshots (blocking_1.png and blocking_2.png) illustrate that when using SslSocketConnector, the jetty handler threads are not released until the 200 seconds maxIdleTime has passed. With sufficient number of SSL connections, this issue could render NN HttpServer to become entirely irresponsive.

      We propose to use the non-blocking SslSelectChannelConnector as a fix. We have deployed the attached patch within our cluster, and have seen significant improvement. The attached screenshot (unblocking.png) further illustrates the behavior of NN jetty server after switching to using SslSelectChannelConnector.

      The patch further disables SSLv3 protocol on server side to preserve the spirit of HADOOP-11260.

      1. blocking_1.png
        1.03 MB
        Min Shen
      2. blocking_2.png
        1.01 MB
        Min Shen
      3. HADOOP-12765.001.patch
        14 kB
        Vinayakumar B
      4. HADOOP-12765.001.patch
        14 kB
        Min Shen
      5. HADOOP-12765.002.patch
        15 kB
        Min Shen
      6. HADOOP-12765.003.patch
        16 kB
        Min Shen
      7. HADOOP-12765.004.patch
        15 kB
        Min Shen
      8. HADOOP-12765.005.patch
        14 kB
        Wei-Chiu Chuang
      9. HADOOP-12765-branch-2.patch
        14 kB
        Wei-Chiu Chuang
      10. unblocking.png
        841 kB
        Min Shen

        Issue Links

          Activity

          Hide
          zhz Zhe Zhang added a comment -

          Thanks for the feedback Wei-Chiu Chuang. I resolved both conflicts and backported this change to branch-2.7. Agreed HADOOP-12688 would be a nice improvement. I tried backporting but it was not quite clean.

          Show
          zhz Zhe Zhang added a comment - Thanks for the feedback Wei-Chiu Chuang . I resolved both conflicts and backported this change to branch-2.7. Agreed HADOOP-12688 would be a nice improvement. I tried backporting but it was not quite clean.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          The conflict in the code is due to HADOOP-12668. Do you want to backport that to branch-2.6 too? Looks like a good one to have in the branch.
          The conflict in the pom is due to HADOOP-10717, which is not related to this. We can exclude that.

          Show
          jojochuang Wei-Chiu Chuang added a comment - The conflict in the code is due to HADOOP-12668 . Do you want to backport that to branch-2.6 too? Looks like a good one to have in the branch. The conflict in the pom is due to HADOOP-10717 , which is not related to this. We can exclude that.
          Hide
          zhz Zhe Zhang added a comment -

          I committed to branch-2 and branch-2.8. But backporting to branch-2.7 is having a conflict on the pom files. Min Shen Wei-Chiu Chuang Could you help take a look? Thanks.

          Show
          zhz Zhe Zhang added a comment - I committed to branch-2 and branch-2.8. But backporting to branch-2.7 is having a conflict on the pom files. Min Shen Wei-Chiu Chuang Could you help take a look? Thanks.
          Hide
          zhz Zhe Zhang added a comment -

          Just noticed that the branch-2 patch has already passed Jenkins. +1. I will commit shortly.

          Show
          zhz Zhe Zhang added a comment - Just noticed that the branch-2 patch has already passed Jenkins. +1. I will commit shortly.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Zhe Zhang for the review. I've filed HADOOP-13535 to fix the potential bug.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Zhe Zhang for the review. I've filed HADOOP-13535 to fix the potential bug.
          Hide
          zhz Zhe Zhang added a comment -

          Thanks Wei-Chiu Chuang. Branch-2 patch LGTM. +1 pending Jenkins.

          The conflict is caused by HADOOP-10588. It's only in branch-2, not trunk. I'll file a JIRA to address.

          Show
          zhz Zhe Zhang added a comment - Thanks Wei-Chiu Chuang . Branch-2 patch LGTM. +1 pending Jenkins. The conflict is caused by HADOOP-10588 . It's only in branch-2, not trunk. I'll file a JIRA to address.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Ok. Thanks. Would you like to review my branch-2 patch?
          Let's commit this to branch-2 and then file a new jira to fix the potential issue.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Ok. Thanks. Would you like to review my branch-2 patch? Let's commit this to branch-2 and then file a new jira to fix the potential issue.
          Hide
          mshen Min Shen added a comment -

          Wei-Chiu Chuang,

          The internal patch we have is based on top 2.6.1, which already have this fix for http connections.
          We didn't see the same issue happening in our environment for https connections though.
          However, this indeed seems like to also hit HADOOP-10588 potentially.

          Show
          mshen Min Shen added a comment - Wei-Chiu Chuang , The internal patch we have is based on top 2.6.1, which already have this fix for http connections. We didn't see the same issue happening in our environment for https connections though. However, this indeed seems like to also hit HADOOP-10588 potentially.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 42s Maven dependency ordering for branch
          +1 mvninstall 6m 23s branch-2 passed
          +1 compile 5m 26s branch-2 passed with JDK v1.8.0_101
          +1 compile 6m 23s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 1m 21s branch-2 passed
          +1 mvnsite 2m 17s branch-2 passed
          +1 mvneclipse 1m 0s branch-2 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 2m 43s branch-2 passed
          +1 javadoc 1m 35s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 1m 46s branch-2 passed with JDK v1.7.0_101
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 1m 42s the patch passed
          +1 compile 6m 49s the patch passed with JDK v1.8.0_101
          +1 javac 6m 49s the patch passed
          +1 compile 6m 56s the patch passed with JDK v1.7.0_101
          +1 javac 6m 56s the patch passed
          +1 checkstyle 1m 29s root: The patch generated 0 new + 82 unchanged - 1 fixed = 82 total (was 83)
          +1 mvnsite 2m 32s the patch passed
          +1 mvneclipse 1m 13s the patch passed
          -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 xml 0m 1s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 3m 44s the patch passed
          +1 javadoc 1m 45s the patch passed with JDK v1.8.0_101
          +1 javadoc 2m 2s the patch passed with JDK v1.7.0_101
          +1 unit 0m 15s hadoop-project in the patch passed with JDK v1.7.0_101.
          +1 unit 8m 56s hadoop-common in the patch passed with JDK v1.7.0_101.
          +1 unit 1m 48s hadoop-kms in the patch passed with JDK v1.7.0_101.
          +1 unit 3m 42s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          113m 36s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824604/HADOOP-12765-branch-2.patch
          JIRA Issue HADOOP-12765
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 5f4cd6977d52 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 43d1279
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10309/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10309/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10309/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 42s Maven dependency ordering for branch +1 mvninstall 6m 23s branch-2 passed +1 compile 5m 26s branch-2 passed with JDK v1.8.0_101 +1 compile 6m 23s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 1m 21s branch-2 passed +1 mvnsite 2m 17s branch-2 passed +1 mvneclipse 1m 0s branch-2 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 2m 43s branch-2 passed +1 javadoc 1m 35s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 46s branch-2 passed with JDK v1.7.0_101 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 1m 42s the patch passed +1 compile 6m 49s the patch passed with JDK v1.8.0_101 +1 javac 6m 49s the patch passed +1 compile 6m 56s the patch passed with JDK v1.7.0_101 +1 javac 6m 56s the patch passed +1 checkstyle 1m 29s root: The patch generated 0 new + 82 unchanged - 1 fixed = 82 total (was 83) +1 mvnsite 2m 32s the patch passed +1 mvneclipse 1m 13s the patch passed -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 3m 44s the patch passed +1 javadoc 1m 45s the patch passed with JDK v1.8.0_101 +1 javadoc 2m 2s the patch passed with JDK v1.7.0_101 +1 unit 0m 15s hadoop-project in the patch passed with JDK v1.7.0_101. +1 unit 8m 56s hadoop-common in the patch passed with JDK v1.7.0_101. +1 unit 1m 48s hadoop-kms in the patch passed with JDK v1.7.0_101. +1 unit 3m 42s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 113m 36s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824604/HADOOP-12765-branch-2.patch JIRA Issue HADOOP-12765 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 5f4cd6977d52 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 43d1279 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10309/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10309/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10309/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Min Shen do you run Jetty version 6.1.26? After this change HTTPS uses SslSelectChannelConnector, and it looks to me it might also hit HADOOP-10588/JETTY-1316. Have you guys seen the weird behavior in your environment?

          I am thinking we might also need to add a similar workaround like in HADOOP-10588 for HTTPS traffic.

          Thanks.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Min Shen do you run Jetty version 6.1.26? After this change HTTPS uses SslSelectChannelConnector, and it looks to me it might also hit HADOOP-10588 /JETTY-1316. Have you guys seen the weird behavior in your environment? I am thinking we might also need to add a similar workaround like in HADOOP-10588 for HTTPS traffic. Thanks.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          There's a conflict due to HADOOP-10588. Attached a branch-2 patch.

          Show
          jojochuang Wei-Chiu Chuang added a comment - There's a conflict due to HADOOP-10588 . Attached a branch-2 patch.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10310 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10310/)
          HADOOP-12765. HttpServer2 should switch to using the non-blocking (weichiu: rev 03a9343d5798384b66fbd21e1e028acaf55b00e9)

          • (edit) hadoop-common-project/hadoop-common/pom.xml
          • (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SslSelectChannelConnectorSecure.java
          • (delete) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SslSocketConnectorSecure.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          • (edit) hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/MiniKMS.java
          • (edit) hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10310 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10310/ ) HADOOP-12765 . HttpServer2 should switch to using the non-blocking (weichiu: rev 03a9343d5798384b66fbd21e1e028acaf55b00e9) (edit) hadoop-common-project/hadoop-common/pom.xml (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SslSelectChannelConnectorSecure.java (delete) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SslSocketConnectorSecure.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java (edit) hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/MiniKMS.java (edit) hadoop-project/pom.xml
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          +1

          Show
          jojochuang Wei-Chiu Chuang added a comment - +1
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 8m 5s trunk passed
          +1 compile 7m 6s trunk passed
          +1 checkstyle 1m 24s trunk passed
          +1 mvnsite 1m 50s trunk passed
          +1 mvneclipse 0m 49s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 2m 7s trunk passed
          +1 javadoc 1m 30s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 39s the patch passed
          +1 compile 6m 44s the patch passed
          +1 javac 6m 44s the patch passed
          +1 checkstyle 1m 29s root: The patch generated 0 new + 81 unchanged - 1 fixed = 81 total (was 82)
          +1 mvnsite 2m 2s the patch passed
          +1 mvneclipse 1m 2s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 2m 41s the patch passed
          +1 javadoc 1m 42s the patch passed
          +1 unit 0m 15s hadoop-project in the patch passed.
          +1 unit 8m 16s hadoop-common in the patch passed.
          +1 unit 2m 16s hadoop-kms in the patch passed.
          +1 unit 3m 47s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          79m 48s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824419/HADOOP-12765.005.patch
          JIRA Issue HADOOP-12765
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux e17215c58626 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ae4db25
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10300/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10300/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 8m 5s trunk passed +1 compile 7m 6s trunk passed +1 checkstyle 1m 24s trunk passed +1 mvnsite 1m 50s trunk passed +1 mvneclipse 0m 49s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 2m 7s trunk passed +1 javadoc 1m 30s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 39s the patch passed +1 compile 6m 44s the patch passed +1 javac 6m 44s the patch passed +1 checkstyle 1m 29s root: The patch generated 0 new + 81 unchanged - 1 fixed = 81 total (was 82) +1 mvnsite 2m 2s the patch passed +1 mvneclipse 1m 2s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 2m 41s the patch passed +1 javadoc 1m 42s the patch passed +1 unit 0m 15s hadoop-project in the patch passed. +1 unit 8m 16s hadoop-common in the patch passed. +1 unit 2m 16s hadoop-kms in the patch passed. +1 unit 3m 47s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 79m 48s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824419/HADOOP-12765.005.patch JIRA Issue HADOOP-12765 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux e17215c58626 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ae4db25 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10300/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10300/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          While Min's patch looks good to me, it did not address Vinayakumar B's comment. So I updated the patch to remove the changes in pom.xml. The code compiles in my local tree. If it passes precommit I'll +1 and commit the patch.

          I wonder whether following change required in both hadoop-kms and https, as dependency will be already propogated from hadoop-common.

          <dependency>
          + <groupId>org.mortbay.jetty</groupId>
          + <artifactId>jetty-sslengine</artifactId>
          + <scope>test</scope>
          + </dependency>

          Show
          jojochuang Wei-Chiu Chuang added a comment - While Min's patch looks good to me, it did not address Vinayakumar B 's comment. So I updated the patch to remove the changes in pom.xml. The code compiles in my local tree. If it passes precommit I'll +1 and commit the patch. I wonder whether following change required in both hadoop-kms and https, as dependency will be already propogated from hadoop-common. <dependency> + <groupId>org.mortbay.jetty</groupId> + <artifactId>jetty-sslengine</artifactId> + <scope>test</scope> + </dependency>
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks. The last patch looks good to me!

          +1. Would any one else like to comment? Otherwise I'll commit by end of day.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks. The last patch looks good to me! +1. Would any one else like to comment? Otherwise I'll commit by end of day.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 6m 21s Maven dependency ordering for branch
          +1 mvninstall 7m 43s trunk passed
          +1 compile 7m 37s trunk passed
          +1 checkstyle 1m 24s trunk passed
          +1 mvnsite 1m 49s trunk passed
          +1 mvneclipse 0m 49s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 2m 8s trunk passed
          +1 javadoc 1m 29s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 37s the patch passed
          +1 compile 6m 44s the patch passed
          +1 javac 6m 44s the patch passed
          +1 checkstyle 1m 29s root: The patch generated 0 new + 81 unchanged - 1 fixed = 81 total (was 82)
          +1 mvnsite 1m 59s the patch passed
          +1 mvneclipse 1m 2s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 5s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 2m 47s the patch passed
          +1 javadoc 1m 42s the patch passed
          +1 unit 0m 15s hadoop-project in the patch passed.
          +1 unit 8m 12s hadoop-common in the patch passed.
          +1 unit 2m 12s hadoop-kms in the patch passed.
          +1 unit 3m 28s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          85m 36s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824038/HADOOP-12765.004.patch
          JIRA Issue HADOOP-12765
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux ea0bb0a14ae1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2353271
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10268/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10268/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 6m 21s Maven dependency ordering for branch +1 mvninstall 7m 43s trunk passed +1 compile 7m 37s trunk passed +1 checkstyle 1m 24s trunk passed +1 mvnsite 1m 49s trunk passed +1 mvneclipse 0m 49s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 2m 8s trunk passed +1 javadoc 1m 29s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 37s the patch passed +1 compile 6m 44s the patch passed +1 javac 6m 44s the patch passed +1 checkstyle 1m 29s root: The patch generated 0 new + 81 unchanged - 1 fixed = 81 total (was 82) +1 mvnsite 1m 59s the patch passed +1 mvneclipse 1m 2s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 5s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 2m 47s the patch passed +1 javadoc 1m 42s the patch passed +1 unit 0m 15s hadoop-project in the patch passed. +1 unit 8m 12s hadoop-common in the patch passed. +1 unit 2m 12s hadoop-kms in the patch passed. +1 unit 3m 28s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 85m 36s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824038/HADOOP-12765.004.patch JIRA Issue HADOOP-12765 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux ea0bb0a14ae1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2353271 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10268/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10268/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          mshen Min Shen added a comment -

          Wei-Chiu Chuang,

          Thanks a lot for reviewing the patch!
          I've updated it addressing these 2 issues.

          Show
          mshen Min Shen added a comment - Wei-Chiu Chuang , Thanks a lot for reviewing the patch! I've updated it addressing these 2 issues.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks again for the match. Looks really good to me!
          One minor issue I noticed is configureChannelConnector(AbstractNIOConnector c), which you could define as configureChannelConnector(SelectChannelConnector c).
          Also, instead of specify the version of jetty-sslengine in hadoop-project/pom.xml, can you use the variable ${jetty.version} for version number instead? This will help us avoid inconsistency if we want to upgrade Jetty in the future.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks again for the match. Looks really good to me! One minor issue I noticed is configureChannelConnector(AbstractNIOConnector c) , which you could define as configureChannelConnector(SelectChannelConnector c) . Also, instead of specify the version of jetty-sslengine in hadoop-project/pom.xml, can you use the variable ${jetty.version} for version number instead? This will help us avoid inconsistency if we want to upgrade Jetty in the future.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 5m 51s Maven dependency ordering for branch
          +1 mvninstall 6m 37s trunk passed
          +1 compile 7m 3s trunk passed
          +1 checkstyle 1m 31s trunk passed
          +1 mvnsite 1m 51s trunk passed
          +1 mvneclipse 0m 50s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 2m 33s trunk passed
          +1 javadoc 1m 28s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 2m 0s the patch passed
          +1 compile 7m 51s the patch passed
          +1 javac 7m 51s the patch passed
          +1 checkstyle 1m 30s root: The patch generated 0 new + 81 unchanged - 1 fixed = 81 total (was 82)
          +1 mvnsite 2m 1s the patch passed
          +1 mvneclipse 1m 1s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 xml 0m 5s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 2m 42s the patch passed
          +1 javadoc 1m 41s the patch passed
          +1 unit 0m 15s hadoop-project in the patch passed.
          +1 unit 7m 49s hadoop-common in the patch passed.
          +1 unit 2m 13s hadoop-kms in the patch passed.
          +1 unit 3m 26s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          84m 44s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823721/HADOOP-12765.003.patch
          JIRA Issue HADOOP-12765
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 2f491993de3c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9f29f42
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10250/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10250/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 5m 51s Maven dependency ordering for branch +1 mvninstall 6m 37s trunk passed +1 compile 7m 3s trunk passed +1 checkstyle 1m 31s trunk passed +1 mvnsite 1m 51s trunk passed +1 mvneclipse 0m 50s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 2m 33s trunk passed +1 javadoc 1m 28s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 0s the patch passed +1 compile 7m 51s the patch passed +1 javac 7m 51s the patch passed +1 checkstyle 1m 30s root: The patch generated 0 new + 81 unchanged - 1 fixed = 81 total (was 82) +1 mvnsite 2m 1s the patch passed +1 mvneclipse 1m 1s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 xml 0m 5s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 2m 42s the patch passed +1 javadoc 1m 41s the patch passed +1 unit 0m 15s hadoop-project in the patch passed. +1 unit 7m 49s hadoop-common in the patch passed. +1 unit 2m 13s hadoop-kms in the patch passed. +1 unit 3m 26s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 84m 44s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823721/HADOOP-12765.003.patch JIRA Issue HADOOP-12765 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 2f491993de3c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9f29f42 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10250/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10250/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          mshen Min Shen added a comment -

          Attaching revised patch to address Wei-Chiu Chuang's comment.

          Show
          mshen Min Shen added a comment - Attaching revised patch to address Wei-Chiu Chuang 's comment.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Hello Min Shen thanks for updating the patch! Overall looks good to me. I noticed the new method you added createHttpsChannelConnector has some duplication with createDefaultChannelConnector. Can you please de-duplicate the code if feasible?

          Show
          jojochuang Wei-Chiu Chuang added a comment - Hello Min Shen thanks for updating the patch! Overall looks good to me. I noticed the new method you added createHttpsChannelConnector has some duplication with createDefaultChannelConnector . Can you please de-duplicate the code if feasible?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 1m 40s Maven dependency ordering for branch
          +1 mvninstall 6m 54s trunk passed
          +1 compile 6m 48s trunk passed
          +1 checkstyle 1m 25s trunk passed
          +1 mvnsite 1m 52s trunk passed
          +1 mvneclipse 0m 50s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 2m 11s trunk passed
          +1 javadoc 1m 31s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 38s the patch passed
          +1 compile 6m 48s the patch passed
          +1 javac 6m 48s the patch passed
          +1 checkstyle 1m 27s root: The patch generated 0 new + 81 unchanged - 1 fixed = 81 total (was 82)
          +1 mvnsite 2m 1s the patch passed
          +1 mvneclipse 1m 2s the patch passed
          -1 whitespace 0m 0s The patch 1 line(s) with tabs.
          +1 xml 0m 5s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 2m 41s the patch passed
          +1 javadoc 1m 44s the patch passed
          +1 unit 0m 15s hadoop-project in the patch passed.
          +1 unit 8m 11s hadoop-common in the patch passed.
          +1 unit 2m 12s hadoop-kms in the patch passed.
          +1 unit 3m 28s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          79m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823589/HADOOP-12765.002.patch
          JIRA Issue HADOOP-12765
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux c5c0e8486ae2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 23c6e3c
          Default Java 1.8.0_101
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10238/artifact/patchprocess/whitespace-tabs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10238/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10238/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 40s Maven dependency ordering for branch +1 mvninstall 6m 54s trunk passed +1 compile 6m 48s trunk passed +1 checkstyle 1m 25s trunk passed +1 mvnsite 1m 52s trunk passed +1 mvneclipse 0m 50s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 2m 11s trunk passed +1 javadoc 1m 31s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 38s the patch passed +1 compile 6m 48s the patch passed +1 javac 6m 48s the patch passed +1 checkstyle 1m 27s root: The patch generated 0 new + 81 unchanged - 1 fixed = 81 total (was 82) +1 mvnsite 2m 1s the patch passed +1 mvneclipse 1m 2s the patch passed -1 whitespace 0m 0s The patch 1 line(s) with tabs. +1 xml 0m 5s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 2m 41s the patch passed +1 javadoc 1m 44s the patch passed +1 unit 0m 15s hadoop-project in the patch passed. +1 unit 8m 11s hadoop-common in the patch passed. +1 unit 2m 12s hadoop-kms in the patch passed. +1 unit 3m 28s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 79m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823589/HADOOP-12765.002.patch JIRA Issue HADOOP-12765 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux c5c0e8486ae2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 23c6e3c Default Java 1.8.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10238/artifact/patchprocess/whitespace-tabs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10238/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10238/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          mshen Min Shen added a comment -

          Attach patch rebased on trunk

          Show
          mshen Min Shen added a comment - Attach patch rebased on trunk
          Hide
          mshen Min Shen added a comment -

          Will attach an updated version of this patch to rebase with trunk soon.

          Show
          mshen Min Shen added a comment - Will attach an updated version of this patch to rebase with trunk soon.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Hello, Min Shen can you help to rebase the patch? Thanks very much!

          Show
          jojochuang Wei-Chiu Chuang added a comment - Hello, Min Shen can you help to rebase the patch? Thanks very much!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 6s HADOOP-12765 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787415/HADOOP-12765.001.patch
          JIRA Issue HADOOP-12765
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10104/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s HADOOP-12765 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787415/HADOOP-12765.001.patch JIRA Issue HADOOP-12765 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10104/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          I am interested in this patch. Is there something I can do to help push this forward?
          Thanks.

          Show
          jojochuang Wei-Chiu Chuang added a comment - I am interested in this patch. Is there something I can do to help push this forward? Thanks.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Patch need rebase.

          I wonder whether following change required in both hadoop-kms and https, as dependency will be already propogated from hadoop-common.

               <dependency>
          +      <groupId>org.mortbay.jetty</groupId>
          +      <artifactId>jetty-sslengine</artifactId>
          +      <scope>test</scope>
          +    </dependency>
          

          Hi Haohui Mai, Can you too take a look.?

          Show
          vinayrpet Vinayakumar B added a comment - Patch need rebase. I wonder whether following change required in both hadoop-kms and https, as dependency will be already propogated from hadoop-common. <dependency> + <groupId>org.mortbay.jetty</groupId> + <artifactId>jetty-sslengine</artifactId> + <scope>test</scope> + </dependency> Hi Haohui Mai , Can you too take a look.?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 3s HADOOP-12765 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787415/HADOOP-12765.001.patch
          JIRA Issue HADOOP-12765
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8599/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 3s HADOOP-12765 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787415/HADOOP-12765.001.patch JIRA Issue HADOOP-12765 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8599/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HADOOP-12765 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787415/HADOOP-12765.001.patch
          JIRA Issue HADOOP-12765
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8598/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-12765 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787415/HADOOP-12765.001.patch JIRA Issue HADOOP-12765 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8598/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Re-attaching same patch to be picked up by yetus

          Show
          vinayrpet Vinayakumar B added a comment - Re-attaching same patch to be picked up by yetus
          Hide
          zhz Zhe Zhang added a comment -

          Thanks for the work Min. Impressive results!

          One quick comment is whether it's possible to code-share with current createDefaultChannelConnector.

          Show
          zhz Zhe Zhang added a comment - Thanks for the work Min. Impressive results! One quick comment is whether it's possible to code-share with current createDefaultChannelConnector .

            People

            • Assignee:
              mshen Min Shen
              Reporter:
              mshen Min Shen
            • Votes:
              0 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development