[HADOOP-12678] Handle empty rename pending metadata file during atomic rename in redo path

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: fs/azure
• Hadoop Flags: Reviewed
• Assignee: madhumita chakraborty
• Reporter: madhumita chakraborty
• Created: 24/Dec/15 04:05
• Updated: 30/Aug/16 01:20
• Resolved: 09/Jan/16 06:20

Description

Handle empty rename pending metadata file during atomic rename in redo path
During atomic rename we create metadata file for rename(-renamePending.json). We create that in 2 steps
1. We create an empty blob corresponding to the .json file in its real location
2. We create a scratch file to which we write the contents of the rename pending which is then copied over into the blob described in 1
If process crash occurs after step 1 and before step 2 is complete - we will be left with a zero size blob corresponding to the pending rename metadata file.
This kind of scenario can happen in the /hbase/.tmp folder because it is considered a candidate folder for atomic rename. Now when HMaster starts up it executes listStatus on the .tmp folder to clean up pending data. At this stage due to the lazy pending rename complete process we look for these json files. On seeing an empty file the process simply throws a fatal exception assuming something went wrong.